05 Sep, 2005
2 commits
-
This adds type-checking to pm_message_t, so that people can't confuse it
with int or u32. It also allows us to fix "disk yoyo" during suspend (disk
spinning down/up/down).[We've tried that before; since that cpufreq problems were fixed and I've
tried make allyes config and fixed resulting damage.]Signed-off-by: Pavel Machek
Signed-off-by: Alexander Nyberg
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Add page_state info to the per-node meminfo file in sysfs. This is mostly
just for informational purposes.The lack of this information was brought up recently during a discussion
regarding pagecache clearing, and I put this patch together to test out one
of the suggestions.It seems like interesting info to have, so I'm submitting the patch.
Signed-off-by: Martin Hicks
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
18 Aug, 2005
1 commit
-
Fix for manual binding of drivers to devices. Problem is if you pass in
a valid device id, but the driver refuses to bind. Infinite loop as
write() tries to resubmit the data it just sent.Thanks to Michal Ostrowski for pointing the
problem out.Signed-off-by: Greg Kroah-Hartman
Signed-off-by: Linus Torvalds
17 Aug, 2005
1 commit
-
This moves the code to free devt_attr from class_device_del() to
class_dev_release() which is called after the last reference to the
corresponding kobject() is gone.This allows us to keep the devt_attr alive while the corresponding
sysfs file is open.Signed-off-by: Maneesh Soni
Signed-off-by: Greg Kroah-Hartman
Signed-off-by: Linus Torvalds
13 Jul, 2005
1 commit
-
Signed-off-by: Len Brown
12 Jul, 2005
1 commit
-
Register an "acpi" system device to be notified of shutdown preparation.
This depends on CONFIG_PMhttp://bugzilla.kernel.org/show_bug.cgi?id=4041
Signed-off-by: Alexey Starikovskiy
Signed-off-by: Andrew Morton
Signed-off-by: Len Brown
30 Jun, 2005
5 commits
-
Use klist_del() instead of klist_remove() when unregistering devices.
This will prevent a deadlock when executing a recursive unregister using
device_for_each_child().Signed-off-by Patrick Mochel
Signed-off-by: Greg Kroah-Hartman -
No one was looking at the return value of bus_rescan_devices, and it
really wasn't anything that anyone in the kernel would ever care about.
So change it which enabled some counting code to be removed also.Signed-off-by: Greg Kroah-Hartman
-
This adds a single file, "bind", to the sysfs directory of every driver
registered with the driver core. To bind a device to a driver, write
the bus id of the device you wish to bind to that specific driver to the
"bind" file (remember to not add a trailing \n). If that bus id matches
a device on that bus, and it does not currently have a driver bound to
it, the probe sequence will be initiated with that driver and device.Note, this requires that the driver itself be willing and able to accept
that device (usually through a device id type table). This patch does
not make it possible to override the driver's id table.Signed-off-by: Greg Kroah-Hartman
-
This adds a single file, "unbind", to the sysfs directory of every
device that is currently bound to a driver. To unbind the driver from
the device, write anything to this file and they will be disconnected
from each other.Signed-off-by: Greg Kroah-Hartman
-
Add bus_find_device() and driver_find_device() which allow searching for a
device in the bus's resp. the driver's klist and obtain a reference on it.Signed-off-by: Cornelia Huck
Signed-off-by: Greg Kroah-Hartman
29 Jun, 2005
1 commit
-
Avoid race occurs when some process have open file descriptor for class
device attributes and already firmware allocated memory are freed. Don't
allow negative loading timeout.Signed-off-by: Stanislaw W. Gruszka
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
26 Jun, 2005
3 commits
-
We already do kobject_hotplug for cpu offline; this adds a kobject_hotplug
call for the online case. This is being requested by developers of an
application which wants to be notified about both kinds of events.Signed-off-by: Nathan Lynch
Cc: Rusty Russell
Cc: Greg KH
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
I really wish smp_prepare_cpu() would disappear eventually. In the interim
this is ideally a weak function, so we dont end up changing several places
to define this dummy in headers.Today since the dummy declaration is done only in drivers/base/cpu.c but
the function is called in kernel/power/smp.c i get undefined reference in
my cpu hotplug code for x86_64 under development.Signed-off-by: Ashok Raj
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Clean CPU states in order to reuse smp boot code for CPU hotplug.
Signed-off-by: Li Shaohua
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
23 Jun, 2005
1 commit
-
Don't error out if something "bad" happens when trying to bind a driver to a
device. We want the sysfs attributes to be present for later when we try to
tear down the device.Signed-off-by: Greg Kroah-Hartman
22 Jun, 2005
1 commit
-
This patch modifies the way pagesets in struct zone are managed.
Each zone has a per-cpu array of pagesets. So any particular CPU has some
memory in each zone structure which belongs to itself. Even if that CPU is
not local to that zone.So the patch relocates the pagesets for each cpu to the node that is nearest
to the cpu instead of allocating the pagesets in the (possibly remote) target
zone. This means that the operations to manage pages on remote zone can be
done with information available locally.We play a macro trick so that non-NUMA pmachines avoid the additional
pointer chase on the page allocator fastpath.AIM7 benchmark on a 32 CPU SGI Altix
w/o patches:
Tasks jobs/min jti jobs/min/task real cpu
1 484.68 100 484.6769 12.01 1.97 Fri Mar 25 11:01:42 2005
100 27140.46 89 271.4046 21.44 148.71 Fri Mar 25 11:02:04 2005
200 30792.02 82 153.9601 37.80 296.72 Fri Mar 25 11:02:42 2005
300 32209.27 81 107.3642 54.21 451.34 Fri Mar 25 11:03:37 2005
400 34962.83 78 87.4071 66.59 588.97 Fri Mar 25 11:04:44 2005
500 31676.92 75 63.3538 91.87 742.71 Fri Mar 25 11:06:16 2005
600 36032.69 73 60.0545 96.91 885.44 Fri Mar 25 11:07:54 2005
700 35540.43 77 50.7720 114.63 1024.28 Fri Mar 25 11:09:49 2005
800 33906.70 74 42.3834 137.32 1181.65 Fri Mar 25 11:12:06 2005
900 34120.67 73 37.9119 153.51 1325.26 Fri Mar 25 11:14:41 2005
1000 34802.37 74 34.8024 167.23 1465.26 Fri Mar 25 11:17:28 2005with slab API changes and pageset patch:
Tasks jobs/min jti jobs/min/task real cpu
1 485.00 100 485.0000 12.00 1.96 Fri Mar 25 11:46:18 2005
100 28000.96 89 280.0096 20.79 150.45 Fri Mar 25 11:46:39 2005
200 32285.80 79 161.4290 36.05 293.37 Fri Mar 25 11:47:16 2005
300 40424.15 84 134.7472 43.19 438.42 Fri Mar 25 11:47:59 2005
400 39155.01 79 97.8875 59.46 590.05 Fri Mar 25 11:48:59 2005
500 37881.25 82 75.7625 76.82 730.19 Fri Mar 25 11:50:16 2005
600 39083.14 78 65.1386 89.35 872.79 Fri Mar 25 11:51:46 2005
700 38627.83 77 55.1826 105.47 1022.46 Fri Mar 25 11:53:32 2005
800 39631.94 78 49.5399 117.48 1169.94 Fri Mar 25 11:55:30 2005
900 36903.70 79 41.0041 141.94 1310.78 Fri Mar 25 11:57:53 2005
1000 36201.23 77 36.2012 160.77 1458.31 Fri Mar 25 12:00:34 2005Signed-off-by: Christoph Lameter
Signed-off-by: Shobhit Dayal
Signed-off-by: Shai Fultheim
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
21 Jun, 2005
23 commits
-
I think we need this patch or we might "lose" devices to the dpm_irq_off
list if a failure occurs during the suspend process.Signed-off-by: Benjamin Herrenschmidt
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Yani Ioannou
Signed-off-by: Greg Kroah-Hartman -
This patch adds the device_attribute paramerter to the
device_attribute store and show sysfs callback functions, and passes a
reference to the attribute when the callbacks are called.Signed-off-by: Yani Ioannou
Signed-off-by: Greg Kroah-Hartman -
The error handling in bus_add_device() and device_attach() is simply
non-existing. This patch propagates any error from device_attach to
the upper layers to allow for a proper recovery.From: Hannes Reinecke
Signed-off-by: Greg Kroah-Hartman -
This adds a generic function 'unregister_node()'.
It is used to remove objects of a node going away
for hotplug. All the devices on the node must be
unregistered before calling this function.Signed-off-by: Keiichiro Tokunaga
Signed-off-by: Greg Kroah-Hartmandiff -puN drivers/base/node.c~numa_hp_base drivers/base/node.c
-
This patch is intended for your "driver" tree. It fixes several subtle
races in driver_detach() and device_release_driver() in the driver-model
core.The major change is to use klist_remove() rather than klist_del() when
taking a device off its driver's list. There's no other way to guarantee
that the list pointers will be updated before some other driver binds to
the device. For this to work driver_detach() can't use a klist iterator,
so the loop over the devices must be written out in full. In addition the
patch protects against the possibility that, when a driver and a device
are unregistered at the same time, one may be unloaded from memory before
the other is finished using it.Signed-off-by: Alan Stern
Signed-off-by: Greg Kroah-Hartman -
There's no check to see if the device is already bound to a driver, which
could do bad things. The first thing to go wrong is that it will try to match
a driver with a device already bound to one. In some cases (it appears with
USB with drivers/usb/core/usb.c::usb_match_id()), some drivers will match a
device based on the class type, so it would be common (especially for HID
devices) to match a device that is already bound.The fun comes when ->probe() is called, it fails, then
driver_probe_device() does this:dev->driver = NULL;
Later on, that pointer could be be dereferenced without checking and cause
hell to break loose.This problem could be nasty. It's very hardware dependent, since some
devices could have a different set of matching qualifiers than others.Now, I don't quite see exactly where/how you were getting that crash.
You're dereferencing bad memory, but I'm not sure which pointer was bad
and where it came from, but it could have come from a couple of different
places.The patch below will hopefully fix it all up for you. It's against
2.6.12-rc2-mm1, and does the following:- Move logic to driver_probe_device() and comments uncommon returns:
1 - If device is bound
0 - If device not bound, and no error
error - If there was an error.- Move locking to caller of that function, since we want to lock a
device for the entire time we're trying to bind it to a driver (to
prevent against a driver being loaded at the same time).- Update __device_attach() and __driver_attach() to do that locking.
- Check if device is already bound in __driver_attach()
- Update the converse device_release_driver() so it locks the device
around all of the operations.- Mark driver_probe_device() as static and remove export. It's an
internal function, it should stay that way, and there are no other
callers. If there is ever a need to export it, we can audit it as
necessary.Signed-off-by: Andrew Morton
-
Also stops looping over the lists when a match is found.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de
-
Signed-off-by: Greg Kroah-Hartman
Index: linux-2.6.12-rc2/drivers/base/driver.c
=================================================================== -
Signed-off-by: Patrick Mochel
Signed-off-by: Greg Kroah-Hartmandiff -Nru a/drivers/base/driver.c b/drivers/base/driver.c
-
- Use klist iterator in device_for_each_child(), making it safe to use for
removing devices.
- Remove unused list_to_dev() function.
- Kills all usage of devices_subsys.rwsem.Signed-off-by: Patrick Mochel
Signed-off-by: Greg Kroah-Hartman -
- Can't wait on removing the current item in the list (the positive refcount *because*
we are using it causes it to deadlock).Signed-off-by: Patrick Mochel
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Patrick Mochel
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Patrick Mochel
Signed-off-by: Greg Kroah-Hartman -
- Don't add devices to bus's embedded kset, since it's not used by anyone anymore.
- Don't need to take the bus rwsem when calling {device,driver}_attach(), since
those functions use the klists and the klists' spinlocks.Signed-off-by: Patrick Mochel
Signed-off-by: Greg Kroah-Hartman -
- Now possible, since the lists are locked using the klist lock and not the
global rwsem.Signed-off-by: Patrick Mochel
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Patrick Mochel
Signed-off-by: Greg Kroah-Hartman -
- Use it in driver_for_each_device() instead of the regular list_head and stop using
the bus's rwsem for protection.
- Use driver_for_each_device() in driver_detach() so we don't deadlock on the
bus's rwsem.
- Remove ->devices.
- Move klist access and sysfs link access out from under device's semaphore, since
they're synchronized through other means.Signed-off-by: Patrick Mochel
Signed-off-by: Greg Kroah-Hartman -
- Use it in bus_for_each_drv().
- Use the klist spinlock instead of the bus rwsem.Signed-off-by: Patrick Mochel
Signed-off-by: Greg Kroah-Hartman -
- Use it for bus_for_each_dev().
- Use the klist spinlock instead of the bus rwsem.Signed-off-by: Patrick Mochel
Signed-off-by: Greg Kroah-Hartman -
Now there's an iterator for accessing each device bound to a driver.
Signed-off-by: Patrick Mochel
Signed-off-by: Greg Kroah-HartmanIndex: linux-2.6.12-rc2/drivers/base/driver.c
=================================================================== -
This relocates the driver binding/unbinding code to drivers/base/dd.c. This is done
for two reasons: One, it's not code related to the bus_type itself; it uses some from
that, some from devices, and some from drivers. And Two, it will make it easier to do
some of the upcoming lock removal on that code..Signed-off-by: Patrick Mochel
Signed-off-by: Greg Kroah-Hartman -
This adds a per-device semaphore that is taken before every call from the core to a
driver method. This prevents e.g. simultaneous calls to the ->suspend() or ->resume()
and ->probe() or ->release(), potentially saving a whole lot of headaches.It also moves us a step closer to removing the bus rwsem, since it protects the fields
in struct device that are modified by the core.Signed-off-by: Patrick Mochel
Signed-off-by: Greg Kroah-Hartman
