11 Jan, 2012

40 commits

  • Signed-off-by: Andy Whitcroft
    Cc: Joe Perches
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andy Whitcroft
     
  • We are incorrectly matching square brackets '[' and ']' leading to false
    positives on more complex functions as below:

    return (dt3155_fbuffer[m]->ready_head -
    dt3155_fbuffer[m]->ready_len +
    dt3155_fbuffer[m]->nbuffers)%
    (dt3155_fbuffer[m]->nbuffers);

    Signed-off-by: Andy Whitcroft
    Cc: Joe Perches
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andy Whitcroft
     
  • It is common to stub out a function as below, this is triggering a complex
    macro format incorrectly. Sort this out:

    #define cma_early_regions_reserve(reserve) do { } while (0)

    Signed-off-by: Andy Whitcroft
    Cc: Joe Perches
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andy Whitcroft
     
  • The following fragment defeats the DEVICE_ATTR style handing, check for
    and ignore the close brace '}' in this context:

    int foo()
    {
    }
    DEVICE_ATTR(link_power_management_policy, S_IRUGO | S_IWUSR,
    ata_scsi_lpm_show, ata_scsi_lpm_put);
    EXPORT_SYMBOL_GPL(dev_attr_link_power_management_policy);

    Signed-off-by: Andy Whitcroft
    Cc: Joe Perches
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andy Whitcroft
     
  • The intent of this check is to catch the options which the user will see
    and ensure they are properly described. It is also common for internal
    only options to have a brief description. Allow this form.

    Reported-by: Steven Rostedt
    Tested-by: Steven Rostedt
    Signed-off-by: Andy Whitcroft
    Cc: Joe Perches
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andy Whitcroft
     
  • In the middle of a long definition or similar, there is no possibility of
    finding a smaller sub-statement. Optimise this case by skipping statement
    aquirey where there are no starts of statement (open brace '{' or
    semi-colon ';'). We are likely to scan slightly more than needed still
    but this is safest.

    Signed-off-by: Andy Whitcroft
    Cc: Joe Perches
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andy Whitcroft
     
  • Inserting a # into the modifiers list will incorrectly add the null string
    to the modifiers list, leading to an infinite loop. As neither of these
    is a valid modifier form simply ignore them.

    Signed-off-by: Andy Whitcroft
    Reported-by: Joe Perches
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andy Whitcroft
     
  • Improve the checking of arguments to memset and min/max tests.

    Move the checking of min/max to statement blocks instead of single line.
    Change $Constant to allow any case type 0x initiator and trailing ul
    specifier. Add $FuncArg type as any function argument with or without a
    cast. Print the whole statement when showing memset or min/max messages.
    Improve the memset with 0 as 3rd argument error message.

    There are still weaknesses in the $FuncArg and $Constant code as arbitrary
    parentheses and negative signs are not generically supported.

    [akpm@linux-foundation.org: fix per Andy]
    Signed-off-by: Joe Perches
    Acked-by: Andy Whitcroft
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Joe Perches
     
  • Move the memset checks over to work against the statement. Also add
    checks for 0 and 1 used as lengths. Generally these indicate badly
    ordered parameters.

    Signed-off-by: Andy Whitcroft
    Cc: Joe Perches
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andy Whitcroft
     
  • When looking for a statement we currently run on through preprocessor
    commands. This means that a header file with just definitions is parsed
    over and over again combining all of the lines from the current line to
    the end of file leading to severe performance issues.

    Fix up context accumulation to track preprocessor commands and stop when
    reaching the end of them. At the same time vastly simplify the #define
    handling.

    Signed-off-by: Andy Whitcroft
    Cc: Joe Perches
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andy Whitcroft
     
  • Add a warn for not using __printf.

    Signed-off-by: Joe Perches
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Joe Perches
     
  • email header lines can look like signature tags. It's valid to have
    multiple email recipients on a single line but not valid to have multiple
    signatures on a single line.

    Validate signatures only when not in the email headers.

    Clear the $in_commit_log flag when the patch filename appears.

    Add '-' to the valid chars in a message header for headers
    like "Message-Id:" and "In-Reply-To:".

    Signed-off-by: Joe Perches
    Reported-by: Julia Lawall
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Joe Perches
     
  • The btree_for_each API is implemented with macros that internally call
    btree_get_prev(), so if btree_get_prev() isn't exported then modules fail
    to link if they try to use one of the btree_for_each macros. Since the
    rest of the btree API is exported, we should keep things orthogonal and
    make this work too.

    Signed-off-by: Roland Dreier
    Signed-off-by: Steve Hodgson
    Acked-by: Joern Engel
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Steve Hodgson
     
  • Saves a small amount of code and systematically eliminates leaks.

    Signed-off-by: Mark Brown
    Cc: Richard Purdie
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Mark Brown
     
  • Saves a small amount of code and systematically eliminates leaks.

    Signed-off-by: Mark Brown
    Cc: Richard Purdie
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Mark Brown
     
  • The LED id begins from 0. Thus the maximum number of leds should be
    MC13783_LED_MAX + 1.

    Signed-off-by: Axel Lin
    Acked-by: Philippe Retornaz
    Cc: Richard Purdie
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Axel Lin
     
  • TI's TCA6507 is the LED driver in the GTA04 Openmoko motherboard. The
    driver provides full support for brightness levels and hardware blinking.

    This driver can drive each of 7 outputs as an LED or a GPIO output,
    and provides hardware-assist blinking.

    [akpm@linux-foundation.org: fix __mod_i2c_device_table alias]
    [akpm@linux-foundation.org: coding-style fixes]
    Signed-off-by: NeilBrown
    Cc: Richard Purdie
    Cc: Randy Dunlap
    Cc: Dan Carpenter
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    NeilBrown
     
  • Use gpio_request_one() instead of multiple gpiolib calls. This also
    simplifies error handling a bit.

    Signed-off-by: Axel Lin
    Cc: Simon Guinot
    Cc: Richard Purdie
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Axel Lin
     
  • Use gpio_request_one() instead of multiple gpiolib calls.

    Signed-off-by: Axel Lin
    Cc: Kim Kyuwon
    Cc: Richard Purdie
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Axel Lin
     
  • Signed-off-by: Axel Lin
    Cc: Samu Onkalo
    Cc: Richard Purdie
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Axel Lin
     
  • Factor out some boilerplate code for spi driver registration into
    module_spi_driver.

    Signed-off-by: Axel Lin
    Cc: Haojian Zhuang
    Cc: Mark Brown
    Cc: Richard Purdie
    Cc: Michael Hennerich
    Cc: Mike Rapoport
    Acked-by: Guennadi Liakhovetski
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Axel Lin
     
  • Factor out some boilerplate code for i2c driver registration
    into module_i2c_driver.

    Signed-off-by: Axel Lin
    Cc: Haojian Zhuang
    Cc: Mark Brown
    Cc: Richard Purdie
    Cc: Michael Hennerich
    Cc: Mike Rapoport
    Cc: Guennadi Liakhovetski
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Axel Lin
     
  • Factor out some boilerplate code for platform driver registration into
    module_platform_driver.

    Signed-off-by: Axel Lin
    Acked-by: Haojian Zhuang [led-88pm860x.c]
    Acked-by: Mark Brown
    Cc: Richard Purdie
    Cc: Michael Hennerich
    Cc: Mike Rapoport
    Cc: Guennadi Liakhovetski
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Axel Lin
     
  • Should be no functional changes, mainly a reorganisation to support future
    work.

    [akpm@linux-foundation.org: fix CONFIG_PM=n build]
    Signed-off-by: Mark Brown
    Cc: Richard Purdie
    Cc: Florian Tobias Schandinat
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Mark Brown
     
  • Saves some error handling code and eliminates a class of leaks.

    Signed-off-by: Mark Brown
    Cc: Richard Purdie
    Cc: Florian Tobias Schandinat
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Mark Brown
     
  • The usage of simple_strtoul() or strict_strtoul() is not preferred. Thus,
    kstrtoul should be used.

    This patch also fixes checkpatch error as follows:
    ERROR: space required after that ',' (ctx:VxV)

    Signed-off-by: Jingoo Han
    Cc: Richard Purdie
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jingoo Han
     
  • module.h is included twice.

    Signed-off-by: Jingoo Han
    Acked-by: H Hartley Sweeten
    Cc: Ryan Mallon
    Cc: Richard Purdie
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jingoo Han
     
  • This patch supports regulator power control in the driver. Current ld9040
    driver was controlled power on/off sequence by callback function in the
    board file. But, by doing this, there's no need to register lcd power
    on/off callback function in the board file.

    Signed-off-by: Donghwa Lee
    Signed-off-by: Kyungmin Park
    Signed-off-by: Inki Dae
    Cc: Richard Purdie
    Cc: Florian Tobias Schandinat
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Donghwa Lee
     
  • Convert the drivers in drivers/video/backlight/* to use the
    module_platform_driver() macro which makes the code smaller and a bit
    simpler.

    Signed-off-by: Axel Lin
    Acked-by: Haojian Zhuang
    Acked-by: H Hartley Sweeten [ep93xx_bl.c]
    Cc: Mike Rapoport
    Cc: Richard Purdie
    Acked-by: Michael Hennerich
    Acked-by: Mark Brown
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Axel Lin
     
  • Support for the Avionic Design Xanthos backlight device got added in
    commit 3b96ea9ef8 ("backlight: Add support for the Avionic Design Xanthos
    backlight device."). That support depends on ARCH_PXA_ADX. The code that
    should have provided that Kconfig symbol never got submitted. It has
    never been possible to even build this driver. Remove it.

    Signed-off-by: Paul Bolle
    Acked-by: Thierry Reding
    Cc: Richard Purdie
    Cc: Wim Van Sebroeck
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Paul Bolle
     
  • As devfreq is merged at mainline. Also update the maintainer entry.

    Signed-off-by: Kyungmin Park
    Cc: Kevin Hilman
    Cc: MyungJoo Ham
    Acked-by: Rafael J. Wysocki
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Kyungmin Park
     
  • commit ca632f55669 ("spi: reorganize drivers") renamed the files, update
    the F: patterns.

    Signed-off-by: Joe Perches
    Acked-by: Grant Likely
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Joe Perches
     
  • commit 0c6967b5a0 ("serial:blackfin: rename Blackfin serial driver to
    bfin_uart.c") renamed the file, update the pattern.

    Signed-off-by: Joe Perches
    Acked-by: Sonic Zhang
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Joe Perches
     
  • commit 4860c73804c ("staging: Move media drivers to staging/media") moved
    the files, update the F: patterns.

    Signed-off-by: Joe Perches
    Acked-by: Mauro Carvalho Chehab
    Cc: Greg KH
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Joe Perches
     
  • commit 61cf45d0199 ("encrypted-keys: create encrypted-keys directory")
    moved the files, update the patterns.

    Signed-off-by: Joe Perches
    Cc: Mimi Zohar
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Joe Perches
     
  • commit 1fe003fd424 ("greth: Move the Aeroflex Gaisler driver") moved the
    files, update the patterns.

    Signed-off-by: Joe Perches
    Cc: Kristoffer Glembo
    Cc: Jeff Kirsher
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Joe Perches
     
  • commit a88394cfb58 ("ewrk3/tulip: Move the DEC - Tulip drivers") moved the
    files, update the patterns.

    Signed-off-by: Joe Perches
    Acked-by: Grant Grundler
    Cc: Jeff Kirsher
    Cc: Tobias Ringstrom
    Cc: Grant Grundler
    Cc: David Davies
    Cc: David Miller
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Joe Perches
     
  • commit 38576af1f8c ("mmc: sdhci: make sdhci-of device drivers self
    registered") moved the files around. Update the patterns.

    Signed-off-by: Joe Perches
    Cc: Shawn Guo
    Cc: Chris Ball
    Acked-by: Anton Vorontsov
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Joe Perches
     
  • commit 8959e74399c ("mfd: Delete ab3550 driver") removed the driver,
    update the patterns.

    Signed-off-by: Joe Perches
    Acked-by: Linus Walleij
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Joe Perches
     
  • Commit f8fc729870ee ("[media] marvell-cam: Move cafe-ccic into its own
    directory") moved the files, update the pattern.

    Signed-off-by: Joe Perches
    Cc: Jonathan Corbet
    Acked-by: Mauro Carvalho Chehab
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Joe Perches