Eric Lee / smarc-fsl-linux-kernel

06 Mar, 2015

1 commit

  • d8bf368d0   genirq: Remove the deprecated 'IRQF_DISABLED' request_irq() flag entirely ... Browse Code »

    The IRQF_DISABLED flag is a NOOP and has been scheduled for removal
    since Linux v2.6.36 by commit 6932bf37bed4 ("genirq: Remove
    IRQF_DISABLED from core code").

    According to commit e58aa3d2d0cc ("genirq: Run irq handlers with
    interrupts disabled"), running IRQ handlers with interrupts
    enabled can cause stack overflows when the interrupt line of the
    issuing device is still active.

    This patch ends the grace period for IRQF_DISABLED (i.e.,
    SA_INTERRUPT in older versions of Linux) and removes the
    definition and all remaining usages of this flag.

    There's still a few non-functional references left in the kernel
    source:

    - The bigger hunk in Documentation/scsi/ncr53c8xx.txt is removed entirely
    as IRQF_DISABLED is gone now; the usage in older kernel versions
    (including the old SA_INTERRUPT flag) should be discouraged. The
    trouble of using IRQF_SHARED is a general problem and not specific to
    any driver.

    - I left the reference in Documentation/PCI/MSI-HOWTO.txt untouched since
    it has already been removed in linux-next.

    - All remaining references are changelogs that I suggest to keep.

    Signed-off-by: Valentin Rothberg
    Cc: Afzal Mohammed
    Cc: Arnd Bergmann
    Cc: Brian Norris
    Cc: Christoph Hellwig
    Cc: Dan Carpenter
    Cc: David Woodhouse
    Cc: Ewan Milne
    Cc: Eyal Perry
    Cc: Felipe Balbi
    Cc: Greg Kroah-Hartman
    Cc: H. Peter Anvin
    Cc: Hannes Reinecke
    Cc: Hongliang Tao
    Cc: Huacai Chen
    Cc: Jiri Kosina
    Cc: Jonathan Corbet
    Cc: Keerthy
    Cc: Laurent Pinchart
    Cc: Linus Torvalds
    Cc: Nishanth Menon
    Cc: Paul Bolle
    Cc: Peter Ujfalusi
    Cc: Peter Zijlstra
    Cc: Quentin Lambert
    Cc: Rajendra Nayak
    Cc: Ralf Baechle
    Cc: Santosh Shilimkar
    Cc: Sricharan R
    Cc: Thomas Gleixner
    Cc: Tony Lindgren
    Cc: Zhou Wang
    Cc: iss_storagedev@hp.com
    Cc: linux-mips@linux-mips.org
    Cc: linux-mtd@lists.infradead.org
    Link: http://lkml.kernel.org/r/1425565425-12604-1-git-send-email-valentinrothberg@gmail.com
    Signed-off-by: Ingo Molnar

    Valentin Rothberg
     

06 Nov, 2014

1 commit

  • aa25729cf   ARM: OMAP3: Fix errors for omap_l3_smx when booted with device tree ... Browse Code »

    When booting omap3 in device tree mode, we're currently getting
    the following errors:

    omap_l3_smx omap_l3_smx.0: couldn't request debug irq
    omap_l3_smx: probe of omap_l3_smx.0 failed with error -22

    This is because we don't have handling in the driver for the
    compatible property and instead assume platform data being
    passed.

    Note that this binding is already documented, and implemented
    for the related omap_l3_noc driver for omap4 and later. Looks
    like the binding somehow never got never implemented for this
    omap_l3_smx driver though.

    Let's also remove __exit_p to allow binding and unbinding
    of the driver while at it.

    Reported-by: Pavel Machek
    Reported-by: Russell King
    Acked-by: Santosh Shilimkar
    Signed-off-by: Tony Lindgren

    Tony Lindgren
     

19 Sep, 2012

1 commit