10 Nov, 2015

1 commit

  • Switch everything to the new and more capable implementation of abs().
    Mainly to give the new abs() a bit of a workout.

    Cc: Michal Nazarewicz
    Cc: John Stultz
    Cc: Ingo Molnar
    Cc: Steven Rostedt
    Cc: Peter Zijlstra
    Cc: Masami Hiramatsu
    Cc: Peter Zijlstra
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Andrew Morton
     

06 Nov, 2015

1 commit

  • Pull spi updates from Mark Brown:
    "Quite a lot of activity in SPI this cycle, almost all of it in drivers
    with a few minor improvements and tweaks in the core.

    - Updates to pxa2xx to support Intel Broxton and multiple chip selects.
    - Support for big endian in the bcm63xx driver.
    - Multiple slave support for the mt8173
    - New driver for the auxiliary SPI controller in bcm2835 SoCs.
    - Support for Layerscale SoCs in the Freescale DSPI driver"

    * tag 'spi-v4.4' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi: (87 commits)
    spi: pxa2xx: Rework self-initiated platform data creation for non-ACPI
    spi: pxa2xx: Add support for Intel Broxton
    spi: pxa2xx: Detect number of enabled Intel LPSS SPI chip select signals
    spi: pxa2xx: Add output control for multiple Intel LPSS chip selects
    spi: pxa2xx: Use LPSS prefix for defines that are Intel LPSS specific
    spi: Add DSPI support for layerscape family
    spi: ti-qspi: improve ->remove() callback
    spi/spi-xilinx: Fix race condition on last word read
    spi: Drop owner assignment from spi_drivers
    spi: Add THIS_MODULE to spi_driver in SPI core
    spi: Setup the master controller driver before setting the chipselect
    spi: dw: replace magic constant by DW_SPI_DR
    spi: mediatek: mt8173 spi multiple devices support
    spi: mediatek: handle controller_data in mtk_spi_setup
    spi: mediatek: remove mtk_spi_config
    spi: mediatek: Update document devicetree bindings to support multiple devices
    spi: fix kernel-doc warnings about missing return desc in spi.c
    spi: fix kernel-doc warnings about missing return desc in spi.h
    spi: pxa2xx: Align a few defines
    spi: pxa2xx: Save other reg_cs_ctrl bits when configuring chip select
    ...

    Linus Torvalds
     

28 Oct, 2015

1 commit


21 Oct, 2015

1 commit


03 Oct, 2015

1 commit

  • drivers/media/i2c/ml86v7667.c:430:3-8: No need to set .owner here. The core will do it.

    Remove .owner field if calls are used which set it automatically

    Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

    CC: Geert Uytterhoeven
    Signed-off-by: Fengguang Wu
    Signed-off-by: Mauro Carvalho Chehab

    Fengguang Wu
     

02 Oct, 2015

1 commit

  • drivers/media/i2c/s5c73m3/s5c73m3-core.c:170:39: warning: incorrect type in argument 1 (different base types)
    drivers/media/i2c/s5c73m3/s5c73m3-core.c:170:39: expected restricted __be16 const [usertype] *p
    drivers/media/i2c/s5c73m3/s5c73m3-core.c:170:39: got unsigned short [usertype] *

    Signed-off-by: Mauro Carvalho Chehab

    Mauro Carvalho Chehab
     

01 Oct, 2015

3 commits

  • Allow the subdevice to be probed asynchronously.

    Signed-off-by: Javier Martinez Canillas
    Acked-by: Sakari Ailus
    Signed-off-by: Hans Verkuil
    Signed-off-by: Mauro Carvalho Chehab

    Javier Martinez Canillas
     
  • The SPI core always reports the MODALIAS uevent as "spi:"
    regardless of the mechanism that was used to register the device
    (i.e: OF or board code) and the table that is used later to match
    the driver with the device (i.e: SPI id table or OF match table).

    So drivers needs to export the SPI id table and this be built into
    the module or udev won't have the necessary information to autoload
    the needed driver module when the device is added.

    But this means that OF-only drivers needs to have both OF and SPI id
    tables that have to be kept in sync and also the dev node compatible
    manufacturer prefix is stripped when reporting the MODALIAS. Which can
    lead to issues if two vendors use the same SPI device name for example.

    To avoid the above, the SPI core behavior may be changed in the future
    to not require an SPI device table for OF-only drivers and report the
    OF module alias. So, it's better to also export the OF table even when
    is unused now to prevent breaking module loading when the core changes.

    Signed-off-by: Javier Martinez Canillas
    Reviewed-by: Andrzej Hajda
    Signed-off-by: Hans Verkuil
    Signed-off-by: Mauro Carvalho Chehab

    Javier Martinez Canillas
     
  • The driver was written with the 'soc_camera' use in mind, however the g_std()
    video method was forgotten. Implement it at last...

    Signed-off-by: Sergei Shtylyov
    Signed-off-by: Hans Verkuil
    Signed-off-by: Mauro Carvalho Chehab

    Sergei Shtylyov
     

06 Sep, 2015

1 commit

  • Pull media updates from Mauro Carvalho Chehab:
    - new DVB frontend drivers: ascot2e, cxd2841er, horus3a, lnbh25
    - new HDMI capture driver: tc358743
    - new driver for NetUP DVB new boards (netup_unidvb)
    - IR support for DVBSky cards (smipcie-ir)
    - Coda driver has gain macroblock tiling support
    - Renesas R-Car gains JPEG codec driver
    - new DVB platform driver for STi boards: c8sectpfe
    - added documentation for the media core kABI to device-drivers DocBook
    - lots of driver fixups, cleanups and improvements

    * tag 'media/v4.3-1' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media: (297 commits)
    [media] c8sectpfe: Remove select on undefined LIBELF_32
    [media] i2c: fix platform_no_drv_owner.cocci warnings
    [media] cx231xx: Use wake_up_interruptible() instead of wake_up_interruptible_nr()
    [media] tc358743: only queue subdev notifications if devnode is set
    [media] tc358743: add missing Kconfig dependency/select
    [media] c8sectpfe: Use %pad to print 'dma_addr_t'
    [media] DocBook media: Fix typo "the the" in xml files
    [media] tc358743: make reset gpio optional
    [media] tc358743: set direction of reset gpio using devm_gpiod_get
    [media] dvbdev: document most of the functions/data structs
    [media] dvb_frontend.h: document the struct dvb_frontend
    [media] dvb-frontend.h: document struct dtv_frontend_properties
    [media] dvb-frontend.h: document struct dvb_frontend_ops
    [media] dvb: Use DVBFE_ALGO_HW where applicable
    [media] dvb_frontend.h: document struct analog_demod_ops
    [media] dvb_frontend.h: Document struct dvb_tuner_ops
    [media] Docbook: Document struct analog_parameters
    [media] dvb_frontend.h: get rid of dvbfe_modcod
    [media] add documentation for struct dvb_tuner_info
    [media] dvb_frontend: document dvb_frontend_tune_settings
    ...

    Linus Torvalds
     

04 Sep, 2015

5 commits

  • drivers/media/i2c/tc358743.c:1960:3-8: No need to set .owner here. The core will do it.

    Remove .owner field if calls are used which set it automatically

    Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

    CC: Geert Uytterhoeven
    Signed-off-by: Fengguang Wu
    Signed-off-by: Mauro Carvalho Chehab

    Fengguang Wu
     
  • Hardware interrupts are enabled in the probe function, before the subdev
    is registered to its v4l2_device. Until v4l2_device_register_subdev_node
    is called, sd->devnode is NULL and v4l2_subdev_notify_event must not be
    called.

    Signed-off-by: Philipp Zabel
    Signed-off-by: Mauro Carvalho Chehab

    Philipp Zabel
     
  • As reported by Randy:
    > when CONFIG_MEDIA_CONTROLLER is not enabled:
    >
    > ../drivers/media/i2c/tc358743.c: In function 'tc358743_probe':
    > ../drivers/media/i2c/tc358743.c:1890:29: error: 'struct v4l2_subdev' has no member named 'entity'
    > err = media_entity_init(&sd->entity, 1, &state->pad, 0);
    > ^
    > ../drivers/media/i2c/tc358743.c:1940:26: error: 'struct v4l2_subdev' has no member named 'entity'
    > media_entity_cleanup(&sd->entity);
    > ^
    > ../drivers/media/i2c/tc358743.c: In function 'tc358743_remove':
    > ../drivers/media/i2c/tc358743.c:1955:26: error: 'struct v4l2_subdev' has no member named 'entity'
    > media_entity_cleanup(&sd->entity);
    > ^

    This driver depends on VIDEO_V4L2_SUBDEV_API and needs to select HDMI.

    Signed-off-by: Hans Verkuil
    Reported-by: Randy Dunlap
    Signed-off-by: Mauro Carvalho Chehab

    Hans Verkuil
     
  • Commit 256148246852 ("[media] tc358743: support probe from device tree")
    specified in the device tree binding documentation that the reset gpio
    is optional. Make the implementation match accordingly.

    Signed-off-by: Uwe Kleine-König
    Reviewed-by: Linus Walleij
    Acked-by: Philipp Zabel
    Signed-off-by: Mauro Carvalho Chehab

    Uwe Kleine-König
     
  • Commit 256148246852 ("[media] tc358743: support probe from device tree")
    failed to explicitly set the direction of the reset gpio. Use the
    optional flag of devm_gpiod_get to make up leeway.

    This is also necessary because the flag parameter will become mandatory
    soon.

    Signed-off-by: Uwe Kleine-König
    Reviewed-by: Linus Walleij
    Acked-by: Philipp Zabel
    Signed-off-by: Mauro Carvalho Chehab

    Uwe Kleine-König
     

17 Aug, 2015

1 commit


16 Aug, 2015

4 commits

  • sr030pc30_get_fmt() can only succeed if both info->curr_win and
    info->curr_fmt are not NULL.

    If one of those vars are null, the curent code would call:
    ret = sr030pc30_set_params(sd);

    If the curr_win is null, it will return -EINVAL, as it would be
    expected. However, if curr_fmt is NULL, the function won't
    set it.

    The code will then try to read from it:

    mf->code = info->curr_fmt->code;
    mf->colorspace = info->curr_fmt->colorspace;

    with obviouly won't work.

    This got reported by smatch:
    drivers/media/i2c/sr030pc30.c:505 sr030pc30_get_fmt() error: we previously assumed 'info->curr_win' could be null (see line 499)
    drivers/media/i2c/sr030pc30.c:507 sr030pc30_get_fmt() error: we previously assumed 'info->curr_fmt' could be null (see line 499)

    Signed-off-by: Mauro Carvalho Chehab

    Mauro Carvalho Chehab
     
  • Why to store the chosed values for prediv, postdiv and mult if
    those won't be used?

    drivers/media/i2c/ov2659.c: In function 'ov2659_pll_calc_params':
    drivers/media/i2c/ov2659.c:912:35: warning: variable 's_mult' set but not used [-Wunused-but-set-variable]
    u32 s_prediv = 1, s_postdiv = 1, s_mult = 1;
    ^
    drivers/media/i2c/ov2659.c:912:20: warning: variable 's_postdiv' set but not used [-Wunused-but-set-variable]
    u32 s_prediv = 1, s_postdiv = 1, s_mult = 1;
    ^
    drivers/media/i2c/ov2659.c:912:6: warning: variable 's_prediv' set but not used [-Wunused-but-set-variable]
    u32 s_prediv = 1, s_postdiv = 1, s_mult = 1;
    ^

    This is likely some leftover from some past change.

    Signed-off-by: Mauro Carvalho Chehab

    Mauro Carvalho Chehab
     
  • drivers/media/i2c/ov9650.c:1439 ov965x_detect_sensor() warn: inconsistent indenting

    Signed-off-by: Mauro Carvalho Chehab

    Mauro Carvalho Chehab
     
  • drivers/media/i2c/tc358743.c:148:19: warning: Variable length array is used.

    As the maximum size is 1026, we can't use dynamic var, as it
    would otherwise spend 1056 bytes of the stack at i2c_wr() function.

    So, allocate a buffer with the allowed maximum size together with
    the state var.

    Signed-off-by: Mauro Carvalho Chehab
    Acked-by: Mats Randgaard
    Signed-off-by: Mauro Carvalho Chehab

    Mauro Carvalho Chehab
     

12 Aug, 2015

2 commits


11 Aug, 2015

11 commits

  • Make the i2c devices menu visible when compile-testing, to allow
    selecting additional drivers on top of the drivers that are already
    automatically selected if MEDIA_SUBDRV_AUTOSELECT is enabled.

    Without this, many drivers stay disabled during e.g. allmodconfig.

    Signed-off-by: Geert Uytterhoeven
    Signed-off-by: Mauro Carvalho Chehab

    Geert Uytterhoeven
     
  • In ancient times it was necessary to manually initialize the bus
    field of an spi_driver to spi_bus_type. These days this is done in
    spi_register_driver(), so we can drop the manual assignment.

    Signed-off-by: Antonio Borneo
    Reviewed-by: Andrzej Hajda
    Signed-off-by: Mauro Carvalho Chehab

    Antonio Borneo
     
  • drivers/media/i2c/mt9v032.c: In function ‘mt9v032_probe’:
    CC [M] drivers/media/i2c/s5k4ecgx.o
    drivers/media/i2c/mt9v032.c:996:20: warning: ‘pdata’ may be used uninitialized in this function [-Wmaybe-uninitialized]
    if (pdata && pdata->link_freqs) {
    ^

    It can indeed be uninitialized in one corner case. Initialize to NULL.

    Signed-off-by: Hans Verkuil
    Signed-off-by: Mauro Carvalho Chehab

    Hans Verkuil
     
  • Using adv7611_read_cable_det() for ADV7612 means that full
    support for '.max_port = ADV7604_PAD_HDMI_PORT_B,' isn't available
    due to the need for multiple port reads to determine cable detection,
    and an agreed mechanism for communicating the separate statuses.

    This patch replaces adv7611_read_cable_det() with a functionally
    identical copy, commented appropriately.

    Earlier submissions [leading to commit 8331d30b] also set .cp_csc,
    which is used in a cp_read() call within adv76xx_log_status().

    Signed-off-by: William Towle
    Signed-off-by: Hans Verkuil
    Signed-off-by: Mauro Carvalho Chehab

    William Towle
     
  • Prior to commit f862f57d ("[media] media: i2c: ADV7604: Migrate to
    regmap"), the local variable 'val' contained the combined register
    reads used in the chipset version ID test. Restore this expectation
    so that the comparison works as it used to.

    Signed-off-by: William Towle
    Signed-off-by: Hans Verkuil
    Signed-off-by: Mauro Carvalho Chehab

    William Towle
     
  • The JPEG colorspace should only be used for JPEG encoded images. This is
    just a regular sRGB sensor.

    Signed-off-by: Hans Verkuil
    Acked-by: Guennadi Liakhovetski
    Signed-off-by: Mauro Carvalho Chehab

    Hans Verkuil
     
  • Simplify confusing conditions. This also swaps the checks for NTSC and PAL:
    to be consistent with other drivers check for NTSC first. So if the user
    sets both NTSC and PAL bits, then NTSC wins.

    Signed-off-by: Hans Verkuil
    Acked-by: Guennadi Liakhovetski
    Signed-off-by: Mauro Carvalho Chehab

    Hans Verkuil
     
  • When the standard changes the VACTIVE and VDELAY values need to be updated.

    Signed-off-by: Hans Verkuil
    Acked-by: Guennadi Liakhovetski
    Signed-off-by: Mauro Carvalho Chehab

    Hans Verkuil
     
  • This is an SDTV video receiver, so the colorspace should be SMPTE170M.

    Signed-off-by: Hans Verkuil
    Acked-by: Guennadi Liakhovetski
    Signed-off-by: Mauro Carvalho Chehab

    Hans Verkuil
     
  • The zoran driver has now been converted to the control framework
    which means that these three subdevice drivers no longer need to
    support the legacy core control ops since the last bridge driver
    that needed that has now been converted.

    Signed-off-by: Hans Verkuil
    Signed-off-by: Mauro Carvalho Chehab

    Hans Verkuil
     
  • The bt pointer was never used, remove it.

    Signed-off-by: Hans Verkuil
    Signed-off-by: Mauro Carvalho Chehab

    Hans Verkuil
     

22 Jul, 2015

5 commits


17 Jul, 2015

2 commits

  • The driver is tested on our hardware and all the implemented features
    works as expected.

    Missing features:
    - CEC support
    - HDCP repeater support
    - IR support

    Signed-off-by: Mats Randgaard
    [hans.verkuil@cisco.com: updated copyright year to 2015]
    [hans.verkuil@cisco.com: update confusing confctl_mutex comment]
    Signed-off-by: Hans Verkuil

    Signed-off-by: Mauro Carvalho Chehab

    Mats Randgaard
     
  • The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is
    not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer
    functionality only, can still be compiled if GPIOLIB is not enabled.

    Relax the dependency of VIDEO_ADV7604 and VIDEO_COBALT (the latter
    selects the former) on GPIOLIB if COMPILE_TEST is enabled.

    Signed-off-by: Geert Uytterhoeven
    Signed-off-by: Hans Verkuil
    Signed-off-by: Mauro Carvalho Chehab

    Geert Uytterhoeven