27 Oct, 2007
5 commits
-
This patch fixes the errors made in the users of the crypto layer during
the sg_init_table conversion. It also adds a few conversions that were
missing altogether.Signed-off-by: Herbert Xu
Signed-off-by: David S. Miller -
The pid namespace patches changed the semantics of
find_task_by_pid without breaking the compile resulting
in get_net_ns_by_pid doing the wrong thing.So switch to using the intended find_task_by_vpid.
Combined with Denis' earlier patch to make netlink traffic
fully synchronous the inadvertent race I introduced with
accessing current is actually removed.Signed-off-by: Eric W. Biederman
Signed-off-by: David S. Miller -
It is not safe to to place struct pernet_operations in a special section.
We need struct pernet_operations to last until we call unregister_pernet_subsys.
Which doesn't happen until module unload.So marking struct pernet_operations is a disaster for modules in two ways.
- We discard it before we call the exit method it points to.
- Because I keep struct pernet_operations on a linked list discarding
it for compiled in code removes elements in the middle of a linked
list and does horrible things for linked insert.So this looks safe assuming __exit_refok is not discarded
for modules.Signed-off-by: Eric W. Biederman
Signed-off-by: David S. Miller -
This patch fixes the following compile errors in some configurations:
...
CC net/ipv4/esp4.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/net/ipv4/esp4.c: In function 'esp_output':
/home/bunk/linux/kernel-2.6/git/linux-2.6/net/ipv4/esp4.c:113: error: implicit declaration of function 'sg_init_table'
make[3]: *** [net/ipv4/esp4.o] Error 1
...
/home/bunk/linux/kernel-2.6/git/linux-2.6/net/ipv6/esp6.c: In function 'esp6_output':
/home/bunk/linux/kernel-2.6/git/linux-2.6/net/ipv6/esp6.c:112: error: implicit declaration of function 'sg_init_table'
make[3]: *** [net/ipv6/esp6.o] Error 1Signed-off-by: Adrian Bunk
Signed-off-by: David S. Miller -
net/ipv6/tcp_ipv6.c: In function 'tcp_v6_rcv':
net/ipv6/tcp_ipv6.c:1736: error: implicit declaration of function
'get_softnet_dma'
net/ipv6/tcp_ipv6.c:1736: warning: assignment makes pointer from integer
without a castSigned-off-by: Jeff Garzik
Signed-off-by: David S. Miller
26 Oct, 2007
22 commits
-
This fixes some awkward, and perhaps even problematic, RCU lock usage in the
NetLabel code as well as some other related trivial cleanups found when
looking through the RCU locking. Most of the changes involve removing the
redundant RCU read locks wrapping spinlocks in the case of a RCU writer.Signed-off-by: Paul Moore
Signed-off-by: David S. Miller -
In the current net-2.6 kernel, handling FLAG_DSACKING_ACK is broken.
The flag is cleared to 1 just after FLAG_DSACKING_ACK is set.if (found_dup_sack)
flag |= FLAG_DSACKING_ACK;
:
flag = 1;To fix it, this patch introduces a part of the tcp_sacktag_state patch:
http://marc.info/?l=linux-netdev&m=119210560431519&w=2Signed-off-by: Ryousei Takano
Signed-off-by: Ilpo Järvinen
Signed-off-by: David S. Miller -
This patch makes three needlessly global functions static.
Signed-off-by: Adrian Bunk
Acked-by: Vlad Yasevich
Signed-off-by: David S. Miller -
Signed-off-by: David S. Miller
-
sctp_update_copy_cksum() is no longer used.
Signed-off-by: Adrian Bunk
Acked-by: Vlad Yasevich
Signed-off-by: David S. Miller -
This patch removes the unused EXPORT_SYMBOL(icmpmsg_statistics).
Signed-off-by: Adrian Bunk
Signed-off-by: David S. Miller -
sock_enable_timestamp() no longer has any modular users.
Signed-off-by: Adrian Bunk
Signed-off-by: David S. Miller -
tcp_match_skb_to_sack() can become static.
Signed-off-by: Adrian Bunk
Signed-off-by: David S. Miller -
ircomm_tty can now become static.
Signed-off-by: Adrian Bunk
Signed-off-by: David S. Miller -
Prevent error/backtrace from dev_rename() when changing
name of network device to the same name. This is a common
situation with udev and other scripts that bind addr to device.Signed-off-by: Stephen Hemminger
Signed-off-by: David S. Miller -
clean skb_clone of any signs of CONFIG_NET_CLS_ACT and
have mirred us skb_act_clone()Signed-off-by: Jamal Hadi Salim
Signed-off-by: David S. Miller -
Use sg_init_table() and sg_mark_end() as needed.
Signed-off-by: David S. Miller
-
Use sg_init_one() and sg_init_table() as needed.
Signed-off-by: David S. Miller
-
Signed-off-by: David S. Miller
-
Fix inconsistency of terms:
1) D-SACK
2) F-RTOSigned-off-by: Ryousei Takano
Signed-off-by: David S. Miller -
My AID message patch introduced a warning on 64-bit machines because ~
extends to unsigned long:| net/mac80211/ieee80211_sta.c: In function ‘ieee80211_rx_mgmt_assoc_resp’:
| net/mac80211/ieee80211_sta.c:1187: warning: format ‘%d’ expects type ‘int’, but argument 7 has type ‘long unsigned int’This fixes it by explicitly casting the result to u16 (which 'aid' is).
Signed-off-by: Johannes Berg
Signed-off-by: John W. Linville -
The length of the SSID desired should also be compared in addition to
the memcmp of the SSIDs.Thanks to Andrea Merello for finding this issue.
Signed-off-by: Michael Wu
Signed-off-by: John W. Linville -
UDP currently uses skb->dev->ifindex which may provide the wrong
information when the socket bound to a specific interface.
This patch makes inet_iif() accessible to UDP and makes UDP use it.The scenario we are trying to fix is when a client is running on
the same system and the server and both client and server bind to
a non-loopback device.Signed-off-by: Vlad Yasevich
Acked-by: David L Stevens
Signed-off-by: David S. Miller -
This was obsoleted by a previous change, but the removal was
forgotten.Reported by David Howells and David Stevens.
Signed-off-by: David S. Miller
-
* 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6:
[IPV4]: Explicitly call fib_get_table() in fib_frontend.c
[NET]: Use BUILD_BUG_ON in net/core/flowi.c
[NET]: Remove in-code externs for some functions from net/core/dev.c
[NET]: Don't declare extern variables in net/core/sysctl_net_core.c
[TCP]: Remove unneeded implicit type cast when calling tcp_minshall_update()
[NET]: Treat the sign of the result of skb_headroom() consistently
[9P]: Fix missing unlock before return in p9_mux_poll_start
[PKT_SCHED]: Fix sch_prio.c build with CONFIG_NETDEVICES_MULTIQUEUE
[IPV4] ip_gre: sendto/recvfrom NBMA address
[SCTP]: Consolidate sctp_ulpq_renege_xxx functions
[NETLINK]: Fix ACK processing after netlink_dump_start
[VLAN]: MAINTAINERS update
[DCCP]: Implement SIOCINQ/FIONREAD
[NET]: Validate device addr prior to interface-up
24 Oct, 2007
13 commits
-
Assigning initial values of `0' is redundant when loading a new CCID structure,
since in net/dccp/ccid.c the entire CCID structure is zeroed out prior to
initialisation in ccid_new():struct ccid {
struct ccid_operations *ccid_ops;
char ccid_priv[0];
};// ...
if (rx) {
memset(ccid + 1, 0, ccid_ops->ccid_hc_rx_obj_size);
if (ccid->ccid_ops->ccid_hc_rx_init != NULL &&
ccid->ccid_ops->ccid_hc_rx_init(ccid, sk) != 0)
goto out_free_ccid;
} else {
memset(ccid + 1, 0, ccid_ops->ccid_hc_tx_obj_size);
/* analogous to the rx case */
}This patch therefore removes the redundant assignments. Thanks to Arnaldo for
the inspiration.Signed-off-by: Gerrit Renker
Signed-off-by: Ian McDonald
Signed-off-by: Arnaldo Carvalho de Melo -
This fixes `unaligned (read) access' errors of the type
Kernel unaligned access at TPC[100f970c] dccp_parse_options+0x4f4/0x7e0 [dccp]
Kernel unaligned access at TPC[1011f2e4] ccid3_hc_tx_parse_options+0x1ac/0x380 [dccp_ccid3]
Kernel unaligned access at TPC[100f9898] dccp_parse_options+0x680/0x880 [dccp]by using the get_unaligned macro for parsing options.
Commiter note: Preserved the sparse __be{16,32} annotations.
Signed-off-by: Gerrit Renker
Signed-off-by: Ian McDonald
Signed-off-by: Arnaldo Carvalho de Melo -
This adds support for converting the 11 currently defined Reset codes into system
error numbers, which are stored in sk_err for further interpretation.This makes the externally visible API behaviour similar to TCP, since a client
connecting to a non-existing port will experience ECONNREFUSED.* Code 0, Unspecified, is interpreted as non-error (0);
* Code 1, Closed (normal termination), also maps into 0;
* Code 2, Aborted, maps into "Connection reset by peer" (ECONNRESET);
* Code 3, No Connection and
Code 7, Connection Refused, map into "Connection refused" (ECONNREFUSED);
* Code 4, Packet Error, maps into "No message of desired type" (ENOMSG);
* Code 5, Option Error, maps into "Illegal byte sequence" (EILSEQ);
* Code 6, Mandatory Error, maps into "Operation not supported on transport endpoint" (EOPNOTSUPP);
* Code 8, Bad Service Code, maps into "Invalid request code" (EBADRQC);
* Code 9, Too Busy, maps into "Too many users" (EUSERS);
* Code 10, Bad Init Cookie, maps into "Invalid request descriptor" (EBADR);
* Code 11, Aggression Penalty, maps into "Quota exceeded" (EDQUOT)
which makes sense in terms of using more than the `fair share' of bandwidth.Signed-off-by: Gerrit Renker
Acked-by: Ian McDonald
Signed-off-by: Arnaldo Carvalho de Melo -
This fixes the following problem: client connects to peer which has no DCCP
enabled or loaded; ICMP error messages ("Protocol Unavailable") can be seen
on the wire, but the application hangs. Reason: ICMP packets don't get through
to dccp_v4_err.When reporting errors, a sequence number check is made for the DCCP packet
that had caused an ICMP error to arrive.
Such checks can not be made if the socket is in state LISTEN, RESPOND (which
in the implementation is the same as LISTEN), or REQUEST, since update_gsr()
has not been called in these states, hence the sequence window is 0..0.This patch fixes the problem by adding the REQUEST state as another exemption
to the window check. The error reporting now works as expected on connecting.Signed-off-by: Gerrit Renker
Acked-by: Ian McDonald
Signed-off-by: Arnaldo Carvalho de Melo -
This fixes a problem when analysing erroneous packets in dccp_v{4,6}_err:
* dccp_hdr_seq currently takes an skb
* however, the transport headers in the skb are shifted, due to the
preceding IPv4/v6 header.
Fixed for v4 and v6 by changing dccp_hdr_seq to take a struct dccp_hdr as
argument. Verified that the correct sequence number is now reported in the
error handler.Signed-off-by: Gerrit Renker
Acked-by: Ian McDonald
Signed-off-by: Arnaldo Carvalho de Melo -
Most drivers need to set length and offset as well, so may as well fold
those three lines into one.Add sg_assign_page() for those two locations that only needed to set
the page, where the offset/length is set outside of the function context.Signed-off-by: Jens Axboe
-
Signed-off-by: Geert Uytterhoeven
Signed-off-by: Jens Axboe -
In case the "multiple tables" config option is y, the ip_fib_local_table
is not a variable, but a macro, that calls fib_get_table(RT_TABLE_LOCAL).Some code uses this "variable" *3* times in one place, thus implicitly
making 3 calls. Fix it.Signed-off-by: Pavel Emelyanov
Signed-off-by: David S. Miller -
Instead of ugly extern not-existing function.
Signed-off-by: Pavel Emelyanov
Signed-off-by: David S. Miller -
Inconsistent prototype and real type for functions may have worse
consequences, than those for variables, so move them into a header.Since they are used privately in net/core, make this file reside in
the same place.Signed-off-by: Pavel Emelyanov
Signed-off-by: David S. Miller -
Some are already declared in include/linux/netdevice.h, while
some others (xfrm ones) need to be declared.The driver/net/rrunner.c just uses same extern as well, so
cleanup it also.Signed-off-by: Pavel Emelyanov
Signed-off-by: David S. Miller -
In some places, the result of skb_headroom() is compared to an unsigned
integer, and in others, the result is compared to a signed integer. Make
the comparisons consistent and correct.Signed-off-by: Chuck Lever
Signed-off-by: David S. Miller -
Signed-off-by: Roel Kluin
Signed-off-by: David S. Miller
