16 Sep, 2008
17 commits
-
Some comments refer to 80211.o or similar; also remove
a comment about implementing fragments better, we really
have better things to do.Signed-off-by: Johannes Berg
Signed-off-by: John W. Linville -
Most of the scan functions are called ieee80211_sta_scan_*
or similar, make clean it up so they are all just called
ieee80211_scan_*.Signed-off-by: Johannes Berg
Signed-off-by: John W. Linville -
The bridge_packets configuration really should be per virtual
interface (theoretically per AP/VLAN, but this is much easier);
there currently is no way to set it yet though. Also invert
the option to "NO_BRIDGE_PACKETS" so the default is to bridge.While at it, also document the flags properly.
Signed-off-by: Johannes Berg
Signed-off-by: John W. Linville -
It really doesn't belong into the wireless extensions code.
Signed-off-by: Johannes Berg
Signed-off-by: John W. Linville -
This way all the utility functions are at the top, then the
state machine and externally callable functions are moved to
the bottom. Also clean up ieee80211_i.h a bit and add a few
comments about which functions are called from where.Signed-off-by: Johannes Berg
Signed-off-by: John W. Linville -
When we remove an interface, we can currently end up having
a pointer to it left in local->scan_sdata after it has been
set down, and then with a hardware scan the scan completion
can try to access it which is a bug. Alternatively, a scan
that started as a hardware scan may terminate as though it
was a software scan, if the timing is just right.On SMP systems, software scan also has a similar problem,
just canceling the delayed work and setting a flag isn't
enough since it may be running concurrently; in this case
we would also never restore state of other interfaces.This patch hopefully fixes the problems by always invoking
ieee80211_scan_completed or requiring it to be invoked by
the driver, I suspect the drivers that have ->hw_scan() are
buggy. The bug will not manifest itself unless you remove
the interface while hw-scanning which will also turn off
the hw, and then add a new interface which will be unusable
until you scan once.Signed-off-by: Johannes Berg
Signed-off-by: John W. Linville -
When we stop an interface, the work on it may still be pending
or running. We do cancel the timer, but we do not currently
protect against the work struct. The race is very unlikely to
hit -- it'll happen only when the driver is using mac80211's
workqueue to run long-running tasks and the sta/mesh works are
delayed for quite a bit.This patch fixes it by cancelling the work explicitly.
Signed-off-by: Johannes Berg
Signed-off-by: John W. Linville -
This patch splits off mesh handling from the STA/IBSS.
Unfortunately it increases mesh code size a bit, but I
think it makes things clearer. The patch also reduces
per-interface run-time memory usage.Also clean up a few places where ifdef is not required.
Signed-off-by: Johannes Berg
Signed-off-by: John W. Linville -
The timer restart is done wrongly, we shouldn't set the REQ_RUN
bit when the scan has finished if it hadn't been set before the
scan started. If the timer fires during the scan, it will set
REQ_RUN and then we can run the work for it, if it didn't fire
then we shouldn't run its work either.Signed-off-by: Johannes Berg
Signed-off-by: John W. Linville -
This I shouldn't have moved to the scan implementation, move
it back to the MLME where it belongs, to the notification.Signed-off-by: Johannes Berg
Signed-off-by: John W. Linville -
ieee80211_sta_expire uses the internal __sta_info_unlink
function which can become static if this function is moved
to sta_info.c.Signed-off-by: Johannes Berg
Signed-off-by: John W. Linville -
And support setting both long and short retries independently.
Signed-off-by: Dan Williams
Signed-off-by: John W. Linville -
RF kill support is enabled when CONFIG_RFKILL
is set.Signed-off-by: Vasanthakumar Thiagarajan
Signed-off-by: John W. Linville -
Some of the functions in main.c are re-ordered in such
a way that all local functions are defined before mac80211
and pci callbacks.Signed-off-by: Vasanthakumar Thiagarajan
Signed-off-by: John W. Linville -
The generic reset command is unused. Each interface type needs to
handle the reset command differently since after reset, the firmware is
dead and interface-specific mechanisms must be used to reinitialize the
card.Signed-off-by: Dan Williams
Signed-off-by: John W. Linville -
This cleans up zd1211rw's own regulatory work, and makes use of
the new cfg80211 regulatory_hint().Signed-off-by: Luis R. Rodriguez
Signed-off-by: John W. Linville -
This adds the new wireless regulatory infrastructure. The
main motiviation behind this was to centralize regulatory
code as each driver was implementing their own regulatory solution,
and to replace the initial centralized code we have where:* only 3 regulatory domains are supported: US, JP and EU
* regulatory domains can only be changed through module parameter
* all rules were built statically in the kernelWe now have support for regulatory domains for many countries
and regulatory domains are now queried through a userspace agent
through udev allowing distributions to update regulatory rules
without updating the kernel.Each driver can regulatory_hint() a regulatory domain
based on either their EEPROM mapped regulatory domain value to a
respective ISO/IEC 3166-1 country code or pass an internally built
regulatory domain. We also add support to let the user set the
regulatory domain through userspace in case of faulty EEPROMs to
further help compliance.Support for world roaming will be added soon for cards capable of
this.For more information see:
http://wireless.kernel.org/en/developers/Regulatory/CRDA
For now we leave an option to enable the old module parameter,
ieee80211_regdom, and to build the 3 old regdomains statically
(US, JP and EU). This option is CONFIG_WIRELESS_OLD_REGULATORY.
These old static definitions and the module parameter is being
scheduled for removal for 2.6.29. Note that if you use this
you won't make use of a world regulatory domain as its pointless.
If you leave this option enabled and if CRDA is present and you
use US or JP we will try to ask CRDA to update us a regulatory
domain for us.Signed-off-by: Luis R. Rodriguez
Signed-off-by: John W. Linville
13 Sep, 2008
7 commits
-
Signed-off-by: Stephen Rothwell
Signed-off-by: David S. Miller -
This patch resolves a few issues found with multiq including wording
suggestions and a problem seen in the allocation of queues.Signed-off-by: Alexander Duyck
Signed-off-by: Jeff Kirsher
Signed-off-by: David S. Miller -
Signed-off-by: Alexander Duyck
Signed-off-by: Jeff Kirsher
Signed-off-by: David S. Miller -
This new action will have the ability to change the priority and/or
queue_mapping fields on an sk_buff.Signed-off-by: Alexander Duyck
Signed-off-by: Jeff Kirsher
Signed-off-by: David S. Miller -
This patch is intended to add a qdisc to support the new tx multiqueue
architecture by providing a band for each hardware queue. By doing
this it is possible to support a different qdisc per physical hardware
queue.This qdisc uses the skb->queue_mapping to select which band to place
the traffic onto. It then uses a round robin w/ a check to see if the
subqueue is stopped to determine which band to dequeue the packet from.Signed-off-by: Alexander Duyck
Signed-off-by: Jeff Kirsher
Signed-off-by: David S. Miller -
inet6_rsk() is called on a struct request_sock * before we
have checked whether the socket is an ipv6 socket or a ipv6-
mapped ipv4 socket. The access that triggers this is the
inet_rsk(rsk)->inet6_rsk_offset dereference in inet6_rsk().This is arguably not a critical error as the inet6_rsk_offset
is only used to compute a pointer which is never really used
(in the code path in question) anyway. But it might be a
latent error, so let's fix it.Spotted by kmemcheck.
Signed-off-by: Vegard Nossum
Acked-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller -
The dst garbage collector dst_gc_task() may not be scheduled as we
expect it to be in __dst_free().Indeed, when the dst_gc_timer was replaced by the delayed_work
dst_gc_work, the mod_timer() call used to schedule the garbage
collector at an earlier date was replaced by a schedule_delayed_work()
(see commit 86bba269d08f0c545ae76c90b56727f65d62d57f).But, the behaviour of mod_timer() and schedule_delayed_work() is
different in the way they handle the delay.mod_timer() stops the timer and re-arm it with the new given delay,
whereas schedule_delayed_work() only check if the work is already
queued in the workqueue (and queue it (with delay) if it is not)
BUT it does NOT take into account the new delay (even if the new delay
is earlier in time).
schedule_delayed_work() returns 0 if it didn't queue the work,
but we don't check the return code in __dst_free().If I understand the code in __dst_free() correctly, we want dst_gc_task
to be queued after DST_GC_INC jiffies if we pass the test (and not in
some undetermined time in the future), so I think we should add a call
to cancel_delayed_work() before schedule_delayed_work(). Patch below.Or we should at least test the return code of schedule_delayed_work(),
and reset the values of dst_garbage.timer_inc and dst_garbage.timer_expires
back to their former values if schedule_delayed_work() failed.
Otherwise the subsequent calls to __dst_free will test the wrong values
and assume wrong thing about when the garbage collector is supposed to
be scheduled.dst_gc_task() also calls schedule_delayed_work() without checking
its return code (or calling cancel_scheduled_work() first), but it
should fine there: dst_gc_task is the routine of the delayed_work, so
no dst_gc_work should be pending in the queue when it's running.Signed-off-by: Benjamin Thery
Acked-by: Eric Dumazet
Signed-off-by: David S. Miller
12 Sep, 2008
16 commits
-
The vlan devices are not reading the gso max size of the parent device. As
a result devices that do not support 64K max gso size are currently
failing.This issue is seen on 2.6.26 kernels as well and the same patch should be
able to be applied without any issues.Signed-off-by: Alexander Duyck
Signed-off-by: Jeff Kirsher
Signed-off-by: David S. Miller -
Conflicts:
drivers/net/wireless/ath9k/beacon.c
drivers/net/wireless/ath9k/core.h -
Noticed by Michael Chan.
Signed-off-by: David S. Miller
-
iwconfig txpower can now be used to set tx power to fixed or auto. If set to
auto the default firmware settings are used.The command CMD_802_11_PA_CFG is only sent to older firmware, as Dan Williams
noted the command was no longer supported in firmware V9+.Signed-off-by: Anna Neal
Signed-off-by: Javier Cardona
Signed-off-by: John W. Linville -
ieee80211_free_keys() must be called before
ieee80211_debugfs_remove_netdev() in order to make sure that the
possible default_key symlink is removed before attempting to
remove the netdev debugfs directory.Signed-off-by: Jouni Malinen
Signed-off-by: Johannes Berg
Signed-off-by: John W. Linville -
The ieee80211_sta_tx function isn't MLME code any more,
it's getting used by a lot of code. Move it to utils and
rename it to ieee80211_tx_skb.Signed-off-by: Johannes Berg
Signed-off-by: John W. Linville -
That function isn't exactly easy to read especially since it
does something in an if branch that continues after the if
because the else returns. Express it in a more readable way.Signed-off-by: Johannes Berg
Signed-off-by: John W. Linville -
Like the HT code, this doesn't depend on the STA-mode implementation
and can be handled entirely independently. There's only stub code
for now, but when it gets filled having it in its own file will be
beneficial.Signed-off-by: Johannes Berg
Signed-off-by: John W. Linville -
The aggregation handling isn't dependent on anything related to our
STA-mode implementation, and doesn't need to depend on it for frame
processing. This patch moves the relevant code to ht.c and adds a
hook in rx.c. For now, the relevant action frames are only processed
in STA/IBSS modes, but that's now something we can easily change.Signed-off-by: Johannes Berg
Signed-off-by: John W. Linville -
When hardware is started it might be in a confused state with
respect to queue QoS parameters. This patch changes mac80211
to set sane defaults right after the hardware is brought up.Signed-off-by: Johannes Berg
Cc: Michael Buesch
Signed-off-by: John W. Linville -
Added support for 3 antennas for Legacy, SISO and MIMO2.
MIMO3 is still not supported yet.Signed-off-by: Guy Cohen
Signed-off-by: Emmanuel Grumbach
Signed-off-by: Zhu Yi
Signed-off-by: John W. Linville -
This patch fixes a bug in Rate Scaling. When moving from SISO to MIMO we
need to choose the lowest higher rate, instead of choosing the highest in MIMO.
No doing this can lead to a high packet loss in the highest rate in MIMO,
leading not to move MIMO although lower in MIMO could give a better TPT.Signed-off-by: Guy Cohen
Signed-off-by: Emmanuel Grumbach
Signed-off-by: Zhu Yi
Signed-off-by: John W. Linville -
Simplify pass_packet_to_mac80211 code block.
Signed-off-by: Abhijeet Kolekar
Signed-off-by: Zhu Yi
Signed-off-by: John W. Linville -
If certain commands were in-flight when the card was pulled or the
driver rmmod-ed, cleanup would block on the work queue stopping, but the
work queue was in turn blocked on the current command being canceled,
which didn't happen. Fix that.Signed-off-by: Dan Williams
Cc: stable
Signed-off-by: John W. Linville -
There isn't really a good reason to have the LED
configuration options selectable per driver, lets
make it default 'y' and make it depend on the
NEW_LEDS and LEDS_CLASS interface.Signed-off-by: Ivo van Doorn
