09 Jan, 2020

1 commit

• ebf3afa3c   gen_initramfs_list.sh: fix 'bad variable name' error ... Browse Code »

  commit cc976614f59bd8e45de8ce988a6bcb5de711d994 upstream.

  Prior to commit 858805b336be ("kbuild: add $(BASH) to run scripts with
  bash-extension"), this shell script was almost always run by bash since
  bash is usually installed on the system by default.

  Now, this script is run by sh, which might be a symlink to dash. On such
  distributions, the following code emits an error:

  local dev=`LC_ALL=C ls -l "${location}"`

  You can reproduce the build error, for example by setting
  CONFIG_INITRAMFS_SOURCE="/dev".

  GEN usr/initramfs_data.cpio.gz
  ./usr/gen_initramfs_list.sh: 131: local: 1: bad variable name
  make[1]: *** [usr/Makefile:61: usr/initramfs_data.cpio.gz] Error 2

  This is because `LC_ALL=C ls -l "${location}"` contains spaces.
  Surrounding it with double-quotes fixes the error.

  Fixes: 858805b336be ("kbuild: add $(BASH) to run scripts with bash-extension")
  Reported-by: Jory A. Pratt
  Signed-off-by: Masahiro Yamada
  Signed-off-by: Greg Kroah-Hartman

  Masahiro Yamada

  2020-01-09 17:20:00 +0800  

22 Aug, 2018

1 commit

• f6f57a464   initramfs: move gen_initramfs_list.sh from scripts/ to usr/ ... Browse Code »

  scripts/gen_initramfs_list.sh is only invoked from usr/Makefile.
  Move it so that all tools to create initramfs are self-contained
  in the usr/ directory.

  Signed-off-by: Masahiro Yamada

  Masahiro Yamada

  2018-08-22 22:21:44 +0800