28 Aug, 2020

1 commit

  • The word "enought" was changed to read as "enough".
    In addition to this, there was a missing new-line after varaible
    declarations within a function.

    Signed-off-by: Timo A. Aranjo
    Link: https://lore.kernel.org/r/20200826012101.12162-1-timo.aranjo@aol.com
    Signed-off-by: Greg Kroah-Hartman

    Timo A. Aranjo
     

29 Jul, 2020

1 commit

  • Drivers using legacy power management .suspen()/.resume() callbacks
    have to manage PCI states and device's PM states themselves. They also
    need to take care of standard configuration registers.

    Switch to generic power management framework using a single
    "struct dev_pm_ops" variable to take the unnecessary load from the driver.
    This also avoids the need for the driver to directly call most of the PCI
    helper functions and device power state control functions, as through
    the generic framework PCI Core takes care of the necessary operations,
    and drivers are required to do only device-specific jobs.

    Signed-off-by: Vaibhav Gupta
    Link: https://lore.kernel.org/r/20200728123349.1331679-1-vaibhavgupta40@gmail.com
    Signed-off-by: Greg Kroah-Hartman

    Vaibhav Gupta
     

29 May, 2020

1 commit


05 May, 2020

3 commits


16 Apr, 2020

1 commit


13 Apr, 2020

1 commit

  • Convert a single line comment to a multiline comment to respect the 80
    character rule.Problem found using checkpatch.

    Signed-off-by: Gokce Kuler
    Reviewed-by: Stefano Brivio
    Link: https://lore.kernel.org/r/20200328201513.GA16863@siyah2
    Signed-off-by: Greg Kroah-Hartman

    Gokce Kuler
     

19 Mar, 2020

1 commit


06 Jan, 2020

1 commit


30 Oct, 2019

2 commits


25 Oct, 2019

5 commits


16 Oct, 2019

1 commit


08 Oct, 2019

2 commits

  • Fixes gcc '-Wunused-but-set-variable' warning:

    drivers/staging/sm750fb/ddk750_chip.c: In function set_chip_clock:
    drivers/staging/sm750fb/ddk750_chip.c:59:15: warning: variable actual_mx_clk set but not used [-Wunused-but-set-variable]

    It is not used since commit f0977109a577 ("staging:
    sm750fb: lower case to fix camelcase checkpatch warning")

    Reported-by: Hulk Robot
    Signed-off-by: zhengbin
    Reviewed-by: Dan Carpenter
    Link: https://lore.kernel.org/r/1570520515-2186-4-git-send-email-zhengbin13@huawei.com
    Signed-off-by: Greg Kroah-Hartman

    zhengbin
     
  • Fixes gcc '-Wunused-but-set-variable' warning:

    drivers/staging/sm750fb/ddk750_mode.c: In function ddk750_setModeTiming:
    drivers/staging/sm750fb/ddk750_mode.c:212:15: warning: variable uiActualPixelClk set but not used [-Wunused-but-set-variable]

    It is not used since commit 81dee67e215b ("staging:
    sm750fb: add sm750 to staging")

    Reported-by: Hulk Robot
    Signed-off-by: zhengbin
    Reviewed-by: Dan Carpenter
    Link: https://lore.kernel.org/r/1570520515-2186-3-git-send-email-zhengbin13@huawei.com
    Signed-off-by: Greg Kroah-Hartman

    zhengbin
     

01 Oct, 2019

1 commit

  • This patch fixes the checkpatch.pl warning: CHECK: Avoid CamelCase for
    the following files:

    drivers/staging/sm750fb/ddk750_chip.c
    drivers/staging/sm750fb/ddk750_chip.h
    drivers/staging/sm750fb/ddk750_mode.c

    Signed-off-by: Ido Tamir
    Link: https://lore.kernel.org/r/20190906112241.GA2144@ubuntu-kernel
    Signed-off-by: Greg Kroah-Hartman

    Ido Tamir
     

15 Aug, 2019

1 commit

  • There is some "confusing" license text in some of the sm750fb driver
    files. After discussing it with the company, it turns out to have been
    a mistake and these lines can be safely removed. The files are all to
    be licensed under the GPLv2 license.

    Cc: Sudip Mukherjee
    Cc: Teddy Wang
    Cc: linux-fbdev@vger.kernel.org
    Cc: devel@driverdev.osuosl.org
    Signed-off-by: Greg Kroah-Hartman
    Link: https://lore.kernel.org/r/20190815123009.16499-1-gregkh@linuxfoundation.org
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

15 Jun, 2019

1 commit

  • The kbuild documentation clearly shows that the documents
    there are written at different times: some use markdown,
    some use their own peculiar logic to split sections.

    Convert everything to ReST without affecting too much
    the author's style and avoiding adding uneeded markups.

    The conversion is actually:
    - add blank lines and identation in order to identify paragraphs;
    - fix tables markups;
    - add some lists markups;
    - mark literal blocks;
    - adjust title markups.

    At its new index.rst, let's add a :orphan: while this is not linked to
    the main index.rst file, in order to avoid build warnings.

    Signed-off-by: Mauro Carvalho Chehab
    Signed-off-by: Jonathan Corbet

    Mauro Carvalho Chehab
     

30 Apr, 2019

1 commit


03 Apr, 2019

3 commits


02 Apr, 2019

1 commit


27 Mar, 2019

1 commit


26 Mar, 2019

1 commit


20 Mar, 2019

1 commit


18 Mar, 2019

3 commits

  • Remove an unnecessary local variable in sm750_format_pll_reg function
    and replace its initialization directly in return type.
    Issue suggested by Coccinelle using ret.cocci.

    Signed-off-by: Madhumitha Prabakaran
    Signed-off-by: Greg Kroah-Hartman

    Madhumitha Prabakaran
     
  • Edit CamelCase in local variables across 4 files:
    - sm750fb/ddk750_chip.c
    - sm750fb/ddk750_chip.h
    - sm750fb/ddk750_dvi.c
    - sm750fb/ddk750_sii164.c
    to comply with the coding style. Also edit associated comments
    accordingly.
    Issue found with Checkpatch.

    Signed-off-by: Nishka Dasgupta
    Signed-off-by: Greg Kroah-Hartman

    Nishka Dasgupta
     
  • In function sm750_hw_copyarea() of sm750_accel.c, there are
    some comments in ASCII graphs, describing 4 possible scenarios
    of overlapping areas when copying an area. However, the graphs
    have broken indention.

    The entire SiliconMotion series video controllers, including
    SM501, SM712 and SM750 have similar 2D engines, yet, I have
    not seen a single version of it with ASCII graphs properly
    formatted...

    Fix the the misleading ASCII graphs. It would eliminate the
    confusions and improve code readability.

    Signed-off-by: Yifeng Li
    Signed-off-by: Greg Kroah-Hartman

    Yifeng Li
     

07 Feb, 2019

1 commit


07 Nov, 2018

1 commit

  • Add spaces around '+' to correct the following checkpath.pl warnings:

    WARNING: line over 80 characters
    + write_dpPort(accel, *(unsigned int *)(pSrcbuf + (j * 4)));

    WARNING: line over 80 characters
    + memcpy(ajRemain, pSrcbuf+ul4BytesPerScan, ulBytesRemain);

    Signed-off-by: Laís Pessine do Carmo
    Signed-off-by: Greg Kroah-Hartman

    Laís Pessine do Carmo
     

09 Oct, 2018

1 commit


03 Oct, 2018

1 commit


26 Sep, 2018

1 commit


11 Jul, 2018

1 commit