28 Aug, 2020
1 commit
-
The word "enought" was changed to read as "enough".
In addition to this, there was a missing new-line after varaible
declarations within a function.Signed-off-by: Timo A. Aranjo
Link: https://lore.kernel.org/r/20200826012101.12162-1-timo.aranjo@aol.com
Signed-off-by: Greg Kroah-Hartman
29 Jul, 2020
1 commit
-
Drivers using legacy power management .suspen()/.resume() callbacks
have to manage PCI states and device's PM states themselves. They also
need to take care of standard configuration registers.Switch to generic power management framework using a single
"struct dev_pm_ops" variable to take the unnecessary load from the driver.
This also avoids the need for the driver to directly call most of the PCI
helper functions and device power state control functions, as through
the generic framework PCI Core takes care of the necessary operations,
and drivers are required to do only device-specific jobs.Signed-off-by: Vaibhav Gupta
Link: https://lore.kernel.org/r/20200728123349.1331679-1-vaibhavgupta40@gmail.com
Signed-off-by: Greg Kroah-Hartman
29 May, 2020
1 commit
-
Add names to proc_setBLANK args.
Found using checkpatch.pl.Signed-off-by: Igor Ribeiro Barbosa Duarte
Link: https://lore.kernel.org/r/20200526224750.GA29722@igor-Aspire-F5-573G
Signed-off-by: Greg Kroah-Hartman
05 May, 2020
3 commits
-
This patch will update error message, so it is same as error message in
another function.Signed-off-by: Matej Dujava
Link: https://lore.kernel.org/r/1588277366-19354-4-git-send-email-mdujava@kocurkovo.cz
Signed-off-by: Greg Kroah-Hartman -
This patch will unify code for updating color offsets and frame buffer
visual mode.Signed-off-by: Matej Dujava
Link: https://lore.kernel.org/r/1588277366-19354-3-git-send-email-mdujava@kocurkovo.cz
Signed-off-by: Greg Kroah-Hartman -
Switch statement does not contain all cases: 8, 16, 24, 32.
This patch will add missing one (24)Fixes: 81dee67e215b ("staging: sm750fb: add sm750 to staging")
Signed-off-by: Matej Dujava
Link: https://lore.kernel.org/r/1588277366-19354-2-git-send-email-mdujava@kocurkovo.cz
Signed-off-by: Greg Kroah-Hartman
16 Apr, 2020
1 commit
-
Make function arguments alignment match open parenthesis.
Found using checkpatch.pl.Signed-off-by: R Veera Kumar
Link: https://lore.kernel.org/r/20200413160753.3787-1-vkor@vkten.in
Signed-off-by: Greg Kroah-Hartman
13 Apr, 2020
1 commit
-
Convert a single line comment to a multiline comment to respect the 80
character rule.Problem found using checkpatch.Signed-off-by: Gokce Kuler
Reviewed-by: Stefano Brivio
Link: https://lore.kernel.org/r/20200328201513.GA16863@siyah2
Signed-off-by: Greg Kroah-Hartman
19 Mar, 2020
1 commit
-
A simple fix of long line in makefile variable assignment.
Found using checkpatch.pl.Signed-off-by: R Veera Kumar
Link: https://lore.kernel.org/r/20200319095024.GA2970@tulip.local
Signed-off-by: Greg Kroah-Hartman
06 Jan, 2020
1 commit
-
ioremap has provided non-cached semantics by default since the Linux 2.6
days, so remove the additional ioremap_nocache interface.Signed-off-by: Christoph Hellwig
Acked-by: Arnd Bergmann
30 Oct, 2019
2 commits
-
Replace multiple spaces before some comments with one tab. Aligning the
comment with the function below it.Signed-off-by: Gabriela Bittencourt
Link: https://lore.kernel.org/r/20191029232207.4113-3-gabrielabittencourt00@gmail.com
Signed-off-by: Greg Kroah-Hartman -
Fixing typo in word 'and'.
Signed-off-by: Gabriela Bittencourt
Acked-by: Julia Lawall
Link: https://lore.kernel.org/r/20191029232207.4113-2-gabrielabittencourt00@gmail.com
Signed-off-by: Greg Kroah-Hartman
25 Oct, 2019
5 commits
-
Cleans up checks of "Alignment should match open parenthesis"
in file sm750_cursor.hSigned-off-by: Gabriela Bittencourt
Link: https://lore.kernel.org/r/20191024163822.7157-4-gabrielabittencourt00@gmail.com
Signed-off-by: Greg Kroah-Hartman -
Cleans up checks of "Alignment should match open parenthesis"
in file sm750_accel.hSigned-off-by: Gabriela Bittencourt
Link: https://lore.kernel.org/r/20191024163822.7157-3-gabrielabittencourt00@gmail.com
Signed-off-by: Greg Kroah-Hartman -
Cleans up checks of "Alignment should match open parenthesis"
in file ddk750_sii164.cSigned-off-by: Gabriela Bittencourt
Link: https://lore.kernel.org/r/20191024163822.7157-2-gabrielabittencourt00@gmail.com
Signed-off-by: Greg Kroah-Hartman -
Formatting comments in file drivers/staging/sm750fb/sm750_accel.h.
Signed-off-by: Gabriela Bittencourt
Link: https://lore.kernel.org/r/20191023163016.30217-3-gabrielabittencourt00@gmail.com
Signed-off-by: Greg Kroah-Hartman -
Formatting comments in file drivers/staging/sm750fb/sm750_accel.c.
Signed-off-by: Gabriela Bittencourt
Link: https://lore.kernel.org/r/20191023163016.30217-2-gabrielabittencourt00@gmail.com
Signed-off-by: Greg Kroah-Hartman
16 Oct, 2019
1 commit
-
Fix lines over 80 character warnings. Issue found
by checkpatch.Signed-off-by: Jamal Shareef
Link: https://lore.kernel.org/r/1f635b0469f93d8460d513f5fabd877dc5054a33.1571108943.git.jamal.k.shareef@gmail.com
Signed-off-by: Greg Kroah-Hartman
08 Oct, 2019
2 commits
-
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/sm750fb/ddk750_chip.c: In function set_chip_clock:
drivers/staging/sm750fb/ddk750_chip.c:59:15: warning: variable actual_mx_clk set but not used [-Wunused-but-set-variable]It is not used since commit f0977109a577 ("staging:
sm750fb: lower case to fix camelcase checkpatch warning")Reported-by: Hulk Robot
Signed-off-by: zhengbin
Reviewed-by: Dan Carpenter
Link: https://lore.kernel.org/r/1570520515-2186-4-git-send-email-zhengbin13@huawei.com
Signed-off-by: Greg Kroah-Hartman -
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/sm750fb/ddk750_mode.c: In function ddk750_setModeTiming:
drivers/staging/sm750fb/ddk750_mode.c:212:15: warning: variable uiActualPixelClk set but not used [-Wunused-but-set-variable]It is not used since commit 81dee67e215b ("staging:
sm750fb: add sm750 to staging")Reported-by: Hulk Robot
Signed-off-by: zhengbin
Reviewed-by: Dan Carpenter
Link: https://lore.kernel.org/r/1570520515-2186-3-git-send-email-zhengbin13@huawei.com
Signed-off-by: Greg Kroah-Hartman
01 Oct, 2019
1 commit
-
This patch fixes the checkpatch.pl warning: CHECK: Avoid CamelCase for
the following files:drivers/staging/sm750fb/ddk750_chip.c
drivers/staging/sm750fb/ddk750_chip.h
drivers/staging/sm750fb/ddk750_mode.cSigned-off-by: Ido Tamir
Link: https://lore.kernel.org/r/20190906112241.GA2144@ubuntu-kernel
Signed-off-by: Greg Kroah-Hartman
15 Aug, 2019
1 commit
-
There is some "confusing" license text in some of the sm750fb driver
files. After discussing it with the company, it turns out to have been
a mistake and these lines can be safely removed. The files are all to
be licensed under the GPLv2 license.Cc: Sudip Mukherjee
Cc: Teddy Wang
Cc: linux-fbdev@vger.kernel.org
Cc: devel@driverdev.osuosl.org
Signed-off-by: Greg Kroah-Hartman
Link: https://lore.kernel.org/r/20190815123009.16499-1-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman
15 Jun, 2019
1 commit
-
The kbuild documentation clearly shows that the documents
there are written at different times: some use markdown,
some use their own peculiar logic to split sections.Convert everything to ReST without affecting too much
the author's style and avoiding adding uneeded markups.The conversion is actually:
- add blank lines and identation in order to identify paragraphs;
- fix tables markups;
- add some lists markups;
- mark literal blocks;
- adjust title markups.At its new index.rst, let's add a :orphan: while this is not linked to
the main index.rst file, in order to avoid build warnings.Signed-off-by: Mauro Carvalho Chehab
Signed-off-by: Jonathan Corbet
30 Apr, 2019
1 commit
-
Resolve checkpatch warning for static const char * array by using const
pointers.Checkpatch Warning in sm750.c:
static const char * array should probably be static const char * constSigned-off-by: Kelsey Skunberg
Signed-off-by: Greg Kroah-Hartman
03 Apr, 2019
3 commits
-
By default all files without license information are under the default
license of the kernel, which is GPL version 2. Because of this, add the
GPL-2.0 identifier to the sm750fb driver which did not have any license
identifiers in it at all.Cc: Sudip Mukherjee
Cc: Teddy Wang
Signed-off-by: Greg Kroah-Hartman -
There are a few remaining drivers/staging/*/Makefile files that do not
have SPDX identifiers in them. Add the correct GPL-2.0 identifier to
them to make scanning tools happy.Reviewed-by: Mukesh Ojha
Signed-off-by: Greg Kroah-Hartman -
There are a few remaining drivers/staging/*/Kconfig files that do not
have SPDX identifiers in them. Add the correct GPL-2.0 identifier to
them to make scanning tools happy.Signed-off-by: Greg Kroah-Hartman
02 Apr, 2019
1 commit
-
Challenge suggested by coccinelle.
Remove unnecessary parenthesis around the right hand
of the assignment using the below script.@@
binary operator op = {!=,&&,||,>=,
Signed-off-by: Greg Kroah-Hartman
27 Mar, 2019
1 commit
-
Lower case to fix CamelCase checkpatch.pl warning
"CHECK: Avoid CamelCase: ".Signed-off-by: Jules Irenge
Signed-off-by: Greg Kroah-Hartman
26 Mar, 2019
1 commit
-
Challenge suggested by coccinelle.
Replace bit shifting on 1 with the BIT(x) macro.
Coccinelle script:@@
constant c;
@@-(1 << c)
+BIT(c)Signed-off-by: Sanjana Sanikommu
Signed-off-by: Greg Kroah-Hartman
20 Mar, 2019
1 commit
-
Edit CamelCase function name
Issue found by checkpatch.plSigned-off-by: Vatsala Narang
Signed-off-by: Greg Kroah-Hartman
18 Mar, 2019
3 commits
-
Remove an unnecessary local variable in sm750_format_pll_reg function
and replace its initialization directly in return type.
Issue suggested by Coccinelle using ret.cocci.Signed-off-by: Madhumitha Prabakaran
Signed-off-by: Greg Kroah-Hartman -
Edit CamelCase in local variables across 4 files:
- sm750fb/ddk750_chip.c
- sm750fb/ddk750_chip.h
- sm750fb/ddk750_dvi.c
- sm750fb/ddk750_sii164.c
to comply with the coding style. Also edit associated comments
accordingly.
Issue found with Checkpatch.Signed-off-by: Nishka Dasgupta
Signed-off-by: Greg Kroah-Hartman -
In function sm750_hw_copyarea() of sm750_accel.c, there are
some comments in ASCII graphs, describing 4 possible scenarios
of overlapping areas when copying an area. However, the graphs
have broken indention.The entire SiliconMotion series video controllers, including
SM501, SM712 and SM750 have similar 2D engines, yet, I have
not seen a single version of it with ASCII graphs properly
formatted...Fix the the misleading ASCII graphs. It would eliminate the
confusions and improve code readability.Signed-off-by: Yifeng Li
Signed-off-by: Greg Kroah-Hartman
07 Feb, 2019
1 commit
-
Fix checkpatch.pl warning:
CHECK: Avoid CamelCase:Signed-off-by: Jin Chen
Signed-off-by: Greg Kroah-Hartman
07 Nov, 2018
1 commit
-
Add spaces around '+' to correct the following checkpath.pl warnings:
WARNING: line over 80 characters
+ write_dpPort(accel, *(unsigned int *)(pSrcbuf + (j * 4)));WARNING: line over 80 characters
+ memcpy(ajRemain, pSrcbuf+ul4BytesPerScan, ulBytesRemain);Signed-off-by: Laís Pessine do Carmo
Signed-off-by: Greg Kroah-Hartman
09 Oct, 2018
1 commit
-
Remove space after cast to fix checkpatch issue.
CHECK: No space is necessary after a castSigned-off-by: Mamta Shukla
Signed-off-by: Greg Kroah-Hartman
03 Oct, 2018
1 commit
-
Remove an extra space in ddk750_mode.c to fix indentation
Signed-off-by: Aymen Qader
Signed-off-by: Greg Kroah-Hartman
26 Sep, 2018
1 commit
-
This patch corrects a typo (frambuffer->framebuffer) in the
sm750fb_fram(e)buffer_release and sm750fb_fram(e)buffer_alloc function
names.Signed-off-by: Aymen Qader
Signed-off-by: Greg Kroah-Hartman
11 Jul, 2018
1 commit
-
Pointer 'output' is being assigned but is never used hence it is redundant
and can be removed.Cleans up clang warning:
warning: variable 'output' set but not used [-Wunused-but-set-variable]Signed-off-by: Colin Ian King
Signed-off-by: Greg Kroah-Hartman