Eric Lee / smarc-fsl-linux-kernel

25 Mar, 2009

2 commits

  • e5779a583   scsi/m68k: Kill NCR_700_detect() warnings ... Browse Code »

    The patch from Ming Lei entitled:
    platform driver: fix incorrect use of 'platform_bus_type' with 'struct devic
    introduced the following warnings on m68k, as `dev' is now a `struct
    platform_device *' instead of a `struct device *':

    | drivers/scsi/a4000t.c:64: warning: passing argument 3 of 'NCR_700_detect' from incompatible pointer type
    | drivers/scsi/mvme16x_scsi.c:67: warning: passing argument 3 of 'NCR_700_detect' from incompatible pointer type
    | drivers/scsi/bvme6000_scsi.c:61: warning: passing argument 3 of 'NCR_700_detect' from incompatible pointer type

    I think the below is missing (untested on real hardware).

    Signed-off-by: Geert Uytterhoeven
    Cc: Ming Lei
    Signed-off-by: Greg Kroah-Hartman

    Geert Uytterhoeven
     
  • 7a192ec33   platform driver: fix incorrect use of 'platform_bus_type' with 'struct device_driver' ... Browse Code »

    This patch fixes the bug reported in
    http://bugzilla.kernel.org/show_bug.cgi?id=11681.

    "Lots of device drivers register a 'struct device_driver' with
    the '.bus' member set to '&platform_bus_type'. This is wrong,
    since the platform_bus functions expect the 'struct device_driver'
    to be wrapped up in a 'struct platform_driver' which provides
    some additional callbacks (like suspend_late, resume_early).
    The effect may be that platform_suspend_late() uses bogus data
    outside the device_driver struct as a pointer pointer to the
    device driver's suspend_late() function or other hard to
    reproduce failures."(Lothar Wassmann)

    Signed-off-by: Ming Lei
    Acked-by: Henrique de Moraes Holschuh
    Acked-by: David Brownell
    Signed-off-by: Greg Kroah-Hartman

    Ming Lei
     

13 Oct, 2007

1 commit

19 Jul, 2007

1 commit

  • 3ac709c11   [SCSI] a4000t, zorro7xx, mvme16x, bvme6000,sim710: xxx_device_remove seems buggy ... Browse Code »

    Fix drivers misusing dev_to_shost

    Some drivers were using dev_to_shost to go from a struct device to the
    corresponding shost. Unfortunately, dev_to_shost only looks up the tree
    to find an shost (it's designed to go from a scsi_device or a
    scsi_target to the parent scsi_host), and these drivers were calling it
    with the parent of the scsi_host.

    I've fixed this by saving a pointer to the Scsi_Host in the drvdata,
    which matches what most scsi drivers do.

    Signed-off-by: Matthew Wilcox
    Cc: Geert Uytterhoeven
    Signed-off-by: James Bottomley

    Matthew Wilcox
     

20 Jun, 2007

1 commit

  • 96249cf98   [SCSI] 53c700: Fixup m68k drivers: ... Browse Code »

    - a4000t.c: Add missing include, needed in some configurations
    - bvme6000_scsi.c: Kill bogus opening brace
    - zorro7xx.c: Remove MODULE_DEVICE_TABLE, it should be part of another
    patch

    Signed-off-by: Geert Uytterhoeven
    Signed-off-by: James Bottomley

    Geert Uytterhoeven
     

18 Jun, 2007

1 commit