16 Apr, 2010

1 commit


13 Apr, 2010

1 commit


30 Mar, 2010

1 commit

  • …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

22 Mar, 2010

1 commit


19 Mar, 2010

1 commit


02 Mar, 2010

3 commits


26 Dec, 2009

1 commit

  • This patch fixes a build failure introduced by the patch
    ALSA: AACI: factor common hw_params logic into aaci_pcm_hw_params [1]
    by adding/moving the aaci struct to the right position.

    The patch mentioned above merged common source parts into one function,
    but unfortunately left out the aaci struct and consequently caused a
    build failure e.g. for arm versatile_config [2]

    References:
    [1] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=d3aee7996c30f928bbbbfd0994148e35d2e83084
    [2] http://kisskb.ellerman.id.au/kisskb/buildresult/1893605/

    Patch against Linus' tree.

    Signed-off-by: Peter Huewe
    Signed-off-by: Takashi Iwai

    Peter Huewe
     

19 Dec, 2009

6 commits


16 Dec, 2009

1 commit


04 Dec, 2009

2 commits


01 Dec, 2009

2 commits


30 Nov, 2009

2 commits


27 Nov, 2009

1 commit


23 Nov, 2009

1 commit


13 Oct, 2009

1 commit

  • After a reboot on an ARM1176 which amounts to a softreset, it has been
    noted that the ALSA driver does not get registered and the probe fails
    with the error "aaci-pl041 fpga:04: ac97 read back fail". In the process
    of reading from a register the SL1TxBusy bit is set indicating that the
    transceiver is busy and remains so until the default timeout occurs.
    Set the Power down register 0x26 to an arbitrary value as specified in
    the PL041 manual (page: 3-18) so that AACISL1TX/AACISL2TX registers take
    their default state.

    Signed-off-by: Philby John
    Signed-off-by: Takashi Iwai

    Philby John
     

21 Sep, 2009

1 commit


10 Sep, 2009

1 commit


05 Sep, 2009

1 commit

  • Today's linux-next fails to build with

    sound/arm/pxa2xx-ac97.c: In function 'pxa2xx_ac97_probe':
    sound/arm/pxa2xx-ac97.c:211: error: 'pxa2xx_audio_ops_t' has no member named 'codec_data'
    make[2]: *** [sound/arm/pxa2xx-ac97.o] Error 1

    It looks like commit e2365bf313fb21b49b1e4c911033389564428d03 has
    introduced this; patch below.

    Signed-off-by: Robert Schwebel
    Signed-off-by: Mark Brown

    Robert Schwebel
     

24 Aug, 2009

1 commit


20 Aug, 2009

1 commit


14 Aug, 2009

1 commit


09 Jul, 2009

1 commit


11 Jun, 2009

1 commit

  • I found the PrimeCell/AMBA Bus drivers distrusting the resource
    passed in as part of the struct amba_device abstraction. This
    patch removes all hard coded resource sizes found in the PrimeCell
    drivers and move the responsibility of this definition back to
    the platform/board device definition, which already exist and
    appear to be correct for all in-tree users of these drivers.
    We do this using the resource_size() inline function which was
    also replicated in the only driver using the resource size, so
    that has been changed too. The KMI_SIZE was left in kmi.h in case
    someone likes it. Test-compiled against Versatile and Integrator
    defconfigs, seems to work but I don't posess these boards and
    cannot test them.

    Signed-off-by: Linus Walleij
    Signed-off-by: Russell King

    Linus Walleij
     

21 May, 2009

1 commit


12 May, 2009

1 commit


15 Apr, 2009

1 commit

  • Currently there are two possible platform datas for the PXA AC97 driver:
    one supported by the generic AC97 driver only which provides callbacks
    to allow board-specific configuration at stream startup and teardown,
    and another for pxa2xx-ac97-lib which allows configuration of the reset
    GPIO for PXA2xx CPUs.

    Obviously this won't actually work when using the generic AC97 driver
    since the drivers will attempt to parse the platform data in both
    formats. Fix this by merging the two structures.

    Signed-off-by: Mark Brown
    Acked-by: Robert Jarzmik
    Cc: Marek Vasut
    Signed-off-by: Eric Miao

    Mark Brown
     

06 Apr, 2009

1 commit


02 Apr, 2009

1 commit


29 Mar, 2009

1 commit


24 Mar, 2009

1 commit