Eric Lee / smarc-fsl-linux-kernel

24 Mar, 2020

2 commits

  • 22dd4acc8   Staging: speakup: Add identifier name to function declaration arguments. ... Browse Code »

    void (*read_buff_add) argument didn't have an identifier name,
    adding a name to it like the rest of all functions' arguments.

    Signed-off-by: Sam Muhammed
    Reviewed-by: Samuel Thibault
    Link: https://lore.kernel.org/r/b2a1ca962553194840d8cd2bf1f7d3174e3b1336.1585046066.git.jane.pnx9@gmail.com
    Signed-off-by: Greg Kroah-Hartman

    Sam Muhammed
     
  • 7cf9a79db   Staging: speakup: Use sizeof(*var) in kmalloc(). ... Browse Code »

    Modifying struct allocation in kmalloc() to match the
    coding standards.

    Checkpatch.pl CHECK: Prefer kmalloc(sizeof(*ldisc_data)...)
    over kmalloc(sizeof(struct spk_ldisc_data)...)

    Signed-off-by: Sam Muhammed
    Reviewed-by: Samuel Thibault
    Link: https://lore.kernel.org/r/19494bdab5709693126e0c0ee14b179a3b601207.1585046066.git.jane.pnx9@gmail.com
    Signed-off-by: Greg Kroah-Hartman

    Sam Muhammed
     

23 Mar, 2020

2 commits

21 Mar, 2020

1 commit

  • 3bd14829d   Merge tag 'staging-5.6-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging ... Browse Code »

    Pull staging/IIO fixes from Greg KH:
    "Here are a number of small staging and IIO driver fixes for 5.6-rc7

    Nothing major here, just resolutions for some reported problems:
    - iio bugfixes for a number of different drivers
    - greybus loopback_test fixes
    - wfx driver fixes

    All of these have been in linux-next with no reported issues"

    * tag 'staging-5.6-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging:
    staging: rtl8188eu: Add device id for MERCUSYS MW150US v2
    staging: greybus: loopback_test: fix potential path truncations
    staging: greybus: loopback_test: fix potential path truncation
    staging: greybus: loopback_test: fix poll-mask build breakage
    staging: wfx: fix RCU usage between hif_join() and ieee80211_bss_get_ie()
    staging: wfx: fix RCU usage in wfx_join_finalize()
    staging: wfx: make warning about pending frame less scary
    staging: wfx: fix lines ending with a comma instead of a semicolon
    staging: wfx: fix warning about freeing in-use mutex during device unregister
    staging/speakup: fix get_word non-space look-ahead
    iio: ping: set pa_laser_ping_cfg in of_ping_match
    iio: chemical: sps30: fix missing triggered buffer dependency
    iio: st_sensors: remap SMO8840 to LIS2DH12
    iio: light: vcnl4000: update sampling periods for vcnl4040
    iio: light: vcnl4000: update sampling periods for vcnl4200
    iio: accel: adxl372: Set iio_chan BE
    iio: magnetometer: ak8974: Fix negative raw values in sysfs
    iio: trigger: stm32-timer: disable master mode when stopping
    iio: adc: stm32-dfsdm: fix sleep in atomic context
    iio: adc: at91-sama5d2_adc: fix differential channels in triggered mode

    Linus Torvalds
     

17 Mar, 2020

1 commit

11 Mar, 2020

1 commit

  • 9d32c0cde   staging/speakup: fix get_word non-space look-ahead ... Browse Code »

    get_char was erroneously given the address of the pointer to the text
    instead of the address of the text, thus leading to random crashes when
    the user requests speaking a word while the current position is on a space
    character and say_word_ctl is not enabled.

    Reported-on: https://github.com/bytefire/speakup/issues/1
    Reported-by: Kirk Reiser
    Reported-by: Janina Sajka
    Reported-by: Alexandr Epaneshnikov
    Reported-by: Gregory Nowak
    Reported-by: deedra waters
    Signed-off-by: Samuel Thibault
    Tested-by: Alexandr Epaneshnikov
    Tested-by: Gregory Nowak
    Tested-by: Michael Taboada
    Cc: stable
    Link: https://lore.kernel.org/r/20200306003047.thijtmqrnayd3dmw@function
    Signed-off-by: Greg Kroah-Hartman

    Samuel Thibault
     

10 Mar, 2020

1 commit

28 Feb, 2020

1 commit

  • 4b70dd57a   vt: selection, push console lock down ... Browse Code »

    We need to nest the console lock in sel_lock, so we have to push it down
    a bit. Fortunately, the callers of set_selection_* just lock the console
    lock around the function call. So moving it down is easy.

    In the next patch, we switch the order.

    Signed-off-by: Jiri Slaby
    Fixes: 07e6124a1a46 ("vt: selection, close sel_buffer race")
    Cc: stable
    Link: https://lore.kernel.org/r/20200228115406.5735-1-jslaby@suse.cz
    Signed-off-by: Greg Kroah-Hartman

    Jiri Slaby
     

24 Feb, 2020

1 commit

  • 42228d9ed   staging: speakup: remove redundant initialization of pointer p_key ... Browse Code »

    Pointer p_key is being initialized with a value that is never read,
    it is assigned a new value later on. The initialization is redundant
    and can be removed.

    Reviewed-by: Samuel Thibault
    Signed-off-by: Colin Ian King
    Addresses-Coverity: ("Unused value")
    Link: https://lore.kernel.org/r/20200223153954.420731-1-colin.king@canonical.com
    Signed-off-by: Greg Kroah-Hartman

    Colin Ian King
     

04 Oct, 2019

1 commit

  • 5dcaa1fce   staging: speakup: document sysfs attributes ... Browse Code »

    Speakup exposes a set of sysfs attributes under
    /sys/accessibility/speakup/ for user-space to interact with and
    configure speakup's kernel modules. This patch describes those
    attributes. Some attributes either lack a description or contain
    incomplete description. They are marked wit TODO.

    Authored-by: Gregory Nowak
    Submitted-by: Okash Khawaja
    Signed-off-by: Okash Khawaja
    Link: https://lore.kernel.org/r/20191001214729.1770-1-okash.khawaja@gmail.com
    Signed-off-by: Greg Kroah-Hartman

    Okash Khawaja
     

31 May, 2019

1 commit

19 Apr, 2019

1 commit

  • 41f130845   staging: speakup: refactor to use existing code in vt ... Browse Code »

    This patch replaces speakup's implementations with calls to functions
    in tty/vt/selection.c. Those functions are:

    cancel_selection()
    set_selection_kernel()
    paste_selection()

    Currently setting selection is done in interrupt context. However,
    set_selection_kernel() can sleep - for instance, it requires console_lock
    which can sleep. Therefore we offload that work to a work_struct thread,
    following the same pattern which was already set for paste_selection().
    When setting selection, we also get a reference to tty and make sure to
    release the reference before returning.

    struct speakup_paste_work has been renamed to the more generic
    speakup_selection_work because it is now used for both pasting as well
    as setting selection. When paste work is cancelled, the code wasn't
    setting tty to NULL. This patch also fixes that by setting tty to NULL
    so that in case of failure we don't get EBUSY forever.

    Signed-off-by: Okash Khawaja
    Reviewed-by: Samuel Thibault
    Tested-by: Gregory Nowak
    Signed-off-by: Greg Kroah-Hartman

    Okash Khawaja
     

03 Apr, 2019

1 commit

01 Apr, 2019

1 commit

19 Mar, 2019

1 commit

18 Mar, 2019

5 commits

01 Mar, 2019

1 commit

26 Feb, 2019

1 commit

11 Feb, 2019

1 commit

30 Jan, 2019

1 commit

  • a1960e0f1   staging: speakup: fix tty-operation NULL derefs ... Browse Code »

    The send_xchar() and tiocmset() tty operations are optional. Add the
    missing sanity checks to prevent user-space triggerable NULL-pointer
    dereferences.

    Fixes: 6b9ad1c742bf ("staging: speakup: add send_xchar, tiocmset and input functionality for tty")
    Cc: stable # 4.13
    Cc: Okash Khawaja
    Cc: Samuel Thibault
    Signed-off-by: Johan Hovold
    Reviewed-by: Samuel Thibault
    Signed-off-by: Greg Kroah-Hartman

    Johan Hovold
     

07 Jan, 2019

1 commit

12 Dec, 2018

1 commit

05 Dec, 2018

1 commit

07 Nov, 2018

4 commits

20 Oct, 2018

1 commit

30 Jul, 2018

1 commit

16 Jul, 2018

1 commit

  • b96fba8d5   staging: speakup: fix wraparound in uaccess length check ... Browse Code »

    If softsynthx_read() is called with `count < 3`, `count - 3` wraps, causing
    the loop to copy as much data as available to the provided buffer. If
    softsynthx_read() is invoked through sys_splice(), this causes an
    unbounded kernel write; but even when userspace just reads from it
    normally, a small size could cause userspace crashes.

    Fixes: 425e586cf95b ("speakup: add unicode variant of /dev/softsynth")
    Cc: stable@vger.kernel.org
    Signed-off-by: Samuel Thibault
    Signed-off-by: Jann Horn
    Signed-off-by: Greg Kroah-Hartman

    Samuel Thibault
     

11 Jul, 2018

1 commit

02 Jul, 2018

1 commit

  • fd29edc72   staging: speakup: Replace strncpy with memcpy ... Browse Code »

    gcc 8.1.0 generates the following warnings.

    drivers/staging/speakup/kobjects.c: In function 'punc_store':
    drivers/staging/speakup/kobjects.c:522:2: warning:
    'strncpy' output truncated before terminating nul
    copying as many bytes from a string as its length
    drivers/staging/speakup/kobjects.c:504:6: note: length computed here

    drivers/staging/speakup/kobjects.c: In function 'synth_store':
    drivers/staging/speakup/kobjects.c:391:2: warning:
    'strncpy' output truncated before terminating nul
    copying as many bytes from a string as its length
    drivers/staging/speakup/kobjects.c:388:8: note: length computed here

    Using strncpy() is indeed less than perfect since the length of data to
    be copied has already been determined with strlen(). Replace strncpy()
    with memcpy() to address the warning and optimize the code a little.

    Signed-off-by: Guenter Roeck
    Reviewed-by: Samuel Thibault
    Signed-off-by: Greg Kroah-Hartman

    Guenter Roeck
     

17 Jun, 2018

1 commit

  • 456aec737   staging: speakup: refactor synths array to use a list ... Browse Code »

    The synths[] array is a collection of synths acting like a list.
    There is no need for synths to be an array, so refactor synths[] to use
    standard kernel list_head API, instead, and modify the usages to suit.
    As a side-effect, the maximum number of synths has also become redundant.

    Signed-off-by: Justin Skists
    Reviewed-by: Samuel Thibault
    Signed-off-by: Greg Kroah-Hartman

    Justin Skists
     

15 May, 2018

1 commit

14 May, 2018

1 commit