29 Nov, 2017

1 commit


18 Nov, 2016

1 commit

  • The Kconfig currently controlling compilation of this code is:

    drivers/i2c/busses/Kconfig:config I2C_PXA_PCI
    drivers/i2c/busses/Kconfig: def_bool I2C_PXA && X86_32 && PCI && OF

    ...meaning that it currently is not being built as a module by anyone.

    Lets remove the modular code that is essentially orphaned, so that
    when reading the driver there is no doubt it is builtin-only.

    We explicitly disallow a driver unbind, since that doesn't have a
    sensible use case anyway, and it allows us to drop the ".remove"
    code for non-modular drivers.

    Since module_pci_driver() uses the same init level priority as
    builtin_pci_driver() the init ordering remains unchanged with
    this commit.

    Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

    We also delete the MODULE_LICENSE tag etc. since all that information
    was (or is now) contained at the top of the file in the comments.

    Signed-off-by: Paul Gortmaker
    Acked-by: Sebastian Andrzej Siewior
    Signed-off-by: Wolfram Sang

    Paul Gortmaker
     

13 Mar, 2014

1 commit


22 Feb, 2013

1 commit

  • There is simply no reason to be manually setting the private driver
    data to NULL in the remove/fail to probe cases. This is just extra
    cruft code that can be removed.

    A few notes:
    * Nothing relies on drvdata being set to NULL.
    * The __device_release_driver() function eventually calls
    dev_set_drvdata(dev, NULL) anyway, so there's no need to do it
    twice.
    * I verified that there were no cases where xxx_get_drvdata() was
    being called in these drivers and checking for / relying on the NULL
    return value.

    This could be cleaned up kernel-wide but for now just take the baby
    step and remove from the i2c subsystem.

    Reported-by: Wolfram Sang
    Reported-by: Stephen Warren
    Signed-off-by: Doug Anderson
    Reviewed-by: Jean Delvare
    Acked-by: Peter Korsgaard
    Reviewed-by: Mika Westerberg
    Reviewed-by: Marek Vasut
    Signed-off-by: Wolfram Sang

    Doug Anderson
     

23 Dec, 2012

1 commit

  • CONFIG_HOTPLUG is going away as an option. As result the __dev*
    markings will be going away.

    Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst,
    and __devexit.

    Signed-off-by: Bill Pemberton
    Acked-by: Peter Korsgaard (for ocores and mux-gpio)
    Acked-by: Havard Skinnemoen (for i2c-gpio)
    Acked-by: Guan Xuetao (for puf3)
    Acked-by: Barry Song (for sirf)
    Reviewed-by: Jean Delvare
    [wsa: Fixed "foo* bar" flaws while we are here]
    Signed-off-by: Wolfram Sang

    Bill Pemberton
     

24 Jul, 2012

1 commit

  • Convert the drivers in drivers/i2c/busses/* to usemodule_pci_driver()
    macro which makes the code smaller and a bit simpler.

    Signed-off-by: Axel Lin
    Acked-by: Wolfram Sang
    Signed-off-by: Jean Delvare
    Cc: Rudolf Marek
    Cc: Olof Johansson
    Cc: "Mark M. Hoffman"
    Cc: Tomoya MORINAGA

    Axel Lin
     

13 Jan, 2012

1 commit

  • Convert static struct pci_device_id *[] to static DEFINE_PCI_DEVICE_TABLE
    tables.

    Use DEFINE_PCI_DEVICE_TABLE ensures we make the pci_device_id table const
    and marked as __devinitconst.

    This also fixes some warnings from checkpatch:
    e.g.
    WARNING: Use DEFINE_PCI_DEVICE_TABLE for struct pci_device_id
    #1096: FILE: i2c/busses/i2c-intel-mid.c:1096:
    +static struct pci_device_id intel_mid_i2c_ids[] = {

    Signed-off-by: Axel Lin
    Cc: Rudolf Marek
    Cc: Ben Dooks
    Acked-by: Olof Johansson
    Cc: "Mark M. Hoffman"
    Acked-by: Dirk Brandewie
    Cc: Tomoya MORINAGA
    Acked-by: Wolfram Sang
    Cc: Feng Tang
    Cc: Sebastian Andrzej Siewior
    Signed-off-by: Jean Delvare

    Axel Lin
     

01 Nov, 2011

1 commit


07 Sep, 2011

1 commit


21 Mar, 2011

1 commit

  • The Sodaville I2C controller is almost the same as found on PXA2xx. The
    difference:
    - the register are at a different offset
    - no slave support

    The PCI probe code adds three platform devices which are probed then by
    the platform code.
    The X86 part also adds dummy clock defines because we don't have HW
    clock support.

    Signed-off-by: Sebastian Andrzej Siewior
    Signed-off-by: Dirk Brandewie
    Signed-off-by: Ben Dooks

    Sebastian Andrzej Siewior