09 Aug, 2012

1 commit

• 155e4e12b   batman-adv: Fix mem leak in the batadv_tt_local_event() function ... Browse Code »

  Memory is allocated for 'tt_change_node' with kmalloc().
  'tt_change_node' may go out of scope really being used for anything
  (except have a few members initialized) if we hit the 'del:' label.
  This patch makes sure we free the memory in that case.

  Signed-off-by: Jesper Juhl
  Acked-by: Antonio Quartulli
  Signed-off-by: David S. Miller

  Jesper Juhl

  2012-08-09 07:04:04 +0800  

07 Aug, 2012

1 commit

• caa0bf648   batman-adv: select an internet gateway if none was chosen ... Browse Code »

  This is a regression introduced by: 2265c141086474bbae55a5bb3afa1ebb78ccaa7c
  ("batman-adv: gateway election code refactoring")

  Reported-by: Nicolás Echániz
  Signed-off-by: Marek Lindner
  Acked-by: Antonio Quartulli
  Signed-off-by: Antonio Quartulli
  Signed-off-by: David S. Miller

  Marek Lindner

  2012-08-07 04:23:46 +0800  

11 Jul, 2012

2 commits

• 04c9f416e   Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net ... Browse Code »

  Conflicts:
  net/batman-adv/bridge_loop_avoidance.c
  net/batman-adv/bridge_loop_avoidance.h
  net/batman-adv/soft-interface.c
  net/mac80211/mlme.c

  With merge help from Antonio Quartulli (batman-adv) and
  Stephen Rothwell (drivers/net/usb/qmi_wwan.c).

  The net/mac80211/mlme.c conflict seemed easy enough, accounting for a
  conversion to some new tracing macros.

  Signed-off-by: David S. Miller

  David S. Miller

  2012-07-11 14:56:33 +0800  
• 2c53040f0   net: Fix (nearly-)kernel-doc comments for various functions ... Browse Code »

  Fix incorrect start markers, wrapped summary lines, missing section
  breaks, incorrect separators, and some name mismatches.

  Signed-off-by: Ben Hutchings
  Signed-off-by: David S. Miller

  Ben Hutchings

  2012-07-11 14:13:45 +0800  

06 Jul, 2012

1 commit

• 2d3f6ccc4   batman-adv: check incoming packet type for bla ... Browse Code »

  If the gateway functionality is used, some broadcast packets (DHCP
  requests) may be transmitted as unicast packets. As the bridge loop
  avoidance code now only considers the payload Ethernet destination,
  it may drop the DHCP request for clients which are claimed by other
  backbone gateways, because it falsely infers from the broadcast address
  that the right backbone gateway should havehandled the broadcast.

  Fix this by checking and delegating the batman-adv packet type used
  for transmission.

  Reported-by: Guido Iribarren
  Signed-off-by: Simon Wunderlich

  Simon Wunderlich

  2012-07-06 06:08:46 +0800  

02 Jul, 2012

16 commits

• 162d549c6   batman-adv: Don't leak information through uninitialized packet fields ... Browse Code »

  The reserved fields in batman-adv packets are not set to a constant value. The
  content of these memory regions is leaked unintentionally to the network.

  This regression was introduced in 3b27ffb00fbe9d9189715ea13ce8712e2f0cb0c5

  Signed-off-by: Sven Eckelmann
  Signed-off-by: Antonio Quartulli

  Sven Eckelmann

  2012-07-02 04:47:24 +0800  
• 0c5e45b63   batman-adv: fix counter summary length ... Browse Code »

  Signed-off-by: Marek Lindner
  Acked-by: Martin Hundebøll
  Signed-off-by: Antonio Quartulli

  Marek Lindner

  2012-07-02 04:47:23 +0800  
• 0aca2369b   batman-adv: Fix alignment after opened parentheses ... Browse Code »

  Signed-off-by: Sven Eckelmann
  Signed-off-by: Antonio Quartulli

  Sven Eckelmann

  2012-07-02 04:47:23 +0800  
• cb4cca710   batman-adv: Remove space before semicolon ... Browse Code »

  Signed-off-by: Sven Eckelmann
  Signed-off-by: Antonio Quartulli

  Sven Eckelmann

  2012-07-02 04:47:23 +0800  
• b706b13b6   batman-adv: Remove bat_ prefix from bat_{debugfs, sysfs}.{c, h} ... Browse Code »

  The "bat_" prefix in the source files implementing the batman-adv sysfs and
  debugfs interface doesn't have a special meaning and are only used by these
  files and files that implement the actual B.A.T.M.A.N. path finding algorithm.

  The prefix is better suited to mark files that are used to implement the main
  part of the path finding. All other files should not use it and therefore gets
  renamed.

  Signed-off-by: Sven Eckelmann

  Sven Eckelmann

  2012-07-02 04:47:22 +0800  
• a8a0a62d1   batman-adv: Transform BATADV_LOG_BUFF(idx) into function ... Browse Code »

  The linux Documentation/CodingStyle says that:
  * Chapter 12: "inline functions are preferable to macros resembling functions"
  * Chapter 12.2: Depending on local variables with a magic name is bad
  * Chapter 12.3: Macros with arguments used as l-value are bad

  Signed-off-by: Sven Eckelmann

  Sven Eckelmann

  2012-07-02 04:47:22 +0800  
• 56303d34a   batman-adv: Prefix types structs with batadv_ ... Browse Code »

  Reported-by: Martin Hundebøll
  Signed-off-by: Sven Eckelmann

  Sven Eckelmann

  2012-07-02 04:47:21 +0800  
• 964126901   batman-adv: Prefix packet structs with batadv_ ... Browse Code »

  Reported-by: Martin Hundebøll
  Signed-off-by: Sven Eckelmann

  Sven Eckelmann

  2012-07-02 04:47:21 +0800  
• b4d66b877   batman-adv: Prefix local sysfs struct with batadv_ ... Browse Code »

  Reported-by: Martin Hundebøll
  Signed-off-by: Sven Eckelmann

  Sven Eckelmann

  2012-07-02 04:47:21 +0800  
• 5bf74e9ca   batman-adv: Prefix hash struct and typedef with batadv_ ... Browse Code »

  Reported-by: Martin Hundebøll
  Signed-off-by: Sven Eckelmann

  Sven Eckelmann

  2012-07-02 04:47:20 +0800  
• 7f223c0c3   batman-adv: Prefix local debugfs structs with batadv_ ... Browse Code »

  Reported-by: Martin Hundebøll
  Signed-off-by: Sven Eckelmann

  Sven Eckelmann

  2012-07-02 04:47:20 +0800  
• 39c75a51e   batman-adv: Prefix main enum with BATADV_ ... Browse Code »

  Reported-by: Martin Hundebøll
  Signed-off-by: Sven Eckelmann

  Sven Eckelmann

  2012-07-02 04:47:19 +0800  
• acd34afa8   batman-adv: Prefix packet enum with BATADV_ ... Browse Code »

  Reported-by: Martin Hundebøll
  Signed-off-by: Sven Eckelmann

  Sven Eckelmann

  2012-07-02 04:47:19 +0800  
• d69909d2f   batman-adv: Prefix types enum with BATADV_ ... Browse Code »

  Reported-by: Martin Hundebøll
  Signed-off-by: Sven Eckelmann

  Sven Eckelmann

  2012-07-02 04:47:19 +0800  
• e9a4f295e   batman-adv: Prefix hard-interface enum with BATADV_ ... Browse Code »

  Reported-by: Martin Hundebøll
  Signed-off-by: Sven Eckelmann

  Sven Eckelmann

  2012-07-02 04:47:18 +0800  
• cd646ab1e   batman-adv: Prefix gateway enum with BATADV_ ... Browse Code »

  Reported-by: Martin Hundebøll
  Signed-off-by: Sven Eckelmann

  Sven Eckelmann

  2012-07-02 04:47:18 +0800  

28 Jun, 2012

18 commits

• 42d0b044b   batman-adv: Prefix main defines with BATADV_ ... Browse Code »

  Reported-by: Martin Hundebøll
  Signed-off-by: Sven Eckelmann

  Sven Eckelmann

  2012-06-28 14:45:05 +0800  
• edbf7ff72   batman-adv: Prefix vis defines with BATADV_ ... Browse Code »

  Reported-by: Martin Hundebøll
  Signed-off-by: Sven Eckelmann

  Sven Eckelmann

  2012-06-28 14:45:04 +0800  
• 4d5d2db8d   batman-adv: Prefix unicast defines with BATADV_ ... Browse Code »

  Reported-by: Martin Hundebøll
  Signed-off-by: Sven Eckelmann

  Sven Eckelmann

  2012-06-28 14:45:02 +0800  
• c11fdfaef   batman-adv: Prefix types defines with BATADV_ ... Browse Code »

  Reported-by: Martin Hundebøll
  Signed-off-by: Sven Eckelmann

  Sven Eckelmann

  2012-06-28 14:45:01 +0800  
• 7e071c79a   batman-adv: Prefix packet defines with BATADV_ ... Browse Code »

  Reported-by: Martin Hundebøll
  Signed-off-by: Sven Eckelmann

  Sven Eckelmann

  2012-06-28 14:45:00 +0800  
• 64346643e   batman-adv: Prefix icmp_socket defines with BATADV_ ... Browse Code »

  Reported-by: Martin Hundebøll
  Signed-off-by: Sven Eckelmann

  Sven Eckelmann

  2012-06-28 14:44:59 +0800  
• 97ea4ba1f   batman-adv: Prefix gateway defines with BATADV_ ... Browse Code »

  Reported-by: Martin Hundebøll
  Signed-off-by: Sven Eckelmann

  Sven Eckelmann

  2012-06-28 14:44:58 +0800  
• 3964f7285   batman-adv: Prefix bridge_loop_avoidance defines with BATADV_ ... Browse Code »

  Reported-by: Martin Hundebøll
  Signed-off-by: Sven Eckelmann

  Sven Eckelmann

  2012-06-28 14:44:56 +0800  
• 036cbfeb6   batman-adv: Prefix sysfs defines with BATADV_ ... Browse Code »

  Reported-by: Martin Hundebøll
  Signed-off-by: Sven Eckelmann

  Sven Eckelmann

  2012-06-28 14:44:55 +0800  
• 54590e4d4   batman-adv: Prefix debugfs defines with BATADV_ ... Browse Code »

  Reported-by: Martin Hundebøll
  Signed-off-by: Sven Eckelmann

  Sven Eckelmann

  2012-06-28 14:44:54 +0800  
• 347c80f0f   batman-adv: Prefix local defines with BATADV_ ... Browse Code »

  Reported-by: Martin Hundebøll
  Signed-off-by: Sven Eckelmann

  Sven Eckelmann

  2012-06-28 14:44:53 +0800  
• d4f446925   batman-adv: beautify tt_global_add() argument list ... Browse Code »

  Instead of adding a new bool argument each time it is needed, it is better (and
  simpler) to pass an 8bit flag argument which contains all the needed flags

  Signed-off-by: Antonio Quartulli
  Signed-off-by: Sven Eckelmann

  Antonio Quartulli

  2012-06-28 14:44:52 +0800  
• 3b643de54   batman-adv: clear ADD+DEL (and viceversa) events in the same orig-interval ... Browse Code »

  During an OGM-interval (time between two different OGM sendings) the same client
  could roam away and then roam back to us. In this case the node would add two
  events to the events list (that is going to be sent appended to the next OGM). A
  DEL one and an ADD one. Obviously they will only increase the overhead (either in
  the air and on the receiver side) and eventually trigger wrong states/events
  without producing any real effect.

  For this reason we can safely delete any ADD event with its related DEL one.

  Signed-off-by: Antonio Quartulli
  Signed-off-by: Sven Eckelmann

  Antonio Quartulli

  2012-06-28 14:44:50 +0800  
• 28afd3c07   batman-adv: Directly print to seq_file in vis ... Browse Code »

  The vis output doesn't need to be buffered in an character buffer before it can
  be send to the userspace program that reads from the vis debug file.

  Signed-off-by: Sven Eckelmann

  Sven Eckelmann

  2012-06-28 14:44:49 +0800  
• 3e34819e0   batman-adv: Prefix remaining function like macros with batadv_ ... Browse Code »

  Signed-off-by: Sven Eckelmann

  Sven Eckelmann

  2012-06-28 14:44:48 +0800  
• ee11ad61f   batman-adv: Prefix main local static functions with batadv_ ... Browse Code »

  All non-static symbols of batman-adv were prefixed with batadv_ to avoid
  collisions with other symbols of the kernel. Other symbols of batman-adv
  should use the same prefix to keep the naming scheme consistent.

  Signed-off-by: Sven Eckelmann

  Sven Eckelmann

  2012-06-28 14:44:47 +0800  
• eaad8ad95   batman-adv: Prefix vis local static functions with batadv_ ... Browse Code »

  All non-static symbols of batman-adv were prefixed with batadv_ to avoid
  collisions with other symbols of the kernel. Other symbols of batman-adv
  should use the same prefix to keep the naming scheme consistent.

  Signed-off-by: Sven Eckelmann

  Sven Eckelmann

  2012-06-28 14:44:46 +0800  
• 0354440ba   batman-adv: Prefix unicast local static functions with batadv_ ... Browse Code »

  All non-static symbols of batman-adv were prefixed with batadv_ to avoid
  collisions with other symbols of the kernel. Other symbols of batman-adv
  should use the same prefix to keep the naming scheme consistent.

  Signed-off-by: Sven Eckelmann

  Sven Eckelmann

  2012-06-28 14:44:44 +0800  

26 Jun, 2012

1 commit

• 29cb99de4   batman-adv: fix global TT entry deletion ... Browse Code »

  During the last merge involving translation-table.c something went wrong and two
  lines disappeared from translation-table.c. This patch recovers them.

  Signed-off-by: Antonio Quartulli
  Signed-off-by: David S. Miller

  Antonio Quartulli

  2012-06-26 14:54:32 +0800