30 Aug, 2005
2 commits
-
Lots of places just needs the states, not even linux/tcp.h, where this
enum was, needs it.This speeds up development of the refactorings as less sources are
rebuilt when things get moved from net/tcp.h.Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller
27 Aug, 2005
5 commits
-
The problem arises if an entity in sysfs is created and removed without
ever having been made completely visible. In SCSI this is triggered by
removing a device while it's initialising.The problem appears to be that because it was never made visible in sysfs,
the sysfs dentry has a null d_inode which oopses when a reference is made
to it. The solution is simply to check d_inode and assume the object was
never made visible (and thus doesn't need deleting) if it's NULL.(akpm: possibly a stopgap for 2.6.13 scsi problems. May not be the
long-term fix)Signed-off-by: James Bottomley
Cc: Greg KH
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
The recent change to locks_remove_flock code in fs/locks.c changes how
byte range locks are removed from closing files, which shows up a bug in
cifs.The assumption in the cifs code was that the close call sent to the
server would remove any pending locks on the server on this file, but
that is no longer safe as the fs/locks.c code on the client wants unlock
of 0 to PATH_MAX to remove all locks (at least from this client, it is
not possible AFAIK to remove all locks from other clients made to the
server copy of the file).Note that cifs locks are different from posix locks - and it is not
possible to map posix locks perfectly on the wire yet, due to
restrictions of the cifs network protocol, even to Samba without adding
a new request type to the network protocol (which we plan to do for
Samba 3.0.21 within a few months), but the local client will have the
correct, posix view, of the lock in most cases.The correct fix for cifs for this would involve a bigger change than I
would like to do this late in the 2.6.13-rc cycle - and would involve
cifs keeping track of all unmerged (uncoalesced) byte range locks for
each remote inode and scanning that list to remove locks that intersect
or fall wholly within the range - locks that intersect may have to be
reaquired with the smaller, remaining range.Signed-off-by: Steve French
Signed-off-by: Dave Kleikamp
Signed-off-by: Linus Torvalds -
While touching this code I noticed the error handling is bogus, so I
fixed it up.I've removed the IS_ERR(proc_dentry) check, which will never trigger and
is clearly a typo: we must check proc_file instead.Signed-off-by: Paolo 'Blaisorblade' Giarrusso
Signed-off-by: Linus Torvalds -
Update hppfs for the symlink functions prototype change.
Yes, I know the code I leave there is still _bogus_, see next patch for
this.Signed-off-by: Paolo 'Blaisorblade' Giarrusso
Signed-off-by: Linus Torvalds -
There is an off by one problem with idr_get_new_above.
The comment and function name suggest that it will return an id >
starting_id, but it actually returned an id >= starting_id, and kernel
callers other than inotify treated it as such.The patch below fixes the comment, and fixes inotifys usage. The
function name still doesn't match the behaviour, but it never did.Signed-off-by: John McCutchan
Signed-off-by: Linus Torvalds
21 Aug, 2005
4 commits
-
It has all the normal priority inversion problems.
Signed-off-by: Linus Torvalds
-
Signed-off-by: Alexey Dobriyan
Signed-off-by: Linus Torvalds -
We'd updated the prototype and the return value, but not the function
declaration itself. -
"extern inline" doesn't make sense.
Signed-off-by: Adrian Bunk
Signed-off-by: Russell King
20 Aug, 2005
4 commits
-
Added missing unlock_kernel() to NFSv4 atomic lookup.
Signed-off-by: Steve Dickson
Signed-off-by: Trond Myklebust
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
This fixes up the symlink functions for the calling convention change:
* afs, autofs4, befs, devfs, freevxfs, jffs2, jfs, ncpfs, procfs,
smbfs, sysvfs, ufs, xfs - prototype change for ->follow_link()
* befs, smbfs, xfs - same for ->put_link()Signed-off-by: Linus Torvalds
-
This bug could cause oopses and page state corruption, because ncpfs
used the generic page-cache symlink handlign functions. But those
functions only work if the page cache is guaranteed to be "stable", ie a
page that was installed when the symlink walk was started has to still
be installed in the page cache at the end of the walk.We could have fixed ncpfs to not use the generic helper routines, but it
is in many ways much cleaner to instead improve on the symlink walking
helper routines so that they don't require that absolute stability.We do this by allowing "follow_link()" to return a error-pointer as a
cookie, which is fed back to the cleanup "put_link()" routine. This
also simplifies NFS symlink handling.Signed-off-by: Linus Torvalds
-
The current calling conventions for ->follow_link() are already fairly
complex.What we have is
1) you can return -error; then you must release nameidata yourself
and ->put_link() will _not_ be called.
2) you can do nd_set_link(nd, ERR_PTR(-error)) and return 0
3) you can do nd_set_link(nd, path) and return 0
4) you can return 0 (after having moved nameidata yourself)jffs2 follow_link() is broken - it has an exit where it returns
-EIO and leaks nameidata.Signed-off-by: Linus Torvalds
19 Aug, 2005
4 commits
-
When i_acl_default is set to some error we do not hold the lock (hence we
are not allowed to drop it and reacquire later).Signed-off-by: Jan Kara
Cc: Jeff Mahoney
Cc: Chris Mason
Cc:
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Down the road we want to eliminate the use of the global kernel lock entirely
from the NFS client. To do this, we need to protect the fields in the
nfs_inode structure adequately. Start by serializing updates to the
"cache_validity" field.Note this change addresses an SMP hang found by njw@osdl.org, where processes
deadlock because nfs_end_data_update and nfs_revalidate_mapping update the
"cache_validity" field without proper serialization.Test plan:
Millions of fsx ops on SMP clients. Run Nick Wilson's breaknfs program on
large SMP clients.Signed-off-by: Chuck Lever
Cc: Trond Myklebust
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Introduce atomic bitops to manipulate the bits in the nfs_inode structure's
"flags" field.Using bitops means we can use a generic wait_on_bit call instead of an ad hoc
locking scheme in fs/nfs/inode.c, so we can remove the "nfs_i_wait" field from
nfs_inode at the same time.The other new flags field will continue to use bitmask and logic AND and OR.
This permits several flags to be set at the same time efficiently. The
following patch adds a spin lock to protect these flags, and this spin lock
will later cover other fields in the nfs_inode structure, amortizing the cost
of using this type of serialization.Test plan:
Millions of fsx ops on SMP clients.Signed-off-by: Chuck Lever
Cc: Trond Myklebust
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Certain bits in nfsi->flags can be manipulated with atomic bitops, and some
are better manipulated via logical bitmask operations.This patch splits the flags field into two. The next patch introduces atomic
bitops for one of the fields.Test plan:
Millions of fsx ops on SMP clients.Signed-off-by: Chuck Lever
Cc: Trond Myklebust
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
18 Aug, 2005
2 commits
-
The nfsd holds the big kernel lock upon exit, when it really shouldn't.
Not to mention that this breaks Ingo's RT patch. This is a trivial fix
to release the lock.Ingo, this patch also works with your kernel, and stops the problem with
nfsd.Note, there's a "goto out;" where "out:" is right above svc_exit_thread.
The point of the goto also holds the kernel_lock, so I don't see any
problem here in releasing it.Signed-off-by: Steven Rostedt
Signed-off-by: Linus Torvalds
17 Aug, 2005
4 commits
-
for mft record writing. I had missed the writepage based mft record
write code path.Signed-off-by: Anton Altaparmakov
-
When the client performs an exclusive create and opens the file for writing,
a Netapp filer will first create the file using the mode 01777. It does this
since an NFSv3/v4 exclusive create cannot immediately set the mode bits.
The 01777 mode then gets put into the inode->i_mode. After the file creation
is successful, we then do a setattr to change the mode to the correct value
(as per the NFS spec).The problem is that nfs_refresh_inode() no longer updates inode->i_mode, so
the latter retains the 01777 mode. A bit later, the VFS notices this, and calls
remove_suid(). This of course now resets the file mode to inode->i_mode & 0777.
Hey presto, the file mode on the server is now magically changed to 0777. Duh...Fixes http://bugzilla.linux-nfs.org/show_bug.cgi?id=32
Signed-off-by: Trond Myklebust
Signed-off-by: Linus Torvalds
16 Aug, 2005
4 commits
-
Signed-off-by: Trond Myklebust
Signed-off-by: Linus Torvalds -
the buffers when mapping them after the VM had discarded them.
Thanks to Martin MOKREJŠ for the bug report.Signed-off-by: Anton Altaparmakov
-
This adds a MOVE_SELF event to inotify. It is sent whenever the inode
you are watching is moved. We need this event so that we can catch
something like this:- app1:
watch /etc/mtab- app2:
cp /etc/mtab /tmp/mtab-work
mv /etc/mtab /etc/mtab~
mv /tmp/mtab-work /etc/mtabapp1 still thinks it's watching /etc/mtab but it's actually watching
/etc/mtab~.Signed-off-by: John McCutchan
Signed-off-by: Robert Love
Signed-off-by: Linus Torvalds -
We are saving the wrong thing in ->last_wd. We want the wd, not the
return value.Signed-off-by: Robert Love
Signed-off-by: Linus Torvalds
15 Aug, 2005
2 commits
-
Fix path name conversion for long filenames when mapchars mount option
was specified at mount time.Signed-off-by: Steve French (sfrench@us.ibm.com)
Signed-off-by: Linus Torvalds -
Fix missing entries in search results when very long file names and more
than 50 (or so) of such long search entries in the directory.FindNext could send corrupt last byte of resume name when resume key was
a few hundred bytes long file name or longer.Fixes Samba Bug # 2932
Signed-off-by: Steve French (sfrench@us.ibm.com)
Signed-off-by: Linus Torvalds
14 Aug, 2005
1 commit
-
Initialize key object ID in inode so that we don't try to remove the inode
when we fail on some checks even before we manage to allocate something.Signed-off-by: Jan Kara
Signed-off-by: Linus Torvalds
11 Aug, 2005
2 commits
-
Signed-off-by: Dave Kleikamp
-
TxAnchor.anon_list is protected by jfsTxnLock (TXN_LOCK), but there was
a place in txLock() that was removing an entry from the list without holding
the spinlock.Signed-off-by: Dave Kleikamp
09 Aug, 2005
1 commit
-
The patch below unhooks fsnotify from vfs_unlink & vfs_rmdir. It
introduces two new fsnotify calls, that are hooked in at the dcache
level. This not only more closely matches how the VFS layer works, it
also avoids the problem with locking and inode lifetimes.The two functions are
- fsnotify_nameremove -- called when a directory entry is going away.
It notifies the PARENT of the deletion. This is called from
d_delete().- inoderemove -- called when the files inode itself is going away. It
notifies the inode that is being deleted. This is called from
dentry_iput().Signed-off-by: John McCutchan
Signed-off-by: Linus Torvalds
08 Aug, 2005
2 commits
-
I'm resending this patch, because I still believe it's the correct fix.
Tested before/after applying the patch with a test application
available from:http://www.inf.bme.hu/~mszeredi/nstest.c
Bind mount from a foreign namespace results in an un-removable mount.
The reason is that mnt->mnt_namespace is copied from the old mount in
clone_mnt(). Because of this check_mnt() in sys_umount() will fail.The solution is to set mnt->mnt_namespace to current->namespace in
clone_mnt(). clone_mnt() is either called from do_loopback() or
copy_tree(). copy_tree() is called from do_loopback() or
copy_namespace().When called (directly or indirectly) from do_loopback(), always
current->namspace is being modified: check_mnt(nd->mnt). So setting
mnt->mnt_namespace to current->namspace is the right thing to do.When called from copy_namespace(), the setting of mnt_namespace is
irrelevant, since mnt_namespace is reset later in that function for
all copied mounts.Jamie said:
This patch is correct. The old code was buggy for more fundamental and
serious reason: it broke the invariant that a tree of vfsmnts all have the
same value of mnt_namespace (and the same for the mnt_list list).Signed-off-by: Miklos Szeredi
Acked-by: Jamie Lokier
Cc:
Cc: Christoph Hellwig
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Remove a very wrong comment.
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
07 Aug, 2005
1 commit
-
This uses the new deflateBound() thing to sanity-check the input to the
zlib decompressor before we even bother to start reading in the blocks.Problem noted by Tim Yamin
05 Aug, 2005
2 commits
-
This avoids the whole #ifdef mess by just getting a copy of
dentry->d_inode before d_delete is called - that makes the codepaths the
same for the INOTIFY/DNOTIFY cases as for the regular no-notify case.
I've been running this under a Gnome session for the last 10 minutes.
Inotify is being used extensively.Signed-off-by: John McCutchan
Signed-off-by: Linus Torvalds -
Signed-off-by: Dave Kleikamp