02 Jul, 2011

1 commit

• 5a3c6b251   drivers/tty: use printk_ratelimited() instead of printk_ratelimit() ... Browse Code »

  Since the printk_ratelimit() shouldn't be used anymore (see comment in
  include/linux/printk.h), replace it with printk_ratelimited().

  Signed-off-by: Manuel Zerpies
  Signed-off-by: Greg Kroah-Hartman

  Manuel Zerpies

  14 years ago  

30 Apr, 2011

1 commit

• df43daaae   drivers/tty/moxa.c: Put correct tty value ... Browse Code »

  The tty value that should be put is the one that was just gotten by
  tty_port_tty_get, not the one that is the argument to the enclosing
  function.

  The semantic match that finds this problem is as follows:
  (http://coccinelle.lip6.fr/)

  //
  @exists@
  local idexpression struct tty_struct *x;
  expression ra,rr;
  statement S1,S2;
  @@

  x = tty_port_tty_get(...)
  ... when != x = rr
  when any
  when != tty_kref_put(x,...)
  when != if (...) { ... tty_kref_put(x,...) ...}
  (
  if() S1 else S2
  |
  if(...) { ... when != x = ra
  when forall
  when != tty_kref_put(x,...)
  *return...;
  }
  )
  //

  Signed-off-by: Julia Lawall
  Signed-off-by: Greg Kroah-Hartman

  Julia Lawall

  14 years ago  

26 Apr, 2011

1 commit

• 0ad7c9af3   Char: moxa, fix locking in moxa_write ... Browse Code »

  moxa_write can be called from atomic context with irqs disabled (from
  ppp_async_push). Don't enable interrupts by spin_unlock_bh as this
  might cause deadlocks in the ppp layer.

  Instead, use irqsave/irqrestore spin_lock functions.

  Signed-off-by: Jiri Slaby
  Cc: Alan Cox
  Signed-off-by: Greg Kroah-Hartman

  Jiri Slaby

  14 years ago  

20 Apr, 2011

2 commits

• 7c31bdb6b   Char: moxa, do not touch NORMAL_ACTIVE bit ... Browse Code »

  The bit is set in tty_port_block_til_ready (via moxa_open) and unset
  in tty_port_close (via moxa_close). No need to pin it in the driver.

  Signed-off-by: Jiri Slaby
  Cc: Alan Cox
  Signed-off-by: Greg Kroah-Hartman

  Jiri Slaby

  14 years ago  
• 9d86f71b5   Char: moxa, remove unused variables ... Browse Code »

  drivers/tty/moxa.c:1287:2: warning: Value stored to 'port' is never read
  port = tty->index;
  ^ ~~~~~~~~~~
  drivers/tty/moxa.c:1763:2: warning: Value stored to 'cflag' is never read
  cflag = termio->c_cflag; /* termio->c_cflag */
  ^ ~~~~~~~~~~~~~~~

  Signed-off-by: Jiri Slaby
  Signed-off-by: Greg Kroah-Hartman

  Jiri Slaby

  14 years ago  

23 Feb, 2011

1 commit

• a6afd9f3e   tty: move a number of tty drivers from drivers/char/ to drivers/tty/ ... Browse Code »

  As planned by Arnd Bergmann, this moves the following drivers from
  drivers/char/ to drivers/tty/ as that's where they really belong:
  amiserial
  nozomi
  synclink
  rocket
  cyclades
  moxa
  mxser
  isicom
  bfin_jtag_comm

  Cc: Arnd Bergmann
  Cc: Alan Cox
  Cc: Jiri Slaby
  Signed-off-by: Greg Kroah-Hartman

  Greg Kroah-Hartman

  14 years ago