13 Jul, 2009
1 commit
-
* Remove smp_lock.h from files which don't need it (including some headers!)
* Add smp_lock.h to files which do need it
* Make smp_lock.h include conditional in hardirq.h
It's needed only for one kernel_locked() usage which is under CONFIG_PREEMPTThis will make hardirq.h inclusion cheaper for every PREEMPT=n config
(which includes allmodconfig/allyesconfig, BTW)Signed-off-by: Alexey Dobriyan
Signed-off-by: Linus Torvalds
11 Jun, 2009
2 commits
-
Switch from ASYNC_* to ASYNCB_*, because {test,set}_bit expect
bit number, not mask.Signed-off-by: Jiri Slaby
Signed-off-by: Alan Cox
Signed-off-by: Linus Torvalds -
Some drivers implement this internally, others miss it out. Push the
behaviour into the core code as that way everyone will do it consistently.Update the dtr rts method to raise or lower depending upon flags. Having a
single method in this style fits most of the implementations more cleanly than
two funtions.We need this in place before we tackle the USB side
Signed-off-by: Alan Cox
Signed-off-by: Linus Torvalds
03 Jan, 2009
8 commits
-
Now we have our ducks in order we can begin switching to the port
operationsSigned-off-by: Alan Cox
Signed-off-by: Linus Torvalds -
We will need this kref fitted to make full use of the port operations.
Signed-off-by: Alan Cox
Signed-off-by: Linus Torvalds -
We need to this ready for using the standard helpers
Signed-off-by: Alan Cox
Signed-off-by: Linus Torvalds -
Bring this driver into the port locking model
Signed-off-by: Alan Cox
Signed-off-by: Linus Torvalds -
disc_data and driver_data are void *
Signed-off-by: Alan Cox
Signed-off-by: Linus Torvalds -
Normalise them so we can use the common helpers later on
Signed-off-by: Alan Cox
Signed-off-by: Linus Torvalds -
This moves another per device special out of what should be shared open
wait paths into private methodsSigned-off-by: Alan Cox
Signed-off-by: Linus Torvalds -
This is the first step to generalising the various pieces of waiting logic
duplicated in all sorts of serial drivers.Signed-off-by: Alan Cox
Signed-off-by: Linus Torvalds
23 Jul, 2008
1 commit
-
Some hardware needs to do break handling itself and may have partial
support only. Make break_ctl return an error code. Add a tty driver flag
so you can indicate driver hardware side break support.Signed-off-by: Alan Cox
Signed-off-by: Linus Torvalds
21 Jul, 2008
2 commits
-
Move more bits into the tty_port structure
Signed-off-by: Alan Cox
Signed-off-by: Linus Torvalds -
Switch the rocketport to use the new tty_port structure
Signed-off-by: Alan Cox
Signed-off-by: Linus Torvalds
30 Apr, 2008
4 commits
-
Signed-off-by: Alan Cox
Cc: Jiri Slaby
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
- Stop drivers calling their own flush method indirectly, it obfuscates code
and it will change soon anyway- A few more lock_kernel paths temporarily needed in some driver internal
waiting code- Remove private put_char method that does a write call for one char - we
have that anyway- Most but not yet all of the termios copy under lock fixing (some has other
dependencies to follow)- Note a few locking bugs in drivers found in the process
- Kill remaining [ab]users of TIOCG/SSOFTCAR in the driver, these must go to
fix the termios lockingSigned-off-by: Alan Cox
Cc: Jiri Slaby
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Nested min() macros shadow _x, separate into two lines.
drivers/char/rocket.c:451:7: warning: symbol '_x' shadows an earlier one
drivers/char/rocket.c:451:7: originally declared here
drivers/char/rocket.c:451:7: warning: symbol '_x' shadows an earlier one
drivers/char/rocket.c:451:7: originally declared here
drivers/char/rocket.c:451:7: warning: symbol '_y' shadows an earlier one
drivers/char/rocket.c:451:7: originally declared here
drivers/char/rocket.c:1754:7: warning: symbol '_x' shadows an earlier one
drivers/char/rocket.c:1754:7: originally declared here
drivers/char/rocket.c:1754:7: warning: symbol '_x' shadows an earlier one
drivers/char/rocket.c:1754:7: originally declared here
drivers/char/rocket.c:1754:7: warning: symbol '_y' shadows an earlier one
drivers/char/rocket.c:1754:7: originally declared here
drivers/char/rocket.c:1751:20: warning: Using plain integer as NULL pointerSigned-off-by: Harvey Harrison
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Wrap the ioctl code in lock_kernel calls
Signed-off-by: Alan Cox
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
20 Mar, 2008
1 commit
-
unsigned long != __le32, TYVM, and unsigned char[4] is not guaranteed
to be aligned for u32.While we are at it, sanitize sOutDW() a bit - have it take Byte_t * and
handle dereferencing internally.NB: sWriteTxPrioByte() is almost certainly buggered on big-endian and is
missing cpu_to_le16() on assignments to *WordPtr; I've left it alone for now.Signed-off-by: Al Viro
Acked-by: "Theodore Ts'o"
Signed-off-by: Linus Torvalds
09 Feb, 2008
2 commits
-
Signed-off-by: Alan Cox
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Also removes a cflag comparison that caused some mode changes to get wrongly
ignoredSigned-off-by: Alan Cox
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
08 Feb, 2008
3 commits
-
Signed-off-by: Jiri Slaby
Acked-by: Alan Cox
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
- add KERN_ level to each print
- change some levels appropriately
- add \n at the ends where missing
- change two complex printks into dev_info, where the original info is
printed automaticallySigned-off-by: Jiri Slaby
Cc: Alan Cox
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Don't busy wait for whole 1s when registering some rocket modems. Sleep
instead since we are not in atomic.Signed-off-by: Jiri Slaby
Cc: Alan Cox
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
20 Oct, 2007
1 commit
-
Fix the various misspellings of "system", controller", "interrupt" and
"[un]necessary".Signed-off-by: Robert P. J. Day
Signed-off-by: Adrian Bunk
19 Oct, 2007
6 commits
-
Signed-off-by: Jiri Slaby
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
if (controller && !request_region) then we leaked a tty driver struct, fix it
by adding function deinit tail with goto-ing into it (and from other fail
paths too)Signed-off-by: Jiri Slaby
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
We may use pdev->revision instead of reading pci config space directly, so
remove pci_read_config_dword invoking.Signed-off-by: Jiri Slaby
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Signed-off-by: Jiri Slaby
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
- register_device unconditionally (non-pci dependent) to have also isa
devices in /dev
- unregister devices on module removal
- don't set TTY_DRIVER_DYNAMIC_DEV twice (removed the one dependent on some
macro)Signed-off-by: Jiri Slaby
Cc: Ferenc Wagner
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
rocket, switch sleep_on to completion
- sleep_on is deprecated and racy, use completion instead
- also check retval of interruptible function and return ERESTARTSYS
eventuallySigned-off-by: Jiri Slaby
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
20 Jul, 2007
1 commit
-
Transform some calls to kmalloc/memset to a single kzalloc (or kcalloc).
Here is a short excerpt of the semantic patch performing
this transformation:@@
type T2;
expression x;
identifier f,fld;
expression E;
expression E1,E2;
expression e1,e2,e3,y;
statement S;
@@x =
- kmalloc
+ kzalloc
(E1,E2)
... when != \(x->fld=E;\|y=f(...,x,...);\|f(...,x,...);\|x=E;\|while(...) S\|for(e1;e2;e3) S\)
- memset((T2)x,0,E1);@@
expression E1,E2,E3;
@@- kzalloc(E1 * E2,E3)
+ kcalloc(E1,E2,E3)[akpm@linux-foundation.org: get kcalloc args the right way around]
Signed-off-by: Yoann Padioleau
Cc: Richard Henderson
Cc: Ivan Kokshaysky
Acked-by: Russell King
Cc: Bryan Wu
Acked-by: Jiri Slaby
Cc: Dave Airlie
Acked-by: Roland Dreier
Cc: Jiri Kosina
Acked-by: Dmitry Torokhov
Cc: Benjamin Herrenschmidt
Acked-by: Mauro Carvalho Chehab
Acked-by: Pierre Ossman
Cc: Jeff Garzik
Cc: "David S. Miller"
Acked-by: Greg KH
Cc: James Bottomley
Cc: "Antonino A. Daplas"
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
17 Jul, 2007
1 commit
-
Check the return of mutex_lock_interruptible() in drivers/char/rocket.c and
return ERESTARTSYS if we were interrupted.Signed-off-by: Satyam Sharma
Cc: Jiri Slaby
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
11 May, 2007
1 commit
-
The process_session() and process_group() values are not really used by the
driver.Signed-off-by: Sukadev Bhattiprolu
Cc: Cedric Le Goater
Cc: Dave Hansen
Cc: Serge Hallyn
Cc:
Cc: Eric W. Biederman
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
09 May, 2007
4 commits
-
The RocketPort driver uses a semaphore as mutex. Use the mutex API instead of
the (binary) semaphore.Signed-off-by: Matthias Kaehlcke
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
use __set_current_state(TASK_*) instead of current->state = TASK_*,
Signed-off-by: Milind Arun Choudhary
Cc: Jiri Slaby
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
rocket, add MODULE_DEVICE_TABLE
Signed-off-by: Jiri Slaby
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
It misspelled "MODVERSIONS" preprocessor variable with "CONFIG_MODVERSIONS".
Just kill it all.Signed-off-by: Robert P. J. Day
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
13 Feb, 2007
1 commit
-
- Use timer macros to set function and data members and to modify
expiration time.
- Use DEFINE_TIMER for global timers and do not init them at run-time in
these cases.
- del_timer_sync is common in most cases -- we want to wait for timer
function if it's still running.Signed-off-by: Jiri Slaby
Cc: Dave Airlie
Cc: David Woodhouse
Cc: Dominik Brodowski
Cc: Alessandro Zummo
Cc: Paul Fulghum
Cc: Kylene Jo Hall
Cc: Wim Van Sebroeck
Acked-by: Dmitry Torokhov (Input bits)
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
12 Feb, 2007
1 commit
-
tty_wakeup cleanup
- remove wake_up_interruptible(&tty->write_wait) surrounding
tty_wakup(tty);
- substitute tty->ldisc.write_wakeup(tty) + wake_up() by tty_wakeup(tty);Signed-off-by: Jiri Slaby
Cc: Alan Cox
Acked-by: Tilman Schmidt
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds