13 Jan, 2012

2 commits

  • Dan Carpenter points out that it's an int, not a bool:
    intelfbdrv.c:818: if (bailearly == 1)
    intelfbdrv.c:828: if (bailearly == 2)
    intelfbdrv.c:836: if (bailearly == 3)
    intelfbdrv.c:842: if (bailearly == 4)
    intelfbdrv.c:851: if (bailearly == 5)
    intelfbdrv.c:859: if (bailearly == 6)
    intelfbdrv.c:866: bailearly > 6 ? bailearly - 6 : 0);
    intelfbdrv.c:874: if (bailearly == 18)
    intelfbdrv.c:886: if (bailearly == 19)
    intelfbdrv.c:893: if (bailearly == 20)

    Signed-off-by: Rusty Russell
    Cc: Dan Carpenter

    Rusty Russell
     
  • module_param(bool) used to counter-intuitively take an int. In
    fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
    trick.

    It's time to remove the int/unsigned int option. For this version
    it'll simply give a warning, but it'll break next kernel version.

    Acked-by: Mauro Carvalho Chehab
    Signed-off-by: Rusty Russell

    Rusty Russell
     

19 Aug, 2011

1 commit


17 Mar, 2011

1 commit


25 Oct, 2010

1 commit


25 May, 2010

1 commit

  • FBIO_WAITFORVSYNC is currently implemented by matroxfb, atyfb, intelfb and
    more. All of them keep redefining the same FBIO_WAITFORVSYNC macro over
    and over again, so move it to linux/fb.h and clean up those duplicate
    defines.

    Signed-off-by: Grazvydas Ignotas
    Cc: Ville Syrjala
    Cc: Grant Likely
    Cc: Maik Broemme
    Cc: Petr Vandrovec
    Cc: Benjamin Herrenschmidt
    Cc: Krzysztof Helt
    Cc: "Hiremath, Vaibhav"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Grazvydas Ignotas
     

30 Mar, 2010

1 commit

  • …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

16 Dec, 2009

1 commit

  • The intelfb driver sets color map depending on currently active pipe.
    However, if an LVDS display is attached (like in laptop) the active pipe
    variable is never set. The default value is PIPE_A and can be wrong. Set
    up the pipe variable during driver initialization after hardware state was
    read.

    Also, the detection of the active display (and hence the pipe) is wrong.
    The pipes are assigned to so called planes. Both pipes are always enabled
    on my laptop but only one plane is enabled (the plane A for the CRT or the
    plane B for the LVDS). Change active pipe detection code to take into
    account a status of the plane assigned to each pipe.

    The problem is visible in the 8 bpp mode if colors above 15 are used. The
    first 16 color entries are displayed correctly.

    The graphics chip description is here (G45 vol. 3):
    http://intellinuxgraphics.org/documentation.html

    Addresses http://bugzilla.kernel.org/show_bug.cgi?id=13285

    Signed-off-by: Krzysztof Helt
    Cc: Michal Suchanek
    Cc: Dean Menezes
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Krzysztof Helt
     

17 Jun, 2009

1 commit

  • When changing video timing dynamically via fbset the screen sporadically
    is rendered black.

    With the attached fix which disables VCO prior to timing register change
    the problem disappears.

    I had a look at the Xserver register setup code. Here the VCO is
    disabled in the same way [1].

    This patch is taken from vga-sync-field version 0.0.11 [2][3].

    [1] http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/tree/src/i830_=
    driver.c
    [2] http://lowbyte.de/vga-sync-fields/vga-sync-fields-0.0.11.tgz
    [3] http://easy-vdr.de/git?p=frc.git/.git;a=commit;h=dcc3b863e5a663652587619c357bd20075af6896
    2587619c357bd20075af6896

    Signed-off-by: Thomas Hilber
    Signed-off-by: Paul Menzel
    Cc: Krzysztof Helt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Paul Menzel
     

14 Apr, 2009

1 commit

  • Support the Intel 854 Chipset in fbdev.

    We test and use the patch on a Thomson IP1101 IPTV-Box. On the VGA-Port
    we get a normal signal.

    Here is the link to the Mambux-Project: http://www.mambux.de

    Cc: Keith Packard
    Cc: Dave Airlie
    Cc: Krzysztof Helt
    Signed-off-by: Stefan Husemann
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Stefan Husemann
     

27 Jan, 2009

1 commit


07 Jan, 2009

1 commit

  • Fix this sparse warnings:

    drivers/video/intelfb/intelfbdrv.c:1497:3: warning: returning void-valued expression
    drivers/video/intelfb/intelfbdrv.c:1525:3: warning: returning void-valued expression
    drivers/video/intelfb/intelfbdrv.c:1544:3: warning: returning void-valued expression
    drivers/video/intelfb/intelfbdrv.c:1558:3: warning: returning void-valued expression

    Signed-off-by: Hannes Eder
    Cc: Krzysztof Helt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Hannes Eder
     

17 Oct, 2008

1 commit

  • Add support for Intel's 945GME graphics chip to the intelfb driver. I
    have assumed that the 945GME is identical to the already-supported 945GM
    apart from its PCI IDs; this is based on a quick look at the X driver for
    these chips which seems to treat them identically.

    The 945GME is used in the ASUS Eee 901, and I coded this in the hope that
    I'd be able to use it to get a console at the native 1024x600 resolution
    which is not known to the BIOS. I realised too late that the intelfb
    driver does not support mode changing on laptops, so it won't be any
    use for me.

    Signed-off-by: Phil Endecott
    Acked-by: Krzysztof Helt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Phil Endecott
     

15 Jul, 2008

1 commit


28 Apr, 2008

1 commit

  • Add support for the 965G and 965GM graphic chipsets to the intelfb driver. I
    have a notebook with an Intel Mobile GM965/GL960 Integrated Graphics
    Controller and with the attached patch the framebuffer comes up. I have
    tested it a bit with DirectFB to make sure it is working stable.

    I also have an Intel Mobile GM945 and I compared the results, the programming
    interface of the 9xx series from Intel is mostly the same, so I think the
    patch should add all the functionality which the 945GM has.

    Signed-off-by: Maik Broemme
    Cc: Dave Airlie
    Cc: Antonino Daplas
    Cc: Geert Uytterhoeven
    Cc: Krzysztof Halasa
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Maik Broemme
     

07 Feb, 2008

1 commit

  • Mostly in and around irq handlers.

    Signed-off-by: Jeff Garzik
    Cc: Russell King
    Cc: "Luck Tony"
    Cc: Roman Zippel
    Cc: Geert Uytterhoeven
    Cc: Paul Mackerras
    Cc: Benjamin Herrenschmidt
    Acked-by: Dmitry Torokhov
    Cc: Karsten Keil
    Acked-by: "John W. Linville"
    Cc: James Bottomley
    Cc: David Brownell
    Cc: "Antonino A. Daplas"
    Acked-by: Josh Boyer
    Acked-by: Holger Schurig
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jeff Garzik
     

03 Feb, 2008

1 commit


20 Oct, 2007

1 commit

  • * Convert files to UTF-8.

    * Also correct some people's names
    (one example is Eißfeldt, which was found in a source file.
    Given that the author used an ß at all in a source file
    indicates that the real name has in fact a 'ß' and not an 'ss',
    which is commonly used as a substitute for 'ß' when limited to
    7bit.)

    * Correct town names (Goettingen -> Göttingen)

    * Update Eberhard Mönkeberg's address (http://lkml.org/lkml/2007/1/8/313)

    Signed-off-by: Jan Engelhardt
    Signed-off-by: Adrian Bunk

    Jan Engelhardt
     

17 Oct, 2007

6 commits


20 Sep, 2007

1 commit


12 Sep, 2007

1 commit

  • Intel framebuffer mis-calculated pixel clocks.

    The pixel clock (and thus both H and V sync) will be slower than requested, so
    if you set the minimum allowed the display may not sync. In case of really
    old CRT display it could theoretically damage it.

    I'm using it with PAL TV (using RGB input - SCART connector) and the bug
    prevented it from working at all (TV requirements are more strict and made the
    bug visible).

    Signed-off-by: Krzysztof Halasa
    Cc: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Krzysztof Halasa
     

18 Jul, 2007

1 commit


09 May, 2007

1 commit

  • If there is less than RING_MIN_FREE available in the ring buffer,
    dinfo->ring_space is set to a big value forcing wait_ring to return.

    Fix by making ring space = 0 if ring space < RING_MIN_FREE.

    Signed-off-by: Dave Airlie
    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Orczykowski, Juergen
     

02 May, 2007

1 commit

  • This shrinks the size of "struct i2c_client" by 40 bytes:

    - Substantially shrinks the string used to identify the chip type
    - The "flags" don't need to be so big
    - Removes some internal padding

    It also adds kerneldoc for that struct, explaining how "name" is really a
    chip type identifier; it's otherwise potentially confusing.

    Because the I2C_NAME_SIZE symbol was abused for both i2c_client.name
    and for i2c_adapter.name, this needed to affect i2c_adapter too. The
    adapters which used that symbol now use the more-obviously-correct
    idiom of taking the size of that field.

    JD: Shorten i2c_adapter.name from 50 to 48 bytes while we're here, to
    avoid wasting space in padding.

    Signed-off-by: David Brownell
    Signed-off-by: Jean Delvare

    David Brownell
     

15 Feb, 2007

2 commits

  • The obsolete SA_xxx interrupt flags have been used despite the scheduled
    removal. Fixup the remaining users.

    Signed-off-by: Thomas Gleixner
    Acked-by: Ingo Molnar
    Cc: "Luck, Tony"
    Cc: Roman Zippel
    Cc: Geert Uytterhoeven
    Cc: Jeff Garzik
    Cc: Wim Van Sebroeck
    Cc: Roland Dreier
    Cc: Alessandro Zummo
    Cc: James Bottomley
    Cc: Greg KH
    Cc: Dave Airlie
    Cc: James Simmons
    Cc: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Thomas Gleixner
     
  • After Al Viro (finally) succeeded in removing the sched.h #include in module.h
    recently, it makes sense again to remove other superfluous sched.h includes.
    There are quite a lot of files which include it but don't actually need
    anything defined in there. Presumably these includes were once needed for
    macros that used to live in sched.h, but moved to other header files in the
    course of cleaning it up.

    To ease the pain, this time I did not fiddle with any header files and only
    removed #includes from .c-files, which tend to cause less trouble.

    Compile tested against 2.6.20-rc2 and 2.6.20-rc2-mm2 (with offsets) on alpha,
    arm, i386, ia64, mips, powerpc, and x86_64 with allnoconfig, defconfig,
    allmodconfig, and allyesconfig as well as a few randconfigs on x86_64 and all
    configs in arch/arm/configs on arm. I also checked that no new warnings were
    introduced by the patch (actually, some warnings are removed that were emitted
    by unnecessarily included header files).

    Signed-off-by: Tim Schmielau
    Acked-by: Russell King
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tim Schmielau
     

13 Feb, 2007

1 commit


11 Dec, 2006

1 commit


09 Dec, 2006

1 commit


26 Oct, 2006

2 commits


05 Oct, 2006

1 commit

  • Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
    of passing regs around manually through all ~1800 interrupt handlers in the
    Linux kernel.

    The regs pointer is used in few places, but it potentially costs both stack
    space and code to pass it around. On the FRV arch, removing the regs parameter
    from all the genirq function results in a 20% speed up of the IRQ exit path
    (ie: from leaving timer_interrupt() to leaving do_IRQ()).

    Where appropriate, an arch may override the generic storage facility and do
    something different with the variable. On FRV, for instance, the address is
    maintained in GR28 at all times inside the kernel as part of general exception
    handling.

    Having looked over the code, it appears that the parameter may be handed down
    through up to twenty or so layers of functions. Consider a USB character
    device attached to a USB hub, attached to a USB controller that posts its
    interrupts through a cascaded auxiliary interrupt controller. A character
    device driver may want to pass regs to the sysrq handler through the input
    layer which adds another few layers of parameter passing.

    I've build this code with allyesconfig for x86_64 and i386. I've runtested the
    main part of the code on FRV and i386, though I can't test most of the drivers.
    I've also done partial conversion for powerpc and MIPS - these at least compile
    with minimal configurations.

    This will affect all archs. Mostly the changes should be relatively easy.
    Take do_IRQ(), store the regs pointer at the beginning, saving the old one:

    struct pt_regs *old_regs = set_irq_regs(regs);

    And put the old one back at the end:

    set_irq_regs(old_regs);

    Don't pass regs through to generic_handle_irq() or __do_IRQ().

    In timer_interrupt(), this sort of change will be necessary:

    - update_process_times(user_mode(regs));
    - profile_tick(CPU_PROFILING, regs);
    + update_process_times(user_mode(get_irq_regs()));
    + profile_tick(CPU_PROFILING);

    I'd like to move update_process_times()'s use of get_irq_regs() into itself,
    except that i386, alone of the archs, uses something other than user_mode().

    Some notes on the interrupt handling in the drivers:

    (*) input_dev() is now gone entirely. The regs pointer is no longer stored in
    the input_dev struct.

    (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
    something different depending on whether it's been supplied with a regs
    pointer or not.

    (*) Various IRQ handler function pointers have been moved to type
    irq_handler_t.

    Signed-Off-By: David Howells
    (cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)

    David Howells
     

04 Oct, 2006

1 commit


01 Oct, 2006

1 commit

  • * 'intelfb-patches' of master.kernel.org:/pub/scm/linux/kernel/git/airlied/intelfb-2.6:
    intelfbhw.c: intelfbhw_get_p1p2 defined but not used
    intelfb: fix mtrr_reg signedness
    intelfb: update doc and Kconfig (supported devices)
    intelfb: add preliminary i2c support
    intelfb: add preliminary i2c support
    intelfb: add preliminary i2c support
    intelfb: add preliminary i2c support
    intelfb: add preliminary i2c support
    intelfb: add preliminary i2c support
    intelfb: add preliminary i2c support
    intelfb: add preliminary i2c support
    intelfb: add vsync interrupt support
    intelfb: add vsync interrupt support
    intelfb: add vsync interrupt support
    intelfb: add vsync interrupt support
    intelfb: add vsync interrupt support

    Linus Torvalds
     

22 Aug, 2006

1 commit