Eric Lee / smarc-fsl-linux-kernel

30 Dec, 2011

1 commit

18 Sep, 2011

1 commit

21 Oct, 2010

1 commit

  • db5a753bf   Revert d88dca79d3852a3623f606f781e013d61486828a ... Browse Code »

    TIPC needs to have its endianess issues fixed. Unfortunately, the format of a
    subscriber message is passed in directly from user space, so requiring this
    message to be in network byte order breaks user space ABI. Revert this change
    until such time as we can determine how to do this in a backwards compatible
    manner.

    Signed-off-by: Neil Horman
    Signed-off-by: David S. Miller

    Neil Horman
     

09 Mar, 2010

1 commit

  • d88dca79d   tipc: fix endianness on tipc subscriber messages ... Browse Code »

    Remove htohl implementation from tipc

    I was working on forward porting the downstream commits for TIPC and ran accross this one:
    http://tipc.cslab.ericsson.net/cgi-bin/gitweb.cgi?p=people/allan/tipc.git;a=commitdiff;h=894279b9437b63cbb02405ad5b8e033b51e4e31e

    I was going to just take it, when I looked closer and noted what it was doing.
    This is basically a routine to byte swap fields of data in sent/received packets
    for tipc, dependent upon the receivers guessed endianness of the peer when a
    connection is established. Asside from just seeming silly to me, it appears to
    violate the latest RFC draft for tipc:
    http://tipc.sourceforge.net/doc/draft-spec-tipc-02.txt
    Which, according to section 4.2 and 4.3.3, requires that all fields of all
    commands be sent in network byte order. So instead of just taking this patch,
    instead I'm removing the htohl function and replacing the calls with calls to
    ntohl in the rx path and htonl in the send path.

    As part of this fix, I'm also changing the subscr_cancel function, which
    searches the list of subscribers, using a memcmp of the entire subscriber list,
    for the entry to tear down. unfortunately it memcmps the entire tipc_subscr
    structure which has several bits that are private to the local side, so nothing
    will ever match. section 5.2 of the draft spec indicates the
    tuple should uniquely identify a subscriber, so convert subscr_cancel to just
    match on those fields (properly endian swapped).

    I've tested this using the tipc test suite, and its passed without issue.

    Signed-off-by: Neil Horman
    Signed-off-by: David S. Miller

    Neil Horman
     

20 May, 2008

4 commits

  • 5b06c85c3   tipc: Cosmetic cleanup of topology service code ... Browse Code »

    This patch contains a set of cosmetic changes to TIPC's network
    topology service subsystem, including:

    - updates to comments (including copyright dates)
    - re-ordering structure fields to group them more logically
    - removal of optional debugging code that is no longer required
    - minor changes to whitespace to conform to Linux coding conventions

    Signed-off-by: Allan Stephens
    Signed-off-by: David S. Miller

    Allan Stephens
     
  • 28353e7fa   tipc: Consolidate subscriber & subscriber port references ... Browse Code »

    This patch modifies TIPC's network topology service so that it
    only requires a single reference table entry per subscriber
    connection, rather than two. This is achieved by letting the
    reference to the server port communicating with the subscriber
    act as the reference to the subscriber object itself. (Since
    the subscriber cannot exist without its port, and vice versa,
    this dual role for the reference is perfectly natural.) This
    consolidation reduces the size of the reference table by 50%
    in the default configuration.

    Signed-off-by: Allan Stephens
    Signed-off-by: David S. Miller

    Allan Stephens
     
  • 8e9501f51   tipc: Add support for customized subscription endianness ... Browse Code »

    This patch enables TIPC's topology server code to do customized
    endianness conversions on a per-subscription basis. (This
    capability is needed to support the upcoming consolidation of
    subscriber and subscription object references.)

    Signed-off-by: Allan Stephens
    Signed-off-by: David S. Miller

    Allan Stephens
     
  • e15f88040   tipc: Add support for customized subscription overlap handling ... Browse Code »

    This patch enables TIPC's topology server code to do customized
    overlap detection handling on a per-subscription basis. (This
    capability is needed to support the upcoming introduction of
    multi-cluster TIPC networks.)

    Signed-off-by: Allan Stephens
    Signed-off-by: David S. Miller

    Allan Stephens
     

11 Feb, 2007

1 commit

18 Jan, 2006

1 commit

13 Jan, 2006

3 commits