23 Jun, 2005
38 commits
-
Signed-off-by: Trond Myklebust
-
This shows up on running tar over NFSv4.
Signed-off-by: Manoj Naik
Signed-off-by: Trond Myklebust -
Request RDATTR_ERROR as an attribute in readdir to distinguish between a
directory being within an absent filesystem or one (or more) of its entries.Signed-off-by: Manoj Naik
Signed-off-by: Trond Myklebust -
Ensure that lock owner structures are not released prematurely.
Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
Basically copies the VFS's method for tracking writebacks and applies
it to the struct nfs_page.Signed-off-by: Trond Myklebust
-
Use stable writes if we can see that we are only going to put a single
write on the wire.Signed-off-by: Trond Myklebust
-
Even if the file is open for writes.
Signed-off-by: Trond Myklebust
-
Unless we're doing O_APPEND writes, we really don't care about revalidating
the file length. Just make sure that we catch any page cache invalidations.Signed-off-by: Trond Myklebust
-
Instead of looking at whether or not the file is open for writes before
we accept to update the length using the server value, we should rather
be looking at whether or not we are currently caching any writes.Failure to do so means in particular that we're not updating the file
length correctly after obtaining a POSIX or BSD lock.Signed-off-by: Trond Myklebust
-
If we do not hold a valid stateid that is open for writes, there is little
point in doing an extra open of the file, as the RFC does not appear to
mandate this...Make setattr use the correct stateid if we're holding mandatory byte
range locks.Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
NFSv3 currently returns the unsigned 64-bit cookie directly to
userspace. The following patch causes the kernel to generate
loff_t offsets for the benefit of userland.
The current server-generated READDIR cookie is cached in the
nfs_open_context instead of in filp->f_pos, so we still end up work
correctly under directory insertions/deletion.Signed-off-by: Olivier Galibert
Signed-off-by: Trond Myklebust -
The changeset "trond.myklebust@fys.uio.no|ChangeSet|20050322152404|16979"
(RPC: Ensure XDR iovec length is initialized correctly in call_header)
causes the NFSv4 callback code to BUG() due to an incorrectly initialized
scratch buffer.Signed-off-by: Trond Myklebust
-
From: Reuben Farrelly
With gcc-4.0:
fs/nfs/nfs4proc.c:2976: error: static declaration of
'nfs4_file_inode_operations' follows non-static declaration
fs/nfs/nfs4_fs.h:179: error: previous declaration of
'nfs4_file_inode_operations' was hereSigned-off-by: Andrew Morton
Signed-off-by: Trond Myklebust -
Older gcc's don't like this.
fs/nfs/nfs4proc.c:2194: field `data' has incomplete type
Signed-off-by: Andrew Morton
Signed-off-by: Trond Myklebust -
The Coverity checker noticed that such a simplification was possible.
Signed-off-by: Adrian Bunk
Signed-off-by: Trond Myklebust -
* Pointer arithmetic bug: p is in word units. This fixes a memory
corruption with big acls.
* Initialize pg_class to prevent a NULL pointer access.Signed-off-by: Andreas Gruenbacher
Signed-off-by: Trond Myklebust -
Initialize the inode cache values correctly.
Clean up __nfs3_forget_cached_acls()Signed-off-by: Trond Myklebust
-
Attach acls to inodes in the icache to avoid unnecessary GETACL RPC
round-trips. As long as the client doesn't retrieve any acls itself, only the
default acls of exiting directories and the default and access acls of new
directories will end up in the cache, which preserves some memory compared to
always caching the access and default acl of all files.Signed-off-by: Andreas Gruenbacher
Acked-by: Olaf Kirch
Signed-off-by: Andrew Morton
Signed-off-by: Trond Myklebust -
NFSv3 has no concept of a umask on the server side: The client applies
the umask locally, and sends the effective permissions to the server.
This behavior is wrong when files are created in a directory that has a
default ACL. In this case, the umask is supposed to be ignored, and
only the default ACL determines the file's effective permissions.Usually its the server's task to conditionally apply the umask. But
since the server knows nothing about the umask, we have to do it on the
client side. This patch tries to fetch the parent directory's default
ACL before creating a new file, computes the appropriate create mode to
send to the server, and finally sets the new file's access and default
acl appropriately.Many thanks to Buck Huppmann for sending the initial
version of this patch, as well as for arguing why we need this change.Signed-off-by: Andreas Gruenbacher
Acked-by: Olaf Kirch
Signed-off-by: Andrew Morton
Signed-off-by: Trond Myklebust -
This adds acl support fo nfs clients via the NFSACL protocol extension, by
implementing the getxattr, listxattr, setxattr, and removexattr iops for the
system.posix_acl_access and system.posix_acl_default attributes. This patch
implements a dumb version that uses no caching (and thus adds some overhead).
(Another patch in this patchset adds caching as well.)Signed-off-by: Andreas Gruenbacher
Acked-by: Olaf Kirch
Signed-off-by: Andrew Morton
Signed-off-by: Trond Myklebust -
Currently we return -ENOMEM for every single failure to create a new auth.
This is actually accurate for auth_null and auth_unix, but for auth_gss it's a
bit confusing.Allow rpcauth_create (and the ->create methods) to return errors. With this
patch, the user may sometimes see an EINVAL instead. Whee.Signed-off-by: J. Bruce Fields
Signed-off-by: Trond Myklebust -
Add nfs4_acl field to the nfs_inode, and use it to cache acls. Only cache
acls of size up to a page. Also prepare for up to a page of acl data even
when the user doesn't pass in a buffer, as when they want to get the acl
length to decide what size buffer to allocate.Signed-off-by: J. Bruce Fields
Signed-off-by: Trond Myklebust -
Client-side write support for NFSv4 ACLs.
Signed-off-by: J. Bruce Fields
Signed-off-by: Trond Myklebust -
Client-side support for NFSv4 acls: xdr encoding and decoding routines for
writing aclsSigned-off-by: J. Bruce Fields
Signed-off-by: Trond Myklebust -
Client-side support for NFSv4 ACLs. Exports the raw xdr code via the
system.nfs4_acl extended attribute. It is up to userspace to decode the acl
(and to provide correctly xdr'd acls on setxattr), and to convert to/from
POSIX ACLs if desired.This patch provides only the read support.
Signed-off-by: J. Bruce Fields
Signed-off-by: Trond Myklebust -
Client-side support for NFSv4 acls: xdr encoding and decoding routines for
reading aclsSigned-off-by: J. Bruce Fields
Signed-off-by: Trond Myklebust -
Make nfs4 fattr size calculations more explicit, revising them downward a
bit in the process.Signed-off-by: J. Bruce Fields
Signed-off-by: Trond Myklebust -
Add {get,set,list}xattr methods for nfs4. The new methods are no-ops, to be
used by subsequent ACL patch.Signed-off-by: J. Bruce Fields
Signed-off-by: Trond Myklebust -
Signed-off-by: Trond Myklebust
-
ACL support will require supporting additional inode operations in v4
(getxattr, setxattr, listxattr). This patch allows different protocol versions
to support different inode operations by adding a file_inode_ops to the
nfs_rpc_ops (to match the existing dir_inode_ops).Signed-off-by: J. Bruce Fields
Signed-off-by: Trond Myklebust -
Remove the wait queue, and replace the functions that depended on it
with wait_on_bit().Signed-off-by: Trond Myklebust
-
Signed-off-by: Trond Myklebust
-
- Move NFSv4 state definitions into a private header file.
- Clean up gunk in nfs_fs.hSigned-off-by: Trond Myklebust
-
Ensure that we fix up the missing fields in the nfs_mount_data with
sane defaults for older versions of mount, and return errors in the
cases where we cannot.Convert a bunch of annoying warnings into dprintks()
Return -EPROTONOSUPPORT rather than EIO if mount() tries to set NFSv3
without it actually being compiled in.Signed-off-by: Trond Myklebust
-
This saves us a couple of lines of cleanup code for each call.
Signed-off-by: Trond Myklebust
14 Jun, 2005
1 commit
-
This fixes a data corruption error for mail delivery applications that
expect to be able to do posix locking and then append writes on NFS.Signed-off-by: Trond Myklebust
Signed-off-by: Linus Torvalds
08 Jun, 2005
1 commit
-
We should never apply a lookup intent to anything other than the last
path component in an open(), create() or access() call.Introduce the helper nfs_lookup_check_intent() which always returns
zero if LOOKUP_CONTINUE or LOOKUP_PARENT are set, and returns the
intent flags if we're on the last component of the lookup.
By doing so, we fix a bug in open(O_EXCL), where we may end up
optimizing away a real lookup of the parent directory.Problem noticed by Linda Dunaphant
Signed-off-by: Trond Myklebust
Signed-off-by: Linus Torvalds