02 Dec, 2006
34 commits
-
Minor cleanup/clarification in the ethernet gadget driver, using standard
calls to test for Ethernet multicast and broadcast addresses.Signed-off-by: David Brownell
Signed-off-by: Greg Kroah-Hartman -
This patch (as809b) moves the declaration of the hub driver's private
data structure from hub.h into the hub.c source file. Lots of other
files import hub.h; they have no need to know about the details of the
hub driver's private data.Signed-off-by: Alan Stern
Signed-off-by: Greg Kroah-Hartman -
Fix STATUS_PACKETS_* macros, where "&&" was mistakenly used where
"&" should have.Signed-off-by: Jean Delvare
Acked-by: David Brownell
Signed-off-by: Greg Kroah-Hartman -
This patch (as814) adds usb_autopm_set_interface() to the autosuspend
API. It also provides convenient wrapper routines,
usb_autopm_enable() and usb_autopm_disable(), for drivers that want
to specify directly whether autosuspend should be allowed.Signed-off-by: Alan Stern
Signed-off-by: Greg Kroah-Hartman -
This patch (as813) gathers together common code for USB interface
autosuspend/autoresume.It also adds some simple checking at the time an autosuspend request
is made, to see whether the request will fail. This way we don't
add a workqueue entry when it would end up doing nothing.Signed-off-by: Alan Stern
Signed-off-by: Greg Kroah-Hartman -
We have no benefits of having the usb_endpoint_* functions as functions,
but making them inline saves text and data segment sizes:text data bss dec hex filename
14893634 3108770 1108840 19111244 1239d4c vmlinux.func
14893185 3108566 1108840 19110591 1239abf vmlinux.inlineThis is the result of a 2.6.19-rc3 kernel compiled with GCC 4.1.1 without
CONFIG_MODULES, CONFIG_CC_OPTIMIZE_FOR_SIZE, CONFIG_REGPARM options set.
USB support is fully enabled (while most of the other drivers are not),
and that kernel has most of the USB code ported to use the endpoint
functions.That happens because a call to those functions are expensive (in terms
of bytes), while the function's size is smaller or have the same 'size' of
the call.Signed-off-by: Luiz Fernando N. Capitulino
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Luiz Fernando N. Capitulino
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Luiz Fernando N. Capitulino
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Luiz Fernando N. Capitulino
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Luiz Fernando N. Capitulino
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Luiz Fernando N. Capitulino
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Luiz Fernando N. Capitulino
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Luiz Fernando N. Capitulino
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Luiz Fernando N. Capitulino
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Luiz Fernando N. Capitulino
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Luiz Fernando N. Capitulino
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Luiz Fernando N. Capitulino
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Luiz Fernando N. Capitulino
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Luiz Fernando N. Capitulino
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Luiz Fernando N. Capitulino
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Luiz Fernando N. Capitulino
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Luiz Fernando N. Capitulino
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Luiz Fernando N. Capitulino
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Luiz Fernando N. Capitulino
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Luiz Fernando N. Capitulino
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Luiz Fernando N. Capitulino
Signed-off-by: Greg Kroah-Hartman -
This patch (as811) removes some stale testing code from the root-hub
resume routine in ohci-hcd. It also adds a spin_lock_irq() call that
inadvertently got left out of an error pathway.Signed-off-by: Alan Stern
Signed-off-by: Greg Kroah-Hartman -
replace open coded kmemdup() to save some screen space,
and allow inlining/not inlining to be triggered by gcc.Signed-off-by: Eric Sesterhenn
Signed-off-by: Greg Kroah-Hartman -
This patch (as808b) moves the Root Hub Status Change interrupt-disable
code in ohci-hcd back into the interrupt handler proper, to avoid the
chance of adverse interactions with mediocre hardware implementations.It also deletes the root-hub status timer from within the interrupt-enable
routine. There's no need to poll for status any more once interrupts are
re-enabled.Signed-off-by: Alan Stern
Signed-off-by: Greg Kroah-Hartman -
This patch (as806) fixes a compiler warning when ohci-hcd is built
with CONFIG_PM turned off.Signed-off-by: Alan Stern
Signed-off-by: Greg Kroah-Hartman -
This patch (as804) makes USB driver matching ignore the interface
class, subclass, and protocol if the device class is Vendor Specific.
Drivers can override this policy by specifying a Vendor ID as part
of the match; then vendor-specific matches are allowed.Linus Walleij has reported a problem this patch fixes. When a
particular mass-storage device is switched from mass-storage mode to
Media Transfer Protocol, the interface class remains set to mass-storage
and usb-storage binds to it erroneously, even though the device class
changes to Vendor-Specific.This may cause a problem for some drivers until their match records can
be updated to include Vendor IDs. But if it does, then those records
were broken to begin with.Signed-off-by: Alan Stern
Signed-off-by: Greg Kroah-Hartman -
The USB HID driver doesn't include any code to handle a STALL on the
interrupt endpoint. While this may be uncommon, it does happen
sometimes. This patch (as805) adds a fix.Signed-off-by: Alan Stern
Signed-off-by: Greg Kroah-Hartman -
Wireless USB Host Controllers accept a large number of devices per
host, which shows up as a large number of ports in its root hub.When the number of ports in a hub device goes over 16, the activation
of the hub fails with the cryptic message in klogd.hub 2-0:1.0: activate --> -22
Following this further, it was seen that:
hub_probe()
hub_configure()
generates pipe numberpseudo allocates buffer 'maxp' bytes in size using usb_maxpacket()
The endpoint descriptor for a root hub interrupt endpoint is
declared in
drivers/usb/core/hcd.c:hs_rh_config_descriptor and declares it
to be size two (supporting 15 devices max).hub_activate()
usb_hcd_submit_urb()
rh_urb_enqueue()
urb->pipe is neither int nor ctl, so it errors out
rh_queue_status()
Returns -EINVAL because the buffer length is smaller
than the minimum needed to report all the hub port
bits as in accordance with USB2.0[11.12.3]. There has
to be trunc((PORTS + 1 + 7) / 8) bytes of space at
least.Alan Stern confirmed that the reason for reading maxpktsize and not
the right amount is because some hubs are known to return more data
and thus cause overflow.So this patch simply changes the code to make the interrupt endpoint's
max packet size be at least the minimum required by USB_MAXCHILDREN
(instead of a fixed magic number) and add documentation for that. This
way we are always ahead of the limit.Signed-off-by: Inaky Perez-Gonzalez
Signed-off-by: Greg Kroah-Hartman -
Current Wireless USB host hardware (Intel i1480 for example) allows up
to 22 devices to connect, thus bringing up the max number of children
in the WUSB Host Controller to 22 'fake' ports. Upcoming hardware
might raise that limit.Makes almost no difference to go to 31, as the bit arrays are
byte-aligned (plus an extra bit in general), so 22 bits fit in 4 bytes
as 31 do.As well, the only other array that depends on USB_MAXCHILDREN is
'struct usb_hub->indicator'. By declaring it 'u8' instead of 'enum
hub_led_mode', we reduce the size of each entry from 4 bytes (in i386)
to 1, which will add as we when are doubling USB_MAXCHILDREN
(with 16 the size of that array is 64 bytes, with 31 would be 128; by
using u8 that goes down to 31 bytes).Signed-off-by: Inaky Perez-Gonzalez
Signed-off-by: Greg Kroah-Hartman
30 Nov, 2006
1 commit
-
This changes the type of variable "i" in rtl8169_init_one()
from "unsigned int" to "int". "i" is checked for < 0 later,
which can never happen for "unsigned". This results in broken
error handling.Signed-off-by: Michael Buesch
Signed-off-by: Francois Romieu
Signed-off-by: Linus Torvalds
29 Nov, 2006
2 commits
-
* 'upstream-linus' of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev:
[PATCH] libata: Fixup ata_sas_queuecmd to handle __ata_scsi_queuecmd failure
[PATCH] ahci: AHCI mode SATA patch for Intel ICH9
[PATCH] libata: don't schedule EH on wcache on/off if old EH -
When we sleep and wait for a suspended operation to be resumed, go
back and check until it's ready -- don't just continue after the first
time we're woken. This can cause file system corruption.Signed-off-by: Joakim Tjernlund
Signed-off-by: David Woodhouse
Signed-off-by: Linus Torvalds
28 Nov, 2006
3 commits
-
Fixes ata_sas_queuecmd to properly handle a failure from
__ata_scsi_queuecmd.Signed-off-by: Brian King
Signed-off-by: Jeff Garzik -
This patch adds the Intel ICH9 AHCI controller DID's for SATA support.
Signed-off-by: Jason Gaston
Signed-off-by: Jeff Garzik -
Do not schedule EH for revalidation on wcache on/off if old EH. Old
EH cannot handle it and will result in WARN_ON()'s and oops.This closes bug #7412.
Signed-off-by: Tejun Heo
Signed-off-by: Jeff Garzik
