13 Apr, 2011
1 commit
-
Most of these are cases where we are trying to read back a register
after a write to ensure completion.Simply pre-fixing the readl() or readq() with "(void)" is sufficient
because these are volatile operations and the compiler cannot eliminate
them just because no real assignment takes place.The case of free_rxd_blk()'s assignments to "struct buffAdd *ba" is a
real spurious assignment as this variable is completely otherwise
unused.Signed-off-by: David S. Miller
Acked-by: Jon Mason
12 Apr, 2011
24 commits
-
Most of these were legitimate, and once case was a real bug
(not propagating errors from ->xcvr_init() methods).Signed-off-by: David S. Miller
-
Signed-off-by: Sjur Brændeland
Signed-off-by: David S. Miller -
If CAIF Link Layer returns an error, we no longer try to re-build the
CAIF packet and resend it. Instead, we simply return any transmission
errors to the socket client.Signed-off-by: Sjur Brændeland
Signed-off-by: David S. Miller -
Cleanup of new CAIF code.
* make local functions static
* remove code that is never used
* expand get_caif_conf() since wrapper is no longer needed
* make args to comparison functions const
* rename connect_req_to_link_param to keep exported names
consistentCompile tested only.
Signed-off-by: Stephen Hemminger
Acked-by: Sjur Brændeland
Signed-off-by: David S. Miller -
Conflicts:
drivers/net/smsc911x.c -
When the RX network flow classification interface was originally
defined for reporting and controlling of flow hashing, AH and ESP were
not given distinct flow class codes (apparently because the Sun
Neptune hardware treats them very similarly).For flow steering, they must be distinguished, so new and separate
flow class codes were added for AH and ESP. But for backward-
compatibility, flow hash operations should continue to support the
original class codes.Signed-off-by: Ben Hutchings
Signed-off-by: David S. Miller -
This code was cribbed from niu, so gfar_set_hash_opts() begins by
converting the ethtool flow class code into a class code for Sun
Neptune hardware, then does the same thing again for the hardware it's
really dealing with. It may also return -1 (-EPERM) for some
unhandled ethtool flow class codes.Remove the useless code and definitions, and fix the error code.
Signed-off-by: Ben Hutchings
Signed-off-by: David S. Miller -
This is a stab at replacing old ethtool phys_id with set_phys_id
on the Qlogic 10Gb driver. Compile tested only.Not sure if set_led_cfg will flash continuously, or needs
to be replaced by ETHTOOL_ID_ON/ETHTOOL_ID_OFFSigned-off-by: Stephen Hemminger
Signed-off-by: Ron Mercer
Signed-off-by: David S. Miller -
This change is meant to add an ntuple data extensions to the rx network flow
classification specifiers. The idea is to allow ntuple to be displayed via
the network flow classification interface.The first patch had some left over stuff from the original flow extension
flags I had added. That bit is removed in this patch.The second had some left over comments that stated we ignored bits in the
masks when we actually match them.This work is based on input from Ben Hutchings.
Signed-off-by: Alexander Duyck
Reviewed-by: Ben Hutchings
Signed-off-by: David S. Miller -
This change is meant to prevent a possible null pointer dereference if
NETIF_F_NTUPLE is defined but the set_rx_ntuple function pointer is not.The main motivation behind this patch is to eventually replace the ntuple
interfaces entirely with the network flow classifier interfaces. This
allows the device drivers to maintain the ntuple check internally while
using the network flow classifier interface for setting up and displaying
rules.
Signed-off-by: Alexander Duyck
Signed-off-by: David S. Miller -
In the CAIF Payload message the Packet Type indication must be set to
UNCLASSIFIED in order to allow packet prioritization in the modem's
network stack. Otherwise TCP-Ack is not prioritized in the modems
transmit queue.Signed-off-by: Sjur Brændeland
Signed-off-by: David S. Miller -
Signed-off-by: Sjur Brændeland
Signed-off-by: David S. Miller -
Machines are getting deadlock in four node cluster environment.
All nodes are accessing (find /gfs2 -depth -print|cpio -ocv > /dev/null)
200 GB storage on a GFS2 filesystem.
This result in memory fragmentation and driver receives 18 frags for
1448 byte packets.
For non tso packet, fw drops the tx request, if it has >14 frags.Fixing it by pulling extra frags.
Cc: stable@kernel.org
Signed-off-by: Amit Kumar Salecha
Signed-off-by: David S. Miller -
replace relpy with reply.
replace premanent with permanent.Signed-off-by: Weiping Pan(潘卫平)
Signed-off-by: David S. Miller -
replace tranmitted with transmitted.
replace tranmitting with transmitting.Signed-off-by: Weiping Pan(潘卫平)
Signed-off-by: David S. Miller -
Now, alb_bond_info uses rx_ntt,rlb_update_delay_counter and
rlb_update_retry_counter to decide when to call rlb_update_rx_clients().Signed-off-by: Weiping Pan(潘卫平)
Signed-off-by: David S. Miller -
Now bonding-alb uses delayed_work instead of timer_list.
Signed-off-by: Weiping Pan(潘卫平)
Signed-off-by: David S. Miller -
It is unnecessary to set save_load to 1 here,
as the tx_hashtbl is just kzalloced.Signed-off-by: Weiping Pan(潘卫平)
Signed-off-by: Jay Vosburgh
Signed-off-by: David S. Miller -
On some old MAC chips without COE sometime the
Transmit Underflow error is issued.The driver aborted all the transmission process
and initialized it from scratch.
This breaks the network activity as raised by Nachiketa
on a SPEAr board.The patch is to fix this rare underflow event.
The driver will only clear the interrupt and the Tx
DMA will go out the Suspend state as soon as the
descriptor is fetched again.
The driver will continue to bump-up the DMA FIFO threshold
that, indeed, helped somebody to prevent this kind of error
in the past as well.Reported-by: Nachiketa Prachanda
Signed-off-by: Giuseppe Cavallaro
Signed-off-by: David S. Miller -
This patch reviews the open function and fixes some
errors when exit with an error state.
It also moves the request_irq after core is initialized
when interrupts are properly masked.Signed-off-by: Shiraz Hashim
Hacked-by: Giuseppe Cavallaro
Signed-off-by: David S. Miller -
This patch fixes a compilation error when build the
dwmac_lib with the DEBUG option enabled.Signed-off-by: Giuseppe Cavallaro
Signed-off-by: David S. Miller -
Otherwise, IWLWIFI_LEGACY has to be selected independently before the
drivers are made available.Reported-by: Dave Airlie
Signed-off-by: John W. Linville
Cc: Stanislaw Gruszka
Cc: Wey-Yi Guy -
In commit 13583b16592a ("PCI: refactor io size calculation code") Ram
had a thinko in the refactorization of the code: the end result used the
variable 'align' for the bus alignment, but the original code used
'min_align'.Since then, another use of that 'align' variable got introduced by
commit c8adf9a3e873 ("PCI: pre-allocate additional resources to devices
only after successful allocation of essential resources.")Fix both of those uses to use 'min_align' as they should.
Daniel Hellstrom
Acked-by: Ram Pai
Acked-by: Jesse Barnes
Signed-off-by: Linus Torvalds
11 Apr, 2011
15 commits
-
* git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6: (34 commits)
net: Add support for SMSC LAN9530, LAN9730 and LAN89530
mlx4_en: Restoring RX buffer pointer in case of failure
mlx4: Sensing link type at device initialization
ipv4: Fix "Set rt->rt_iif more sanely on output routes."
MAINTAINERS: add entry for Xen network backend
be2net: Fix suspend/resume operation
be2net: Rename some struct members for clarity
pppoe: drop PPPOX_ZOMBIEs in pppoe_flush_dev
dsa/mv88e6131: add support for mv88e6085 switch
ipv6: Enable RFS sk_rxhash tracking for ipv6 sockets (v2)
be2net: Fix a potential crash during shutdown.
bna: Fix for handling firmware heartbeat failure
can: mcp251x: Allow pass IRQ flags through platform data.
smsc911x: fix mac_lock acquision before calling smsc911x_mac_read
iwlwifi: accept EEPROM version 0x423 for iwl6000
rt2x00: fix cancelling uninitialized work
rtlwifi: Fix some warnings/bugs
p54usb: IDs for two new devices
wl12xx: fix potential buffer overflow in testmode nvs push
zd1211rw: reset rx idle timer from tasklet
... -
This patch adds support for SMSC's LAN9530, LAN9730 and LAN89530 USB
ethernet controllers to the existing smsc95xx driver by adding
their new USB VID/PID pairs.Signed-off-by: Steve Glendinning
Signed-off-by: David S. Miller -
Signed-off-by: Michał Mirosław
Signed-off-by: David S. Miller -
Trivial conversion.
This also enables toggling TX VLAN offload and fixes TX checksumming
race with offload changes.Signed-off-by: Michał Mirosław
Signed-off-by: David S. Miller -
This also fixes possible race when changing receive checksum state
and removes IPV6_CSUM_GEN_HACK as it's always set.BTW, The claim about fake IPV6 checksum looks dubious. If that were true,
then there's a problem in networking core and should be fixed there and not
in random drivers.BTW#2, there's no MAINTAINERS entry for this driver. I assume this driver
is supported by Micrel?Signed-off-by: Michał Mirosław
Signed-off-by: David S. Miller -
This also removes TSO as it's made fully in software --- better to leave this
to networking core.If the MAC features can be detected at probe time and not at open, then
stmmac_fix_features could be simplified by limiting hw_features. That's
also better for users as they don't see offloads being togglable but
never turned on.Redundant fallbacks for TX csum are removed as it's already handled
by network core.Signed-off-by: Michał Mirosław
Signed-off-by: David S. Miller -
Signed-off-by: Michał Mirosław
Signed-off-by: David S. Miller -
Simple conversion with a bit of needed cleanup.
This also fixes:
- confusion around vlan_features in rtl8169_vlan_mode(),
- problem with broken TSO for too big MTU (the limit is set
at 0xFFF --- max MSS field value).SG+IP_CSUM+TSO is left disabled by default, based on suggestion by
David Dillow.Signed-off-by: Michał Mirosław
Signed-off-by: David S. Miller -
Fix up after merge with NETIF_F_RXHASH implementation.
This allows to toggle NETIF_F_RXHASH and NETIF_F_HW_VLAN_TX.
Signed-off-by: Michał Mirosław
Signed-off-by: David S. Miller -
Remove offload changing ethtool ops which drivers don't really support:
- fs_enet
- ucc_gethSigned-off-by: Michał Mirosław
Signed-off-by: David S. Miller -
The reverse path filter interferes with IPsec subnet-to-subnet tunnels,
especially when the link to the IPsec peer is on an interface other than
the one hosting the default route.With dynamic routing, where the peer might be reachable through eth0
today and eth1 tomorrow, it's difficult to keep rp_filter enabled unless
fake routes to the remote subnets are configured on the interface
currently used to reach the peer.IPsec provides a much stronger anti-spoofing policy than rp_filter, so
this patch disables the rp_filter for packets with a security path.Signed-off-by: Michael Smith
Signed-off-by: David S. Miller -
This makes sk_buff available for other use in fib_validate_source().
Signed-off-by: Michael Smith
Signed-off-by: David S. Miller -
This patch adds some debug to the reset function to print out the
reason why it fails.Signed-off-by: Simon Wood
Signed-off-by: David S. Miller -
This patch adds support for the PL-25A1 by adding the appropriate
USB ID's. This chip is used in the Belkin 'Windows Easy Transfer'
Cables.Signed-off-by: Simon Wood
Signed-off-by: David S. Miller -
This patch cleans up a couple of instances of incorrect whitespace
Signed-off-by: Simon Wood
Signed-off-by: David S. Miller
