03 May, 2007

3 commits

  • Unless we finally completely remove it, people will always add new users.

    Signed-off-by: Adrian Bunk
    Signed-off-by: Greg Kroah-Hartman

    Adrian Bunk
     
  • This patch removes the PCI_MULTITHREAD_PROBE option that had already
    been marked as broken.

    Signed-off-by: Adrian Bunk
    Signed-off-by: Greg Kroah-Hartman

    Adrian Bunk
     
  • Currently, there is no minimum number of fields required when adding
    a new device ID to a PCI driver through the new_id sysfs file. It is
    possible to add a new ID with only the vendor ID set, causing the
    driver to attempt to attach to all PCI devices from that vendor. This
    has been reported to happen accidentally:
    http://lists.lm-sensors.org/pipermail/lm-sensors/2007-March/019366.html
    It is even possible to not even set the vendor ID field, causing the
    driver to attempt to attach to _all_ the PCI devices.

    This sounds dangerous and I fail to see any valid use of this
    "feature". Thus I suggest that we now require at least the first two
    fields (vendor ID and device ID) to be set. For what it's worth, this
    is what the USB subsystem does.

    Signed-off-by: Jean Delvare
    Signed-off-by: Greg Kroah-Hartman

    Jean Delvare
     

17 Feb, 2007

1 commit

  • Marin Mitov spotted a brainfart where I had
    failed to update copied text with *_remove and __devexit().

    Marin made a good comment in his email to me:
    | mydriver_probe() is _always_ executed, while mydriver_remove() is not.
    | See: include/linux/init.h

    Which says:
    /* Functions marked as __devexit may be discarded at kernel link time, depending
    on config options. Newer versions of binutils detect references from
    retained sections to discarded sections and flag an error. Pointers to
    __devexit functions must use __devexit_p(function_name), the wrapper will
    insert either the function_name or NULL, depending on the config options.
    */

    Signed-off-by: Grant Grundler
    Signed-off-by: Greg Kroah-Hartman

    Grant Grundler
     

23 Jan, 2007

1 commit

  • Rewrite Documentation/pci.txt:
    o restructure document to match how API is used when writing init code.
    o update to reflect changes in struct pci_driver function pointers.
    o removed language on "new style vs old style" device discovery.
    "Old style" is now deprecated. Don't use it. Left description in
    to document existing driver behaviors.
    o add section "Legacy I/O Port free driver" by Kenji Kaneshige
    http://lkml.org/lkml/2006/11/22/25
    (renamed to "pci_enable_device_bars() and Legacy I/O Port space")
    o add "MMIO space and write posting" section to help avoid common pitfall
    when converting drivers from IO Port space to MMIO space.
    Orignally posted http://lkml.org/lkml/2006/2/27/24
    o many typo/grammer/spelling corrections from Randy Dunlap
    o two more spelling corrections from Stephan Richter
    o fix CodingStyle as per Randy Dunlap

    Signed-off-by: Grant Grundler
    Signed-off-by: Greg Kroah-Hartman

    Grant Grundler
     

03 Jul, 2006

1 commit


22 Jun, 2006

1 commit

  • On Thu, Jun 01, 2006 at 02:46:11AM -0700, Rajesh Shah wrote:
    > This patch assumes that pci_request_region() will always be called
    > after pci_enable_device() and pci_release_region() will always
    > be called before pci_disable_device(). We cannot make this
    > assumption,since it's perfectly legal to disable a device
    > first and then release it's regions. So, I think that patch
    > needs to change.

    Patch below clarifies comments in Documentation/pci.txt.

    Signed-off-by: Grant Grundler
    Signed-off-by: Greg Kroah-Hartman

    Grant Grundler
     

28 Apr, 2006

1 commit


11 Sep, 2005

1 commit


17 Aug, 2005

1 commit


04 May, 2005

1 commit


17 Apr, 2005

1 commit

  • Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds