31 Oct, 2008
1 commit
-
Using NIPQUAD() with NIPQUAD_FMT, %d.%d.%d.%d or %u.%u.%u.%u
can be replaced with %pI4Signed-off-by: Harvey Harrison
Signed-off-by: David S. Miller
13 Oct, 2008
3 commits
-
If the driver knows when hardware is removed like with cxgb3i,
bnx2i, qla4xxx and iser then we will want to remove the sessions/devices
that are bound to that device before removing the host.cxgb3i and in the future bnx2i will remove the host and that will
remove all the sessions on the hba. iser can call iscsi_kill_session
when it gets an event that indicates that a hca is removed.
And when qla4xxx is hooked in to the lib (it is only hooked into
the class right now) it can call iscsi remove host like the
partial offload card drivers.Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
This patch converts the iscsi drivers to the new host byte values.
v2
Drop some conversions. Want to avoid conflicts with other patches.
v1
initial patch.Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
When qla4xxx begins recovery and the iscsi class is firing up to handle
it, we need to retrn SCSI_MLQUEUE_TARGET_BUSY from the driver instead
of host busy, because the session recovery only affects the one target.Signed-off-by: Mike Christie
Acked-by: David C Somayajulu
Signed-off-by: James Bottomley
09 Oct, 2008
1 commit
-
Right now SCSI and others do their own command timeout handling.
Move those bits to the block layer.Instead of having a timer per command, we try to be a bit more clever
and simply have one per-queue. This avoids the overhead of having to
tear down and setup a timer for each command, so it will result in a lot
less timer fiddling.Signed-off-by: Mike Anderson
Signed-off-by: Jens Axboe
27 Jul, 2008
1 commit
-
We want to set the queue depth to something reasonable - not
the can_queue.Signed-off-by: Mike Christie
Cc: David Somayajulu
Signed-off-by: James Bottomley
12 Jul, 2008
2 commits
-
This removes the session and conn data_size fields from the iscsi_transport.
Just pass in the value like with host allocation. This patch also makes
it so the LLD iscsi_conn data is allocated with the iscsi_cls_conn.Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
bnx2i allocates a host per netdevice but will use libiscsi,
so this unbinds the session from the host in that code.This will also be useful for the iser parent device dma settings
fixes.Signed-off-by: Mike Christie
Signed-off-by: James Bottomley
08 Apr, 2008
2 commits
-
This patch contains the following:
1. when hba completion status is good, check for iscsi transport
errors (underflow/overflow) prior to checking the scsi status2. New firmware requires that one marker iocb be issued for each task
management command. The patch issues marker iocb immediately
following a LUN or Target reset.Signed-off-by: David C Somayajulu
Signed-off-by: James Bottomley -
This patch adds target reset functionalty.
Signed-off-by: Mike Christie
Acked-by: David Somayajulu
Signed-off-by: James Bottomley
06 Mar, 2008
2 commits
-
We are seeing EXIST errors from sysfs during device addition.
We need a start scan callout so we do not start scanning sessions
found during hba setup, before the async scsi scan code is ready.Signed-off-by: Mike Christie
Acked-by: David C Somayajulu
Signed-off-by: James Bottomley -
The host reset callout could be starting to reset the hba at the same
time the dpc thread is. This creates lots of problems because they both
want to do wierd things with the firmware and interrupts, etc.This patch just has the host reset function fully shutdown the dpc
thread before resetting the hba.This patch also moves the setting of the session online bit to fix
a potential race with the dpc thread and iscsi recovery thread.Signed-off-by: Mike Christie
Acked-by: David C Somayajulu
Signed-off-by: James Bottomley
23 Feb, 2008
1 commit
-
the check in the residual case has an incorrect test of scsi_status
(the logic is reversed, it should be scsi_status != 0 instead of
!scsi_status. Since we checked a few lines above that scsi_status was
non-zero, just eliminate this testSigned-off-by: David C Somayajulu
Signed-off-by: James Bottomley
08 Feb, 2008
4 commits
-
qla4xxx has the old school startup/probe where it finds presetup sessions
in its flash and then attempts to log into them before returning from the
probe. This however, makes it very simple to add a iscsi class scan finished
helper which the driver can use.In future patches Dave or I will rip apart the driver to make it more
like qla2xxx, but for now this is a very simple two line patch which
fixes the problem of trying to figure out when the initial sessions
are done being scanned.Signed-off-by: Mike Christie
Cc: David Somayajulu
Signed-off-by: James Bottomley -
If qla4xxx is resetting up a session and the recovery timer
fires we do not want to just set it to dead, because
the dpc thread could have just set it to online and is in the
middle of resetting it up.Signed-off-by: Mike Christie
Cc: David Somayajulu
Signed-off-by: James Bottomley -
This has qla4xxx use the iscsi class's check ready function
in the queue command function, so all iscsi drivers return the
same error value for common problems.Signed-off-by: Mike Christie
Cc: David Somayajulu
Signed-off-by: James Bottomley -
Qla4xxx can just call the iscsi recovery functions directly.
There is no need for userspace to do this for qla4xxx, because
we do not use the mutex to iterate over devices anymore and iscsi_block
/unblock_session can be called from interrupt context or the dpc thread.
And having userspace do this just creates uneeded headaches for qla4xxx root
situations where the session may experience problems. For example
during the kernel shutdown the scsi layer wants to send sync caches, but at
this time userspace is not up (iscsid is not running), so we cannot
recover from the problem.Signed-off-by: Mike Christie
Cc: David Somayajulu
Signed-off-by: James Bottomley
03 Feb, 2008
1 commit
-
Signed-off-by: Joe Perches
Acked-by: Andrew Vasquez
Acked-by: James Smart
Acked-by: Darrick J. Wong
Acked-by: David Somayajulu
Acked-by: Mark Salyzyn
Signed-off-by: Adrian Bunk
31 Jan, 2008
1 commit
-
With the sg table code, every SCSI driver is now either chain capable
or broken (or has sg_tablesize set so chaining is never activated), so
there's no need to have a check in the host template.Also tidy up the code by moving the scatterlist size defines into the
SCSI includes and permit the last entry of the scatterlist pools not
to be a power of two.
Signed-off-by: James Bottomley
29 Jan, 2008
1 commit
-
print_mac() used many most net drivers and format_addr() used by
net-sysfs.c are very similar and they can be intergrated.format_addr() is also identically redefined in the qla4xxx iscsi
driver.Export a new function sysfs_format_mac() to be used by net-sysfs,
qla4xxx and others in the future. Both print_mac() and
sysfs_format_mac() call _format_mac_addr() to do the formatting.Changed print_mac() to use unsigned char * to be consistent with
net_device struct's dev_addr. Added buffer length overrun checking
as suggested by Joe Perches.Signed-off-by: Michael Chan
Signed-off-by: David S. Miller
24 Jan, 2008
1 commit
-
This replaces sizeof sense_buffer with SCSI_SENSE_BUFFERSIZE in
several LLDs. It's a preparation for the future changes to remove
sense_buffer array in scsi_cmnd structure.Signed-off-by: FUJITA Tomonori
Signed-off-by: James Bottomley
12 Jan, 2008
1 commit
-
We were using the device delete sysfs file to remove each device
then logout. Now in 2.6.21 this will not work because
the sysfs delete file returns immediately and does not wait for
the device removal to complete. This causes a hang if a cache sync
is needed during shutdown. Before .21, that approach had other
problems, so this patch fixes the shutdown code so that we remove the target
and unbind the session before logging out and shut down the sessionSigned-off-by: Mike Christie
Signed-off-by: James Bottomley
20 Oct, 2007
2 commits
-
Fix the various misspellings of "system", controller", "interrupt" and
"[un]necessary".Signed-off-by: Robert P. J. Day
Signed-off-by: Adrian Bunk -
Prior to use struct marker in the linux kernel markers, we need to clean
two drivers which use this structure name.Change bonding driver types :
- struct marker to struct bond_marker.
- marker_t to bond_marker_t.
- marker_header to bond_marker_header.
- marker_header_t to bond_marker_header_t.Change qla4xxx struct marker_entry usage :
- Change struct marker_entry for struct qla4_marker_entry.Signed-off-by: Mathieu Desnoyers
Cc: Chad Tindel
Cc: Jay Vosburgh
Cc: David Somayajulu
Cc: James Bottomley
Cc: Ravi Anand
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
19 Oct, 2007
1 commit
-
Found these while looking at printk uses.
Add missing newlines to dev_ uses
Add missing KERN_ prefixes to multiline dev_s
Fixed a wierd->weird spelling typo
Added a newline to a printkSigned-off-by: Joe Perches
Cc: "Luck, Tony"
Cc: Jens Axboe
Cc: Mark M. Hoffman
Cc: Roland Dreier
Cc: Tilman Schmidt
Cc: David Woodhouse
Cc: Jeff Garzik
Cc: Stephen Hemminger
Cc: Greg KH
Cc: Jeremy Fitzhardinge
Cc: Geert Uytterhoeven
Cc: Alessandro Zummo
Cc: David Brownell
Cc: James Smart
Cc: Andrew Vasquez
Cc: "Antonino A. Daplas"
Cc: Evgeniy Polyakov
Cc: Russell King
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
16 Oct, 2007
1 commit
-
This option is true if a low-level driver can support sg
chaining. This will be removed eventually when all the drivers are
converted to support sg chaining. q->max_phys_segments is set to
SCSI_MAX_SG_SEGMENTS if false.Signed-off-by: FUJITA Tomonori
Signed-off-by: Jens Axboe
20 Jul, 2007
1 commit
-
Slab destructors were no longer supported after Christoph's
c59def9f222d44bb7e2f0a559f2906191a0862d7 change. They've been
BUGs for both slab and slub, and slob never supported them
either.This rips out support for the dtor pointer from kmem_cache_create()
completely and fixes up every single callsite in the kernel (there were
about 224, not including the slab allocator definitions themselves,
or the documentation references).Signed-off-by: Paul Mundt
15 Jul, 2007
1 commit
-
On Wed, 2007-06-06 at 11:55 -0700, David C Somayajulu wrote:
This patch fixes the code handling underrun and overrun conditions.
Also fixed coding style as per Mike Christie's advice.Signed-off-by: David Somayajulu
Signed-off-by: James Bottomley
18 Jun, 2007
1 commit
-
This patch provides the following:
1. remove warning ignoring the return value of pci_set_mwi()
2. allows HBA to be online when the initiator ip address is uninitialized.Signed-off-by: David Somayajulu
Signed-off-by: James Bottomley
03 Jun, 2007
3 commits
-
iSCSI must support software iscsi (iscsi_tcp, iser), hardware iscsi (qla4xxx),
and partial offload (broadcom). To be able to allow each stack or driver
or port (virtual or physical) to be able to log into the same target portal
we use the initiator tuple [[HWADDRESS | NETDEVNAME], INITIATOR_NAME] and
the target tuple [TARGETNAME, CONN_ADDRESS, CONN_PORT] to id a session.
This patch adds the netdev name, which is used by software iscsi when
it binds a session to a netdevice using the SO_BINDTODEVICE sock opt.
It cannot use HWADDRESS because if someone did vlans then the same netdevice
will have the same mac and the initiator,target id will not be unique.Signed-off-by: Mike Christie
Cc: Roland Dreier
Cc: David C Somayajulu
Signed-off-by: James Bottomley -
This patch exports the local address for the session. For
qla4xxx this is the ip of the hba's port. For software
this is the src addr of the socket.Signed-off-by: Mike Christie
Cc: David C Somayajulu
Signed-off-by: James Bottomley -
Userspace will want to know what the driver/FW/HW capabilites
when it comes to some operations like if the hardware can
do discovery or if it can store iscsi info like what target
was used for boot. This patch adds some new caps so userspace
can tell if the driver supports hardware/fw based sendtargets
discovery and if the hardware has some flash which may be
holding or can contain some iscsi target info
.
Signed-off-by: Mike Christie
Cc: David C Somayajulu
Signed-off-by: James Bottomley
02 Jun, 2007
3 commits
-
For iscsi root boot, software iscsi needs to know what the BIOS/OF
initiator used for the initiator name so this puts it in sysfs
for userspace to be able to pick up.For hw iscsi, it is nice to see what the card is using.
This patch adds the new param, and hooks in qla4xxx, iscsi_tcp, and ib_iser.
Signed-off-by: Mike Christie
Cc: Roland Dreier
Cc: David C Somayajulu
Signed-off-by: James Bottomley -
We are going to be adding more host level sysfs attrs and
set_params, so this patch has them take a scsi_host instead
of either a scsi_host or host no.Signed-off-by: Mike Christie
Cc: David C Somayajulu
Signed-off-by: James Bottomley -
Export mac as hw address.
Signed-off-by: Mike Christie
Cc: David C Somayajulu
Signed-off-by: James Bottomley
30 May, 2007
1 commit
-
- remove the unnecessary map_single path.
- convert to use the new accessors for the sg lists and the
parameters.Jens Axboe did the for_each_sg cleanup.
Signed-off-by: FUJITA Tomonori
Acked-by: David C Somayajulu
Signed-off-by: James Bottomley
27 May, 2007
4 commits
-
Free memory resources after invoking free_irq() in
qla4xxx_free_adapter(). QLA4xxx has two pci functions per port
(Ethernet and iSCSI). When one of these PCI functions issues a HBA
reset, all other functions are notified and need to acknowledge and
re-initialize. During module qla4xxx_remove_adapter() gets
invoked. This function needs to wait if it is currently responding to
a reset from another function.Signed-off-by: David Somayajulu
Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
All all inbound mbx registers for all mbx commands. Remove dead code.
Signed-off-by: David Somayajulu
Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
Add support to log all AENs and service mbx cmd completions for QLA4032
Signed-off-by: David Somayajulu
Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
Clean up and update version number
Signed-off-by: David Somayajulu
Signed-off-by: Mike Christie
Signed-off-by: James Bottomley