12 Oct, 2011
15 commits
-
Add documentation about NOACK tx flag usage.
Signed-off-by: Helmut Schaa
Signed-off-by: John W. Linville -
When tx is suspended temporarily and the queue is flushed, do not increase
the retry count or attempt to send out BAR frames. Instead simply retry
the affected subframes normally after the reset.Signed-off-by: Felix Fietkau
Signed-off-by: John W. Linville -
Do not increment the retry counter if packets to a sleeping station
were not sent because of tx failure, instead of only checking the filter
flag.
Clear the PS filter only after an A-MPDU was reported as filtered,
otherwise the hardware might do some unnecessary extra retransmissions.Signed-off-by: Felix Fietkau
Signed-off-by: John W. Linville -
Export how many times each of the reset triggers has fired through debugfs.
Signed-off-by: Felix Fietkau
Signed-off-by: John W. Linville -
Signed-off-by: Felix Fietkau
Signed-off-by: John W. Linville -
Mesh paths should only exist over established peer links.
Signed-off-by: Javier Cardona
Signed-off-by: John W. Linville -
drivers/net/wireless/mwifiex/main.c +828 mwifiex_remove_card(52)
error: potential null derefence 'priv'.
drivers/net/wireless/mwifiex/main.c +828 mwifiex_remove_card(52)
error: we previously assumed 'priv' could be null (see line 820)
drivers/net/wireless/mwifiex/txrx.c +90 mwifiex_process_tx(24)
error: potential null derefence 'local_tx_pd'.
drivers/net/wireless/mwifiex/sta_ioctl.c +766
mwifiex_rate_ioctl_set_rate_value(30)
error: buffer overflow 'rate' 14
Signed-off-by: Yogesh Ashok Powar
Signed-off-by: Bing Zhao
Signed-off-by: John W. Linville -
If "axq_qnum >= ARRAY_SIZE(sc->tx.txq)", then the call to
ath9k_hw_releasetxqueue() would read beyond the end of the ah->txq[]
array and possibly corrupt memory. Fortunately,
ath9k_hw_setuptxqueue() doesn't return high values of "axq_qnum" and
this code can be removed.Signed-off-by: Dan Carpenter
Signed-off-by: John W. Linville -
th5k_hw_setup_tx_queue() returns a valid offset into the ah->ah_txq[]
array. The ah->ah_txq[] and the ah->txqs[] array are the same size.
Both have AR5K_NUM_TX_QUEUES elements. So this error handling code
will never trigger.Also it's wrong. The call to ath5k_hw_release_tx_queue() with a qnum
of AR5K_NUM_TX_QUEUES or more will just trigger a WARN_ON() and
return. Or if it missed the WARN_ON(), it would just corrupt some
memory and return.Signed-off-by: Dan Carpenter
Reviewed-by: Bob Copeland
Signed-off-by: John W. Linville -
When I introduced in-kernel off-channel TX I
introduced a bug -- the work can't be canceled
again because the code clear the skb pointer.
Fix this by keeping track separately of whether
TX status has already been reported.Cc: stable@kernel.org [2.6.38+]
Reported-by: Jouni Malinen
Tested-by: Jouni Malinen
Signed-off-by: Johannes Berg
Signed-off-by: John W. Linville -
My previous patch for init calib cfg disable a set of calibration for both
init and runtime which cause performance issue, Fix itSigned-off-by: Wey-Yi Guy
Signed-off-by: John W. Linville -
This is needed so that offloaded scan can do the
right thing. Without this patch, the no_cck flag
contains random values from the kernel heap.Signed-off-by: Johannes Berg
Signed-off-by: John W. Linville -
Add the brcm80211 tree to drivers/net/wireless, and disable the version that's
in drivers/staging. This version includes the sources currently in staging,
plus any changes that have been sent out for review.Sources in staging will be deleted in a followup patch.
Signed-off-by: Arend van Spriel
Signed-off-by: John W. Linville -
CC [M] drivers/net/wireless/ath/ath6kl/cfg80211.o
drivers/net/wireless/ath/ath6kl/cfg80211.c:1838:2: warning: initialization from incompatible pointer typeCaused by commit e9f935e3e8dc0bddd0df6d148165d95925422502...
Signed-off-by: John W. Linville
07 Oct, 2011
4 commits
-
The current wl12xx fw (7.3.0.0.77) supports both STA and AP mode, and
we no longer use AP-mode-specific quirks.WL12XX_QUIRK_END_OF_TRANSACTION is still used for certain HWs, while
WL12XX_QUIRK_LPD_MODE is not used anymore.Signed-off-by: Eliad Peller
Signed-off-by: Luciano Coelho -
The wl12xx FW supports HW channel switch. If we don't use it,
sometimes the firmware gets confused when recalibrating to the new
channel, causing RX problems. This commit adds HW channel switch
support by implementing the channell_switch op.Signed-off-by: Shahar Levi
[added one comment, remove the tx_flush and rephrased the commit message]
Signed-off-by: Luciano Coelho -
The wiphy max_sched_scan_ie_len attribute was not set correctly and
remained as 0, so when IEs were being passed in a scheduled scan, we
were returning -EINVAL.Fix this by setting the attribute properly.
Signed-off-by: Luciano Coelho
-
p2p packets should go out only with OFDM rates.
Configure a new rate policy that will (later) be used
during p2p_find (when the p2p_cli / p2p_go interfaces
are in use, we won't have to use this policy, as
the configured rates should already be OFDM-only).Additionally, update CONF_TX_MAX_RATE_CLASSES to reflect
the current value from the fw api.Signed-off-by: Eliad Peller
Signed-off-by: Luciano Coelho
05 Oct, 2011
1 commit
04 Oct, 2011
13 commits
-
the AR_SREV register does not seems to indicate whether AR9480 is
pci_express capable or not though the other information like macVersion
etc can be obtained properly. this fix is essential as ASPM won't be intialized
and its related driver functionality ath9k_hw_configpcipowersave won't be
calledSigned-off-by: Mohammed Shafi Shajakhan
Signed-off-by: John W. Linville -
this patch fixes the assumption of maximum number of GPIO pins present
in AR9287/AR9300. this fix is essential as we might encounter some
functionality issues involved in accessing the status of GPIO pins which
are all incorrectly assumed to be not within the range of max_num_gpio
of AR9300/AR9287 chipsetsCc: stable@kernel.org
Signed-off-by: Mohammed Shafi Shajakhan
Signed-off-by: John W. Linville -
Recent patches added support for resetting the SD8686 hardware when
commands time out, which seems to happen quite frequently soon after
resuming the system from a Wake-on-WLAN-triggered resume.At http://dev.laptop.org/ticket/10969 we see the same thing happen
with transmits. In this case, the hardware will fail to respond to
a frame passed for transmission, and libertas (correctly) will block
all further commands and transmissions as the hardware can only
deal with one thing at a time. This results in a lockup while the
system waits indefinitely for the dead card to respond.Hook up a TX lockup timer to detect this and reset the hardware.
Signed-off-by: Daniel Drake
Signed-off-by: John W. Linville -
tx params should be configured per interface.
add ieee80211_vif param to the conf_tx callback,
and change all the drivers that use this callback.The following spatch was used:
@rule1@
struct ieee80211_ops ops;
identifier conf_tx_op;
@@
ops.conf_tx = conf_tx_op;@rule2@
identifier rule1.conf_tx_op;
identifier hw, queue, params;
@@
conf_tx_op (
- struct ieee80211_hw *hw,
+ struct ieee80211_hw *hw, struct ieee80211_vif *vif,
u16 queue,
const struct ieee80211_tx_queue_params *params) {...}Signed-off-by: Eliad Peller
Signed-off-by: John W. Linville -
Rename the iwlagn module as iwlwifi in preparation for future
changes. Add an alias to iwlagn for backward compatibility.Signed-off-by: Don Fry
Signed-off-by: Wey-Yi Guy
Signed-off-by: John W. Linville -
this extends the bits for rf kill GPIO selection to [7:2] from [4:2] as
we use GPIO pin 11 as rfkill for AR9480 and also remove few unused
macrosCc: Wilson Tsao
Cc: "Hu, Russell"
Cc: Rajkumar Manoharan
Signed-off-by: Mohammed Shafi Shajakhan
Signed-off-by: John W. Linville -
In failure case locks are not allocated in mwifiex_register().
So mwifiex_free_lock_list() routine call becomes redundant.
Also we don't need to check return type for mwifiex_init_lock_list()
routine. It never fails.Signed-off-by: Amitkumar Karwar
Signed-off-by: Bing Zhao
Signed-off-by: John W. Linville -
The commit "mwifiex: remove list traversal.."(fcf2176c87..)
wrongly modifies AMSDU aggregation check. Due to this even though
packet size for iperf traffic is already large, we unnecessarily
try to aggregate them which adds some delay. If Tx iperf is started
on UUT for 30 seconds, UUT keeps sending Tx packets for few more
seconds.That commit is reverted to fix the problem.
Also, MIN_NUM_AMSDU check is moved inside the loop to optimize the
loop.Signed-off-by: Amitkumar Karwar
Signed-off-by: Yogesh Ashok Powar
Signed-off-by: Bing Zhao
Signed-off-by: John W. Linville -
This was reported and tested by Martin Walter over at AVM GmbH Berlin.
This also applies to 3.0.1 so sendint to stable.Cc: s.kirste@avm.de
Cc: d.friedel@avm.de
Cc: Martin Walter
Cc: Peter Grabienski
Cc: stable@kernel.org
Tested-by: Martin Walter
Signed-off-by: Luis R. Rodriguez
Signed-off-by: John W. Linville -
Recently mac80211 was changed to use nullfunc instead of probe
request for connection monitoring for tx ack status reporting
hardwares. Sometimes in congested network, STA got disconnected
quickly after the association. It was observered that the rate
control was not adopted to environment due to minimal transmission.As the nullfunc are used for monitoring purpose, these frames should
not be sacrificed for rate control updation. So it is better to send
the monitoring null func frames at minimum rate that could help to
retain the connection.Signed-off-by: Rajkumar Manoharan
Signed-off-by: John W. Linville -
Add a gpio setup function which gives a chance to set up
platform specific configuration such as pin multiplexing,
input/output direction at the runtime or booting time.Signed-off-by: Sangwook Lee
Signed-off-by: John W. Linville -
Allow injected unicast frames to be sent without having to wait
for an ACK.Signed-off-by: Helmut Schaa
Signed-off-by: John W. Linville
03 Oct, 2011
1 commit
-
Fixes compilation errors when compiling for ARM:
ath6kl/debug.c:312: error: implicit declaration of function 'vmalloc'
ath6kl/debug.c:312: warning: assignment makes pointer from integer without a cast
ath6kl/debug.c:342: error: implicit declaration of function 'vfree'
ath6kl/debug.c:696: warning: assignment makes pointer from integer without a cast
ath6kl/debug.c:871: warning: assignment makes pointer from integer without a castSigned-off-by: Kalle Valo
01 Oct, 2011
6 commits
-
My earlier debug log additions added these warnings when compiling 64 bit
kernels:ath6kl/init.c:962: warning: format '%d' expects type 'int',
but argument 3 has type 'size_t'
ath6kl/init.c:975: warning: format '%d' expects type 'int',
but argument 3 has type 'size_t'
ath6kl/init.c:988: warning: format '%d' expects type 'int',
but argument 3 has type 'size_t'
ath6kl/init.c:1009: warning: format '%d' expects type 'int',
but argument 3 has type 'size_t'
ath6kl/init.c:1192: warning: format '%d' expects type 'int',
but argument 4 has type 'size_t'
ath6kl/init.c:1236: warning: format '%d' expects type 'int',
but argument 4 has type 'size_t'
ath6kl/init.c:1267: warning: format '%d' expects type 'int',
but argument 4 has type 'size_t'Reported-by: Vasanthakumar Thiagarajan
Signed-off-by: Kalle Valo -
802.11 says:
"Sequence numbers for QoS (+)Null frames may be
set to any value."However, if we use the normal counters then peers
will get confused with aggregation since there'll
be holes in the sequence number sequence.To avoid that, neither assign a sequence number
to QoS null frames nor put them on aggregation.Signed-off-by: Johannes Berg
Signed-off-by: John W. Linville -
With the addition of uAPSD and driver buffering
the powersave handling has gotten quite complex.
Add a section to the documentation to explain it
for anyone wanting to implement it.Signed-off-by: Johannes Berg
Signed-off-by: John W. Linville -
iwlwifi has a separate EOSP notification from
the device, and to make use of that properly
it needs to be passed to mac80211. To be able
to mix with tx_status_irqsafe and rx_irqsafe
it also needs to be an "_irqsafe" version in
the sense that it goes through the tasklet,
the actual flag clearing would be IRQ-safe
but doing it directly would cause reordering
issues.This is needed in the case of a P2P GO going
into an absence period without transmitting
any frames that should be driver-released as
in this case there's no other way to inform
mac80211 that the service period ended. Note
that for drivers that don't use the _irqsafe
functions another version of this function
will be required.Signed-off-by: Johannes Berg
Signed-off-by: John W. Linville -
iwlwifi needs to know the number of frames that are
going to be sent to a station while it is asleep so
it can properly handle the uCode blocking of that
station.Before uAPSD, we got by by telling the device that
a single frame was going to be released whenever we
encountered IEEE80211_TX_CTL_POLL_RESPONSE. With
uAPSD, however, that is no longer possible since
there could be more than a single frame.To support this model, add a new callback to notify
drivers when frames are going to be released.Signed-off-by: Johannes Berg
Signed-off-by: John W. Linville -
My work and some previous work didn't add
all the flags, add them now and while at it
simplify the code.Signed-off-by: Johannes Berg
Signed-off-by: John W. Linville