09 Mar, 2021

1 commit


11 Sep, 2020

1 commit

  • This reverts commit 14775b04964264189caa4a0862eac05dab8c0502 as there
    were still some parsing problems with it, and the follow-on patch for
    it.

    Let's revisit it later, just drop it for now.

    Cc:
    Cc: Jim Cromie
    Reported-by: Naresh Kamboju
    Cc: Stephen Rothwell
    Fixes: 14775b049642 ("dyndbg: accept query terms like file=bar and module=foo")
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

24 Jul, 2020

4 commits

  • Current code expects "keyword" "arg" as 2 words, space separated.
    Change to also accept "keyword=arg" form as well, and drop !(nwords%2)
    requirement. Then in rest of function, use new keyword, arg variables
    instead of word[i], word[i+1]

    Acked-by:
    Signed-off-by: Jim Cromie
    Link: https://lore.kernel.org/r/20200719231058.1586423-15-jim.cromie@gmail.com
    Signed-off-by: Greg Kroah-Hartman

    Jim Cromie
     
  • Accept these additional query forms:

    echo "file $filestr +_" > control

    path/to/file.c:100 # as from control, column 1
    path/to/file.c:1-100 # or any legal line-range
    path/to/file.c:func_A # as from an editor/browser
    path/to/file.c:drm_* # wildcards still work
    path/to/file.c:*_foo # lead wildcard too

    1st 2 examples are treated as line-ranges, 3-5 are treated as func's

    Doc these changes, and sprinkle in a few extra wild-card examples and
    trailing # explanation texts.

    Acked-by:
    Signed-off-by: Jim Cromie
    Link: https://lore.kernel.org/r/20200719231058.1586423-14-jim.cromie@gmail.com
    Signed-off-by: Greg Kroah-Hartman

    Jim Cromie
     
  • since cf964976484 in 2012, initialization is done with early_initcall,
    update the Docs, which still say arch_initcall.

    Acked-by:
    Signed-off-by: Jim Cromie
    Link: https://lore.kernel.org/r/20200719231058.1586423-3-jim.cromie@gmail.com
    Signed-off-by: Greg Kroah-Hartman

    Jim Cromie
     
  • Regarding:
    commit 2b6783191da7 ("dynamic_debug: add trim_prefix() to provide source-root relative paths")
    commit a73619a845d5 ("kbuild: use -fmacro-prefix-map to make __FILE__ a relative path")

    2nd commit broke dynamic-debug's "file $fullpath" query form, but
    nobody noticed because 1st commit had trimmed prefixes from
    control-file output, so the click-copy-pasting of fullpaths into new
    queries had ceased; that query form became unused.

    Removing the function is cleanest, but it could be useful in
    old-compiler corner cases, where __FILE__ still has /full/path,
    and it safely does nothing otherwize.

    So instead, quietly deprecate "file /full/path" query form, by
    removing all /full/paths examples in the docs. I skipped adding a
    back-compat note.

    Acked-by:
    Signed-off-by: Jim Cromie
    Link: https://lore.kernel.org/r/20200719231058.1586423-2-jim.cromie@gmail.com
    Signed-off-by: Greg Kroah-Hartman

    Jim Cromie
     

09 Jun, 2020

1 commit

  • Instead of enabling dynamic debug globally with CONFIG_DYNAMIC_DEBUG,
    CONFIG_DYNAMIC_DEBUG_CORE will only enable core function of dynamic
    debug. With the DYNAMIC_DEBUG_MODULE defined for any modules, dynamic
    debug will be tied to them.

    This is useful for people who only want to enable dynamic debug for
    kernel modules without worrying about kernel image size and memory
    consumption is increasing too much.

    [orson.zhai@unisoc.com: v2]
    Link: http://lkml.kernel.org/r/1587408228-10861-1-git-send-email-orson.unisoc@gmail.com

    Signed-off-by: Orson Zhai
    Signed-off-by: Andrew Morton
    Acked-by: Greg Kroah-Hartman
    Acked-by: Petr Mladek
    Cc: Jonathan Corbet
    Cc: Sergey Senozhatsky
    Cc: Steven Rostedt
    Cc: Jason Baron
    Cc: Randy Dunlap
    Link: http://lkml.kernel.org/r/1586521984-5890-1-git-send-email-orson.unisoc@gmail.com
    Signed-off-by: Linus Torvalds

    Orson Zhai
     

13 Feb, 2020

1 commit

  • With the realization that having debugfs enabled on "production" systems
    is generally not a good idea, debugfs is being disabled from more and
    more platforms over time. However, the functionality of dynamic
    debugging still is needed at times, and since it relies on debugfs for
    its user api, having debugfs disabled also forces dynamic debug to be
    disabled.

    To get around this, also create the "control" file for dynamic_debug in
    procfs. This allows people turn on debugging as needed at runtime for
    individual driverfs and subsystems.

    Reported-by: many different companies
    Cc: Jason Baron
    Acked-by: Will Deacon
    Link: https://lore.kernel.org/r/20200210211142.GB1373304@kroah.com
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

08 Nov, 2018

2 commits


18 Nov, 2017

1 commit

  • Fix minor typo.

    Fix missing words in explaining parsing of last line number.

    Link: http://lkml.kernel.org/r/ebb7ff42-4945-103f-d5b4-f07a6f3343a7@infradead.org
    Signed-off-by: Randy Dunlap
    Cc: Jason Baron
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Randy Dunlap
     

27 Jan, 2017

1 commit

  • Two of the example command lines use an argument to echo of "-c" which
    isn't valid in (most versions of) echo causing these examples to fail.
    Correct the argument to "-n" which works correctly.

    Signed-off-by: Steven Price
    Signed-off-by: Jonathan Corbet

    Steven Price
     

24 Oct, 2016

1 commit