Eric Lee / smarc-fsl-linux-kernel

18 Nov, 2010

1 commit

03 Sep, 2010

1 commit

  • bc8acf2c8   drivers/net: avoid some skb->ip_summed initializations ... Browse Code »
    48

    fresh skbs have ip_summed set to CHECKSUM_NONE (0)

    We can avoid setting again skb->ip_summed to CHECKSUM_NONE in drivers.

    Introduce skb_checksum_none_assert() helper so that we keep this
    assertion documented in driver sources.

    Change most occurrences of :

    skb->ip_summed = CHECKSUM_NONE;

    by :

    skb_checksum_none_assert(skb);

    Signed-off-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Eric Dumazet
     

27 Jul, 2010

2 commits

  • d7f61777e   drivers/net/qla3xxx.c: Checkpatch cleanups ... Browse Code »

    Remove typedefs
    Indentation and spacing
    Use a temporary for a very long pointer variable
    More 80 column compatible
    Convert a switch to if/else if

    Compile tested only, depends on patch "Update logging message style"

    (old)
    $ scripts/checkpatch.pl -f drivers/net/qla3xxx.c | grep "^total:"
    total: 209 errors, 82 warnings, 3995 lines checked

    (new)
    $ scripts/checkpatch.pl -f drivers/net/qla3xxx.c | grep "^total:"
    total: 2 errors, 0 warnings, 3970 lines checked

    $ size drivers/net/qla3xxx.o.*
    text data bss dec hex filename
    50413 212 13864 64489 fbe9 drivers/net/qla3xxx.o.old
    49959 212 13728 63899 f99b drivers/net/qla3xxx.o.new

    Signed-off-by: Joe Perches
    Signed-off-by: David S. Miller

    Joe Perches
     
  • eddc5fbd8   drivers/net/qla3xxx.c: Update logging message style ... Browse Code »

    Use pr_
    Use netdev_
    Use netif_
    Remove #define PFX
    Improve a couple of loops to avoid deep indentation.

    Compile tested only

    $ size drivers/net/qla3xxx.o.*
    text data bss dec hex filename
    51603 212 13864 65679 1008f drivers/net/qla3xxx.o.old
    50413 212 13864 64489 fbe9 drivers/net/qla3xxx.o.new

    Signed-off-by: Joe Perches
    Signed-off-by: David S. Miller

    Joe Perches
     

14 May, 2010

1 commit

  • a4b770972   drivers/net: Remove unnecessary returns from void function()s ... Browse Code »

    This patch removes from drivers/net/ all the unnecessary
    return; statements that precede the last closing brace of
    void functions.

    It does not remove the returns that are immediately
    preceded by a label as gcc doesn't like that.

    It also does not remove null void functions with return.

    Done via:
    $ grep -rP --include=*.[ch] -l "return;\n}" net/ | \
    xargs perl -i -e 'local $/ ; while (<>) { s/\n[ \t\n]+return;\n}/\n}/g; print; }'

    with some cleanups by hand.

    Compile tested x86 allmodconfig only.

    Signed-off-by: Joe Perches
    Signed-off-by: David S. Miller

    Joe Perches
     

13 Apr, 2010

1 commit

25 Mar, 2010

1 commit

18 Jan, 2010

1 commit

  • 2ae3111ea   drivers/net: Eliminate useless code ... Browse Code »

    The variable qdev is initialized twice to the same (side effect-free)
    expression. Drop one initialization.

    A simplified version of the semantic match that finds this problem is:
    (http://coccinelle.lip6.fr/)

    //
    @forall@
    idexpression *x;
    identifier f!=ERR_PTR;
    @@

    x = f(...)
    ... when != x
    (
    x = f(...,,...)
    |
    * x = f(...)
    )
    //

    Signed-off-by: Julia Lawall
    Signed-off-by: David S. Miller

    Julia Lawall
     

08 Jan, 2010

1 commit

10 Dec, 2009

1 commit

  • 4ef58d4e2   Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial ... Browse Code »

    * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (42 commits)
    tree-wide: fix misspelling of "definition" in comments
    reiserfs: fix misspelling of "journaled"
    doc: Fix a typo in slub.txt.
    inotify: remove superfluous return code check
    hdlc: spelling fix in find_pvc() comment
    doc: fix regulator docs cut-and-pasteism
    mtd: Fix comment in Kconfig
    doc: Fix IRQ chip docs
    tree-wide: fix assorted typos all over the place
    drivers/ata/libata-sff.c: comment spelling fixes
    fix typos/grammos in Documentation/edac.txt
    sysctl: add missing comments
    fs/debugfs/inode.c: fix comment typos
    sgivwfb: Make use of ARRAY_SIZE.
    sky2: fix sky2_link_down copy/paste comment error
    tree-wide: fix typos "couter" -> "counter"
    tree-wide: fix typos "offest" -> "offset"
    fix kerneldoc for set_irq_msi()
    spidev: fix double "of of" in comment
    comment typo fix: sybsystem -> subsystem
    ...

    Linus Torvalds
     

04 Dec, 2009

1 commit

  • 8e95a2026   drivers/net: Move && and || to end of previous line ... Browse Code »

    Only files where David Miller is the primary git-signer.
    wireless, wimax, ixgbe, etc are not modified.

    Compile tested x86 allyesconfig only
    Not all files compiled (not x86 compatible)

    Added a few > 80 column lines, which I ignored.
    Existing checkpatch complaints ignored.

    Signed-off-by: Joe Perches
    Signed-off-by: David S. Miller

    Joe Perches
     

09 Nov, 2009

1 commit

01 Sep, 2009

1 commit

24 Jun, 2009

2 commits

20 Jun, 2009

1 commit

29 May, 2009

1 commit

  • cdd0db058   net: dont update dev->trans_start ... Browse Code »

    Second round of drivers for Gb cards (and NIU one I forgot in the 10GB round)

    Now that core network takes care of trans_start updates, dont do it
    in drivers themselves, if possible. Drivers can avoid one cache miss
    (on dev->trans_start) in their start_xmit() handler.

    Exceptions are NETIF_F_LLTX drivers

    Signed-off-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Eric Dumazet
     

07 Apr, 2009

2 commits

22 Jan, 2009

1 commit

  • 288379f05   net: Remove redundant NAPI functions ... Browse Code »

    Following the removal of the unused struct net_device * parameter from
    the NAPI functions named *netif_rx_* in commit 908a7a1, they are
    exactly equivalent to the corresponding *napi_* functions and are
    therefore redundant.

    Signed-off-by: Ben Hutchings
    Acked-by: Neil Horman
    Signed-off-by: David S. Miller

    Ben Hutchings
     

27 Dec, 2008

1 commit

23 Dec, 2008

1 commit

  • 908a7a16b   net: Remove unused netdev arg from some NAPI interfaces. ... Browse Code »

    When the napi api was changed to separate its 1:1 binding to the net_device
    struct, the netif_rx_[prep|schedule|complete] api failed to remove the now
    vestigual net_device structure parameter. This patch cleans up that api by
    properly removing it..

    Signed-off-by: Neil Horman
    Signed-off-by: David S. Miller

    Neil Horman
     

26 Nov, 2008

1 commit

  • be5a3c62c   qla3xxx: fix warning in drivers/net/qla3xxx.c ... Browse Code »

    this warning:

    drivers/net/qla3xxx.c: In function ‘ql3xxx_probe’:
    drivers/net/qla3xxx.c:3912: warning: ‘pci_using_dac’ may be used uninitialized in this function

    triggers because GCC does not recognize the (correct) error flow
    between 'pci_using_dac' and 'err'.

    Annotate it.

    Signed-off-by: Ingo Molnar
    Signed-off-by: David S. Miller

    Ingo Molnar
     

22 Nov, 2008

1 commit

19 Nov, 2008

1 commit

16 Nov, 2008

1 commit

04 Nov, 2008

1 commit

31 Oct, 2008

1 commit

  • 275f165fa   pci: use pci_ioremap_bar() in drivers/net ... Browse Code »

    Use the newly introduced pci_ioremap_bar() function in drivers/net.
    pci_ioremap_bar() just takes a pci device and a bar number, with the goal
    of making it really hard to get wrong, while also having a central place
    to stick sanity checks.

    Signed-off-by: Arjan van de Ven
    Signed-off-by: Jeff Garzik

    Arjan van de Ven
     

28 Oct, 2008

1 commit

  • e174961ca   net: convert print_mac to %pM ... Browse Code »

    This converts pretty much everything to print_mac. There were
    a few things that had conflicts which I have just dropped for
    now, no harm done.

    I've built an allyesconfig with this and looked at the files
    that weren't built very carefully, but it's a huge patch.

    Signed-off-by: Johannes Berg
    Signed-off-by: David S. Miller

    Johannes Berg
     

07 Aug, 2008

4 commits

27 Jul, 2008

1 commit

  • 8d8bb39b9   dma-mapping: add the device argument to dma_mapping_error() ... Browse Code »

    Add per-device dma_mapping_ops support for CONFIG_X86_64 as POWER
    architecture does:

    This enables us to cleanly fix the Calgary IOMMU issue that some devices
    are not behind the IOMMU (http://lkml.org/lkml/2008/5/8/423).

    I think that per-device dma_mapping_ops support would be also helpful for
    KVM people to support PCI passthrough but Andi thinks that this makes it
    difficult to support the PCI passthrough (see the above thread). So I
    CC'ed this to KVM camp. Comments are appreciated.

    A pointer to dma_mapping_ops to struct dev_archdata is added. If the
    pointer is non NULL, DMA operations in asm/dma-mapping.h use it. If it's
    NULL, the system-wide dma_ops pointer is used as before.

    If it's useful for KVM people, I plan to implement a mechanism to register
    a hook called when a new pci (or dma capable) device is created (it works
    with hot plugging). It enables IOMMUs to set up an appropriate
    dma_mapping_ops per device.

    The major obstacle is that dma_mapping_error doesn't take a pointer to the
    device unlike other DMA operations. So x86 can't have dma_mapping_ops per
    device. Note all the POWER IOMMUs use the same dma_mapping_error function
    so this is not a problem for POWER but x86 IOMMUs use different
    dma_mapping_error functions.

    The first patch adds the device argument to dma_mapping_error. The patch
    is trivial but large since it touches lots of drivers and dma-mapping.h in
    all the architecture.

    This patch:

    dma_mapping_error() doesn't take a pointer to the device unlike other DMA
    operations. So we can't have dma_mapping_ops per device.

    Note that POWER already has dma_mapping_ops per device but all the POWER
    IOMMUs use the same dma_mapping_error function. x86 IOMMUs use device
    argument.

    [akpm@linux-foundation.org: fix sge]
    [akpm@linux-foundation.org: fix svc_rdma]
    [akpm@linux-foundation.org: build fix]
    [akpm@linux-foundation.org: fix bnx2x]
    [akpm@linux-foundation.org: fix s2io]
    [akpm@linux-foundation.org: fix pasemi_mac]
    [akpm@linux-foundation.org: fix sdhci]
    [akpm@linux-foundation.org: build fix]
    [akpm@linux-foundation.org: fix sparc]
    [akpm@linux-foundation.org: fix ibmvscsi]
    Signed-off-by: FUJITA Tomonori
    Cc: Muli Ben-Yehuda
    Cc: Andi Kleen
    Cc: Thomas Gleixner
    Cc: Ingo Molnar
    Cc: Avi Kivity
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    FUJITA Tomonori
     

28 Jun, 2008

1 commit

27 Jun, 2008

1 commit

13 May, 2008

1 commit

26 Mar, 2008

1 commit

29 Jan, 2008

2 commits