23 Sep, 2019

1 commit

• be21683e4   block: t10-pi: fix -Wswitch warning ... Browse Code »

  Changing the switch() statement to symbolic constants made the compiler
  (at least clang-9, did not check gcc) notice that there is one enum value
  that is not handled here:

  block/t10-pi.c:62:11: error: enumeration value 'T10_PI_TYPE0_PROTECTION'
  not handled in switch [-Werror,-Wswitch]

  Add a BUG_ON statement if we ever get to t10_pi_verify function with
  TYPE0 and replace the switch() statement with if/else clause for the
  valid types.

  Fixes: 9b2061b1a262 ("block: use symbolic constants for t10_pi type")
  Cc: Arnd Bergmann
  Signed-off-by: Max Gurtovoy
  Signed-off-by: Jens Axboe

  Max Gurtovoy

  2019-09-23 22:05:19 +0800  

18 Sep, 2019

2 commits

• 54d4e6ab9   block: centralize PI remapping logic to the block layer ... Browse Code »

  Currently t10_pi_prepare/t10_pi_complete functions are called during the
  NVMe and SCSi layers command preparetion/completion, but their actual
  place should be the block layer since T10-PI is a general data integrity
  feature that is used by block storage protocols. Introduce .prepare_fn
  and .complete_fn callbacks within the integrity profile that each type
  can implement according to its needs.

  Suggested-by: Christoph Hellwig
  Reviewed-by: Christoph Hellwig
  Suggested-by: Martin K. Petersen
  Reviewed-by: Martin K. Petersen
  Signed-off-by: Max Gurtovoy

  Fixed to not call queue integrity functions if BLK_DEV_INTEGRITY
  isn't defined in the config.

  Signed-off-by: Jens Axboe

  Max Gurtovoy

  2019-09-18 10:03:49 +0800  
• 5eaed68dd   block: use symbolic constants for t10_pi type ... Browse Code »

  Replace all hard-coded values with T10_PI_TYPES to make the code more
  readable.

  Reviewed-by: Christoph Hellwig
  Reviewed-by: Martin K. Petersen
  Signed-off-by: Max Gurtovoy
  Signed-off-by: Jens Axboe

  Max Gurtovoy

  2019-09-18 10:03:49 +0800  

01 May, 2019

1 commit

• 8c16567d8   block: switch all files cleared marked as GPLv2 to SPDX tags ... Browse Code »

  All these files have some form of the usual GPLv2 boilerplate. Switch
  them to use SPDX tags instead.

  Reviewed-by: Chaitanya Kulkarni
  Signed-off-by: Christoph Hellwig
  Signed-off-by: Jens Axboe

  Christoph Hellwig

  2019-05-01 06:11:57 +0800  

30 Jul, 2018

1 commit

• 10c41ddd6   block: move dif_prepare/dif_complete functions to block layer ... Browse Code »

  Currently these functions are implemented in the scsi layer, but their
  actual place should be the block layer since T10-PI is a general data
  integrity feature that is used in the nvme protocol as well. Also, use
  the tuple size from the integrity profile since it may vary between
  integrity types.

  Suggested-by: Christoph Hellwig
  Reviewed-by: Martin K. Petersen
  Signed-off-by: Max Gurtovoy
  Signed-off-by: Jens Axboe

  Max Gurtovoy

  2018-07-30 22:27:02 +0800  

04 Jul, 2017

1 commit

• 128b6f9fd   t10-pi: Move opencoded contants to common header ... Browse Code »

  Signed-off-by: Dmitry Monakhov
  Reviewed-by: Martin K. Petersen
  Signed-off-by: Christoph Hellwig
  Signed-off-by: Jens Axboe

  Dmitry Monakhov

  2017-07-04 06:56:25 +0800  

16 Jun, 2017

1 commit

• a462b9508   block: Dedicated error code fixups ... Browse Code »

  This patch fixes two sparse warnings introduced by the "dedicated
  error codes for the block layer V3" patch series. These changes
  have not been tested.

  Signed-off-by: Bart Van Assche
  Reviewed-by: Christoph Hellwig
  Signed-off-by: Jens Axboe

  Bart Van Assche

  2017-06-16 23:47:15 +0800  

09 Jun, 2017

1 commit

• 4e4cbee93   block: switch bios to blk_status_t ... Browse Code »

  Replace bi_error with a new bi_status to allow for a clear conversion.
  Note that device mapper overloaded bi_error with a private value, which
  we'll have to keep arround at least for now and thus propagate to a
  proper blk_status_t value.

  Signed-off-by: Christoph Hellwig
  Signed-off-by: Jens Axboe

  Christoph Hellwig

  2017-06-09 23:27:32 +0800  

25 Mar, 2017

1 commit

• 869ab90f0   block: constify struct blk_integrity_profile ... Browse Code »

  blk_integrity_profile's are never modified, so mark them 'const' so that
  they are placed in .rodata and benefit from memory protection.

  Signed-off-by: Eric Biggers
  Signed-off-by: Jens Axboe

  Eric Biggers

  2017-03-25 10:34:39 +0800  

22 Oct, 2015

1 commit

• 0f8087ecd   block: Consolidate static integrity profile properties ... Browse Code »

  We previously made a complete copy of a device's data integrity profile
  even though several of the fields inside the blk_integrity struct are
  pointers to fixed template entries in t10-pi.c.

  Split the static and per-device portions so that we can reference the
  template directly.

  Signed-off-by: Martin K. Petersen
  Reported-by: Christoph Hellwig
  Reviewed-by: Sagi Grimberg
  Cc: Dan Williams
  Signed-off-by: Dan Williams
  Signed-off-by: Jens Axboe

  Martin K. Petersen

  2015-10-22 04:42:38 +0800  

27 Sep, 2014

1 commit

• 2341c2f8c   block: Add T10 Protection Information functions ... Browse Code »

  The T10 Protection Information format is also used by some devices that
  do not go through the SCSI layer (virtual block devices, NVMe). Relocate
  the relevant functions to a block layer library that can be used without
  involving SCSI.

  Signed-off-by: Martin K. Petersen
  Reviewed-by: Christoph Hellwig
  Signed-off-by: Jens Axboe

  Martin K. Petersen

  2014-09-27 23:14:59 +0800