22 Jul, 2008
40 commits
-
in the error case the ipaq driver leaves a dangling pointer to already
freed memory that will be freed again.Signed-off-by: Oliver Neukum
Signed-off-by: Greg Kroah-Hartman -
Here's the fix. cdc-wdm has the same problem. The fix is the same.
Signed-off-by: Oliver Neukum
Signed-off-by: Greg Kroah-Hartman -
Remove the board-specific UP2OCR configuration from the
pxa27x-udc driver.Signed-off-by: Daniel Ribeiro
Signed-off-by: Greg Kroah-Hartman -
A couple of USB register initializations had to be changed on MPC85xx
platforms. This is due to the internal SoC buses being different on
MPC83xx SoCs vs MPC85xx SoCs.We currently handle this via an ifdef since 83xx and 85xx are mutually
exclusive kernel builds.Signed-off-by: Srikanth Srinivasan
Signed-off-by: Kumar Gala
Signed-off-by: Greg Kroah-Hartman -
Fix pointer/int cast in USB devio code, and thus avoid a compiler warning.
A void* data argument passed to bus_find_device() and thence to match_devt()
is used to carry a 32-bit datum. However, casting directly between a u32 and
a pointer is not permitted - there must be an intermediate cast via (unsigned)
long.This was introduced by the following patch:
commit 94b1c9fa060ece2c8f080583beb6cc6008e41413
Author: Alan Stern
Date: Tue Jun 24 14:47:12 2008 -0400usbfs: simplify the lookup-by-minor routines
This patch (as1105) simplifies the lookup-by-minor-number code in
usbfs. Instead of passing the minor number to the callback, which
must then reconstruct the entire dev_t value, the patch passes the
dev_t value directly.Signed-off-by: Alan Stern
Signed-off-by: Greg Kroah-HartmanSigned-off-by: David Howells
Cc: Alan Stern
Signed-off-by: Greg Kroah-Hartman -
g_cdc needs to depend on NET, otherwise net-related build errors happen:
ERROR: "netif_carrier_on" [drivers/usb/gadget/g_cdc.ko] undefined!
ERROR: "netif_carrier_off" [drivers/usb/gadget/g_cdc.ko] undefined!
ERROR: "netif_rx" [drivers/usb/gadget/g_cdc.ko] undefined!
ERROR: "alloc_etherdev_mq" [drivers/usb/gadget/g_cdc.ko] undefined!
ERROR: "free_netdev" [drivers/usb/gadget/g_cdc.ko] undefined!
ERROR: "register_netdev" [drivers/usb/gadget/g_cdc.ko] undefined!
ERROR: "print_mac" [drivers/usb/gadget/g_cdc.ko] undefined!
ERROR: "dev_kfree_skb_any" [drivers/usb/gadget/g_cdc.ko] undefined!
ERROR: "__alloc_skb" [drivers/usb/gadget/g_cdc.ko] undefined!
ERROR: "eth_type_trans" [drivers/usb/gadget/g_cdc.ko] undefined!
ERROR: "unregister_netdev" [drivers/usb/gadget/g_cdc.ko] undefined!
ERROR: "__netif_schedule" [drivers/usb/gadget/g_cdc.ko] undefined!
ERROR: "skb_put" [drivers/usb/gadget/g_cdc.ko] undefined!Signed-off-by: Randy Dunlap
Signed-off-by: Greg Kroah-Hartman -
Copy the OHCI/EHCI PM callbacks of the PCI implementation since
they work equally well on Au1xxx hardware.Tested on Au1200.
Signed-off-by: Manuel Lauss
Cc: David Brownell
Signed-off-by: Greg Kroah-Hartman -
- Fold multiple probe/remove callbacks into one function;
- minor style fixes, no functional changes.Tested on Au1200.
Signed-off-by: Manuel Lauss
Cc: David Brownell
Signed-off-by: Greg Kroah-Hartman -
This patch (as1107) fixes a small bug in the usbfs registration and
unregistration code. It avoids leaving an error value stored in the
device's usb_classdev field and it avoids trying to unregister a NULL
pointer. (It also fixes a rather extreme overuse of whitespace.)Signed-off-by: Alan Stern
Signed-off-by: Greg Kroah-Hartman -
This patch (as1106) fixes a race between opening and unregistering
device files in usbfs. The current code drops its reference to the
device and then reacquires it, ignoring the possibility that the
device structure might have been removed in the meantime. It also
doesn't check whether the device is already in the NOTATTACHED state
when the file is opened.Signed-off-by: Alan Stern
Signed-off-by: Greg Kroah-Hartman -
This patch (as1105) simplifies the lookup-by-minor-number code in
usbfs. Instead of passing the minor number to the callback, which
must then reconstruct the entire dev_t value, the patch passes the
dev_t value directly.Signed-off-by: Alan Stern
Signed-off-by: Greg Kroah-Hartman -
USB device files are accessible in two ways: as files in usbfs and as
character device nodes. The two paths are supposed to behave
identically, but they don't. When the underlying USB device is
unplugged, disconnect signals are sent to processes with open usbfs
files (if they requested these signals) but not to processes with open
device node files.This patch (as1104) fixes the bug by moving the disconnect-signalling
code into a common subroutine which is called from both paths.
Putting this subroutine in devio.c removes the only out-of-file
reference to struct dev_state, and so the structure's declaration can
be moved from usb.h into devio.c.Finally, the new subroutine performs one extra action: It kills all
the outstanding async URBs. (I'd kill the outstanding synchronous
URBs too, if there was any way to do it.) In the past this hasn't
mattered much, because devices were unregistered from usbfs only
when they were disconnected. But now the unregistration can also
occur whenever devices are unbound from the usb_generic driver. At
any rate, killing URBs when a device is unregistered from usbfs seems
like a good thing to do.Signed-off-by: Alan Stern
Signed-off-by: Greg Kroah-Hartman -
This patch (as1024) takes care of a FIXME issue: Drivers that don't
have the necessary suspend, resume, reset_resume, pre_reset, or
post_reset methods will be unbound and their interface reprobed when
one of the unsupported events occurs.This is made slightly more difficult by the fact that bind operations
won't work during a system sleep transition. So instead the code has
to defer the operation until the transition ends.Signed-off-by: Alan Stern
Signed-off-by: Greg Kroah-Hartman -
Various cleanups and fixes to the i2c code in ohci-pnx4008:
* Delete empty isp1301_command. The i2c driver command implementation
is optional, so there's no point in providing an empty
implementation.
* Give a name to isp1301_driver. I'm surprised that i2c-core accepted
to register this driver at all. I've chosen "isp1301_pnx" as the
name, because it's not a generic ISP1301 driver (much like the
isp1301_omap driver.) We might want to make the name even more
specific (but "isp1301_ohci_pnx4008" doesn't fit.)
* The ISP1301 is definitely not a hardware monitoring device.
* Fix a memory leak on failure in isp1301_attach. If
i2c_attach_client fails, the client is not registered so
isp1301_detach is never called and the i2c_client memory is lost.
* Use strlcpy instead of strcpy.Signed-off-by: Jean Delvare
Cc: Vitaly Wool
Cc: David Brownell
Signed-off-by: Greg Kroah-Hartman -
USB debug port only supports 8 byte rx/tx packets. Although spec implies that
"if a packet larger than eight bytes is received from the remote computer, the
device must break the larger packet into eight-byte packets before sending the
data to the Debug Port", the real PLX NET20DC device does not handle it right -
data is corrupted on debug port end if serial interface sends >8 byte urbs.
Patch below fixes the issue by limiting tx urb to 8 byte.Signed off by: Aleks Gorelov
Signed-off-by: Greg Kroah-Hartman -
cdc-acm must give up secondary interfaces if the primary is disconnected
and vice versa. This wasn't done correctly.Signed-off-by: Oliver Neukum
Signed-off-by: Greg Kroah-Hartman -
usb serial decrements the pm counter even if an interface has been
disconnected. If it was a logical disconnect the interface may belong
already to another driver. This patch introduces a check for disconnected
interfaces.Signed-off-by: Oliver Neukum
Cc: Stable
Signed-off-by: Greg Kroah-Hartman -
this patch implements
- suspend/resume
- aggressive autosuspend for the cdc-wdm driver
- pre/post_resetSigned-off-by: Oliver Neukum
Signed-off-by: Greg Kroah-Hartman -
this patch saves power for cdc-acm devices that support remote wakeup
while the device is connected.- request needs_remote_wakeup when needed
- delayed write while a device is autoresumed
- the device is marked busy when appropriateSigned-off-by: Oliver Neukum
Signed-off-by: Greg Kroah-Hartman -
The 28xb, as documented in comments, has the same ID's as the 28x.
Remove the duplicated ID's from the device tables, and expand the
comment to document this.Signed-off-by: Ben Collins
Signed-off-by: Greg Kroah-Hartman -
This fixes the compiler warning.
Signed-off-by: Greg Kroah-Hartman
-
fix interrupt transfer interval for Full/Low speed device.
Signed-off-by: Yoshihiro Shimoda
Signed-off-by: Greg Kroah-Hartman -
fix the problem that did not set IRQF_TRIGGER_ flag.
Signed-off-by: Yoshihiro Shimoda
Signed-off-by: Greg Kroah-Hartman -
This patch renames the existing usb_reset_device in hub.c to
usb_reset_and_verify_device and renames the existing
usb_reset_composite_device to usb_reset_device. Also the new
usb_reset_and_verify_device does't need to be EXPORTED .The idea of the patch is that external interface driver
should warn the other interfaces' driver of the same
device before and after reseting the usb device. One interface
driver shoud call _old_ usb_reset_composite_device instead of
_old_ usb_reset_device since it can't assume the device contains
only one interface. The _old_ usb_reset_composite_device
is safe for single interface device also. we rename the two
functions to make the change easily.This patch is under guideline from Alan Stern.
Signed-off-by: Ming Lei
-
fix the following sparse warning:
drivers/usb/serial/usb-serial.c:927:43: warning: incorrect type in argument 3 (different signedness)
drivers/usb/serial/usb-serial.c:927:43: expected unsigned int *minor
drivers/usb/serial/usb-serial.c:927:43: got int *
CHECK drivers/usb/serial/generic.cSigned-off-by: Andre Haupt
Signed-off-by: Greg Kroah-Hartman -
This adds support for hardware configurations that don't match the
chip default register settings (e.g., 16-bit data bus, DACK and
DREQ pulled up instead of down, analog overcurrent mode).These settings are passed in via the OF device tree. The PCI
interface still assumes the same default values.Signed-off-by: Nate Case
Acked-by: Olof Johansson
Signed-off-by: Greg Kroah-Hartman -
It is the usb interface driver probe() methods that
can't call usb_set_configuration, not usb device driver.Signed-off-by: Ming Lei
Signed-off-by: Greg Kroah-Hartman -
This patch (as1103) changes the iteration in the USB scatter-gather to
use a standard SG iterator. Otherwise the iteration will fail if it
encounters a chained SG list.Signed-off-by: Alan Stern
Acked-by: Jens Axboe
Signed-off-by: Greg Kroah-Hartman -
From the current implementation of usb_reset_composite_device
function, the iface parameter is no longer useful. This function
doesn't do something special for the iface usb_interface,compared
with other interfaces in the usb_device. So remove the parameter
and fix the related caller.Signed-off-by: Ming Lei
Acked-by: Alan Stern
Signed-off-by: Greg Kroah-Hartman -
Remove an explicit memset(.., 0, ...) to a variable allocated with kzalloc
(i.e. 'card_info' array of the structure 'instance').Signed-off-by: Christophe Jaillet
Signed-off-by: Andrew Morton
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Andrew Morton
Signed-off-by: Greg Kroah-Hartman -
- fixes an error with filling out control requests
- increases grepability and error logging
- fixes the short read code pathSigned-off-by: Oliver Neukum
Signed-off-by: Greg Kroah-Hartman -
This driver is only for one device id, and the option driver should be
used instead for it.Signed-off-by: Greg Kroah-Hartman
-
Signed-off-by: Akinobu Mita
Acked-by: Pete Zaitcev
Signed-off-by: Andrew Morton
Signed-off-by: Greg Kroah-Hartman -
mark this array as const because it is read-only
Signed-off-by: Ming Lei
Acked-by: Alan Stern
Signed-off-by: Greg Kroah-Hartman -
Mark the tables as const so that they end up in .rodata
section and don't cacheline share with things that get
written to.Signed-off-by: Ming Lei
Cc: Yoshihiro Shimoda
Signed-off-by: Greg Kroah-Hartman -
This patch (as1102) clarifies two points in the USB Gadget kerneldoc:
Request completion callbacks are always made with interrupts
disabled;Device controllers may not support STALLing the status stage
of a control transfer after the data stage is over.Signed-off-by: Alan Stern
Acked-by: David Brownell
Signed-off-by: Greg Kroah-Hartman -
General cleanup on ir-usb module. Introduced
a common header that could be used also on
usb gadget framework.Lot's of cleanups and now using macros from the header
file.Signed-off-by: Felipe Balbi
Signed-off-by: Greg Kroah-Hartman -
This patch fixes some performance bugs observed with some workloads
when unlinking EHCI queue header (QH) descriptors from the async ring
(control/bulk schedule).The mechanism intended to defer unlinking an empty QH (so there is no
penalty in common cases where it's quickly reused) was not working as
intended. Sometimes the unlink was scheduled:- too quickly ... which can be a *strong* negative effect, since
that QH becomes unavailable for immediate re-use;- too slowly ... wasting DMA cycles, usually a minor issue except
for increased bus contention and power usage;Plus there was an extreme case of "too slowly": a logical error in the
IAA watchdog-timer conversion meant that sometimes the unlink never
got scheduled.The fix replaces a simple counter with a timestamp derived from the
controller's 8 KHz microframe counter, and adjusts the timer usage
for some issues associated with HZ being less than 8K.(Based on a patch originally by Alan Stern, and good troubleshooting
from Leonid.)Signed-off-by: David Brownell
Cc: Alan Stern
Cc: Leonid
Signed-off-by: Greg Kroah-Hartman -
We can't allow hubs on the 7th tier as they would allow
devices on the 8th tier.Signed-off-by: Felipe Balbi
Cc: Alan Stern
Signed-off-by: Greg Kroah-Hartman
