Eric Lee / smarc-fsl-linux-kernel

11 Feb, 2007

1 commit

09 Feb, 2007

1 commit

12 Dec, 2006

1 commit

03 Dec, 2006

17 commits

  • 59348b19e   [DCCP]: Simplified conditions due to use of enum:8 states ... Browse Code »

    This reaps the benefit of the earlier patch, which changed the type of
    CCID 3 states to use enums, in that many conditions are now simplified
    and the number of possible (unexpected) values is greatly reduced.

    In a few instances, this also allowed to simplify pre-conditions; where
    care has been taken to retain logical equivalence.

    [DCCP]: Introduce a consistent BUG/WARN message scheme

    This refines the existing set of DCCP messages so that
    * BUG(), BUG_ON(), WARN_ON() have meaningful DCCP-specific counterparts
    * DCCP_CRIT (for severe warnings) is not rate-limited
    * DCCP_WARN() is introduced as rate-limited wrapper

    Using these allows a faster and cleaner transition to their original
    counterparts once the code has matured into a full DCCP implementation.

    Signed-off-by: Gerrit Renker
    Signed-off-by: Arnaldo Carvalho de Melo

    Gerrit Renker
     
  • 58a5a7b95   [NET]: Conditionally use bh_lock_sock_nested in sk_receive_skb ... Browse Code »

    Spotted by Ian McDonald, tentatively fixed by Gerrit Renker:

    http://www.mail-archive.com/dccp%40vger.kernel.org/msg00599.html

    Rewritten not to unroll sk_receive_skb, in the common case, i.e. no lock
    debugging, its optimized away.

    Signed-off-by: Arnaldo Carvalho de Melo

    Arnaldo Carvalho de Melo
     
  • 7d533f941   [NET]: More dccp endianness annotations. ... Browse Code »

    Signed-off-by: Al Viro
    Signed-off-by: David S. Miller

    Al Viro
     
  • 868c86bcb   [NET]: annotate csum_ipv6_magic() callers in net/* ... Browse Code »

    Signed-off-by: Al Viro
    Signed-off-by: David S. Miller

    Al Viro
     
  • cfb6eeb4c   [TCP]: MD5 Signature Option (RFC2385) support. ... Browse Code »

    Based on implementation by Rick Payne.

    Signed-off-by: YOSHIFUJI Hideaki
    Signed-off-by: David S. Miller

    YOSHIFUJI Hideaki
     
  • 09dbc3895   [DCCP]: Miscellaneous code tidy-ups ... Browse Code »

    This patch does not change code; it performs some trivial clean/tidy-ups:

    * removal of a `debug_prefix' string in favour of the
    already existing dccp_role(sk)

    * add documentation of structures and constants

    * separated out the cases for invalid packets (step 1
    of the packet validation)

    * removing duplicate statements

    * combining declaration & initialisation

    Signed-off-by: Gerrit Renker
    Signed-off-by: Arnaldo Carvalho de Melo

    Gerrit Renker
     
  • b9df3cb8c   [TCP/DCCP]: Introduce net_xmit_eval ... Browse Code »

    Throughout the TCP/DCCP (and tunnelling) code, it often happens that the
    return code of a transmit function needs to be tested against NET_XMIT_CN
    which is a value that does not indicate a strict error condition.

    This patch uses a macro for these recurring situations which is consistent
    with the already existing macro net_xmit_errno, saving on duplicated code.

    Signed-off-by: Gerrit Renker
    Signed-off-by: Arnaldo Carvalho de Melo

    Gerrit Renker
     
  • d7f7365f5   [DCCPv6]: Choose a genuine initial sequence number ... Browse Code »

    This
    * resolves a FIXME - DCCPv6 connections started all with
    an initial sequence number of 1;
    * provides a redirection `secure_dccpv6_sequence_number'
    in case the init_sequence_v6 code should be updated later;
    * concentrates the update of S.GAR into dccp_connect_init();
    * removes a duplicate dccp_update_gss() in ipv4.c;
    * uses inet->dport instead of usin->sin_port, due to the
    following assignment in dccp_v4_connect():
    inet->dport = usin->sin_port;

    Signed-off-by: Gerrit Renker
    Signed-off-by: Arnaldo Carvalho de Melo

    Gerrit Renker
     
  • 865e9022d   [DCCP]: Remove redundant statements in init_sequence (ISS) ... Browse Code »

    This patch removes the following redundancies:

    1) The test skb->protocol == htons(ETH_P_IPV6) in dccp_v6_init_sequence
    is always true since
    * dccp_v6_conn_request() is the only calling function
    * dccp_v6_conn_request() redirects all skb's with ETH_P_IP to
    dccp_v4_conn_request()

    2) The first argument, `struct sock *sk', of dccp_v{4,6}_init_sequence()
    is never used.

    (This is similar for tcp_v{4,6}_init_sequence, an analogous patch has been
    submitted to netdev and merged.)

    By the way - are the `sport' / `dport' arguments in the right order?
    I have made them consistent among calls but they seem to be in the
    reverse order.

    Signed-off-by: Gerrit Renker
    Signed-off-by: Arnaldo Carvalho de Melo

    Gerrit Renker
     
  • 6f4e5fff1   [DCCP]: Support for partial checksums (RFC 4340, sec. 9.2) ... Browse Code »

    This patch does the following:
    a) introduces variable-length checksums as specified in [RFC 4340, sec. 9.2]
    b) provides necessary socket options and documentation as to how to use them
    c) basic support and infrastructure for the Minimum Checksum Coverage feature
    [RFC 4340, sec. 9.2.1]: acceptability tests, user notification and user
    interface

    In addition, it

    (1) fixes two bugs in the DCCPv4 checksum computation:
    * pseudo-header used checksum_len instead of skb->len
    * incorrect checksum coverage calculation based on dccph_x
    (2) removes dccp_v4_verify_checksum() since it reduplicates code of the
    checksum computation; code calling this function is updated accordingly.
    (3) now uses skb_checksum(), which is safer than checksum_partial() if the
    sk_buff has is a non-linear buffer (has pages attached to it).
    (4) fixes an outstanding TODO item:
    * If P.CsCov is too large for the packet size, drop packet and return.

    The code has been tested with applications, the latest version of tcpdump now
    comes with support for partial DCCP checksums.

    Signed-off-by: Gerrit Renker
    Signed-off-by: Arnaldo Carvalho de Melo

    Gerrit Renker
     
  • d83ca5acc   [DCCP]: Update code comments for Step 2/3 ... Browse Code »

    Sorts out the comments for processing steps 2,3 in section 8.5 of RFC 4340.
    All comments have been updated against this document, and the reference to step
    2 has been made consistent throughout the files.

    Signed-off-by: Gerrit Renker
    Signed-off-by: Arnaldo Carvalho de Melo

    Gerrit Renker
     
  • cf557926f   [DCCP]: tidy up dccp_v{4,6}_conn_request ... Browse Code »

    This is a code simplification to remove reduplicated code
    by concentrating and abstracting shared code.

    Detailed Changes:

    Gerrit Renker
     
  • 73c9e02c2   [DCCPv6]: remove forward declarations in ipv6.c ... Browse Code »

    This does the same for ipv6.c as the preceding one does for ipv4.c: Only the
    inet_connection_sock_af_ops forward declarations remain, since at least
    dccp_ipv6_mapped has a circular dependency to dccp_v6_request_recv_sock.

    No code change, merely re-ordering.

    Signed-off-by: Gerrit Renker
    Signed-off-by: Arnaldo Carvalho de Melo

    Gerrit Renker
     
  • 8a73cd09d   [DCCP]: calling dccp_v{4,6}_reqsk_send_ack is a BUG ... Browse Code »

    This patch removes two functions, the send_ack functions of request_sock,
    which are not called/used by the DCCP code. It is correct that these
    functions are not called, below is a justification why calling these
    functions (on a passive socket in the LISTEN/RESPOND state) would mean
    a DCCP protocol violation.

    A) Background: using request_sock in TCP:

    Gerrit Renker
     
  • d23c7107b   [DCCP]: Simplify jump labels in dccp_v{4,6}_rcv ... Browse Code »

    This is a code simplification and was singled out from the
    DCCPv6 Oops patch on
    http://www.mail-archive.com/dccp@vger.kernel.org/msg00600.html

    It mainly makes the code consistent between ipv{4,6}.c for the functions
    dccp_v4_rcv
    dccp_v6_rcv
    and removes the do_time_wait label to simplify code somewhat.

    Commiter note: fixed up a compile problem, trivial.

    Signed-off-by: Gerrit Renker
    Signed-off-by: Arnaldo Carvalho de Melo

    Gerrit Renker
     
  • 9b42078ed   [DCCP]: Combine allocating & zeroing header space on skb ... Browse Code »

    This is a code simplification:
    it combines three often recurring operations into one inline function,

    * allocate `len' bytes header space in skb
    * fill these `len' bytes with zeroes
    * cast the start of this header space as dccp_hdr

    Signed-off-by: Gerrit Renker
    Signed-off-by: Arnaldo Carvalho de Melo

    Gerrit Renker
     
  • 89e7e5777   [DCCPv6]: Add a FIXME for missing IPV6_PKTOPTIONS ... Browse Code »

    This refers to the possible memory leak pointed out in
    http://www.mail-archive.com/dccp@vger.kernel.org/msg00574.html,
    fixed by David Miller in
    http://www.mail-archive.com/netdev@vger.kernel.org/msg24881.html

    and adds a FIXME to point out where code is missing.

    Signed-off-by: Gerrit Renker
    Signed-off-by: Arnaldo Carvalho de Melo

    Gerrit Renker
     

22 Nov, 2006

1 commit

25 Oct, 2006

1 commit

  • 0e64e94e4   [DCCP]: Update documentation references. ... Browse Code »

    Updates the references to spec documents throughout the code, taking into
    account that

    * the DCCP, CCID 2, and CCID 3 drafts all became RFCs in March this year

    * RFC 1063 was obsoleted by RFC 1191

    * draft-ietf-tcpimpl-pmtud-0x.txt was published as an Informational
    RFC, RFC 2923 on 2000-09-22.

    All references verified.

    Signed-off-by: Gerrit Renker
    Signed-off-by: Arnaldo Carvalho de Melo
    Signed-off-by: David S. Miller

    Gerrit Renker
     

22 Oct, 2006

2 commits

  • fd169f15a   [DCCP] ipv6: Fix opt_skb leak. ... Browse Code »

    Based upon a patch from Jesper Juhl. Try to match the
    TCP IPv6 code this was copied from as much as possible,
    so that it's easy to see where to add the ipv6 pktoptions
    support code.

    Signed-off-by: David S. Miller

    David S. Miller
     
  • 82709531a   [DCCP]: Fix Oops in DCCPv6 ... Browse Code »

    I think I got the cause for the Oops observed in
    http://www.mail-archive.com/dccp@vger.kernel.org/msg00578.html

    The problem is always with applications listening on PF_INET6 sockets. Apart
    from the mentioned oops, I observed another one one, triggered at irregular
    intervals via timer interrupt:

    run_timer_softirq -> dccp_keepalive_timer
    -> inet_csk_reqsk_queue_prune
    -> reqsk_free
    -> dccp_v6_reqsk_destructor

    The latter function is the problem and is also the last function to be called
    in said kernel panic.

    In any case, there is a real problem with allocating the right request_sock
    which is what this patch tackles.

    It fixes the following problem:
    - application listens on PF_INET6
    - DCCPv4 packet comes in, is handed over to dccp_v4_do_rcv, from there
    to dccp_v4_conn_request

    Now: socket is PF_INET6, packet is IPv4. The following code then furnishes the
    connection with IPv6 - request_sock operations:

    req = reqsk_alloc(sk->sk_prot->rsk_prot);

    The first problem is that all further incoming packets will get a Reset since
    the connection can not be looked up.

    The second problem is worse:
    --> reqsk_alloc is called instead of inet6_reqsk_alloc
    --> consequently inet6_rsk_offset is never set (dangling pointer)
    --> the request_sock_ops are nevertheless still dccp6_request_ops
    --> destructor is called via reqsk_free
    --> dccp_v6_reqsk_destructor tries to free random memory location (inet6_rsk_offset not set)
    --> panic

    I have tested this for a while, DCCP sockets are now handled correctly in all
    three scenarios (v4/v6 only/v4-mapped).

    Commiter note: I've added the dccp_request_sock_ops forward declaration to keep
    the tree building and to reduce the size of the patch for 2.6.19,
    later I'll move the functions to the top of the affected source
    code to match what we have in the TCP counterpart, where this
    problem hasn't existed in the first place, dumb me not to have
    done the same thing on DCCP land 8)

    Signed-off-by: Gerrit Renker
    Signed-off-by: Arnaldo Carvalho de Melo

    Gerrit Renker
     

12 Oct, 2006

1 commit

23 Sep, 2006

4 commits

  • fda9ef5d6   [NET]: Fix sk->sk_filter field access ... Browse Code »

    Function sk_filter() is called from tcp_v{4,6}_rcv() functions with arg
    needlock = 0, while socket is not locked at that moment. In order to avoid
    this and similar issues in the future, use rcu for sk->sk_filter field read
    protection.

    Signed-off-by: Dmitry Mishin
    Signed-off-by: Alexey Kuznetsov
    Signed-off-by: Kirill Korotaev

    Dmitry Mishin
     
  • 8e1ef0a95   [IPV6]: Cache source address as well in ipv6_pinfo{}. ... Browse Code »

    Based on MIPL2 kernel patch.

    Signed-off-by: YOSHIFUJI Hideaki
    Signed-off-by: Ville Nuorvala
    Signed-off-by: David S. Miller

    YOSHIFUJI Hideaki
     
  • 4237c75c0   [MLSXFRM]: Auto-labeling of child sockets ... Browse Code »

    This automatically labels the TCP, Unix stream, and dccp child sockets
    as well as openreqs to be at the same MLS level as the peer. This will
    result in the selection of appropriately labeled IPSec Security
    Associations.

    This also uses the sock's sid (as opposed to the isec sid) in SELinux
    enforcement of secmark in rcv_skb and postroute_last hooks.

    Signed-off-by: Venkat Yekkirala
    Signed-off-by: David S. Miller

    Venkat Yekkirala
     
  • beb8d13be   [MLSXFRM]: Add flow labeling ... Browse Code »

    This labels the flows that could utilize IPSec xfrms at the points the
    flows are defined so that IPSec policy and SAs at the right label can
    be used.

    The following protos are currently not handled, but they should
    continue to be able to use single-labeled IPSec like they currently
    do.

    ipmr
    ip_gre
    ipip
    igmp
    sit
    sctp
    ip6_tunnel (IPv6 over IPv6 tunnel device)
    decnet

    Signed-off-by: Venkat Yekkirala
    Signed-off-by: David S. Miller

    Venkat Yekkirala
     

03 Aug, 2006

1 commit

  • 497c615ab   [IPV6]: Audit all ip6_dst_lookup/ip6_dst_store calls ... Browse Code »

    The current users of ip6_dst_lookup can be divided into two classes:

    1) The caller holds no locks and is in user-context (UDP).
    2) The caller does not want to lookup the dst cache at all.

    The second class covers everyone except UDP because most people do
    the cache lookup directly before calling ip6_dst_lookup. This patch
    adds ip6_sk_dst_lookup for the first class.

    Similarly ip6_dst_store users can be divded into those that need to
    take the socket dst lock and those that don't. This patch adds
    __ip6_dst_store for those (everyone except UDP/datagram) that don't
    need an extra lock.

    Signed-off-by: Herbert Xu
    Signed-off-by: David S. Miller

    Herbert Xu
     

25 Jul, 2006

1 commit

  • 4b79f0af4   [DCCP]: Fix default sequence window size ... Browse Code »

    When using the default sequence window size (100) I got the following in
    my logs:

    Jun 22 14:24:09 localhost kernel: [ 1492.114775] DCCP: Step 6 failed for
    DATA packet, (LSWL(6279674225)
    Signed-off-by: Arnaldo Carvalho de Melo
    Signed-off-by: David S. Miller

    Ian McDonald
     

01 Jul, 2006

1 commit

21 Mar, 2006

8 commits