13 Jan, 2012
1 commit
-
module_param(bool) used to counter-intuitively take an int. In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.It's time to remove the int/unsigned int option. For this version
it'll simply give a warning, but it'll break next kernel version.Acked-by: Mauro Carvalho Chehab
Signed-off-by: Rusty Russell
26 May, 2011
1 commit
-
The abituguru drivers are only built on X86, where DMI support is now
enabled by default. So let these drivers depend on DMI, for the
following gains:
* Robustness and safety. Detection of these devices is weak and uses
non-standard methods, it should really be limited to Abit boards
unless the user explicitly asks otherwise.
* Code simplicity. The code is easier to read without ifdefs.
* Better build testing coverage. Now there's only one way to build the
drivers, so no risk of build failure on exotic systems.Signed-off-by: Jean Delvare
Acked-by: Guenter Roeck
Acked-by: Alistair John Strachan
Acked-by: Hans de Goede
31 Mar, 2011
1 commit
-
Fixes generated by 'codespell' and manually reviewed.
Signed-off-by: Lucas De Marchi
22 Mar, 2011
1 commit
-
Signed-off-by: Hans de Goede
Signed-off-by: Jean Delvare
09 Jan, 2011
1 commit
-
Added #define pr_fmt KBUILD_MODNAME ": " fmt
Converted printks to pr_
Coalesced any long formats
Removed prefixes from formats
Added a few static strings to standardize logging messages.Signed-off-by: Joe Perches
Signed-off-by: Guenter Roeck
15 Sep, 2009
2 commits
-
Drivers should be including instead of .
Signed-off-by: H Hartley Sweeten
Cc: Alistair John Strachan
Cc: Nicolas Boichat
Cc: Juerg Haefliger
Cc: Frank Seidel
Acked-by: Jim Cromie
Cc: "Mark M. Hoffman"
Cc: Roger Lucas
Signed-off-by: Jean Delvare -
Most known Abit motherboards have unique uguru chip IDs. However,
some "refresh" boards keep the same chip ID but have a different
DMI string. As our DMI board string matching is (necessarily)
strict, some boards were failing DMI detection, and as the old
probe method was also failing, the driver would not load.The only known boards affected by this problem are the IP35 Pro XE
(vs IP35 Pro) and the AB9 Pro (vs AB9). Is it not sufficient to
relax the match criteria, as some boards (e.g. the AB9 Quad GT)
have different uguru chip IDs.This patch replaces the dmi_name string with a NULL terminated
array of strings to be matched per uguru chip ID. It has been
compile and runtime tested (thanks Rune).References: https://bugs.launchpad.net/bugs/298798
Signed-off-by: Alistair John Strachan
Tested-by: Rune Svendsen
Acked-by: Hans de Goede
Signed-off-by: Jean Delvare
11 Jul, 2009
1 commit
-
Switch the AB9, AB9 QuadQT and IX38 QuadGT over from port
probing to the preferred DMI probe method.Signed-off-by: Alistair John Strachan
Tested-by: dan
Tested-by: Nygel Lyndley
Tested-by: Dmitriy Fedchenko
Acked-by: Hans de Goede
Signed-off-by: Jean Delvare
12 Mar, 2009
1 commit
-
Fix a logic bug reported by Roel Kluin, by rewriting the error
handling code in a clearer way.Signed-off-by: Jean Delvare
Cc: Roel Kluin
Acked-by: Alistair John Strachan
Acked-by: Hans de Goede
16 Jan, 2009
3 commits
-
When CONFIG_DMI is not enabled, dmi detection should flag that no board
could be detected (err=1) rather than another error condition (err
Cc: Hans de Goede
Signed-off-by: Jean Delvare -
Switch the IN9 32X MAX over from port probing to the preferred DMI
probe method.Signed-off-by: Alistair John Strachan
Tested-by: Paul Hartman
Cc: Hans de Goede
Signed-off-by: Jean Delvare -
The switch-over to using DMI board strings to identify abituguru3 compatible
mainboards works most of the time, but sometimes the vendor has substantially
modified the board string between BIOS revisions.We have found that the vendor chipset identification string (provided in
brackets) changes frequently and is of no use to us. The rest of the board
string sometimes changes in subtle ways, e.g. whitespace or variations in
capitalization.The new comparison code checks only a part of the supplied DMI board string,
trimming the bracketed content, whitespace, and ignoring case as necessary.This fixes a bug where an IP35 Pro running an early BIOS would not be
detected without the force=1 module parameter, and also speculatively
fixes other similiar issues.Signed-off-by: Alistair John Strachan
Reported-by: Nick Pasich
Cc: Hans de Goede
Signed-off-by: Jean Delvare
27 Oct, 2008
2 commits
-
Switch the AW9D-MAX over from port probing to the preferred DMI
probe method.Signed-off-by: Alistair John Strachan
Tested-by: Justin Piszcz
Acked-by: Hans de Goede
Signed-off-by: Jean Delvare -
As the probable result of zealous copy/pasting, many supported boards
contain sensor names with trailing whitespace. Though this is not a
huge problem, it is inconsistent with other sensor names, and with
other similar hwmon drivers.Additionally, the DMI nag message added in 2.6.27 was missing a
space between two sentence fragments -- might as well clean that up
too.Doesn't alter any kernel text, just data.
Signed-off-by: Alistair John Strachan
Reported-by: Justin Piszcz
Acked-by: Hans de Goede
Signed-off-by: Jean Delvare
09 Oct, 2008
2 commits
-
Enable driver checking of the DMI product name (when enabled) on
an Abit AT8 32X, instead of falling back to a manual probe. This
eliminates false negatives and eventually will help avoid
unnecessary bus probes on unsupported mainboards.Signed-off-by: Alistair John Strachan
Tested-by: Daniel Exner
Acked-by: Hans de Goede
Signed-off-by: Jean Delvare -
The table for the Abit AT8 32X was incorrectly missing an entry
for the sixth ("AUX3") fan. Add this entry, exporting the fan
reading to userspace.Closes lm-sensors.org ticket #2339.
Signed-off-by: Alistair John Strachan
Tested-by: Daniel Exner
Acked-by: Hans de Goede
Signed-off-by: Jean Delvare
15 Aug, 2008
1 commit
-
Previously the driver was only using DMI to prevent smbus probing on
non-Abit motherboards. However, since the manual probing method is
brittle and prone to failure on some Abit motherboards (esp. the Abit
IP35 Pro) it is better to use DMI to also read the board name and then
decide whether or not to probe the bus.At the moment, we do not have a list of valid DMI name strings to use
for existing and supported motherboards. This patch only implements DMI
probing for the IP35 Pro. For motherboards that can not yet use DMI
probing, a warning will be printed to the kernel log asking those users
to email me their dmidecode output.The existing manual probing mechanism will be used if CONFIG_DMI is not
enabled, if DMI probing fails (for DMI-unsupported motherboards), or if
DMI probing fails and the "force" option is set (for DMI-supported
motherboards). Ideally in the longer term this manual probing method
would be removed.This patch should be safe to apply as it does not change the probing
behaviour for most of the supported motherboards, just the IP35 Pro,
which already has regressions filed against it in 2.6.26.Addresses http://bugzilla.kernel.org/show_bug.cgi?id=11212
Signed-off-by: Alistair John Strachan
Acked-by: Hans de Goede
Cc: "Mark M. Hoffman"
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
19 Jun, 2008
2 commits
-
It has been reported that the abituguru3 driver fails to load after a BIOS
update. This patch fixes this by loosening the detection routine so that it
will work after the BIOS update too. To compensate for the now very loose
detection an additional check is added on the DMI Base Board vendor string to
make sure we only load on Abit motherboards, this is the same as the check in
the abituguru (1 / 2) driver.Signed-of-by: Hans de Goede
Signed-off-by: Alistair John Strachan
Signed-off-by: Mark M. Hoffman -
This patch identifies the Abit AW8D board as such, and adds support for its
aux5 fan connectorSigned-off-by: Hans de Goede
Acked-by: Jean Delvare
Signed-off-by: Mark M. Hoffman
08 Feb, 2008
1 commit
-
Abit IP35 Pro has 6 fan connectors (CPU, SYS and AUX1-4), but the
entry for AUX4 was missing from the table.Signed-off-by: Sergey Vlasov
Acked-by: Hans de Goede
Signed-off-by: Mark M. Hoffman
08 Nov, 2007
2 commits
-
This patch changes the identification string for motherboards with an id of
0x001A from unknown to "Abit IP35 Pro". Thanks to James Scott who has an Abit
IP35 Pro.Signed-off-by: Hans de Goede
Acked-by: Jean Delvare
Signed-off-by: Mark M. Hoffman -
Signed-of-by: Hans de Goede
Acked-by: Jean Delvare
Signed-off-by: Mark M. Hoffman
10 Oct, 2007
1 commit
-
Convert from class_device to device for hwmon_device_register/unregister
Signed-off-by: Tony Jones
Signed-off-by: Greg Kroah-Hartman
Signed-off-by: Kay Sievers
Signed-off-by: Mark M. Hoffman
31 Jul, 2007
1 commit
-
abituguru3_read_increment_offset() can become static.
Signed-off-by: Adrian Bunk
Acked-by: Hans de Goede
Signed-off-by: Mark M. Hoffman
20 Jul, 2007
2 commits
-
This patch changes the driver to also detect uguru3's which hold 0x08 at DATA
initially, as has been reported here:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220160Also when an uguru3's holds 0x0014 in the ID register it will now report
"Abit AB9 Pro" as motherboard identification.Signed-off-by: Hans de Goede
Signed-off-by: Mark M. Hoffman -
This patch adds a new driver for the hardware monitoring features of the
third revision of the Abit uGuru chip, found on recent Abit
motherboards. This is an entirely different beast then the first and
second revision (its again a winbond microcontroller, but the "protocol"
to talk to it and the bank addresses are very different.Signed-off-by: Hans de Goede
Signed-off-by: Mark M. Hoffman