19 Nov, 2011
1 commit
-
The slicoss driver uses network interfaces so it should depend
on NET. Fixes the following build errors:ERROR: "eth_change_mtu" [drivers/staging/slicoss/slicoss.ko] undefined!
ERROR: "eth_validate_addr" [drivers/staging/slicoss/slicoss.ko] undefined!
ERROR: "register_netdev" [drivers/staging/slicoss/slicoss.ko] undefined!
ERROR: "alloc_etherdev_mqs" [drivers/staging/slicoss/slicoss.ko] undefined!
ERROR: "__netif_schedule" [drivers/staging/slicoss/slicoss.ko] undefined!
ERROR: "netif_rx" [drivers/staging/slicoss/slicoss.ko] undefined!
ERROR: "eth_type_trans" [drivers/staging/slicoss/slicoss.ko] undefined!
ERROR: "skb_put" [drivers/staging/slicoss/slicoss.ko] undefined!
ERROR: "skb_pull" [drivers/staging/slicoss/slicoss.ko] undefined!
ERROR: "__alloc_skb" [drivers/staging/slicoss/slicoss.ko] undefined!
ERROR: "free_netdev" [drivers/staging/slicoss/slicoss.ko] undefined!
ERROR: "unregister_netdev" [drivers/staging/slicoss/slicoss.ko] undefined!
ERROR: "consume_skb" [drivers/staging/slicoss/slicoss.ko] undefined!
ERROR: "dev_kfree_skb_irq" [drivers/staging/slicoss/slicoss.ko] undefined!Signed-off-by: Randy Dunlap
Cc: Lior Dotan
Cc: Christopher Harrer
Signed-off-by: Greg Kroah-Hartman
26 Oct, 2011
1 commit
-
Mark Einon points out that the Kconfig option for NETDEV_1000 no longer
exists, and the merge of the staging drivers should have removed that
for the et131x driver.And while checking for it, I noticed that slicoss had the same stale
dependency. Remove that one too.Reported-by: Mark Einon
Signed-off-by: Linus Torvalds
18 Aug, 2011
1 commit
-
replace it by ndo_set_rx_mode
Signed-off-by: Jiri Pirko
Signed-off-by: David S. Miller
31 Mar, 2011
1 commit
-
Fixes generated by 'codespell' and manually reviewed.
Signed-off-by: Lucas De Marchi
30 Sep, 2010
1 commit
-
Freeing netdev without free_netdev() leads to net, tx leaks.
I might lead to dereferencing freed pointer.The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)@@
struct net_device* dev;
@@-kfree(dev)
+free_netdev(dev)Signed-off-by: Vasiliy Kulikov
Acked-by: Denis Kirjanov
Signed-off-by: Greg Kroah-Hartman
01 Sep, 2010
1 commit
-
Remove explicit arch dependencies
Signed-off-by: Denis Kirjanov
Signed-off-by: Greg Kroah-Hartman
03 Aug, 2010
1 commit
-
Remove net_device_stats from the driver's private.
Signed-off-by: Denis Kirjanov
Signed-off-by: Greg Kroah-Hartman
23 Jul, 2010
1 commit
-
Reorder functions to kill their prototypes.
Signed-off-by: Denis Kirjanov
Signed-off-by: Greg Kroah-Hartman
09 Jul, 2010
4 commits
-
This patch makes error handling more readable due to 'goto err' pattern.
Signed-off-by: Kulikov Vasiliy
Cc: Denis Kirjanov
Signed-off-by: Greg Kroah-Hartman -
This patch makes error handling more readable due to 'goto err' pattern.
Signed-off-by: Kulikov Vasiliy
Cc: Denis Kirjanov
Signed-off-by: Greg Kroah-Hartman -
Remove defines of STATUS_XXX from header file.
Signed-off-by: Kulikov Vasiliy
Cc: Denis Kirjanov
Signed-off-by: Greg Kroah-Hartman -
Change defined STATUS_XXX return codes to standard -EYYY.
Signed-off-by: Kulikov Vasiliy
Cc: Denis Kirjanov
Signed-off-by: Greg Kroah-Hartman
04 Apr, 2010
1 commit
-
Converts the list and the core manipulating with it to be the same as uc_list.
+uses two functions for adding/removing mc address (normal and "global"
variant) instead of a function parameter.
+removes dev_mcast.c completely.
+exposes netdev_hw_addr_list_* macros along with __hw_addr_* functions for
manipulation with lists on a sandbox (used in bonding and 80211 drivers)Signed-off-by: Jiri Pirko
Signed-off-by: David S. Miller
05 Mar, 2010
1 commit
-
There were a number of patches that went into Linus's
tree already that conflicted with other changes in the
staging branch. This merge resolves those merge conflicts.Signed-off-by: Greg Kroah-Hartman
04 Mar, 2010
10 commits
-
String constants that are continued on subsequent lines with \
are not good.Signed-off-by: Joe Perches
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Ben Hutchings
Signed-off-by: Greg Kroah-Hartman -
Use pci_set_consistent_dma_mask() in the case of 64-bit consistent allocations.
Signed-off-by: Denis Kirjanov
Signed-off-by: Greg Kroah-Hartman -
Use compare_ether_addr.
Signed-off-by: Denis Kirjanov
Signed-off-by: Greg Kroah-Hartman -
Use PCI_DEVICE_TABLE: defines array as const and puts
it into the __devinitconst section.Signed-off-by: Denis Kirjanov
Signed-off-by: Greg Kroah-Hartman -
Use dev->stats rather than adapter->stats.
Signed-off-by: Denis Kirjanov
Signed-off-by: Greg Kroah-Hartman -
No need to check pointer expicitly since it has been done in debugfs_remove()
Signed-off-by: Denis Kirjanov
Signed-off-by: Greg Kroah-Hartman -
No need type casting when using netdev_priv.
Signed-off-by: Denis Kirjanov
Signed-off-by: Greg Kroah-Hartman -
Check for valid hw address.
Signed-off-by: Denis Kirjanov
Signed-off-by: Greg Kroah-Hartman -
Convert to netdev_tx_t.
Signed-off-by: Denis Kirjanov
Signed-off-by: Greg Kroah-Hartman
19 Feb, 2010
1 commit
-
removed needless checks in arlan-main.c and slicoss.c
fixed bug in et131x_netdev.c to actually fill addresses in.Signed-off-by: Jiri Pirko
Signed-off-by: David S. Miller
13 Feb, 2010
1 commit
-
This patch replaces dev->mc_count in all drivers (hopefully I didn't miss
anything). Used spatch and did small tweaks and conding style changes when
it was suitable.Jirka
Signed-off-by: Jiri Pirko
Signed-off-by: David S. Miller
12 Dec, 2009
1 commit
-
The definition of slic_netdev_ops has initializations of a local function
and eth_mac_addr for its ndo_set_mac_address field. This change uses only
the local function.The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)//
@r@
identifier I, s, fld;
position p0,p;
expression E;
@@struct I s =@p0 { ... .fld@p = E, ...};
@s@
identifier I, s, r.fld;
position r.p0,p;
expression E;
@@struct I s =@p0 { ... .fld@p = E, ...};
@script:python@
p0 << r.p0;
fld << r.fld;
ps << s.p;
pr << r.p;
@@if int(ps[0].line)!=int(pr[0].line) or int(ps[0].column)!=int(pr[0].column):
cocci.print_main(fld,p0)
//Signed-off-by: Julia Lawall
Signed-off-by: Greg Kroah-Hartman
16 Sep, 2009
1 commit
-
These changes were a direct result of using a semantic patch
More information can be found at http://www.emn.fr/x-info/coccinelle/Signed-off-by: Stoyan Gaydarov
Signed-off-by: Greg Kroah-Hartman
06 Jul, 2009
1 commit
-
This patch is the result of an automatic spatch transformation to convert
all ndo_start_xmit() return values of 0 to NETDEV_TX_OK.Some occurences are missed by the automatic conversion, those will be
handled in a seperate patch.Signed-off-by: Patrick McHardy
Signed-off-by: David S. Miller
20 Jun, 2009
2 commits
-
This fixes some build warnings in the slicoss driver.
Signed-off-by: Greg Kroah-Hartman
-
The remove function uses __devexit, so the .remove assignment needs
__devexit_p() to fix a build error with hotplug disabled.Signed-off-by: Jean Delvare
Signed-off-by: Greg Kroah-Hartman
18 Apr, 2009
3 commits
-
I looked, I gagged, I left
Signed-off-by: Stephen Hemminger
Signed-off-by: Greg Kroah-Hartman -
Revert commit 2bb347361e2c19799431f56488a3f64de40a3aa6
This commit has been reported to cause problems:
Mar 24 11:50:31 linuxdev kernel: BUG: sleeping function called from invalid context at mm/slub.c:1599 Mar 24 11:50:31 linuxdev kernel: in_atomic(): 1, irqs_disabled(): 0, pid: 3251, name: avahi-daemonCc: Lior Dotan
Cc: Christopher Harrer
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Alexander Beregalov
Acked-by: David S. Miller
Signed-off-by: Greg Kroah-Hartman
07 Apr, 2009
1 commit
-
Replace all DMA_64BIT_MASK macro with DMA_BIT_MASK(64)
Signed-off-by: Yang Hongyang
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
04 Apr, 2009
5 commits
-
Lots of spaces->tabs cleanups for slichw.h
It's much more sane and "Linux-like" now.
Cc: Lior Dotan
Signed-off-by: Greg Kroah-Hartman -
Move the ASSERT macro into slicoss.c as that's all that is currently
being used.Cc: Lior Dotan
Signed-off-by: Greg Kroah-Hartman -
No one uses it, so drop it.
Cc: Lior Dotan
Signed-off-by: Greg Kroah-Hartman -
Use the dev_err() call instead, it is the standard and provides much
more information.Cc: Lior Dotan
Signed-off-by: Greg Kroah-Hartman -
They aren't needed or used anymore.
Cc: Lior Dotan
Signed-off-by: Greg Kroah-Hartman