13 Jan, 2012
1 commit
-
module_param(bool) used to counter-intuitively take an int. In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.It's time to remove the int/unsigned int option. For this version
it'll simply give a warning, but it'll break next kernel version.Acked-by: Mauro Carvalho Chehab
Signed-off-by: Rusty Russell
27 Nov, 2011
2 commits
-
In speakup_init, we have the following:
if (quiet_boot)
spk_shut_up |= 0x01;
And in spk_types.h:
This patch moves the statement in speakup_init so that
speakup_console[vc->vc_num] is guaranteed to be allocated when it
executes.Signed-off-by: Christopher Brannon
Signed-off-by: Greg Kroah-Hartman -
Use kmemdup rather than duplicating its implementation
The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.Signed-off-by: Thomas Meyer
Signed-off-by: Greg Kroah-Hartman
03 Aug, 2011
1 commit
-
x86_64 allmodconfig:
In file included from arch/x86/include/asm/uaccess.h:572,
from include/linux/uaccess.h:5,
from drivers/staging/speakup/devsynth.c:4:
In function 'copy_from_user',
inlined from 'speakup_file_write' at drivers/staging/speakup/devsynth.c:28:
arch/x86/include/asm/uaccess_64.h:64: error: call to 'copy_from_user_overflow' declared with attribute error: copy_from_user() buffer size is not provably correctI'm not sure what was unprovable about it, but size_t is the correct type
anyway.Also replace needless min_t() with min()
Cc: William Hubbs
Cc: Arjan van de Ven
Signed-off-by: Andrew Morton
Signed-off-by: Greg Kroah-Hartman
06 Jul, 2011
1 commit
-
It was pointed out by 'make versioncheck' that some includes of
linux/version.h are not needed in drivers/staging/speakup/.
This patch removes them.Signed-off-by: Jesper Juhl
Signed-off-by: Greg Kroah-Hartman
29 Jun, 2011
1 commit
-
This patch replaces the code for getting an unsigned long from a
userspace buffer by a simple call to kstroul_from_user.
This makes it easier to read and less error prone.Kernel Version: staging of 20110606
Signed-off-by: Peter Huewe
Signed-off-by: Greg Kroah-Hartman
31 Mar, 2011
1 commit
-
Fixes generated by 'codespell' and manually reviewed.
Signed-off-by: Lucas De Marchi
15 Mar, 2011
1 commit
-
This patch was generated by the following semantic patch:
//
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
//Signed-off-by: Ilia Mirkin
Signed-off-by: Greg Kroah-Hartman
24 Feb, 2011
1 commit
-
The cur_item variable from keyhelp.c is an index into a table of
messages. The following condition should always hold:
MSG_FUNCNAMES_START + cur_item
Signed-off-by: Greg Kroah-Hartman
05 Feb, 2011
1 commit
-
Enclosed all macros with complex values in parenthesis
Signed-off-by: Timo von Holtz
Signed-off-by: Greg Kroah-Hartman
03 Feb, 2011
1 commit
-
This was done to resolve conflicts in the following files due
to patches in Linus's tree and in the staging-next tree:
drivers/staging/brcm80211/brcmsmac/wl_mac80211.c
drivers/staging/ste_rmi4/synaptics_i2c_rmi4.cSigned-off-by: Greg Kroah-Hartman
21 Jan, 2011
2 commits
-
We still leaked many resources when Speakup failed to initialize.
Examples of leaked resources include:
/dev/synth, keyboard or VT notifiers, and heap-allocated st_spk_t
structs.
This is fixed.* We now use PTR_ERR to detect kthread_create failure
(thank you Dan Carpenter).* The loop which frees members of the speakup_console array now iterates
over the whole array, not stopping at the first NULL value. Fixes
a possible memory leak. Safe because kfree(NULL) is a no-op.* The order of some initializations was changed. The safe ones, which
will never fail, are performed first.Signed-off-by: Christopher Brannon
Acked-by: Dan Carpenter
Signed-off-by: Greg Kroah-Hartman -
Fix test: the branch is always taken.
Signed-off-by: Roel Kluin
Cc: Andrew Morton
Cc: stable
Signed-off-by: Greg Kroah-Hartman
11 Jan, 2011
2 commits
-
* 'staging-next' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging-2.6: (510 commits)
staging: speakup: fix failure handling
staging: usbip: remove double giveback of URB
Staging: batman-adv: Remove batman-adv from staging
Staging: hv: Use only one txf buffer per channel and kmalloc/GFP_KERNEL on initialize
staging: hv: remove unneeded osd_schedule_callback
staging: hv: convert channel_mgmt.c to not call osd_schedule_callback
staging: hv: convert vmbus_on_msg_dpc to not call osd_schedule_callback
staging: brcm80211: Fix WL_ logging macros
Staging: IIO: DDS: AD9833 / AD9834 driver
Staging: IIO: dds.h convenience macros
Staging: IIO: Direct digital synthesis abi documentation
staging: brcm80211: Convert ETHER_TYPE_802_1X to ETH_P_PAE
staging: brcm80211: Remove unused ETHER_TYPE_ #defines
staging: brcm80211: Remove ETHER_HDR_LEN, use ETH_HLEN
staging: brcm80211: Convert ETHER_ADDR_LEN to ETH_ALEN
staging: brcm80211: Convert ETHER_IS to is__ether_addr
staging: brcm80211: Remove unused ether_ #defines and struct
staging: brcm80211: Convert ETHER_IS_MULTI to is_multicast_ether_addr
staging: brcm80211: Remove unused #defines ETHER__LOCALADDR
Staging: comedi: Fix checkpatch.pl issues in file s526.c
...Fix up trivial conflict in drivers/video/udlfb.c
-
fix the failure handling in kobjects and the main function so that we
release the virtual keyboard if we exit due to another failure.Signed-off-by: William Hubbs
Signed-off-by: Greg Kroah-Hartman
17 Dec, 2010
2 commits
-
The whole function can be expressed as a simple this_cpu_read() operation.
The function overhead is now likely multiple times that of the single
instruction that is executed in it.Sedat: fixed compile failure caused by an extra ')'.
Cc: William Hubbs
Cc: Sedat Dilek
Acked-by: H. Peter Anvin
Signed-off-by: Christoph Lameter
Signed-off-by: Tejun Heo -
__get_cpu_var() can be replaced with this_cpu_read and will then use a single
read instruction with implied address calculation to access the correct per cpu
instance.However, the address of a per cpu variable passed to __this_cpu_read() cannot be
determed (since its an implied address conversion through segment prefixes).
Therefore apply this only to uses of __get_cpu_var where the addres of the
variable is not used.V3->V4:
- Move one instance of this_cpu_inc_return to a later patch
so that this one can go in without percpu infrastructrure
changes.Sedat: fixed compile failure caused by an extra ')'.
Cc: Neil Horman
Cc: Martin Schwidefsky
Cc: Sedat Dilek
Acked-by: H. Peter Anvin
Signed-off-by: Christoph Lameter
Signed-off-by: Tejun Heo
08 Dec, 2010
1 commit
-
This was done to handle a number of conflicts in the batman-adv
and winbond drivers properly. It also now allows us to fix up the sysfs
attributes properly that were not in the .37 release due to them being
only in this tree at the time.Signed-off-by: Greg Kroah-Hartman
30 Nov, 2010
1 commit
18 Nov, 2010
1 commit
-
The big kernel lock has been removed from all these files at some point,
leaving only the #include.Remove this too as a cleanup.
Signed-off-by: Arnd Bergmann
Signed-off-by: Linus Torvalds
17 Nov, 2010
1 commit
-
input_unregister_device() frees the device so the call to
input_free_device() is a double free.Signed-off-by: Dan Carpenter
Signed-off-by: Greg Kroah-Hartman
10 Nov, 2010
1 commit
-
Checkpatch.pl gives WARNING: missing space after struct definition.
This patch fixes that warning that was on line 55.Signed-off-by: Tracey Dent
Signed-off-by: Greg Kroah-Hartman
20 Oct, 2010
9 commits
-
speakup_init() didn't free first_console if speakup_kobj_init() fails.
Also propagate speakup_kobj_init()'s return code.Signed-off-by: Vasiliy Kulikov
Signed-off-by: Greg Kroah-Hartman -
speakup_kobj_init() and speakup_kobj_exit() didn't remove
i18n_attr_group and main_attr_group sysfs groups.Signed-off-by: Vasiliy Kulikov
Signed-off-by: Greg Kroah-Hartman -
fix issues reported by checkpatch.pl
Signed-off-by: William Hubbs
Signed-off-by: Greg Kroah-Hartman -
fix issues reported by checkpatch.pl
Signed-off-by: William Hubbs
Signed-off-by: Greg Kroah-Hartman -
fix issues reported by checkpatch.pl
Signed-off-by: William Hubbs
Signed-off-by: Greg Kroah-Hartman -
fix issues reported by checkpatch.pl
Signed-off-by: William Hubbs
Signed-off-by: Greg Kroah-Hartman -
fix issues reported by checkpatch.pl
Signed-off-by: William Hubbs
Signed-off-by: Greg Kroah-Hartman -
- fix issues reported by checkpatch.pl
- run code through Lindent
- move some prototypes to speakup.hSigned-off-by: William Hubbs
Signed-off-by: Greg Kroah-Hartman -
A help message had to be slightly reworded, but the meaning is the same.
Signed-off-by: William Hubbs
Signed-off-by: Greg Kroah-Hartman
16 Oct, 2010
9 commits
-
* Clean this file based on reports from checkpatch.pl.
* Replace a function-like macro with an inline function.
* Remove an incorrect use of the volatile qualifier. The
previously-volatile variable is now always protected by a spinlock.Signed-off-by: Christopher Brannon
Signed-off-by: Greg Kroah-Hartman -
* Clean this file based on reports from checkpatch.pl.
Signed-off-by: Christopher Brannon
Signed-off-by: Greg Kroah-Hartman -
* Clean this file based on reports from checkpatch.pl.
Signed-off-by: Christopher Brannon
Signed-off-by: Greg Kroah-Hartman -
* Clean this file based on reports from checkpatch.pl.
* Make the file_operations structure const.
* Use strict_strtoul instead of simple_strtoul.Signed-off-by: Christopher Brannon
Signed-off-by: Greg Kroah-Hartman -
* Clean this file based on reports from checkpatch.pl.
* Remove an unused function-like macro.Signed-off-by: Christopher Brannon
Signed-off-by: Greg Kroah-Hartman -
* Clean this file based on reports from checkpatch.pl.
* Eliminate the unused synth_readable macro.
* Convert function-like macros to inline functions.Signed-off-by: Christopher Brannon
Signed-off-by: Greg Kroah-Hartman -
* Clean this file based on reports from checkpatch.pl.
Signed-off-by: Christopher Brannon
Signed-off-by: Greg Kroah-Hartman -
* Clean this file based on reports from checkpatch.pl.
* Replace function-like macros with inline functions.
* Simplify some boolean expressions.Signed-off-by: Christopher Brannon
Signed-off-by: Greg Kroah-Hartman -
* Clean this file based on reports from checkpatch.pl.
Signed-off-by: Christopher Brannon
Signed-off-by: Greg Kroah-Hartman