Eric Lee / smarc-fsl-linux-kernel

11 Jun, 2011

1 commit

  • 8de111e27   [media] lirc_dev: store cdev in irctl, up maxdevs ... Browse Code »

    Store the cdev pointer in struct irctl, allocated dynamically as needed,
    rather than having a static array. At the same time, recycle some of the
    saved memory to nudge the maximum number of lirc devices supported up a
    ways -- its not that uncommon these days, now that we have the rc-core
    lirc bridge driver, to see a system with at least 4 raw IR receivers.
    (consider a mythtv backend with several video capture devices and the
    possible need for IR transmit hardware).

    Signed-off-by: Jarod Wilson
    Signed-off-by: Mauro Carvalho Chehab

    Jarod Wilson
     

29 Dec, 2010

1 commit

  • 0e835087d   [media] lirc_dev: add some __user annotations ... Browse Code »

    Sparse complains because there are no __user annotations.

    drivers/media/rc/lirc_dev.c:156:27: warning:
    incorrect type in initializer (incompatible argument 2 (different address spaces))
    drivers/media/rc/lirc_dev.c:156:27: expected int ( *read )( ... )
    drivers/media/rc/lirc_dev.c:156:27: got int ( extern [toplevel] * )( ... )

    Signed-off-by: Dan Carpenter
    Acked-by: Jarod Wilson
    Signed-off-by: Mauro Carvalho Chehab

    Dan Carpenter
     

21 Oct, 2010

2 commits

  • be1f985ff   [media] IR/lirc: further ioctl portability fixups ... Browse Code »

    >From Joris van Rantwijk :

    I tested lirc_serial and found that it works fine.
    Except the LIRC ioctls do not work in my 64-bit-kernel/32-bit-user
    setup. I added compat_ioctl entries in the drivers to fix this.

    While doing so, I noticed inconsistencies in the argument type of
    the LIRC ioctls. All ioctls are declared in lirc.h as having argument
    type __u32, however there are a few places where the driver calls
    get_user/put_user with an unsigned long argument.

    The patch below changes lirc_dev and lirc_serial to use __u32 for all
    ioctl arguments, and adds compat_ioctl entries.
    It should probably also be done in the other low-level drivers,
    but I don't have hardware to test those.

    I've dropped the .compat_ioctl addition from Joris' original patch,
    as I swear the non-compat definition should now work for both 32-bit
    and 64-bit userspace. Technically, I think we still need/want a
    in getting a reply to you).

    Reported-by: Joris van Rantwijk
    Signed-off-by: Jarod Wilson
    Signed-off-by: Mauro Carvalho Chehab

    Jarod Wilson
     
  • 22c00854f   [media] lirc: Make struct file_operations pointer const ... Browse Code »

    struct file_operations was made const in the drivers, but not in struct
    lirc_driver:

    drivers/staging/lirc/lirc_it87.c:365: warning: initialization discards qualifiers from pointer target type
    drivers/staging/lirc/lirc_parallel.c:571: warning: initialization discards qualifiers from pointer target type
    drivers/staging/lirc/lirc_serial.c:1073: warning: initialization discards qualifiers from pointer target type
    drivers/staging/lirc/lirc_sir.c:482: warning: initialization discards qualifiers from pointer target type
    drivers/staging/lirc/lirc_zilog.c:1284: warning: assignment discards qualifiers from pointer target type

    Signed-off-by: Geert Uytterhoeven
    Acked-by: Jarod Wilson
    Signed-off-by: Mauro Carvalho Chehab

    Geert Uytterhoeven
     

03 Aug, 2010

1 commit

  • 5690085e7   V4L/DVB: IR/lirc: make lirc userspace and staging modules buildable ... Browse Code »

    The lirc userspace needs all the current ioctls defined, and we need to
    put the header files in places out-of-tree and/or staging lirc drivers
    (which I plan to prep soon) can easily build with. I've actually tested this
    in a tree w/all the lirc drivers queued up to be submitted for staging. I'm
    also reasonably sure that Andy Walls is going to need most of the ioctls
    anyway for his cx23888 IR driver work.

    Signed-off-by: Jarod Wilson
    Signed-off-by: Mauro Carvalho Chehab

    Jarod Wilson