21 Jun, 2011
2 commits
-
We already have access to the chan, we don't have to access the
socket to get its imtu.Signed-off-by: Vinicius Costa Gomes
Signed-off-by: Gustavo F. Padovan -
We should not try to do any other type of configuration for
LE links when they become ready.Signed-off-by: Vinicius Costa Gomes
Signed-off-by: Gustavo F. Padovan
18 Jun, 2011
1 commit
-
There was no unlock call on the errors path
Signed-off-by: Gustavo F. Padovan
17 Jun, 2011
4 commits
-
Instead of setting bits manually we use set_bit, test_bit, etc.
Also remove L2CAP_ prefix from macros.Signed-off-by: Gustavo F. Padovan
-
Instead of making the bit operations manually, we now use set_bit,
test_bit, etc.Signed-off-by: Gustavo F. Padovan
-
Management interface commands for blocking and unblocking devices.
Signed-off-by: Antti Julku
Signed-off-by: Gustavo F. Padovan -
Move blacklisting functions to hci_core.c, so that they can
be used by both management interface and hci socket interface.Signed-off-by: Antti Julku
Signed-off-by: Gustavo F. Padovan
15 Jun, 2011
2 commits
-
This patch implements a check in smp cmd pairing request and pairing
response to verify if encryption key maximum size is compatible in both
slave and master when SMP Pairing is requested. Keys are also masked to
the correct negotiated size.Signed-off-by: Vinicius Costa Gomes
Signed-off-by: Anderson Briglia
Signed-off-by: Gustavo F. Padovan -
This patch adds support for disconnecting the link when SMP procedure
takes more than 30 seconds.SMP begins when either the Pairing Request command is sent or the
Pairing Response is received, and it ends when the link is encrypted
(or terminated). Vol 3, Part H Section 3.4.Signed-off-by: Vinicius Costa Gomes
Signed-off-by: Gustavo F. Padovan
14 Jun, 2011
24 commits
-
The "dc" variable is initialized but not passed to hci_send_cmd().
Signed-off-by: Anderson Lizardo
Signed-off-by: Bruna Moreira
Signed-off-by: Gustavo F. Padovan -
This patch implements a simple version of the SMP Pairing Features
exchange procedure (Vol. 3 Part H, Section 2.3.5.1).For now, everything that would cause a Pairing Method different of
Just Works to be chosen is rejected.Signed-off-by: Vinicius Costa Gomes
Signed-off-by: Gustavo F. Padovan -
Before we are able to do a proper exchange of pairing parameters,
we need a unified way of building pairing requests and responses.For IO Capability we use the value that was set by userspace,
using the management interface.Signed-off-by: Vinicius Costa Gomes
Signed-off-by: Gustavo F. Padovan -
If the pending security level is greater than the current security
level and the link is now encrypted, we should update the link
security level.This is only useful for LE links, when the only event generated
when SMP is sucessful in the Encrypt Change event.Signed-off-by: Vinicius Costa Gomes
Signed-off-by: Gustavo F. Padovan -
As the default security level (BT_SECURITY_SDP) doesn't make sense for
LE links, initialize LE links with something that makes sense.Signed-off-by: Vinicius Costa Gomes
Signed-off-by: Gustavo F. Padovan -
This adds support for resuming the user space traffic when SMP
negotiation is complete.Signed-off-by: Vinicius Costa Gomes
Signed-off-by: Gustavo F. Padovan -
Now that these commands are sent to the controller we can use hcidump
to verify that the correct values are produced.Signed-off-by: Vinicius Costa Gomes
Signed-off-by: Gustavo F. Padovan -
This adds support for starting SMP Phase 2 Encryption, when the initial
SMP negotiation is successful. This adds the LE Start Encryption and LE
Long Term Key Request commands and related events.Signed-off-by: Vinicius Costa Gomes
Signed-off-by: Gustavo F. Padovan -
This patch includes support for generating and sending the random value
used to produce the confirmation value.Signed-off-by: Anderson Briglia
Signed-off-by: Vinicius Costa Gomes
Signed-off-by: Gustavo F. Padovan -
This patch adds initial support for verifying the confirmation value
that the remote side has sent.Signed-off-by: Anderson Briglia
Signed-off-by: Vinicius Costa Gomes
Signed-off-by: Gustavo F. Padovan -
This patch implements SMP crypto functions called ah, c1, s1 and e.
It also implements auxiliary functions. All These functions are needed
for SMP keys generation.Signed-off-by: Anderson Briglia
Signed-off-by: Anderson Lizardo
Signed-off-by: Bruna Moreira
Signed-off-by: Vinicius Costa Gomes
Signed-off-by: Gustavo F. Padovan -
This will allow using the crypto subsystem for encrypting data. As SMP
(Security Manager Protocol) is implemented almost entirely on the host
side and the crypto module already implements the needed methods
(AES-128), it makes sense to use it.There's now a new module option to enable/disable SMP support.
Signed-off-by: Vinicius Costa Gomes
Signed-off-by: Anderson Briglia
Signed-off-by: Gustavo F. Padovan -
This implementation only exchanges SMP messages between the Host and the
Remote. No keys are being generated. TK and STK generation will be
provided in further patches.Signed-off-by: Vinicius Costa Gomes
Signed-off-by: Gustavo F. Padovan -
Start SMP procedure for LE connections. This modification intercepts
l2cap received frames and call proper SMP functions to start the SMP
procedure. By now, no keys are being used.Signed-off-by: Vinicius Costa Gomes
Signed-off-by: Anderson Briglia
Signed-off-by: Gustavo F. Padovan -
These simple commands will allow the SMP procedure to be started
and terminated with a not supported error. This is the first step
toward something useful.Signed-off-by: Vinicius Costa Gomes
Signed-off-by: Anderson Briglia
Signed-off-by: Gustavo F. Padovan -
Otherwise the wrong error can be returned.
Signed-off-by: Gustavo F. Padovan
-
ERTM use the generic L2CAP timer functions to keep a reference to the
channel. This is useful for avoiding crashes.Signed-off-by: Gustavo F. Padovan
-
We now plan to use l2cap_set_timer and l2cap_clear_timer in ERTM timers.
Signed-off-by: Gustavo F. Padovan
-
struct l2cap_chan has now its own refcnt that is compatible with the
socket refcnt, i.e., we won't see sk_refcnt = 0 and chan->refcnt > 0.Signed-off-by: Gustavo F. Padovan
-
Now socket state is tracked by struct sock and channel state is tracked by
chan->state. At this point both says the same, but this is going to change
when we add AMP Support for example.Signed-off-by: Gustavo F. Padovan
-
close() calls l2cap_sock_kill() on l2cap_sock.c
Signed-off-by: Gustavo F. Padovan
-
This abstracts the call to sock_queue_recv_skb() into
l2cap_chan_ops->recv().Signed-off-by: Gustavo F. Padovan
-
Add an abstraction layer between L2CAP core and its users (only
l2cap_sock.c now). The first function implemented is new_connection() that
replaces calls to l2cap_sock_alloc() in l2cap_core.cSigned-off-by: Gustavo F. Padovan
-
As a first step to remove l2cap_sock_alloc() and l2cap_sock_init() from
l2cap_core.cSigned-off-by: Gustavo F. Padovan
10 Jun, 2011
7 commits
-
Conflicts:
net/bluetooth/rfcomm/sock.c -
Fix lines longer than 80 chars in length.
Signed-off-by: Waldemar Rymarkiewicz
Signed-off-by: Gustavo F. Padovan -
Signed-off-by: David S. Miller
Signed-off-by: Gustavo F. Padovan -
Some old hci controllers do not accept any mask so leave the
default mask on for these devices.< HCI Command: Set Event Mask (0x03|0x0001) plen 8
Mask: 0xfffffbff00000000
> HCI Event: Command Complete (0x0e) plen 4
Set Event Mask (0x03|0x0001) ncmd 1
status 0x12
Error: Invalid HCI Command ParametersSigned-off-by: Ville Tervo
Tested-by: Corey Boyle
Tested-by: Ed Tomlinson
Signed-off-by: Gustavo F. Padovan -
Signed-off-by: David S. Miller
Signed-off-by: Gustavo F. Padovan -
shutdown should wait for SCO link to be properly disconnected before
detroying the socket, otherwise an application using the socket may
assume link is properly disconnected before it really happens which
can be a problem when e.g synchronizing profile switch.Signed-off-by: Luiz Augusto von Dentz
Signed-off-by: Gustavo F. Padovan -
Enabling DEBUG_STRICT_USER_COPY_CHECKS causes the following
warning:In function 'copy_from_user',
inlined from 'rfcomm_sock_setsockopt' at
net/bluetooth/rfcomm/sock.c:705:
arch/x86/include/asm/uaccess_64.h:65:
warning: call to 'copy_from_user_overflow' declared with
attribute warning: copy_from_user() buffer size is not provably
correctpresumably due to buf_size being signed causing GCC to fail to
see that buf_size can't become negative.Cc: Marcel Holtmann
Cc: Gustavo F. Padovan
Signed-off-by: Stephen Boyd
Signed-off-by: Gustavo F. Padovan
