08 Mar, 2011
17 commits
-
Signed-off-by: Hagen Paul Pfeifer
Signed-off-by: David S. Miller -
ip6_mc_source(), ip6_mc_msfilter() as well as ip6_mc_msfget() declare
and assign dev but do not use the variable afterwards.Signed-off-by: Hagen Paul Pfeifer
Signed-off-by: David S. Miller -
drivers/net/s2io.c:7559: warning: ‘tcp_len’ may be used uninitialized in this function
Signed-off-by: Shan Wei
Signed-off-by: David S. Miller -
When there is a ptype handler holding a clone of this skb, whose
destination MAC addresse is overwritten, the owner of this handler may
get a corrupted packet.Signed-off-by: Changli Gao
Signed-off-by: David S. Miller -
These two functions are only used when net poll controller is enabled.
Signed-off-by: Changli Gao
Signed-off-by: David S. Miller -
This was there before, I forgot about this. Allows deliveries to
ptype_base handlers registered for orig_dev. I presume this is still
desired.Signed-off-by: Jiri Pirko
Reviewed-by: Nicolas de Pesloüan
Signed-off-by: David S. Miller -
Lancer requires multicast capability flag set during IFACE_CREATE
for adding multicast filters.Signed-off-by: Padmanabh Ratnakar
Signed-off-by: Sathya Perla
Signed-off-by: Subramanian Seetharaman
Signed-off-by: David S. Miller -
For Lancer disable interrupts in close by disarming CQs and EQs.
Change the order of calls in be_close to achieve the correct result.Signed-off-by: Padmanabh Ratnakar
Signed-off-by: Sathya Perla
Signed-off-by: Subramanian Seetharaman
Signed-off-by: David S. Miller -
Remove TX Queue stop in close
Signed-off-by: Padmanabh Ratnakar
Signed-off-by: Sathya Perla
Signed-off-by: Subramanian Seetharaman
Signed-off-by: David S. Miller -
Change f/w command versions for Lancer
Signed-off-by: Padmanabh Ratnakar
Signed-off-by: Sathya Perla
Signed-off-by: Subramanian Seetharaman
Signed-off-by: David S. Miller -
Add error recovery during load for Lancer
Signed-off-by: Padmanabh Ratnakar
Signed-off-by: Sathya Perla
Signed-off-by: Subramanian Seetharaman
Signed-off-by: David S. Miller -
L4 checksum field is valid only for TCP/UDP packets in Lancer
Signed-off-by: Padmanabh Ratnakar
Signed-off-by: Sathya Perla
Signed-off-by: Subramanian Seetharaman
Signed-off-by: David S. Miller -
Workaround added for Lancer in handling RX ERR completion received
when no RX buffers are posted is not needed.Signed-off-by: Padmanabh Ratnakar
Signed-off-by: Sathya Perla
Signed-off-by: Subramanian Seetharaman
Signed-off-by: David S. Miller -
This elimiates a lot of pure overhead due to parameter
passing.Signed-off-by: David S. Miller
-
fib_semantic_match() requires that if the type doesn't signal an
automatic error, it must be of type RTN_UNICAST, RTN_LOCAL,
RTN_BROADCAST, RTN_ANYCAST, or RTN_MULTICAST.Checking this every route lookup is pointless work.
Instead validate it during route insertion, via fib_create_info().
Also, there was nothing making sure the type value was less than
RTN_MAX, so add that missing check while we're here.Signed-off-by: David S. Miller
-
This allows any caller to be prefaced by any specific
pr_fmt to better identify which device driver is using
this function inappropriately.Add terminating newline.
Signed-off-by: Joe Perches
Signed-off-by: David S. Miller
07 Mar, 2011
1 commit
05 Mar, 2011
22 commits
-
When trying to associate a net_device with another net_device which
already exists, batman-adv assumes that this interface is a fully
initialized batman mesh interface without checking it. The behaviour
when accessing data behind netdev_priv of a random net_device is
undefined and potentially dangerous.Reported-by: Linus Lüssing
Signed-off-by: Marek Lindner -
Signed-off-by: Linus Lüssing
Signed-off-by: Marek Lindner -
Signed-off-by: Marek Lindner
-
Batman-adv works with "hard interfaces" as well as "soft interfaces".
The new name should better make clear which kind of interfaces this
list stores.Signed-off-by: Marek Lindner
-
Signed-off-by: Marek Lindner
-
Signed-off-by: Marek Lindner
-
It might be possible that 2 threads access the same data in the same
rcu grace period. The first thread calls call_rcu() to decrement the
refcount and free the data while the second thread increases the
refcount to use the data. To avoid this race condition all refcount
operations have to be atomic.Reported-by: Sven Eckelmann
Signed-off-by: Marek Lindner -
Signed-off-by: Marek Lindner
-
Note: The function compare_ether_addr() provided by the Linux kernel
requires aligned memory.Signed-off-by: Marek Lindner
-
When printing the soft interface table the number of entries in the
softif neigh list are first being counted and a fitting buffer
allocated. After that the softif neigh list gets locked again and
the buffer printed - which has the following two issues:For one thing, the softif neigh list might have grown when reacquiring
the rcu lock, which results in writing outside of the allocated buffer.
Furthermore 31 Bytes are not enough for printing an entry with a vid
of more than 2 digits.The manual buffering is unnecessary, we can safely print to the seq
directly during the rcu_read_lock().Signed-off-by: Linus Lüssing
Signed-off-by: Marek Lindner -
When unicast_send_skb() is increasing the orig_node's refcount another
thread might have been freeing this orig_node already. We need to
increase the refcount in the rcu read lock protected area to avoid that.Signed-off-by: Linus Lüssing
Signed-off-by: Marek Lindner -
The rcu protected macros rcu_dereference() and rcu_assign_pointer()
for the bat_priv->curr_gw need to be used, as well as spin/rcu locking.Otherwise we might end up using a curr_gw pointer pointing to already
freed memory.Reported-by: Sven Eckelmann
Signed-off-by: Linus Lüssing
Signed-off-by: Marek Lindner -
Batman-adv could receive several payload broadcasts at the same time
that would trigger access to the broadcast seqno sliding window to
determine whether this is a new broadcast or not. If these incoming
broadcasts are accessing the sliding window simultaneously it could
be left in an inconsistent state. Therefore it is necessary to make
sure this access is atomic.Reported-by: Linus Lüssing
Signed-off-by: Marek Lindner -
Reported-by: Linus Lüssing
Signed-off-by: Marek Lindner -
It might be possible that 2 threads access the same data in the same
rcu grace period. The first thread calls call_rcu() to decrement the
refcount and free the data while the second thread increases the
refcount to use the data. To avoid this race condition all refcount
operations have to be atomic.Reported-by: Sven Eckelmann
Signed-off-by: Marek Lindner -
It might be possible that 2 threads access the same data in the same
rcu grace period. The first thread calls call_rcu() to decrement the
refcount and free the data while the second thread increases the
refcount to use the data. To avoid this race condition all refcount
operations have to be atomic.Reported-by: Sven Eckelmann
Signed-off-by: Marek Lindner -
It might be possible that 2 threads access the same data in the same
rcu grace period. The first thread calls call_rcu() to decrement the
refcount and free the data while the second thread increases the
refcount to use the data. To avoid this race condition all refcount
operations have to be atomic.Reported-by: Sven Eckelmann
Signed-off-by: Marek Lindner -
It might be possible that 2 threads access the same data in the same
rcu grace period. The first thread calls call_rcu() to decrement the
refcount and free the data while the second thread increases the
refcount to use the data. To avoid this race condition all refcount
operations have to be atomic.Reported-by: Sven Eckelmann
Signed-off-by: Marek Lindner -
bonding / alternating candidates need to be secured by rcu locks
as well. This patch therefore converts the bonding list
from a plain pointer list to a rcu securable lists and references
the bonding candidates.Signed-off-by: Simon Wunderlich
Signed-off-by: Marek Lindner -
Signed-off-by: Marek Lindner
-
Signed-off-by: Marek Lindner
-
Signed-off-by: Marek Lindner
