12 Dec, 2015
3 commits
-
There is no good reason to keep them apart, and this makes using the API
a bit simpler.Signed-off-by: Christoph Hellwig
Reviewed-by: Bart Van Assche -
There is no good reason to start out disabled - drivers can control if
the poll instance can be scheduled by simply not scheduling it yet.Signed-off-by: Christoph Hellwig
Reviewed-by: Bart Van Assche -
The new name is irq_poll as iopoll is already taken. Better suggestions
welcome.Signed-off-by: Christoph Hellwig
Reviewed-by: Bart Van Assche
12 Nov, 2015
2 commits
-
SCSI queue for 4.4.
Signed-off-by: Martin K. Petersen
-
drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous':
drivers/scsi/be2iscsi/be_main.c:3187:18: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
WARN_ON(!length > 0);gcc version 5.2.1
Signed-off-by: Tim Gardner
Cc: Jayamohan Kallickal
Cc: Minh Tran
Cc: John Soni Jose
Cc: "James E.J. Bottomley"
Reported-by: Joel Stanley
Reviewed-by: Manoj Kumar
Signed-off-by: Martin K. Petersen
10 Nov, 2015
2 commits
-
Signed-off-by: John Soni Jose
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
While posting WRB the next_pointer of the current WRB should point
to itself and the previous WRB next_pointer should point to the
current WRB.The next pointer value was retrieved during alloc_pdu and was updated
in wrb before ringing the doorbell. The fix retrieves the
next_pointer just before ringing the doorbell and updates in the WRB.Signed-off-by: John Soni Jose
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley
27 Oct, 2015
1 commit
-
We would like to get the following updates in:
Revert ownership to "Emulex" from "Avago Technologies"Signed-off-by: Ketan Mukadam
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley
25 May, 2015
6 commits
-
Bump the driver version
[jejb: resolve conflict with 4627de9 MAINTAINERS, be2iscsi: change email domain]
Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Once be2iscsi driver is loaded and operational close Boot
session established by FW.Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Check DMA memory before it is unmapped.
Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Driver was not freeing the DMA memory allocated for EQ/CQ in the
unload path. This patch frees the DMA memory during the driver unload.Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Reserve device PCI I/O and Memory resources.
Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley -
Increment the retry count to get the boot target info when
port async event is received by the driver. Update sysfs enteries
with the boot target parameters.Signed-off-by: Minh Tran
Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: James Bottomley
19 May, 2015
1 commit
-
be2iscsi change of ownership from Emulex to Avago Technologies recently. We
like to get the following updates in: changed "Emulex" to "Avago
Technologies", changed email addresses from "emulex.com" to "avagotech.com",
updated MAINTAINER list for be2iscsi driver.Signed-off-by: Minh Tran
Signed-off-by: Jayamohan Kallickal
Signed-off-by: James Bottomley
15 Apr, 2015
1 commit
-
Pull trivial tree from Jiri Kosina:
"Usual trivial tree updates. Nothing outstanding -- mostly printk()
and comment fixes and unused identifier removals"* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial:
goldfish: goldfish_tty_probe() is not using 'i' any more
powerpc: Fix comment in smu.h
qla2xxx: Fix printks in ql_log message
lib: correct link to the original source for div64_u64
si2168, tda10071, m88ds3103: Fix firmware wording
usb: storage: Fix printk in isd200_log_config()
qla2xxx: Fix printk in qla25xx_setup_mode
init/main: fix reset_device comment
ipwireless: missing assignment
goldfish: remove unreachable line of code
coredump: Fix do_coredump() comment
stacktrace.h: remove duplicate declaration task_struct
smpboot.h: Remove unused function prototype
treewide: Fix typo in printk messages
treewide: Fix typo in printk messages
mod_devicetable: fix comment for match_flags
09 Apr, 2015
1 commit
-
Kernel panic was happening as iscsi_host_remove() was called on
a host which was not yet added.Signed-off-by: John Soni Jose
Reviewed-by: Mike Christie
Cc:
Signed-off-by: James Bottomley
07 Mar, 2015
1 commit
-
This patch fix spelling typo in printk messages.
Signed-off-by: Masanari Iida
Acked-by: Randy Dunlap
Signed-off-by: Jiri Kosina
22 Feb, 2015
1 commit
-
Pull misc SCSI patches from James Bottomley:
"This is a short patch set representing a couple of left overs from the
merge window (debug removal and MAINTAINER changes).Plus one merge window regression (the local workqueue for hpsa) and a
set of bug fixes for several issues (two for scsi-mq and the rest an
assortment of long standing stuff, all cc'd to stable)"* tag 'scsi-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi:
sg: fix EWOULDBLOCK errors with scsi-mq
sg: fix unkillable I/O wait deadlock with scsi-mq
sg: fix read() error reporting
wd719x: add missing .module to wd719x_template
hpsa: correct compiler warnings introduced by hpsa-add-local-workqueue patch
fixed invalid assignment of 64bit mask to host dma_boundary for scatter gather segment boundary limit.
fcoe: Transition maintainership to Vasu
am53c974: remove left-over debugging code
16 Feb, 2015
1 commit
-
…egment boundary limit.
In reference to bug https://bugzilla.redhat.com/show_bug.cgi?id=1097141
Assert is seen with AMD cpu whenever calling pci_alloc_consistent.[ 29.406183] ------------[ cut here ]------------
[ 29.410505] kernel BUG at lib/iommu-helper.c:13!Signed-off-by: Minh Tran <minh.tran@emulex.com>
Fixes: 6733b39a1301b0b020bbcbf3295852e93e624cb1
Cc: <stable@vger.kernel.org>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
14 Feb, 2015
1 commit
-
The patch "module: fix types of device tables aliases" newly requires that
invocations ofMODULE_DEVICE_TABLE(type, name);
come *after* the definition of `name'. That is reasonable, but some
drivers weren't doing this. Fix them.Cc: James Bottomley
Cc: Andrey Ryabinin
Cc: David Miller
Cc: Hans Verkuil
Acked-by: Mauro Carvalho Chehab
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
24 Nov, 2014
2 commits
-
Drop the now unused reason argument from the ->change_queue_depth method.
Also add a return value to scsi_adjust_queue_depth, and rename it to
scsi_change_queue_depth now that it can be used as the default
->change_queue_depth implementation.Signed-off-by: Christoph Hellwig
Reviewed-by: Mike Christie
Reviewed-by: Hannes Reinecke -
All drivers use the implementation for ramping the queue up and down, so
instead of overloading the change_queue_depth method call the
implementation diretly if the driver opts into it by setting the
track_queue_depth flag in the host template.Note that a few drivers validated the new queue depth in their
change_queue_depth method, but as we never go over the queue depth
set during slave_configure or the sysfs file this isn't nessecary
and can safely be removed.Signed-off-by: Christoph Hellwig
Reviewed-by: Mike Christie
Reviewed-by: Hannes Reinecke
Reviewed-by: Venkatesh Srinivas
30 Sep, 2014
3 commits
-
Dan Carpenter found a issue where be2iscsi would copy the ip
from userspace to the driver buffer before checking the len
of the data being copied:
http://marc.info/?l=linux-scsi&m=140982651504251&w=2This patch just has us only copy what we the driver buffer
can support.Cc:
Tested-by: John Soni Jose
Signed-off-by: Mike Christie
Signed-off-by: Christoph Hellwig -
Bump the driver version
Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Signed-off-by: Christoph Hellwig -
In the reboot/shutdown path, workqueue was destroyed after the
adapter resource were freed. The task associated with workqueue
was getting executed after resources were freed. This lead to
kernel panic.Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Signed-off-by: Christoph Hellwig
17 Sep, 2014
6 commits
-
As result of deprecation of MSI-X/MSI enablement functions
pci_enable_msix() and pci_enable_msi_block() all drivers
using these two interfaces need to be updated to use the
new pci_enable_msi_range() and pci_enable_msix_range()
interfaces.Signed-off-by: Alexander Gordeev
Reviewed-by: Tomas Henzl
Acked-by: Jayamohan Kallickal
Signed-off-by: Christoph Hellwig -
Bump the driver version
Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: Christoph Hellwig -
Driver should process the completion queue entries before a connection
resources are freed. While running mixed traffic due to latency, driver
processes the CQE after the connection resources are freed. This fix
processes all the completion queue before the connection resources are
freed.Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: Christoph Hellwig -
During port async event driver should check if there is any boot target
configured on the adapter. Update sysfs enteries with the boot target
parameters.Signed-off-by: Minh Tran
Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: Christoph Hellwig -
Change the copyright year to 2014
Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: Christoph Hellwig -
commit 73af08e11c6638e2abd6b1fa13cdab58c2bbdbf8
Author: Jayamohan Kallickal
Date: Mon May 5 21:41:26 2014 -0400be2iscsi: Fix interrupt Coalescing mechanism.
Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Reviewed-by: Mike Christie
Signed-off-by: Christoph Hellwig
13 Aug, 2014
1 commit
-
We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to
meet kernel coding style guidelines. This issue was reported by checkpatch.A simplified version of the semantic patch that makes this change is as
follows (http://coccinelle.lip6.fr/)://
@@
identifier i;
declarer name DEFINE_PCI_DEVICE_TABLE;
initializer z;
@@- DEFINE_PCI_DEVICE_TABLE(i)
+ const struct pci_device_id i[]
= z;//
[bhelgaas: add semantic patch]
Signed-off-by: Benoit Taine
Signed-off-by: Bjorn Helgaas
09 Aug, 2014
1 commit
-
Remove the now unnecessary memset too.
Signed-off-by: Joe Perches
Cc: Adam Radford
Cc: "James E.J. Bottomley"
Cc: Jayamohan Kallickal
Cc: Dario Ballabio
Cc: Michael Neuffer
Cc: "Stephen M. Cameron"
Cc: Neela Syam Kolli
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
26 Jul, 2014
2 commits
-
The if_info pointer is not released by the mgmt_set_ip() function
Signed-off-by: Maurizio Lombardi
Reviewed-by: Tomas Henzl
Signed-off-by: Christoph Hellwig -
The custom stats is an array with custom_length indicating the length
of the array. This patch fixes bnx2i and be2iscsi's setting of the
custom stats length. They both just have the one, eh_abort_cnt, so that should
be in the first entry of the custom array and custom_length should then
be one.Reported-by: Rickard Strandqvist
Signed-off-by: Mike Christie
Acked-by: Vikas Chaudhary
Acked-by: Eddie Wai
Signed-off-by: Christoph Hellwig
25 Jun, 2014
2 commits
-
commit 0e7c60c [SCSI] be2iscsi: fix memory leak in error path
fixed an potential junk pointer free if mgmt_get_if_info() returned an errorfix it on one more place
Signed-off-by: Tomas Henzl
Reviewed-by: Mike Christie
Signed-off-by: Christoph Hellwig -
a jump to 'free_memory' is apparently missing
Signed-off-by: Tomas Henzl
Reviewed-by: Mike Christie
Signed-off-by: Christoph Hellwig
02 Jun, 2014
1 commit
-
This reverts commit 11206081ad895d83e717bfe23603168dc307d904.
Based on comments from Mike Christie and Sony John-N.
29 May, 2014
1 commit
-
Bumping the driver version.
Signed-off-by: John Soni Jose
Signed-off-by: Jayamohan Kallickal
Signed-off-by: Christoph Hellwig