07 Apr, 2009

1 commit

  • PCI parallel port devices can IRQ share so we should stop them hogging
    the line and making a mess on modern PC systems. We know the sharing
    side works as the PCMCIA driver has shared the parallel port IRQ for
    some time.

    Signed-off-by: Alan Cox
    Signed-off-by: Linus Torvalds

    Alan Cox
     

03 Apr, 2009

1 commit

  • netmos serial/parallel adapters come in different flavour differing only
    by the number of parallel and serial ports, which are encoded in the
    subdevice ID.

    Last fix of Christian Pellegrin for 9855 2P2S broke support for 9855 1P4S,
    and works only by side-effect for the first parallel port of a 2P2S, as
    this first parallel port is found by reading the second addr entry of
    (struct parport_pc_pci) cards[netmos_9855], which is not initialized, and
    hence has value 0, which happens to be the BAR of the first parallel port.

    netmos_9xx5_combo entry in (struct parport_pc_pci) cards[], which is used
    for a 9845 1P4S must also be fixed for the parallel port support when
    there are 4 serial ports because this entry currently gives 2 as BAR index
    for the parallel port. Actually, in this case, BAR 2 is the 3rd serial
    port while the parallel port is at BAR 4.

    I fixed 9845 1P4S and 9855 1P4S support, while preserving 9855 2P2S support,

    - by creating a netmos_9855_2p entry and using it for 9855 boards with 2
    parallel ports : 9855 2P2S and 9855 2P0S boards,

    - and by allowing netmos_parallel_init to change not only the number of
    parallel ports (0 or 1), but making it also change the BAR index of the
    parallel port when the serial ports are before the parallel port.

    PS: the netmos_9855_2p entry in (struct pciserial_board)
    pci_parport_serial_boards[] is needed because netmos_parallel_init has no
    clean way to replace FL_BASE2 by FL_BASE4 in the description of the serial
    ports in function of the number of parallel ports on the card.

    Tested with 9845 1P4S, 9855 1P4S and 9855 2P2S boards.

    Signed-off-by: Philippe De Muyter
    Tested-by: Christian Pellegrin
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Philippe De Muyter
     

12 Feb, 2009

1 commit

  • Since netmos 9835 with subids 0x1014(IBM):0x0299 is now bound with
    serial/8250_pci, because it has no parallel ports and subdevice id isn't
    in the expected form, return -ENODEV from probe function.

    This is performed in netmos preinit_hook.

    Signed-off-by: Jiri Slaby
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jiri Slaby
     

02 Dec, 2008

1 commit

  • The netmos_9xx5_combo type assumes that PCI SSID provides always the
    correct value for the number of parallel and serial ports, but there are
    indeed broken devices with wrong numbers, which may result in Oops.

    This patch simply adds the check of the array range.

    Reference: Novell bnc#447067
    https://bugzilla.novell.com/show_bug.cgi?id=447067

    Signed-off-by: Takashi Iwai
    Cc:
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Takashi Iwai
     

07 Feb, 2008

1 commit

  • Fix wrong netmos 9855 serial port configuration.

    On loading only one serial port was present and it wasn't working. After
    looking in the data sheet I realized that the base address was wrong. For
    further reference here is lspci and relevant dmesg output:

    02:00.0 Communication controller: NetMos Technology PCI 9855 Multi-I/O
    Controller (rev 01) (prog-if 02)
    Subsystem: LSI Logic / Symbios Logic Unknown device 0022
    Flags: medium devsel, IRQ 19
    I/O ports at df00 [size=8]
    I/O ports at de00 [size=8]
    I/O ports at dd00 [size=8]
    I/O ports at dc00 [size=8]
    I/O ports at db00 [size=8]
    I/O ports at da00 [size=16]

    parport1: PC-style at 0xdd00 [PCSPP,TRISTATE]
    parport2: PC-style at 0xdf00 [PCSPP,TRISTATE,EPP]
    0000:02:00.0: ttyS0 at I/O 0xdb00 (irq = 19) is a 16550A
    0000:02:00.0: ttyS1 at I/O 0xda00 (irq = 19) is a 16550A

    Signed-off-by: Christian Pellegrin
    Cc: Thomas Richter
    Cc: Bjorn Helgaas
    Cc: Martin Schitter
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Christian Pellegrin
     

20 Jul, 2007

1 commit

  • Transform some calls to kmalloc/memset to a single kzalloc (or kcalloc).

    Here is a short excerpt of the semantic patch performing
    this transformation:

    @@
    type T2;
    expression x;
    identifier f,fld;
    expression E;
    expression E1,E2;
    expression e1,e2,e3,y;
    statement S;
    @@

    x =
    - kmalloc
    + kzalloc
    (E1,E2)
    ... when != \(x->fld=E;\|y=f(...,x,...);\|f(...,x,...);\|x=E;\|while(...) S\|for(e1;e2;e3) S\)
    - memset((T2)x,0,E1);

    @@
    expression E1,E2,E3;
    @@

    - kzalloc(E1 * E2,E3)
    + kcalloc(E1,E2,E3)

    [akpm@linux-foundation.org: get kcalloc args the right way around]
    Signed-off-by: Yoann Padioleau
    Cc: Richard Henderson
    Cc: Ivan Kokshaysky
    Acked-by: Russell King
    Cc: Bryan Wu
    Acked-by: Jiri Slaby
    Cc: Dave Airlie
    Acked-by: Roland Dreier
    Cc: Jiri Kosina
    Acked-by: Dmitry Torokhov
    Cc: Benjamin Herrenschmidt
    Acked-by: Mauro Carvalho Chehab
    Acked-by: Pierre Ossman
    Cc: Jeff Garzik
    Cc: "David S. Miller"
    Acked-by: Greg KH
    Cc: James Bottomley
    Cc: "Antonino A. Daplas"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Yoann Padioleau
     

09 May, 2007

2 commits

  • drivers/parport/parport_serial.c:402: warning: ignoring return value of 'pci_enable_device', declared with attribute warn_unused_result

    Signed-off-by: Randy Dunlap
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Randy Dunlap
     
  • Currently a parport_driver can't get a handle on the device node for the
    underlying parport (PNPACPI, PCI, etc). That prevents correct placement of
    sysfs child nodes, which can affect things like power management.

    This patch adds a field to "struct parport" pointing to that device node, and
    updates non-legacy port drivers to initialize that device pointer. That field
    replaces the analagous PCI-only support in parport_pc.

    [akpm@linux-foundation.org: fix powerpc build]
    Signed-off-by: David Brownell
    Cc: Paul Mackerras
    Cc: Benjamin Herrenschmidt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Brownell
     

30 Sep, 2006

1 commit


11 Apr, 2006

1 commit


21 Mar, 2006

1 commit


06 Mar, 2006

1 commit

  • Steinar H. Gunderson reported:

    - For some reason, it detects the 9845 as a 9735 -- it appears this is
    simply related to the ordering in parport_serial_pci_tbl[]. If we move
    the 9845 up above the 9735, it prints out 9710:9845, but no change in
    behaviour. (We didn't find out why this was the case; we left it alone
    since it didn't affect our problem.)
    - The card has no parallel port (at least no physical ones), yet it reports
    (via its subsystem ID of 0x0014) one parallel port and four serial ports.
    The probe for the parallel port fails, and the driver just aborts. Thus,
    it doesn't find the serial ports.

    Fix the debugging code to use dev_dbg, but don't bother displaying the
    PCI ID of the detected board (that's accessible via other means.)

    Also, arrange for parport_register() to return 0 even if it finds no
    ports.

    Signed-off-by: Russell King

    Russell King
     

04 Feb, 2006

1 commit


10 Jan, 2006

1 commit


27 Jul, 2005

1 commit


24 Jun, 2005

1 commit

  • kernel 2.6.12-rc2 adopted some code by Bjorn Helgaas supporting NetMos combo
    controller cards. this implementation doesn't work for nm9855 based cards!

    there are two reasons:

    a) the module 'parport_pc' doesn't want to give the resonsibility for
    the netmos_9855 to 'parport_serial' and can not handle the serial lines
    -- trivial to fix...

    http://lists.infradead.org/pipermail/linux-parport/2005-February/000250.html
    http://lkml.org/lkml/2005/3/24/199 b) the support for the nm9855 in

    'parport_serial' still doesn't work because of wrong assumptions about
    the relevant BARs port address layout for this chip:

    0000:00:09.0 Communication controller:
    NetMos Technology PCI 9855
    Multi-I/O Controller (rev 01)
    (= 9710:9855)
    Subsystem: LSI Logic / Symbios Logic 1P4S (= 1000:0014)
    Flags: medium devsel, IRQ 177
    I/O ports at a800 [size=8] (= parport)
    I/O ports at a400 [size=8]
    I/O ports at a000 [size=8] (= serial)
    I/O ports at 9800 [size=8] (= serial)
    I/O ports at 9400 [size=8] (= serial)
    I/O ports at 9000 [size=16] (= serial)

    the following patch will fix the problem.

    Cc: Bjorn Helgaas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Martin Schitter
     

17 Apr, 2005

1 commit

  • Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds