Eric Lee / smarc-fsl-linux-kernel

07 Feb, 2008

16 commits

  • 5beec4aa2   spi: remove more dev->power.power_state usage ... Browse Code »

    Remove some more references to dev->power.power_state. That field is overdue
    for removal, but we can't do that while it's still referenced in the kernel.
    The only reason to update it was to make the /sys/devices/.../power/state
    files (now removed) work better.

    Signed-off-by: David Brownell
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Brownell
     
  • 26fdc1f0d   spi_bfin: headers are not for changelogs ... Browse Code »

    Use simpler comment headers, and strip out information that is maintained in
    GIT history

    Signed-off-by: Mike Frysinger
    Signed-off-by: Bryan Wu
    Signed-off-by: David Brownell
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Mike Frysinger
     
  • 13f3e642b   spi_bfin: wait for tx to complete on write paths ... Browse Code »

    SPI writes should also not return until the last bit is sent.

    Signed-off-by: Sonic Zhang
    Signed-off-by: Bryan Wu
    Signed-off-by: David Brownell
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Sonic Zhang
     
  • 4fd432d9c   spi_bfin: wait for tx to complete on full duplex paths ... Browse Code »

    Full duplex SPI operation should not read a dummy byte at the first transfer.
    Bug and fix by Jean-Christian de Rivaz :

    http://blackfin.uclinux.org/gf/project/uclinux-dist/tracker/?action=TrackerItemEdit&tracker_item_id=3678

    Signed-off-by: Jean-Christian de Rivaz
    Signed-off-by: Bryan Wu
    Signed-off-by: David Brownell
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Bryan Wu
     
  • e26aa015d   spi_bfin: wait for tx to complete on some cs_chg paths ... Browse Code »

    PBX 2 SPI devices need the nonstandard "cs change per word" mechanism.

    This patch is one of three updating this driver to make the last data bits get
    sent before advancing the transfer ... in this case, before the chipselect
    gets deactivated.

    Signed-off-by: Bryan Wu
    Signed-off-by: David Brownell
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Bryan Wu
     
  • aab0d83ee   spi_bfin: use more useful GPIO labels ... Browse Code »

    Use the SPI driver's name when requesting gpio lines. When there are gpio
    conflicts, this helps to narrow down the problems; "bfin-spi" is not
    informative.

    Signed-off-by: Bryan Wu
    Signed-off-by: David Brownell
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Bryan Wu
     
  • 8d20d0a7c   spi_bfin: remove useless fault path ... Browse Code »

    Remove useless return status check in restore_state function. Issue was
    pointed out by Michael.

    Cc: Michael Hennerich
    Signed-off-by: Bryan Wu
    Signed-off-by: David Brownell
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Bryan Wu
     
  • ccc7baed1   spi: omap2_mcspi handles omap3 too ... Browse Code »

    This adds driver OMAP SPI specific changes to support OMAP 3430

    Signed-off-by: Girish S G
    Signed-off-by: David Brownell
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Girish
     
  • 37e466408   spi: SuperH SPI using SCI ... Browse Code »

    Add support for SPI over SCI pins. SCI is a very simple serial controller
    block that can be found on older SuperH processors. In theory it is
    possible to use the SCI hardware block in syncronous mode, but this version
    of the driver simply hooks up the bit banging code on the SCI pins.

    Signed-off-by: Magnus Damm
    Signed-off-by: David Brownell
    Cc: Paul Mundt
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Magnus Damm
     
  • b359fbc45   spi: s3c drivers shouldn't care about spi_board_info ... Browse Code »

    The two S3C SPI master drivers got merged without much review, so I just
    noticed that they're doing something that the SPI core code is responsible
    for, rather than any adapter driver: they try to register SPI devices.

    This removes that support from those drivers so they act normally.
    Interestingly, none of the current boards are affected. So it's a net code
    shrink with no loss of functionality.

    Signed-off-by: David Brownell
    Cc: Ben Dooks
    Cc: Russell King
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Brownell
     
  • 8bacb2190   atmel_spi: fix dmachain oops with DEBUG enabled ... Browse Code »

    In atmel_spi_next_xfer, xfer can be NULL because the next transfer may
    already have been submitted to the PDC (using DMA chaining). This can
    cause an oops, since the debug message assumed it was never null. The
    fix changes how those debug messages are issued, ensuring that one is
    issued each time a transfer is started instead of once per call.

    Also, properly indent the "can this transfer be chained" test so it's
    not hidden as if it were non-conditional code.

    Signed-off-by: Haavard Skinnemoen
    Signed-off-by: David Brownell
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Haavard Skinnemoen
     
  • 154443c72   atmel_spi: chain DMA transfers ... Browse Code »

    Add support for chained transfers in the atmel_spi driver, letting the DMA
    controller switch to the next buffer pair without CPU intervention. This
    reduced I/O latencies by about 2% in one bulk I/O test. It should also help
    work around several interrelated errata affecting chipselect 0 on at91rm9200
    chips.

    Almost all of the changes are in the reworked atmel_spi_next_xfer() function.
    That's now called with the driver in one of three states:

    1. It isn't transferring anything (in which case the first transfer
    of the current message is going to be sent)
    2. It has finished transfering a non-chainable transfer (in which
    case it will go to the next transfer in the message)
    3. It has finished transfering a chained transfer (in which case the
    next transfer is already queued)

    After that it will queue the next transfer if it can be chained.

    Signed-off-by: Szilveszter Ordog
    Acked-by: Haavard Skinnemoen
    Signed-off-by: David Brownell
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Silvester Erdeg
     
  • 1eed29df4   atmel_spi throughput improvement ... Browse Code »

    Don't insert (undesirable) delays between consecutive words (DLYBCT) or when
    activating chipselects (DLYBS).

    Removing the between-word delays improves the performance of bulk transfers
    (such as mtd_dataflash, m25p80, mmc_spi) significantly. In one test, the
    improvement was a factor of more than eight!

    (The large DLYBCT value came from the legacy at91 SPI driver, and it's not
    clear why it used such a huge value.)

    Signed-off-by: Haavard Skinnemoen
    Signed-off-by: David Brownell
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Haavard Skinnemoen
     
  • 3c72426f0   spi core: stop updating dev->power.power_state ... Browse Code »

    Don't update dev->power.power_state any more in the SPI core. The only
    reason to update this scheduled-to-be-removed field was to make the
    already-removed /sys/devices/.../power/state files work better.

    Signed-off-by: David Brownell
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Brownell
     
  • 15aafa2f9   Remove pointless casts from void pointers ... Browse Code »

    Mostly in and around irq handlers.

    Signed-off-by: Jeff Garzik
    Cc: Russell King
    Cc: "Luck Tony"
    Cc: Roman Zippel
    Cc: Geert Uytterhoeven
    Cc: Paul Mackerras
    Cc: Benjamin Herrenschmidt
    Acked-by: Dmitry Torokhov
    Cc: Karsten Keil
    Acked-by: "John W. Linville"
    Cc: James Bottomley
    Cc: David Brownell
    Cc: "Antonino A. Daplas"
    Acked-by: Josh Boyer
    Acked-by: Holger Schurig
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jeff Garzik
     
  • 911f21501   Remove inclusions of <linux/autoconf.h> ... Browse Code »

    Nothing should ever include this file.

    Signed-off-by: Ralf Baechle
    Acked-by: "Mike Frysinger"
    Acked-by: "Bryan Wu"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Ralf Baechle
     

03 Feb, 2008

1 commit

31 Jan, 2008

2 commits

28 Jan, 2008

1 commit

27 Jan, 2008

2 commits

  • 4fb4c5582   [POWERPC] mpc52xx_psc_spi device driver must not touch port_config and cdm ... Browse Code »

    It is dangerous for an mpc52xx device driver to modify the port_config
    register. If the driver is probed incorrectly, it will change the pin
    IO configuration in ways which may not be compatible with the board.
    port_config should be set up by the bootloader, or failing that, in
    the platform setup code in arch/powerpc/platforms/52xx.

    Also, modifying CDM registers directly can cause a race condition with
    other drivers. Instead call a common routine to modify CDM settings.

    Signed-off-by: Grant Likely
    Acked-by: Dragos Carp

    Grant Likely
     
  • 66ffbe490   [POWERPC] mpc5200: normalize compatible property bindings ... Browse Code »

    Update MPC5200 drivers to also look for compatible properties in the
    form "fsl,mpc5200-*" to better conform to open firmware generic names
    recommended practice as published here:

    http://www.openfirmware.org/1275/practice/gnames/gnamv14a.html

    This patch should *not* break compatibility with older device trees
    which do not use the 'fsl,' prefix. The drivers will still bind against
    the older names also.

    Signed-off-by: Grant Likely

    Grant Likely
     

26 Jan, 2008

2 commits

25 Jan, 2008

2 commits

  • 5ed2c832e   spi: use class iteration api ... Browse Code »

    Convert to use the class iteration api.

    Signed-off-by: Dave Young
    Acked-by: David Brownell
    Signed-off-by: Greg Kroah-Hartman

    Dave Young
     
  • feed9bab7   spi: omap2_mcspi PIO RX fix ... Browse Code »

    Before transmission of the last word in PIO RX_ONLY mode rx+tx mode
    is enabled:

    /* prevent last RX_ONLY read from triggering
    * more word i/o: switch to rx+tx
    */
    if (c == 0 && tx == NULL)
    mcspi_write_cs_reg(spi,
    OMAP2_MCSPI_CHCONF0, l);

    But because c is decremented after the test, c will never be zero and
    rx+tx will not be enabled. This breaks RX_ONLY mode PIO transfers.

    Fix it by decrementing c in the beginning of the various I/O loops.

    Signed-off-by: Kalle Valo
    Signed-off-by: David Brownell
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Kalle Valo
     

24 Jan, 2008

1 commit

19 Jan, 2008

1 commit

09 Jan, 2008

1 commit

11 Dec, 2007

4 commits

  • d84248bf4   atmel_spi: reload RCR before TCR ... Browse Code »

    We have a wifi module connected to the spi bus and got sometimes FIFO
    overrun errors on the spi bus.

    After some investigation i found that the driver loads the TCR (transmit
    count) register before the RCR (receive count). When the transfer list is
    not empty the atmel_spi_next_message is called while tx and rx are enabled.
    As soon as the TCR is loaded, hardware starts transfer and causes a rx
    fifo overrun because the RCR is not loaded yet.

    Load the RCR before the TCR. After this patch the fifo overrun disapears
    at out setup.

    Signed-off-by: Haavard Skinnemoen
    Signed-off-by: Rini van Zetten
    Signed-off-by: David Brownell
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Rini van Zetten
     
  • 8805f2387   spi_imx: fix typo in description ... Browse Code »

    Signed-off-by: Will Newton
    Signed-off-by: David Brownell
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Will Newton
     
  • 6b1a80283   spi_bfin5xx: fix typo in description ... Browse Code »

    Signed-off-by: Will Newton
    Signed-off-by: David Brownell
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Will Newton
     
  • 037cdafe4   pxa2xx_spi: fix typo in description ... Browse Code »

    Signed-off-by: Will Newton
    Signed-off-by: David Brownell
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Will Newton
     

06 Dec, 2007

7 commits