25 Jun, 2006
2 commits
-
We have had no use of the coredump file for a long time.
So just exit(1) and avoid coredumping.Signed-off-by: Sam Ravnborg
-
Signed-off-by: Al Viro
Signed-off-by: Sam Ravnborg
17 Jun, 2006
1 commit
-
read_dump didn't split lines between module name and export type.
Signed-off-by: Laurent Riffard
Signed-off-by: Sam Ravnborg
10 Jun, 2006
3 commits
-
scripts/mod/modpost.c: In function `check_license':
scripts/mod/modpost.c:1094: parse error before `const'
scripts/mod/modpost.c:1095: `basename' undeclared (first use in this function)
scripts/mod/modpost.c:1095: (Each undeclared identifier is reported only once
scripts/mod/modpost.c:1095: for each function it appears in.)Signed-off-by: Andrew Morton
Signed-off-by: Sam Ravnborg -
Modules that uses GPL symbols can no longer be build with kbuild,
the build will fail during the modpost step.
When a GPL-incompatible module uses a EXPORT_SYMBOL_GPL_FUTURE symbol
then warn during modpost so author are actually notified.The actual license compatibility check is shared with the kernel
to make sure it is in sync.Patch originally from: Andreas Gruenbacher and
Ram PaiSigned-off-by: Sam Ravnborg
-
This patch provides the ability to identify the export-type of each
exported symbols in Module.symvers.NOTE: It updates the Module.symvers file with the additional
information as shown below.0x0f8b92af platform_device_add_resources vmlinux EXPORT_SYMBOL_GPL
0xcf7efb2a ethtool_op_set_tx_csum vmlinux EXPORT_SYMBOLSigned-off-by: Andreas Gruenbacher
Signed-off-by: Ram Pai
Signed-off-by: Avantika Mathur
Signed-off-by: Valdis Kletnieks
Signed-off-by: Andrew Morton
Signed-off-by: Sam Ravnborg
09 Jun, 2006
2 commits
-
Ignoring references to .init.text, .exit.text from the .plt section brought
the false positives down to two warnings for a defconfig build of ARCH=um
on x86_64.Signed-off-by: Sam Ravnborg
-
Add ".smp_locks" section to whitelist as being safe from
init and exit sections.Signed-off-by: Randy Dunlap
Signed-off-by: Sam Ravnborg
22 May, 2006
2 commits
-
Here is an updated r_info layout fix. Please apply "check SHT_REL
sections" patch before this.64bit mips has different r_info layout. This patch fixes modpost
segfault for 64bit little endian mips kernel.Signed-off-by: Atsushi Nemoto
Cc: Sam Ravnborg
Cc: Ralf Baechle
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
I found that modpost can not detect section mismatch on mips and i386. On
mips64, the modpost (with r_info layout fix) can detect it. The current
modpst only checks SHT_RELA section but I suppose SHT_REL section should be
checked also. This patch does not contain r_info layout fix. I'll post an
updated r_info layout fix on next mail.Check SHT_REL sections as like as SHT_RELA sections to detect section
mismatch.Signed-off-by: Atsushi Nemoto
Cc: Sam Ravnborg
Cc: Ralf Baechle
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
09 May, 2006
2 commits
-
This reverts commit c8d8b837ebe4b4f11e1b0c4a2bdc358c697692ed, which
caused problems for the x86 build. Quoth Sam:"It was discussed on mips list but apparently the fix was bogus. I
will not have time to look into it so mips can carry this local fix
until we get a proper fix in mainline."Signed-off-by: Linus Torvalds
-
* git://git.kernel.org/pub/scm/linux/kernel/git/sam/kbuild:
kbuild: Do not overwrite makefile as anohter user
kbuild: drivers/video/logo/ - fix ident glitch
kbuild: fix gen_initramfs_list.sh
kbuild modpost - relax driver data name
kbuild: removing .tmp_versions considered harmful
kbuild: fix modpost segfault for 64bit mipsel kernel
01 May, 2006
2 commits
-
Relax driver data name from *_driver to *driver.
This fixes the 26 section mismatch warnings in drivers/ide/pci.Signed-off-by: Randy Dunlap
Signed-off-by: Sam Ravnborg -
64bit mips has different r_info layout. This patch fixes modpost
segfault for 64bit little endian mips kernel.Signed-off-by: Atsushi Nemoto
Signed-off-by: Sam Ravnborg
29 Apr, 2006
1 commit
26 Apr, 2006
1 commit
-
Signed-off-by: Dmitry Torokhov
15 Apr, 2006
1 commit
-
Darren Jenkins pointed out a
number of false positives where we referenced variables
from a _driver variable.
Fix it by check for that pattern and ignore it.Randy.Dunlap pointed out a similar
set of warnings for a number of scsi drivers.
In scsi world they misname their variables *_template or
*_sht so add these to list of variables that may have references
to .init.text with no warning.Randy.Dunlap also pointed out a scsi driver
with many references to .exit.text from .rodata. This is compiler
generated references and we already ignore these for .init.text, so
ignore them for .exit.text also.Signed-off-by: Sam Ravnborg
11 Apr, 2006
1 commit
-
before is NULL in this case, concluding from the surrounding code
it seems that after is the right one to use.Signed-off-by: Eric Sesterhenn
Signed-off-by: Sam Ravnborg
26 Mar, 2006
1 commit
-
* master.kernel.org:/pub/scm/linux/kernel/git/sam/kbuild: (46 commits)
kbuild: remove obsoleted scripts/reference_* files
kbuild: fix make help & make *pkg
kconfig: fix time ordering of writes to .kconfig.d and include/linux/autoconf.h
Kconfig: remove the CONFIG_CC_ALIGN_* options
kbuild: add -fverbose-asm to i386 Makefile
kbuild: clean-up genksyms
kbuild: Lindent genksyms.c
kbuild: fix genksyms build error
kbuild: in makefile.txt note that Makefile is preferred name for kbuild files
kbuild: replace PHONY with FORCE
kbuild: Fix bug in crc symbol generating of kernel and modules
kbuild: change kbuild to not rely on incorrect GNU make behavior
kbuild: when warning symbols exported twice now tell user this is the problem
kbuild: fix make dir/file.xx when asm symlink is missing
kbuild: in the section mismatch check try harder to find symbols
kbuild: fix section mismatch check for unwind on IA64
kbuild: kill false positives from section mismatch warnings for powerpc
kbuild: kill trailing whitespace in modpost & friends
kbuild: small update of allnoconfig description
kbuild: make namespace.pl CROSS_COMPILE happy
...Trivial conflict in arch/ppc/boot/Makefile manually fixed up
17 Mar, 2006
1 commit
-
Jiri Benc reported that modpost would stop with SIGABRT if
used with long filepaths.
The error looked like:
> Building modules, stage 2.
> MODPOST
> *** glibc detected *** scripts/mod/modpost: realloc(): invalid next size:
+0x0809f588 ***
> [...]Fix this by allocating at least the required memory + SZ bytes each time.
Before we sometimes ended up allocating too little memory resuting in the
glibc detected bug above. Based on patch originally submitted by: Jiri
BencSigned-off-by: Sam Ravnborg
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
09 Mar, 2006
1 commit
-
The scripts/genksyms/genksyms.c uses hardcoded "__crc_" prefix for
crc symbols in kernel and modules. The prefix should be replaced by
"MODULE_SYMBOL_PREFIX##__crc_" otherwise there will be warnings when
MODULE_SYMBOL_PREFIX is not NULL.I am sorry my last patch for this issue is actually wrong. I revert
it in this patch.Signed-off-by: Luke Yang
Signed-off-by: Sam Ravnborg
07 Mar, 2006
1 commit
-
Fix matching of devmodel in modaliases. It breaks automatic loading of any
dasd module.Cc: Heiko Carstens
Cc: Martin Schwidefsky
Acked-by: Cornelia Huck
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
05 Mar, 2006
4 commits
-
Warning now looks like this:
WARNING: vmlinux: 'strcpy' exported twice. Previous export was in vmlinuxWhich gives much better hint how to fix it.
Signed-off-by: Sam Ravnborg
-
When searching for symbols the only check performed was if
offset equals st_value. Adding an additional check to see if st_name
points t a valid name made us sort out a few more false positives and
let us report more correct names in warnings.Signed-off-by: Sam Ravnborg
-
Parameters to strstr() was reversed.
Signed-off-by: Sam Ravnborg
-
Building an allmodconfig kernel for ppc64 revealed a number of false
positives - originally reported by Andrew Morton.
This patch removes most if not all false positives for ppc64:Section .opd
The .opd section contains function descriptors at least for ppc64.
So ignore it for .init.text (was ignored for .exit.text).
See description of function descriptors here:
http://www.linuxbase.org/spec/ELF/ppc64/PPC-elf64abi-1.7.htmlSection .toc1
ppc64 places some static variables in .toc1 - ignore the.Section __bug_tabe
BUG() and friends uses __bug_table. Ignore warnings from that section.Module parameters are placed in .data.rel for ppc64, for adjust pattern to
match on section named .data*Tested with gcc: 3.4.0 and binutils 2.15.90.0.3
Signed-off-by: Sam Ravnborg
03 Mar, 2006
1 commit
-
Signed-off-by: Sam Ravnborg
27 Feb, 2006
2 commits
-
In several cases the section mismatch check triggered false warnings.
Following patch introduce a whitelist to 'false positives' are not warned of.
Two types of patterns are recognised:
1) Typical case when a module parameter is _initdata
2) When a function pointer is assigned to a driver structureIn both patterns we rely on the actual name of the variable assigned
Signed-off-by: Sam Ravnborg
-
It seems popular to protect your work with copyright, so I decided to do
so for modpost which I patch a great deal atm.Signed-off-by: Sam Ravnborg
23 Feb, 2006
2 commits
-
Andrew Morton reported a number of false positives for ia64 - like these:
WARNING: drivers/acpi/button.o - Section mismatch: reference to .init.text: from .IA_64.unwind.init.text after '' (at offset 0x0)
WARNING: drivers/acpi/button.o - Section mismatch: reference to .exit.text: from .IA_64.unwind.exit.text after '' (at offset 0x0)
WARNING: drivers/acpi/processor.o - Section mismatch: reference to .init.text: from .IA_64.unwind after '' (at offset 0x1e8)They are all false positives - or at least the .c code looks OK.
It is not known why sometimes a section name is appended and sometimes not.Fix is to accept references from all sections that includes "unwind." in the name.
Signed-off-by: Sam Ravnborg
-
The kernel now requires that CC be 3.1.0 or higher. But we shouldn't place
that requirement upon HOSTCC unless we really need to. Fixes my ia64 problem.Signed-off-by: Andrew Morton
Signed-off-by: Sam Ravnborg
19 Feb, 2006
8 commits
-
Try to look up the symbol that is referenced. Include the symbol
name in the warning message.Signed-off-by: Sam Ravnborg
-
Do not try to look up section name until we know it is not a special
section. Otherwise we will address outside legal space and segfault.Signed-off-by: Sam Ravnborg
-
A combination of calling modpost with option -a and MODVERDIR undefined
caused segmentation fault. So provide a default value and accept the
error messages it generates instead.Signed-off-by: Sam Ravnborg
-
Section mismatch is identified as references to .init*
sections from non .init sections. And likewise references
to .exit.* sections outside .exit sections..init.* sections are discarded after a module is initialized
and references to .init.* sections are oops candidates.
.exit.* sections are discarded when a module is built-in and
thus references to .exit are also oops candidates.The checks were possible to do using 'make buildcheck' which
called the two perl scripts: reference_discarded.pl and
reference_init.pl. This patch just moves the same functionality
inside modpost and the scripts are then obsoleted.
They will though be kept for a while so users can do double
checks - but note that some .o files are skipped by the perl scripts
so result is not 1:1.
All credit for the concept goes to Keith Owens who implemented
the original perl scrips - this patch just moves it to modpost.Compared to the perl script the implmentation in modpost will be run
for each kernel build - thus catching the error much sooner, but
the downside is that the individual .o file are not always identified.Signed-off-by: Sam Ravnborg
-
In modpost introduce a check for symbols exported twice.
This check caught only one victim (inet_bind_bucket_create) for
which a patch is already sent to netdev.Signed-off-by: Sam Ravnborg
-
With following patch a second option is enabled to obtain
symbol information from a second external module when a
external module is build.
The recommended approach is to use a common kbuild file but
that may be impractical in certain cases.
With this patch one can copy over a Module.symvers from one
external module to make symbols (and symbol versions) available
for another external module.Updated documentation in Documentation/kbuild/modules.txt
Signed-off-by: Sam Ravnborg
-
Just some light CodingStyle updates - no functional changes.
Signed-off-by: Sam Ravnborg
-
modpost.c provides warn() and fatal() - so use them all over the place.
Signed-off-by: Sam Ravnborg
09 Jan, 2006
1 commit
-
SND_MAX should be FF_MAX
Signed-off-by: Brian Gerst
Signed-off-by: Sam Ravnborg
