19 Aug, 2020

1 commit


26 Jun, 2020

2 commits


21 Apr, 2020

1 commit


16 Feb, 2020

1 commit


01 Jan, 2020

1 commit


25 Nov, 2019

1 commit


03 Nov, 2019

1 commit


23 Jul, 2019

1 commit


25 May, 2019

2 commits

  • While it can be slightly beneficial for the build performance to use
    forward declarations instead of includes, the handling of them together
    with changes in the included headers makes it unnecessary complicated and
    fragile. Just replace them with actual includes since some parts (hwmon,
    ..) of the kernel even request avoidance of forward declarations and net/
    is mostly not using them in *.c file.

    Signed-off-by: Sven Eckelmann
    Signed-off-by: Simon Wunderlich

    Sven Eckelmann
     
  • main.h is using atomic_add_unless and log.h atomic_read. The main
    header linux/atomic.h should be included for these files.

    Signed-off-by: Sven Eckelmann
    Signed-off-by: Simon Wunderlich

    Sven Eckelmann
     

22 May, 2019

1 commit


10 May, 2019

1 commit


06 May, 2019

1 commit


25 Mar, 2019

2 commits

  • The sysfs files will be marked as deprecated in the near future. They are
    already replaced by the batadv generic netlink family. Add an Kconfig
    option to disable the sysfs support for users who want to test their tools
    or want to safe some space. This setting should currently still be enabled
    by default to keep backward compatible with legacy tools.

    Signed-off-by: Sven Eckelmann
    Signed-off-by: Simon Wunderlich

    Sven Eckelmann
     
  • All files got a SPDX-License-Identifier with commit 7db7d9f369a4
    ("batman-adv: Add SPDX license identifier above copyright header"). All the
    required information about the license conditions can be found in
    LICENSES/.

    Signed-off-by: Sven Eckelmann
    Signed-off-by: Simon Wunderlich

    Sven Eckelmann
     

04 Jan, 2019

1 commit


30 Dec, 2018

1 commit


12 Nov, 2018

2 commits

  • The netlink dump functionality transfers a large number of entries from the
    kernel to userspace. It is rather likely that the transfer has to
    interrupted and later continued. During that time, it can happen that
    either new entries are added or removed. The userspace could than either
    receive some entries multiple times or miss entries.

    Commit 670dc2833d14 ("netlink: advertise incomplete dumps") introduced a
    mechanism to inform userspace about this problem. Userspace can then decide
    whether it is necessary or not to retry dumping the information again.

    The netlink dump functions have to be switched to exclusive locks to avoid
    changes while the current message is prepared. And an external generation
    sequence counter is introduced which tracks all modifications of the list.

    Reported-by: Matthias Schiffer
    Signed-off-by: Sven Eckelmann
    Signed-off-by: Simon Wunderlich

    Sven Eckelmann
     
  • Signed-off-by: Simon Wunderlich

    Simon Wunderlich
     

14 Sep, 2018

1 commit


22 Apr, 2018

1 commit


27 Feb, 2018

3 commits


22 Dec, 2017

2 commits

  • The header file is used by different userspace programs to inject packets
    or to decode sniffed packets. It should therefore be available to them as
    userspace header.

    Also other components in the kernel (like the flow dissector) require
    access to the packet definitions to be able to decode ETH_P_BATMAN ethernet
    packets.

    Signed-off-by: Sven Eckelmann
    Signed-off-by: David S. Miller

    Sven Eckelmann
     
  • The headers used by packet.h should also be included by it directly. main.h
    is currently dealing with it in batman-adv, but this will no longer work
    when this header is moved to include/uapi/linux/.

    Signed-off-by: Sven Eckelmann
    Signed-off-by: David S. Miller

    Sven Eckelmann
     

16 Dec, 2017

4 commits

  • Externally visible functions should be documented with kernel-doc. This
    usually refers to non-static functions but also static inline files in
    headers are visible in other files and should therefore be documented.

    Signed-off-by: Sven Eckelmann
    Signed-off-by: Simon Wunderlich

    Sven Eckelmann
     
  • All enums in types.h are already documented. But some other headers
    still have private enums which also should be documented.

    Signed-off-by: Sven Eckelmann
    Signed-off-by: Simon Wunderlich

    Sven Eckelmann
     
  • The documentation describing kernel-doc comments for functions ("How to
    format kernel-doc comments") uses parentheses at the end of the function
    name. Using this format allows to use a consistent style when adding
    documentation to a function and when referencing this function in a
    different kernel-doc section.

    Signed-off-by: Sven Eckelmann
    Signed-off-by: Simon Wunderlich

    Sven Eckelmann
     
  • The "Linux kernel licensing rules" require that each file has a SPDX
    license identifier as first line (and sometimes as second line).

    The FSFE REUSE practices [1] would also require the same tags but have no
    restrictions on the placement in the source file. Using the "Linux kernel
    licensing rules" is therefore also fulfilling the FSFE REUSE practices
    requirements at the same time.

    [1] https://reuse.software/practices/

    Signed-off-by: Sven Eckelmann
    Signed-off-by: Simon Wunderlich

    Sven Eckelmann
     

04 Dec, 2017

1 commit


28 Sep, 2017

1 commit


29 Jul, 2017

1 commit


23 May, 2017

2 commits

  • With this patch the maximum fragment size is reduced from 1400 to 1280
    bytes.

    Fragmentation v2 correctly uses the smaller of 1400 and the interface
    MTU, thus generally supporting interfaces with an MTU < 1400 bytes, too.

    However, currently "Fragmentation v2" does not support re-fragmentation.
    Which means that once a packet is split into two packets of 1400 + x
    bytes for instance and the next hop provides an interface with an even
    smaller MTU of 1280 bytes, then the larger fragment is lost.

    A maximum fragment size of 1280 bytes is a safer option as this is the
    minimum MTU required by IPv6, making interfaces with an MTU < 1280
    rather exotic.

    Regarding performance, this should have no negative impact on unicast
    traffic: Having some more bytes in the smaller and some less in the
    larger does not change the sum of both fragments.

    Concerning TT, choosing 1280 bytes fragments might result in more TT
    messages than necessary when a large network is bridged into batman-adv.
    However, the TT overhead in general is marginal due to its reactive
    nature, therefore such a performance impact on TT should not be
    noticeable for a user.

    Cc: Matthias Schiffer
    [linus.luessing@c0d3.blue: Added commit message]
    Signed-off-by: Linus Lüssing
    Signed-off-by: Sven Eckelmann
    Signed-off-by: Simon Wunderlich

    Matthias Schiffer
     
  • Signed-off-by: Simon Wunderlich

    Simon Wunderlich
     

17 Mar, 2017

2 commits


26 Jan, 2017

1 commit


01 Jan, 2017

1 commit