07 Oct, 2017

3 commits

  • That Bluetooth SMP knows about the private key is pointless, since the
    detection of debug key usage is actually via the public key portion.
    With this patch, the Bluetooth SMP will stop keeping a copy of the
    ecdh private key and will let the crypto subsystem to generate and
    handle the ecdh private key, potentially benefiting of hardware
    ecc private key generation and retention.

    The loop that tries to generate a correct private key is now removed and
    we trust the crypto subsystem to generate a correct private key. This
    backup logic should be done in crypto, if really needed.

    Signed-off-by: Tudor Ambarus
    Signed-off-by: Marcel Holtmann

    Tudor Ambarus
     
  • ecdh_helper functions were hiding the error codes and chose to return
    the return value of an relational operator, "==". Remove the unnecessary
    query and reveal the error codes.

    While updating the return values, code in a way that compilers will
    warn in case of uninitialized err.

    Signed-off-by: Tudor Ambarus
    Signed-off-by: Marcel Holtmann

    Tudor Ambarus
     
  • Before this change, a new crypto tfm was allocated, each time,
    for both key generation and shared secret computation.

    Allocate a single tfm for both cases.

    Signed-off-by: Tudor Ambarus
    Signed-off-by: Marcel Holtmann

    Tudor Ambarus
     

25 Apr, 2017

1 commit