08 Nov, 2019

1 commit

  • dpm_sysfs_remove() and device_pm_remove() are already called by
    device_del() on device removal so there is no need to call
    device_init_wakeup(dev, false) from the driver and it allows to remove the
    .remove callback.

    Link: https://lore.kernel.org/r/20191021155806.3625-4-alexandre.belloni@bootlin.com
    Reviewed-by: Baolin Wang
    Signed-off-by: Alexandre Belloni

    Alexandre Belloni
     

10 Sep, 2019

1 commit

  • The SPRD_RTC_POWEROFF_ALM_FLAG flag is used to indicate if a poweroff alarm
    is set, which can power on the system when system in power-off status.

    And the bootloader will validate this flag to check if the booting mode is
    alarm booting mode, thus we should not clear this flag in kernel, instead
    bootloader will clear this flag after checking the booting mode.

    Signed-off-by: Baolin Wang
    Link: https://lore.kernel.org/r/1f75310242de75b14d8973538bf96efffb395daf.1567666894.git.baolin.wang@linaro.org
    Signed-off-by: Alexandre Belloni

    Baolin Wang
     

21 Aug, 2019

1 commit

  • The RTC core now has error messages in case of registration failure, there
    is no need to have other messages in the drivers.

    Signed-off-by: Alexandre Belloni
    Link: https://lore.kernel.org/r/20190818220041.17833-2-alexandre.belloni@bootlin.com
    Signed-off-by: Alexandre Belloni

    Alexandre Belloni
     

13 Aug, 2019

1 commit

  • We don't need dev_err() messages when platform_get_irq() fails now that
    platform_get_irq() prints an error message itself when something goes
    wrong. Let's remove these prints with a simple semantic patch.

    //
    @@
    expression ret;
    struct platform_device *E;
    @@

    ret =
    (
    platform_get_irq(E, ...)
    |
    platform_get_irq_byname(E, ...)
    );

    if ( \( ret < 0 \| ret

    While we're here, remove braces on if statements that only have one
    statement (manually).

    Cc: Alessandro Zummo
    Cc: Alexandre Belloni
    Cc: linux-rtc@vger.kernel.org
    Cc: Greg Kroah-Hartman
    Signed-off-by: Stephen Boyd
    Link: https://lore.kernel.org/r/20190730181557.90391-40-swboyd@chromium.org
    Signed-off-by: Alexandre Belloni

    Stephen Boyd
     

25 Oct, 2018

5 commits


01 Jun, 2018

1 commit

  • We should use the new method to check if RTC was powered down, which
    is more solid. Since we have introduced power control and power status
    registers, and we just check if the power status is the default value
    (0x96), if yes that means the RTC has been powered down. Meanwhile We
    can set the power control register to be one valid value to change
    the power status to indicate RTC device is valid now.

    Signed-off-by: Baolin Wang
    Signed-off-by: Alexandre Belloni

    Baolin Wang
     

04 May, 2018

2 commits


02 Mar, 2018

1 commit


21 Nov, 2017

1 commit