04 Oct, 2019

1 commit

• 020fa0f2f   mac80211: IBSS: avoid unneeded return value processing ... Browse Code »

  when ieee80211_ibss_csa_beacon() fails, we return it's value.
  When it succeeds, we basically copy it's value and also .. return it.

  Just return it immediately, simplifying the code.

  Signed-off-by: Koen Vandeputte
  Link: https://lore.kernel.org/r/20190911141431.12498-1-koen.vandeputte@ncentric.com
  Signed-off-by: Johannes Berg

  Koen Vandeputte

  2019-10-04 19:47:12 +0800  

11 Sep, 2019

1 commit

• 4b08d1b6a   mac80211: IBSS: send deauth when expiring inactive STAs ... Browse Code »

  When we expire an inactive station, try to send it a deauth. This
  helps if it's actually still around, and just has issues with
  beacon distribution (or we do), and it will not also remove us.
  Then, if we have shared state, this may not be reset properly,
  causing problems; for example, we saw a case where aggregation
  sessions weren't removed properly (due to the TX start being
  offloaded to firmware and it relying on deauth for stop), causing
  a lot of traffic to get lost due to the SN reset after remove/add
  of the peer.

  Signed-off-by: Johannes Berg
  Signed-off-by: Luca Coelho
  Link: https://lore.kernel.org/r/20190830112451.21655-9-luca@coelho.fi
  Signed-off-by: Johannes Berg

  Johannes Berg

  2019-09-11 15:33:29 +0800  

19 Jun, 2019

1 commit

• d2912cb15   treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 ... Browse Code »

  Based on 2 normalized pattern(s):

  this program is free software you can redistribute it and or modify
  it under the terms of the gnu general public license version 2 as
  published by the free software foundation

  this program is free software you can redistribute it and or modify
  it under the terms of the gnu general public license version 2 as
  published by the free software foundation #

  extracted by the scancode license scanner the SPDX license identifier

  GPL-2.0-only

  has been chosen to replace the boilerplate/reference in 4122 file(s).

  Signed-off-by: Thomas Gleixner
  Reviewed-by: Enrico Weigelt
  Reviewed-by: Kate Stewart
  Reviewed-by: Allison Randal
  Cc: linux-spdx@vger.kernel.org
  Link: https://lkml.kernel.org/r/20190604081206.933168790@linutronix.de
  Signed-off-by: Greg Kroah-Hartman

  Thomas Gleixner

  2019-06-19 23:09:55 +0800  

08 Feb, 2019

1 commit

• 4abb52a46   mac80211: pass bssids to elements parsing function ... Browse Code »

  In multiple BSSID, we have nested IEs inside the multiple
  BSSID IE, that override the external ones for that specific
  BSS. As preparation for supporting that, pass 2 BSSIDs to the
  parse function, the transmitter, and the selected BSSID, so
  it can know which IEs to choose. If the selected BSSID is
  NULL, the outer ones will be applied.

  Change ieee80211_bss_info_update to parse elements itself,
  instead of receiving them parsed, so we have the relevant
  bss entry in hand.

  Signed-off-by: Sara Sharon
  Signed-off-by: Johannes Berg

  Sara Sharon

  2019-02-08 20:51:50 +0800  

05 Sep, 2018

1 commit

• 7eb26df29   mac80211: add ability to parse CCFS2 ... Browse Code »

  With newer VHT implementations, it's necessary to look at the
  HT operation's CCFS2 field to identify the actual bandwidth
  used.

  Signed-off-by: Johannes Berg

  Johannes Berg

  2018-09-05 16:03:14 +0800  

03 Sep, 2018

1 commit

• c6e57b389   mac80211: shorten the IBSS debug messages ... Browse Code »

  When tracing is enabled, all the debug messages are recorded and must
  not exceed MAX_MSG_LEN (100) columns. Longer debug messages grant the
  user with:

  WARNING: CPU: 3 PID: 32642 at /tmp/wifi-core-20180806094828/src/iwlwifi-stack-dev/net/mac80211/./trace_msg.h:32 trace_event_raw_event_mac80211_msg_event+0xab/0xc0 [mac80211]
  Workqueue: phy1 ieee80211_iface_work [mac80211]
  RIP: 0010:trace_event_raw_event_mac80211_msg_event+0xab/0xc0 [mac80211]
  Call Trace:
  __sdata_dbg+0xbd/0x120 [mac80211]
  ieee80211_ibss_rx_queued_mgmt+0x15f/0x510 [mac80211]
  ieee80211_iface_work+0x21d/0x320 [mac80211]

  Signed-off-by: Emmanuel Grumbach
  Signed-off-by: Luca Coelho
  Signed-off-by: Johannes Berg

  Emmanuel Grumbach

  2018-09-03 16:41:27 +0800  

29 Mar, 2018

1 commit

• 018f6fbf5   mac80211: Send control port frames over nl80211 ... Browse Code »

  If userspace requested control port frames to go over 80211, then do so.
  The control packets are intercepted just prior to delivery of the packet
  to the underlying network device.

  Pre-authentication type frames (protocol: 0x88c7) are also forwarded
  over nl80211.

  Signed-off-by: Denis Kenzior
  Signed-off-by: Johannes Berg

  Denis Kenzior

  2018-03-29 20:08:30 +0800  

23 Mar, 2018

1 commit

• dcbe73ca5   mac80211: notify driver for change in multicast rates ... Browse Code »

  With drivers implementing rate control in driver or firmware
  rate_control_send_low() may not get called, and thus the
  driver needs to know about changes in the multicast rate.

  Add and use a new BSS change flag for this.

  Signed-off-by: Pradeep Kumar Chitrapu
  [rewrite commit message]
  Signed-off-by: Johannes Berg

  Pradeep Kumar Chitrapu

  2018-03-23 20:23:17 +0800  

20 Nov, 2017

1 commit

• 34f11cd32   mac80211: Convert timers to use timer_setup() ... Browse Code »

  In preparation for unconditionally passing the struct timer_list pointer to
  all timer callbacks, switch to using the new timer_setup() and from_timer()
  to pass the timer pointer explicitly.

  Cc: Johannes Berg
  Cc: "David S. Miller"
  Cc: linux-wireless@vger.kernel.org
  Cc: netdev@vger.kernel.org
  Signed-off-by: Kees Cook
  Signed-off-by: Johannes Berg

  Kees Cook

  2017-11-20 23:55:11 +0800  

16 Jun, 2017

1 commit

• 59ae1d127   networking: introduce and use skb_put_data() ... Browse Code »

  A common pattern with skb_put() is to just want to memcpy()
  some data into the new space, introduce skb_put_data() for
  this.

  An spatch similar to the one for skb_put_zero() converts many
  of the places using it:

  @@
  identifier p, p2;
  expression len, skb, data;
  type t, t2;
  @@
  (
  -p = skb_put(skb, len);
  +p = skb_put_data(skb, data, len);
  |
  -p = (t)skb_put(skb, len);
  +p = skb_put_data(skb, data, len);
  )
  (
  p2 = (t2)p;
  -memcpy(p2, data, len);
  |
  -memcpy(p, data, len);
  )

  @@
  type t, t2;
  identifier p, p2;
  expression skb, data;
  @@
  t *p;
  ...
  (
  -p = skb_put(skb, sizeof(t));
  +p = skb_put_data(skb, data, sizeof(t));
  |
  -p = (t *)skb_put(skb, sizeof(t));
  +p = skb_put_data(skb, data, sizeof(t));
  )
  (
  p2 = (t2)p;
  -memcpy(p2, data, sizeof(*p));
  |
  -memcpy(p, data, sizeof(*p));
  )

  @@
  expression skb, len, data;
  @@
  -memcpy(skb_put(skb, len), data, len);
  +skb_put_data(skb, data, len);

  (again, manually post-processed to retain some comments)

  Reviewed-by: Stephen Hemminger
  Signed-off-by: Johannes Berg
  Signed-off-by: David S. Miller

  Johannes Berg

  2017-06-16 23:48:37 +0800  

19 May, 2017

1 commit

• 61b81b401   mac80211: move clearing result into ieee80211_parse_ch_switch_ie() ... Browse Code »

  Clear the csa_ie in ieee80211_parse_ch_switch_ie() where the data
  is filled in, rather than in each caller.

  Signed-off-by: Johannes Berg

  Johannes Berg

  2017-05-19 19:25:57 +0800  

08 May, 2017

1 commit

• f1f3e9e2a   mac80211: fix IBSS presp allocation size ... Browse Code »

  When VHT IBSS support was added, the size of the extra elements
  wasn't considered in ieee80211_ibss_build_presp(), which makes
  it possible that it would overrun the allocated buffer. Fix it
  by allocating the necessary space.

  Fixes: abcff6ef01f9 ("mac80211: add VHT support for IBSS")
  Reported-by: Shaul Triebitz
  Signed-off-by: Johannes Berg

  Johannes Berg

  2017-05-08 17:25:04 +0800  

28 Apr, 2017

3 commits

• 21a8e9dd5   mac80211: Fix possible sband related NULL pointer de-reference ... Browse Code »

  Existing API 'ieee80211_get_sdata_band' returns default 2 GHz band even
  if the channel context configuration is NULL. This crashes for chipsets
  which support 5 Ghz alone when it tries to access members of 'sband'.
  Channel context configuration can be NULL in multivif case and when
  channel switch is in progress (or) when it fails. Fix this by replacing
  the API 'ieee80211_get_sdata_band' with 'ieee80211_get_sband' which
  returns a NULL pointer for sband when the channel configuration is NULL.

  An example scenario is as below:

  In multivif mode (AP + STA) with drivers like ath10k, when we do a
  channel switch in the AP vif (which has a number of clients connected)
  and a STA vif which is connected to some other AP, when the channel
  switch in AP vif fails, while the STA vifs tries to connect to the
  other AP, there is a window where the channel context is NULL/invalid
  and this results in a crash while the clients connected to the AP vif
  tries to reconnect and this race is very similar to the one investigated
  by Michal in https://patchwork.kernel.org/patch/3788161/ and this does
  happens with hardware that supports 5Ghz alone after long hours of
  testing with continuous channel switch on the AP vif

  ieee80211 phy0: channel context reservation cannot be finalized because
  some interfaces aren't switching
  wlan0: failed to finalize CSA, disconnecting
  wlan0-1: deauthenticating from 8c:fd:f0:01:54:9c by local choice
  (Reason: 3=DEAUTH_LEAVING)

  WARNING: CPU: 1 PID: 19032 at net/mac80211/ieee80211_i.h:1013 sta_info_alloc+0x374/0x3fc [mac80211]
  [] (sta_info_alloc [mac80211])
  [] (ieee80211_add_station [mac80211]))
  [] (nl80211_new_station [cfg80211])

  Unable to handle kernel NULL pointer dereference at virtual
  address 00000014
  pgd = d5f4c000
  Internal error: Oops: 17 [#1] PREEMPT SMP ARM
  PC is at sta_info_alloc+0x380/0x3fc [mac80211]
  LR is at sta_info_alloc+0x37c/0x3fc [mac80211]
  [] (sta_info_alloc [mac80211])
  [] (ieee80211_add_station [mac80211])
  [] (nl80211_new_station [cfg80211]))

  Cc: Michal Kazior
  Signed-off-by: Mohammed Shafi Shajakhan
  Signed-off-by: Johannes Berg

  Mohammed Shafi Shajakhan

  2017-04-28 18:28:44 +0800  
• da6a4352e   mac80211: separate encoding/bandwidth from flags ... Browse Code »

  We currently use a lot of flags that are mutually incompatible,
  separate this out into actual encoding and bandwidth enum values.

  Much of this again done with spatch, with manual post-editing,
  mostly to add the switch statements and get rid of the conversions.

  @@
  expression status;
  @@
  -status->enc_flags |= RX_ENC_FLAG_80MHZ
  +status->bw = RATE_INFO_BW_80
  @@
  expression status;
  @@
  -status->enc_flags |= RX_ENC_FLAG_40MHZ
  +status->bw = RATE_INFO_BW_40
  @@
  expression status;
  @@
  -status->enc_flags |= RX_ENC_FLAG_20MHZ
  +status->bw = RATE_INFO_BW_20
  @@
  expression status;
  @@
  -status->enc_flags |= RX_ENC_FLAG_160MHZ
  +status->bw = RATE_INFO_BW_160
  @@
  expression status;
  @@
  -status->enc_flags |= RX_ENC_FLAG_5MHZ
  +status->bw = RATE_INFO_BW_5
  @@
  expression status;
  @@
  -status->enc_flags |= RX_ENC_FLAG_10MHZ
  +status->bw = RATE_INFO_BW_10

  @@
  expression status;
  @@
  -status->enc_flags |= RX_ENC_FLAG_VHT
  +status->encoding = RX_ENC_VHT
  @@
  expression status;
  @@
  -status->enc_flags |= RX_ENC_FLAG_HT
  +status->encoding = RX_ENC_HT
  @@
  expression status;
  @@
  -status.enc_flags |= RX_ENC_FLAG_VHT
  +status.encoding = RX_ENC_VHT
  @@
  expression status;
  @@
  -status.enc_flags |= RX_ENC_FLAG_HT
  +status.encoding = RX_ENC_HT

  @@
  expression status;
  @@
  -(status->enc_flags & RX_ENC_FLAG_HT)
  +(status->encoding == RX_ENC_HT)
  @@
  expression status;
  @@
  -(status->enc_flags & RX_ENC_FLAG_VHT)
  +(status->encoding == RX_ENC_VHT)

  @@
  expression status;
  @@
  -(status->enc_flags & RX_ENC_FLAG_5MHZ)
  +(status->bw == RATE_INFO_BW_5)
  @@
  expression status;
  @@
  -(status->enc_flags & RX_ENC_FLAG_10MHZ)
  +(status->bw == RATE_INFO_BW_10)
  @@
  expression status;
  @@
  -(status->enc_flags & RX_ENC_FLAG_40MHZ)
  +(status->bw == RATE_INFO_BW_40)
  @@
  expression status;
  @@
  -(status->enc_flags & RX_ENC_FLAG_80MHZ)
  +(status->bw == RATE_INFO_BW_80)
  @@
  expression status;
  @@
  -(status->enc_flags & RX_ENC_FLAG_160MHZ)
  +(status->bw == RATE_INFO_BW_160)

  Signed-off-by: Johannes Berg

  Johannes Berg

  2017-04-28 16:41:45 +0800  
• 7fdd69c5a   mac80211: clean up rate encoding bits in RX status ... Browse Code »

  In preparation for adding support for HE rates, clean up
  the driver report encoding for rate/bandwidth reporting
  on RX frames.

  Much of this patch was done with the following spatch:

  @@
  expression status;
  @@
  -status->flag & (RX_FLAG_HT | RX_FLAG_VHT)
  +status->enc_flags & (RX_ENC_FLAG_HT | RX_ENC_FLAG_VHT)

  @@
  assignment operator op;
  expression status;
  @@
  -status->flag op RX_FLAG_SHORTPRE
  +status->enc_flags op RX_ENC_FLAG_SHORTPRE
  @@
  expression status;
  @@
  -status->flag & RX_FLAG_SHORTPRE
  +status->enc_flags & RX_ENC_FLAG_SHORTPRE

  @@
  assignment operator op;
  expression status;
  @@
  -status->flag op RX_FLAG_HT
  +status->enc_flags op RX_ENC_FLAG_HT
  @@
  expression status;
  @@
  -status->flag & RX_FLAG_HT
  +status->enc_flags & RX_ENC_FLAG_HT

  @@
  assignment operator op;
  expression status;
  @@
  -status->flag op RX_FLAG_40MHZ
  +status->enc_flags op RX_ENC_FLAG_40MHZ
  @@
  expression status;
  @@
  -status->flag & RX_FLAG_40MHZ
  +status->enc_flags & RX_ENC_FLAG_40MHZ

  @@
  assignment operator op;
  expression status;
  @@
  -status->flag op RX_FLAG_SHORT_GI
  +status->enc_flags op RX_ENC_FLAG_SHORT_GI
  @@
  expression status;
  @@
  -status->flag & RX_FLAG_SHORT_GI
  +status->enc_flags & RX_ENC_FLAG_SHORT_GI

  @@
  assignment operator op;
  expression status;
  @@
  -status->flag op RX_FLAG_HT_GF
  +status->enc_flags op RX_ENC_FLAG_HT_GF
  @@
  expression status;
  @@
  -status->flag & RX_FLAG_HT_GF
  +status->enc_flags & RX_ENC_FLAG_HT_GF

  @@
  assignment operator op;
  expression status;
  @@
  -status->flag op RX_FLAG_VHT
  +status->enc_flags op RX_ENC_FLAG_VHT
  @@
  expression status;
  @@
  -status->flag & RX_FLAG_VHT
  +status->enc_flags & RX_ENC_FLAG_VHT

  @@
  assignment operator op;
  expression status;
  @@
  -status->flag op RX_FLAG_STBC_MASK
  +status->enc_flags op RX_ENC_FLAG_STBC_MASK
  @@
  expression status;
  @@
  -status->flag & RX_FLAG_STBC_MASK
  +status->enc_flags & RX_ENC_FLAG_STBC_MASK

  @@
  assignment operator op;
  expression status;
  @@
  -status->flag op RX_FLAG_LDPC
  +status->enc_flags op RX_ENC_FLAG_LDPC
  @@
  expression status;
  @@
  -status->flag & RX_FLAG_LDPC
  +status->enc_flags & RX_ENC_FLAG_LDPC

  @@
  assignment operator op;
  expression status;
  @@
  -status->flag op RX_FLAG_10MHZ
  +status->enc_flags op RX_ENC_FLAG_10MHZ
  @@
  expression status;
  @@
  -status->flag & RX_FLAG_10MHZ
  +status->enc_flags & RX_ENC_FLAG_10MHZ

  @@
  assignment operator op;
  expression status;
  @@
  -status->flag op RX_FLAG_5MHZ
  +status->enc_flags op RX_ENC_FLAG_5MHZ
  @@
  expression status;
  @@
  -status->flag & RX_FLAG_5MHZ
  +status->enc_flags & RX_ENC_FLAG_5MHZ

  @@
  assignment operator op;
  expression status;
  @@
  -status->vht_flag op RX_VHT_FLAG_80MHZ
  +status->enc_flags op RX_ENC_FLAG_80MHZ
  @@
  expression status;
  @@
  -status->vht_flag & RX_VHT_FLAG_80MHZ
  +status->enc_flags & RX_ENC_FLAG_80MHZ

  @@
  assignment operator op;
  expression status;
  @@
  -status->vht_flag op RX_VHT_FLAG_160MHZ
  +status->enc_flags op RX_ENC_FLAG_160MHZ
  @@
  expression status;
  @@
  -status->vht_flag & RX_VHT_FLAG_160MHZ
  +status->enc_flags & RX_ENC_FLAG_160MHZ

  @@
  assignment operator op;
  expression status;
  @@
  -status->vht_flag op RX_VHT_FLAG_BF
  +status->enc_flags op RX_ENC_FLAG_BF
  @@
  expression status;
  @@
  -status->vht_flag & RX_VHT_FLAG_BF
  +status->enc_flags & RX_ENC_FLAG_BF

  @@
  assignment operator op;
  expression status, STBC;
  @@
  -status->flag op STBC << RX_FLAG_STBC_SHIFT
  +status->enc_flags op STBC << RX_ENC_FLAG_STBC_SHIFT

  @@
  assignment operator op;
  expression status;
  @@
  -status.flag op RX_FLAG_SHORTPRE
  +status.enc_flags op RX_ENC_FLAG_SHORTPRE
  @@
  expression status;
  @@
  -status.flag & RX_FLAG_SHORTPRE
  +status.enc_flags & RX_ENC_FLAG_SHORTPRE

  @@
  assignment operator op;
  expression status;
  @@
  -status.flag op RX_FLAG_HT
  +status.enc_flags op RX_ENC_FLAG_HT
  @@
  expression status;
  @@
  -status.flag & RX_FLAG_HT
  +status.enc_flags & RX_ENC_FLAG_HT

  @@
  assignment operator op;
  expression status;
  @@
  -status.flag op RX_FLAG_40MHZ
  +status.enc_flags op RX_ENC_FLAG_40MHZ
  @@
  expression status;
  @@
  -status.flag & RX_FLAG_40MHZ
  +status.enc_flags & RX_ENC_FLAG_40MHZ

  @@
  assignment operator op;
  expression status;
  @@
  -status.flag op RX_FLAG_SHORT_GI
  +status.enc_flags op RX_ENC_FLAG_SHORT_GI
  @@
  expression status;
  @@
  -status.flag & RX_FLAG_SHORT_GI
  +status.enc_flags & RX_ENC_FLAG_SHORT_GI

  @@
  assignment operator op;
  expression status;
  @@
  -status.flag op RX_FLAG_HT_GF
  +status.enc_flags op RX_ENC_FLAG_HT_GF
  @@
  expression status;
  @@
  -status.flag & RX_FLAG_HT_GF
  +status.enc_flags & RX_ENC_FLAG_HT_GF

  @@
  assignment operator op;
  expression status;
  @@
  -status.flag op RX_FLAG_VHT
  +status.enc_flags op RX_ENC_FLAG_VHT
  @@
  expression status;
  @@
  -status.flag & RX_FLAG_VHT
  +status.enc_flags & RX_ENC_FLAG_VHT

  @@
  assignment operator op;
  expression status;
  @@
  -status.flag op RX_FLAG_STBC_MASK
  +status.enc_flags op RX_ENC_FLAG_STBC_MASK
  @@
  expression status;
  @@
  -status.flag & RX_FLAG_STBC_MASK
  +status.enc_flags & RX_ENC_FLAG_STBC_MASK

  @@
  assignment operator op;
  expression status;
  @@
  -status.flag op RX_FLAG_LDPC
  +status.enc_flags op RX_ENC_FLAG_LDPC
  @@
  expression status;
  @@
  -status.flag & RX_FLAG_LDPC
  +status.enc_flags & RX_ENC_FLAG_LDPC

  @@
  assignment operator op;
  expression status;
  @@
  -status.flag op RX_FLAG_10MHZ
  +status.enc_flags op RX_ENC_FLAG_10MHZ
  @@
  expression status;
  @@
  -status.flag & RX_FLAG_10MHZ
  +status.enc_flags & RX_ENC_FLAG_10MHZ

  @@
  assignment operator op;
  expression status;
  @@
  -status.flag op RX_FLAG_5MHZ
  +status.enc_flags op RX_ENC_FLAG_5MHZ
  @@
  expression status;
  @@
  -status.flag & RX_FLAG_5MHZ
  +status.enc_flags & RX_ENC_FLAG_5MHZ

  @@
  assignment operator op;
  expression status;
  @@
  -status.vht_flag op RX_VHT_FLAG_80MHZ
  +status.enc_flags op RX_ENC_FLAG_80MHZ
  @@
  expression status;
  @@
  -status.vht_flag & RX_VHT_FLAG_80MHZ
  +status.enc_flags & RX_ENC_FLAG_80MHZ

  @@
  assignment operator op;
  expression status;
  @@
  -status.vht_flag op RX_VHT_FLAG_160MHZ
  +status.enc_flags op RX_ENC_FLAG_160MHZ
  @@
  expression status;
  @@
  -status.vht_flag & RX_VHT_FLAG_160MHZ
  +status.enc_flags & RX_ENC_FLAG_160MHZ

  @@
  assignment operator op;
  expression status;
  @@
  -status.vht_flag op RX_VHT_FLAG_BF
  +status.enc_flags op RX_ENC_FLAG_BF
  @@
  expression status;
  @@
  -status.vht_flag & RX_VHT_FLAG_BF
  +status.enc_flags & RX_ENC_FLAG_BF

  @@
  assignment operator op;
  expression status, STBC;
  @@
  -status.flag op STBC << RX_FLAG_STBC_SHIFT
  +status.enc_flags op STBC << RX_ENC_FLAG_STBC_SHIFT

  @@
  @@
  -RX_FLAG_STBC_SHIFT
  +RX_ENC_FLAG_STBC_SHIFT

  Signed-off-by: Johannes Berg

  Johannes Berg

  2017-04-28 16:41:38 +0800  

18 Apr, 2017

1 commit

• a4ac6f2e5   mac80211: ibss: Fix channel type enum in ieee80211_sta_join_ibss() ... Browse Code »

  cfg80211_chandef_create() expects an 'enum nl80211_channel_type' as
  channel type however in ieee80211_sta_join_ibss()
  NL80211_CHAN_WIDTH_20_NOHT is passed in two occasions, which is of
  the enum type 'nl80211_chan_width'. Change the value to NL80211_CHAN_NO_HT
  (20 MHz, non-HT channel) of the channel type enum.

  Signed-off-by: Matthias Kaehlcke
  Signed-off-by: Johannes Berg

  Matthias Kaehlcke

  2017-04-18 17:02:35 +0800  

09 Feb, 2017

1 commit

• f181d6a3b   mac80211: fix CSA in IBSS mode ... Browse Code »

  Add the missing IBSS capability flag during capability init as it needs
  to be inserted into the generated beacon in order for CSA to work.

  Fixes: cd7760e62c2ac ("mac80211: add support for CSA in IBSS mode")
  Signed-off-by: Piotr Gawlowicz
  Signed-off-by: Mikołaj Chwalisz
  Tested-by: Koen Vandeputte
  Signed-off-by: Johannes Berg

  Koen Vandeputte

  2017-02-09 22:18:24 +0800  

12 Apr, 2016

1 commit

• 57fbcce37   cfg80211: remove enum ieee80211_band ... Browse Code »

  This enum is already perfectly aliased to enum nl80211_band, and
  the only reason for it is that we get IEEE80211_NUM_BANDS out of
  it. There's no really good reason to not declare the number of
  bands in nl80211 though, so do that and remove the cfg80211 one.

  Signed-off-by: Johannes Berg

  Johannes Berg

  2016-04-12 21:56:15 +0800  

06 Apr, 2016

2 commits

• b8da6b6a9   mac80211: add separate last_ack variable ... Browse Code »

  Instead of touching the rx_stats.last_rx from the status path, introduce
  and use a status_stats.last_ack variable. This will make rx_stats.last_rx
  indicate when the last frame was received, making it available for real
  "last_rx" and statistics gathering; statistics, when done per-CPU, will
  need to figure out which place was updated last for those items where the
  "last" value is exposed.

  Signed-off-by: Johannes Berg

  Johannes Berg

  2016-04-06 19:18:16 +0800  
• 2df8bfd72   mac80211: remove rx_stats.last_rx update after sta alloc ... Browse Code »

  There's no need to update rx_stats.last_rx after allocating
  a station since it's already updated during allocation.

  Signed-off-by: Johannes Berg

  Johannes Berg

  2016-04-06 19:18:15 +0800  

02 Mar, 2016

1 commit

• d67703fce   Merge tag 'mac80211-next-for-davem-2016-02-26' of git://git.kernel.org/pub/scm/l… ... Browse Code »

  …inux/kernel/git/jberg/mac80211-next

  Johannes Berg says:

  ====================
  Here's another round of updates for -next:
  * big A-MSDU RX performance improvement (avoid linearize of paged RX)
  * rfkill changes: cleanups, documentation, platform properties
  * basic PBSS support in cfg80211
  * MU-MIMO action frame processing support
  * BlockAck reordering & duplicate detection offload support
  * various cleanups & little fixes
  ====================

  Signed-off-by: David S. Miller <davem@davemloft.net>

  David S. Miller

  2016-03-02 06:03:27 +0800  

24 Feb, 2016

2 commits

• d321cd014   mac80211: fix ibss scan parameters ... Browse Code »

  When joining IBSS a full scan should be initiated in order to search
  for existing cell, unless the fixed_channel parameter was set.
  A default channel to create the IBSS on if no cell was found is
  provided as well.
  However - a scan is initiated only on the default channel provided
  regardless of whether ifibss->fixed_channel is set or not, with the
  obvious result of the cell not joining existing IBSS cell that is
  on another channel.

  Fixes: 76bed0f43b27 ("mac80211: IBSS fix scan request")
  Signed-off-by: Sara Sharon
  Signed-off-by: Emmanuel Grumbach
  Signed-off-by: Johannes Berg

  Sara Sharon

  2016-02-24 16:04:27 +0800  
• 8ac3c7041   mac80211: refactor HT/VHT to chandef code ... Browse Code »

  The station MLME and IBSS/mesh ones use entirely different
  code for interpreting HT and VHT operation elements. Change
  the code that interprets them a bit - it now modifies an
  existing chandef - and use it also in the MLME code.

  Signed-off-by: Johannes Berg

  Johannes Berg

  2016-02-24 16:04:21 +0800  

26 Jan, 2016

1 commit

• 4fa11ec72   mac80211: Requeue work after scan complete for all VIF types. ... Browse Code »

  During a sw scan ieee80211_iface_work ignores work items for all vifs.
  However after the scan complete work is requeued only for STA, ADHOC
  and MESH iftypes.

  This occasionally results in event processing getting delayed/not
  processed for iftype AP when it coexists with a STA. This can result
  in data halt and eventually disconnection on the AP interface.

  Cc: stable@vger.kernel.org
  Signed-off-by: Sachin Kulkarni
  Signed-off-by: Johannes Berg

  Sachin Kulkarni

  2016-01-26 18:27:39 +0800  

04 Dec, 2015

1 commit

• c39b336de   mac80211: Allow a STA to join an IBSS with 80+80 MHz channel ... Browse Code »

  While it was possible to create an IBSS with 80+80 MHz channel, joining
  such an IBSS resulted in falling back to 20 MHz channel with VHT
  disabled due to a missing switch case for 80+80.

  Signed-off-by: Jouni Malinen
  Signed-off-by: Johannes Berg

  Jouni Malinen

  2015-12-04 21:43:32 +0800  

03 Nov, 2015

2 commits

• cec662835   mac80211: make enable_qos parameter to ieee80211_set_wmm_default() ... Browse Code »

  The function currently determines this value, for use in bss_info.qos,
  based on the interface type itself. Make it a parameter instead and
  set it with the same logic for now.

  Signed-off-by: Johannes Berg

  Johannes Berg

  2015-11-03 17:55:55 +0800  
• 57f255f58   mac80211: TDLS: add proper HT-oper IE ... Browse Code »

  When 11n peers performs a TDLS connection on a legacy BSS, the HT
  operation IE must be specified according to IEEE802.11-2012 section
  9.23.3.2. Otherwise HT-protection is compromised and the medium becomes
  noisy for both the TDLS and the BSS links.

  Signed-off-by: Arik Nemtsov
  Signed-off-by: Emmanuel Grumbach
  Signed-off-by: Johannes Berg

  Arik Nemtsov

  2015-11-03 17:42:47 +0800  

21 Oct, 2015

1 commit

• e5a9f8d04   mac80211: move station statistics into sub-structs ... Browse Code »

  Group station statistics by where they're (mostly) updated
  (TX, RX and TX-status) and group them into sub-structs of
  the struct sta_info.

  Also rename the variables since the grouping now makes it
  obvious where they belong.

  This makes it easier to identify where the statistics are
  updated in the code, and thus easier to think about them.

  Signed-off-by: Johannes Berg

  Johannes Berg

  2015-10-21 16:08:22 +0800  

13 Oct, 2015

1 commit

• 61f6bba00   mac80211: use new cfg80211_inform_bss_frame_data() API ... Browse Code »

  The new API is more easily extensible with a metadata struct
  passed to it, use it in mac80211.

  Signed-off-by: Johannes Berg

  Johannes Berg

  2015-10-13 17:36:21 +0800  

10 Jun, 2015

1 commit

• 8df734e86   mac80211: fix the beacon csa counter for mesh and ibss ... Browse Code »

  The csa counter has moved from sdata to beacon/presp but
  it is not updated accordingly for mesh and ibss. Fix this.

  Fixes: af296bdb8da4 ("mac80211: move csa counters from sdata to beacon/presp")
  Signed-off-by: Chun-Yeow Yeoh
  Signed-off-by: Johannes Berg

  Chun-Yeow Yeoh

  2015-06-10 04:04:25 +0800  

11 May, 2015

1 commit

• 96a4688ed   mac80211: check fast-xmit if IBSS STA QoS changed ... Browse Code »

  When an IBSS station gets QoS enabled after having been added,
  check fast-xmit to make sure the QoS header gets added to the
  cache properly and frames can go out with QoS and higher rates.

  Reported-by: Janusz Dziedzic
  Signed-off-by: Johannes Berg

  Johannes Berg

  2015-05-11 20:01:36 +0800  

01 Apr, 2015

1 commit

• 7b6249bba   Merge tag 'mac80211-next-for-davem-2015-03-30' of git://git.kernel.org/pub/scm/l… ... Browse Code »

  …inux/kernel/git/jberg/mac80211-next

  Johannes Berg says:

  ====================
  Lots of updates for net-next; along with the usual flurry
  of small fixes, cleanups and internal features we have:
  * VHT support for TDLS and IBSS (conditional on drivers though)
  * first TX performance improvements (the biggest will come later)
  * many suspend/resume (race) fixes
  * name_assign_type support from Tom Gundersen
  ====================

  Signed-off-by: David S. Miller <davem@davemloft.net>

  David S. Miller

  2015-04-01 04:39:04 +0800  

30 Mar, 2015

3 commits

• abcff6ef0   mac80211: add VHT support for IBSS ... Browse Code »

  Add VHT support for IBSS. Drivers could activate
  this feature by setting NL80211_EXT_FEATURE_VHT_IBSS
  flag.

  Signed-off-by: Janusz Dziedzic
  Signed-off-by: Johannes Berg

  Janusz.Dziedzic@tieto.com

  2015-03-30 16:48:26 +0800  
• 76bed0f43   mac80211: IBSS fix scan request ... Browse Code »

  In case of wide bandwidth (wider than 20MHz) used by IBSS,
  scan all channels in chandef to be able to find neighboring
  IBSS netwqworks that use the same overall channels but a different
  control channel.

  Signed-off-by: Janusz Dziedzic
  Signed-off-by: Johannes Berg

  Janusz.Dziedzic@tieto.com

  2015-03-30 16:47:56 +0800  
• 527871d72   mac80211: make sta.wme indicate whether QoS is used ... Browse Code »

  Indicating just the peer's capability is fairly pointless
  if the local device doesn't support it. Make the variable
  track both combined, and remove the 'local support' check
  in the TX path.

  Signed-off-by: Johannes Berg

  Johannes Berg

  2015-03-30 16:47:16 +0800  

20 Mar, 2015

1 commit

• e8f4fb7c7   mac80211: remove drop_unencrypted code ... Browse Code »

  This mechanism was historic, and only ever used by IBSS, which
  also doesn't need to have it as it properly manages station's
  802.1X PAE state (or, with WEP, always has a key.)

  Remove the mechanism to clean up the code.

  Signed-off-by: Johannes Berg

  Johannes Berg

  2015-03-20 18:37:36 +0800  

17 Mar, 2015

1 commit

• 8a4988d13   mac80211: IBSS: refactor ieee80211_rx_bss_info ... Browse Code »

  Put station specific code in ieee80211_update_sta_info
  function.

  Signed-off-by: Janusz Dziedzic
  Signed-off-by: Johannes Berg

  Janusz.Dziedzic@tieto.com

  2015-03-17 18:06:53 +0800  

04 Mar, 2015

1 commit

• c84a67a2f   mac80211: Use eth_<foo>_addr instead of memset ... Browse Code »

  Use the built-in function instead of memset.

  Signed-off-by: Joe Perches
  Signed-off-by: David S. Miller

  Joe Perches

  2015-03-04 06:01:38 +0800  

03 Mar, 2015

1 commit

• 6eb181376   cfg80211: add bss_type and privacy arguments in cfg80211_get_bss() ... Browse Code »

  802.11ad adds new a network type (PBSS) and changes the capability
  field interpretation for the DMG (60G) band.
  The same 2 bits that were interpreted as "ESS" and "IBSS" before are
  re-used as a 2-bit field with 3 valid values (and 1 reserved). Valid
  values are: "IBSS", "PBSS" (new) and "AP".

  In order to get the BSS struct for the new PBSS networks, change the
  cfg80211_get_bss() function to take a new enum ieee80211_bss_type
  argument with the valid network types, as "capa_mask" and "capa_val"
  no longer work correctly (the search must be band-aware now.)

  The remaining bits in "capa_mask" and "capa_val" are used only for
  privacy matching so replace those two with a privacy enum as well.

  Signed-off-by: Dedy Lansky
  [rewrite commit log, tiny fixes]
  Signed-off-by: Johannes Berg

  Dedy Lansky

  2015-03-03 22:56:01 +0800  

17 Dec, 2014

1 commit

• d29544571   mac80211: notify NSS changed when IBSS and HT ... Browse Code »

  When using IBSS in HT mode, we always get NSS=1
  in rc_update callback. Force NSS recalculation when
  rates updated and notify driver that NSS changed.

  Signed-off-by: Janusz Dziedzic
  Signed-off-by: Johannes Berg

  Janusz Dziedzic

  2014-12-17 18:47:26 +0800