09 Jun, 2014

1 commit

  • When the user does:

    make -C tools/perf LDFLAGS=-static

    asking for a static build, and the glibc-static (or equivalent) is not
    found, the message wasn't clear, stating that one of glibc-devel or
    glibc-static wasn't installed, clarify it checking if -static is
    present in LDFLAGS.

    Cc: Adrian Hunter
    Cc: David Ahern
    Cc: Don Zickus
    Cc: Frederic Weisbecker
    Cc: Ingo Molnar
    Cc: Mike Galbraith
    Cc: Namhyung Kim
    Cc: Paul Mackerras
    Cc: Peter Zijlstra
    Cc: Stephane Eranian
    Link: http://lkml.kernel.org/n/tip-7e0sfobbzgeydzi9gsz8ss3m@git.kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo

    Arnaldo Carvalho de Melo
     

04 Jun, 2014

2 commits

  • Currently 'make help' message has such hint:

    use "make prefix= " to install to a particular
    path like make prefix=/usr/local install install-doc

    But this is misleading, when I specify "prefix=/usr/local", it has got no
    respect at all.

    This is because that, "DESTDIR" is considered first. In this case, "DESTDIR"
    has an empty value, so "prefix" is honored. However, "prefix" is unconditionally
    assigned to $HOME, regardless of what it is set to from command line. So our
    "prefix" setting got no respect and the actual destination falls back to $HOME.

    This patch fixes this issue and corrects the help message.

    Signed-off-by: Jianyu Zhan
    Acked-by: Namhyung Kim
    Link: http://lkml.kernel.org/r/1401727474-19370-1-git-send-email-nasa4836@gmail.com
    Signed-off-by: Jiri Olsa

    Jianyu Zhan
     
  • We were just showing "libperl: OFF", unlike other features where we
    present the user with a message helping have a feature built in.

    Fix it by adding the following message:

    config/Makefile:450: Missing perl devel files. Disabling perl scripting support, consider installing perl-ExtUtils-Embed

    Signed-off-by: Arnaldo Carvalho de Melo
    Cc: Adrian Hunter
    Cc: David Ahern
    Cc: Don Zickus
    Cc: Frederic Weisbecker
    Cc: Mike Galbraith
    Cc: Namhyung Kim
    Cc: Paul Mackerras
    Cc: Peter Zijlstra
    Cc: Stephane Eranian
    Link: http://lkml.kernel.org/n/tip-t7yeud34ehimlfi6pklb29p7@git.kernel.org
    Signed-off-by: Jiri Olsa

    Arnaldo Carvalho de Melo
     

16 May, 2014

1 commit

  • Adding dwarf unwind test, that setups live machine data over
    the perf test thread and does the remote unwind.

    Need to use -fno-optimize-sibling-calls for test compilation,
    otherwise 'krava_*' function calls are optimized into jumps
    and omitted from the stack unwind.

    So far it was enabled only for x86.

    Signed-off-by: Jean Pihet
    Reviewed-by: Will Deacon
    Cc: Arnaldo Carvalho de Melo
    Cc: Corey Ashford
    Cc: David Ahern
    Cc: Frederic Weisbecker
    Cc: Ingo Molnar
    Cc: Namhyung Kim
    Cc: Paul Mackerras
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/1400229672-16104-3-git-send-email-jean.pihet@linaro.org
    Signed-off-by: Jiri Olsa

    Jean Pihet
     

12 May, 2014

1 commit

  • The on_exit() function was only used in perf record but it's gone in
    previous patch.

    Signed-off-by: Namhyung Kim
    Acked-by: Stephane Eranian
    Cc: Bernhard Rosenkraenzer
    Cc: Irina Tirdea
    Link: http://lkml.kernel.org/r/1399855645-25815-2-git-send-email-namhyung@kernel.org
    Signed-off-by: Jiri Olsa

    Namhyung Kim
     

01 May, 2014

1 commit

  • …/jolsa/perf into perf/core

    Pull perf/core improvements and fixes from Jiri Olsa:

    * Wire up perf_regs and unwind support for ARM64 (Jean Pihet)

    * Move u64_swap union to its single user's header, evsel.h (Borislav Petkov)

    * Fix for s390 to properly parse tracepoints plus test code (Alexander Yarygin)

    * Handle EINTR error for readn/writen (Namhyung Kim)

    Signed-off-by: Jiri Olsa <jolsa@kernel.org>
    Signed-off-by: Ingo Molnar <mingo@kernel.org>

    Ingo Molnar
     

30 Apr, 2014

2 commits

  • arch/x86/tests/regs_load.S is missing the linker note about the stack
    requirements, therefore making the linker fall back to an executable
    stack. As this object gets linked against the final perf binary, it'll
    needlessly end up with an executable stack. Fix this by adding the
    appropriate linker note.

    Also add a global linker flag to prevent future regressions, as
    suggested by Jiri. This way perf won't get an executable stack even if
    we fail to add the .GNU-stack linker note to future assembler files.
    Though, doing so might create regressions the other way around, when
    (statically) linking against libraries needing an executable stack.
    But, apparently, regressing in that direction is wanted as it is an
    indicator of poor code quality -- or just missing linker notes.

    Fixes: 3c8b06f981 ("perf tests x86: Introduce perf_regs_load function")

    Signed-off-by: Mathias Krause
    Acked-by: Ingo Molnar
    Cc: Arnaldo Carvalho de Melo
    Cc: Paul Mackerras
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/1398617466-22749-1-git-send-email-minipli@googlemail.com
    Signed-off-by: Jiri Olsa

    Mathias Krause
     
  • There's false assumption in the library detection code
    assuming -liberty and -lz are always present once bfd
    is detected. The fails on Ubuntu (14.04) as reported
    by Ingo.

    Forcing the bdf dependency libraries detection any
    time bfd library is detected.

    Reported-by: Ingo Molnar
    Tested-by: Ingo Molnar
    Cc: Arnaldo Carvalho de Melo
    Cc: Corey Ashford
    Cc: David Ahern
    Cc: Frederic Weisbecker
    Cc: Ingo Molnar
    Cc: Namhyung Kim
    Cc: Paul Mackerras
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/1398676935-6615-1-git-send-email-jolsa@kernel.org
    Signed-off-by: Jiri Olsa

    Jiri Olsa
     

29 Apr, 2014

1 commit

  • This patch hooks in the perf_regs and libunwind code for ARM64.
    The tools/perf/arch/arm64 is created; it contains the arch specific
    code for DWARF unwinding.

    Signed-off-by: Jean Pihet
    Acked-by: Will Deacon
    Link: http://lkml.kernel.org/r/1398688353-3737-1-git-send-email-jean.pihet@linaro.org
    Signed-off-by: Jiri Olsa

    Jean Pihet
     

23 Apr, 2014

1 commit

  • So far there's only x86 libdw unwind support merged in perf.
    Disable it on all other architectures in case libdw unwind
    support is detected in system.

    Cc: Arnaldo Carvalho de Melo
    Cc: Corey Ashford
    Cc: David Ahern
    Cc: Frederic Weisbecker
    Cc: Ingo Molnar
    Cc: Jean Pihet
    Cc: Josh Boyer
    Cc: Namhyung Kim
    Cc: Paul Mackerras
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/1397988006-14158-1-git-send-email-jolsa@redhat.com
    Signed-off-by: Jiri Olsa

    Jiri Olsa
     

14 Apr, 2014

3 commits

  • Conflicts:
    tools/perf/bench/numa.c

    Pull perf fixes from Jiri Olsa.

    Signed-off-by: Ingo Molnar

    Ingo Molnar
     
  • The Makefile logic sets FEATURE_CHECKS_CFLAGS-libdw-dwarf-unwind and
    FEATURE_CHECKS_LDFLAGS-libdw-dwarf-unwind only if LIBDW_DIR is
    defined. This means that under a normal setup,

    $ make NO_LIBUNWIND=1

    won't automatically pick up libdw. Fix this.

    Signed-off-by: Ramkumar Ramachandra
    Acked-by: Jean Pihet
    Cc: Arnaldo Carvalho de Melo
    Cc: Jiri Olsa
    Link: http://lkml.kernel.org/r/1395873845-466-1-git-send-email-artagnon@gmail.com
    Signed-off-by: Jiri Olsa

    Ramkumar Ramachandra
     
  • I.e. do the same as when NO_LIBELF is explicitely passed in the 'make'
    command line, fixing this:

    Auto-detecting system features:
    ... dwarf: [ OFF ]
    ... glibc: [ on ]
    ... gtk2: [ OFF ]
    ... libaudit: [ OFF ]
    ... libbfd: [ OFF ]
    ... libelf: [ OFF ]
    ... libunwind: [ OFF ]
    ... libdw-dwarf-unwind: [ OFF ]
    ... DWARF post unwind library: libdw

    CC /tmp/build/perf/util/symbol-minimal.o
    CC /tmp/build/perf/util/unwind-libdw.o
    arch/x86/util/unwind-libdw.c:1:30: fatal error: elfutils/libdwfl.h: No such file or directory
    compilation terminated.
    CC /tmp/build/perf/tests/keep-tracking.o
    util/unwind-libdw.c:2:28: fatal error: elfutils/libdw.h: No such file or directory
    compilation terminated.

    Cc: Adrian Hunter
    Cc: David Ahern
    Cc: Don Zickus
    Cc: Frederic Weisbecker
    Cc: Jiri Olsa
    Cc: Mike Galbraith
    Cc: Namhyung Kim
    Cc: Paul Mackerras
    Cc: Peter Zijlstra
    Cc: Stephane Eranian
    Link: http://lkml.kernel.org/n/tip-e39j1yxanltjx4t0msse63ax@git.kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo
    Signed-off-by: Jiri Olsa

    Arnaldo Carvalho de Melo
     

06 Apr, 2014

1 commit

  • Pull arch/tile updates from Chris Metcalf:
    "These fix a few stray build issues seen in linux-next, and also add
    the minimal required support for perf to tilegx"

    * git://git.kernel.org/pub/scm/linux/kernel/git/cmetcalf/linux-tile:
    arch/tile: remove unused variable 'devcap'
    tile: Fix vDSO compilation issue with allyesconfig
    perf tools: Allow building for tile
    tile/perf: Support perf_events on tilegx and tilepro
    tile: Enable NMIs on return from handle_nmi() without errors
    tile: Add support for handling PMC hardware
    tile: don't use __get_cpu_var() with structure-typed arguments
    tile: avoid overflow in ns2cycles

    Linus Torvalds
     

11 Mar, 2014

1 commit


08 Mar, 2014

1 commit


28 Feb, 2014

1 commit

  • opensuse libbfd requires -lz -liberty to build. Add those to the BFD
    feature detection.

    Signed-off-by: Andi Kleen
    Acked-by: David Ahern
    Acked-by: Jiri Olsa
    Cc: Adrian Hunter
    Cc: David Ahern
    Cc: Frederic Weisbecker
    Cc: Ingo Molnar
    Cc: Jiri Olsa
    Cc: Namhyung Kim
    Link: http://lkml.kernel.org/r/1389469379-13340-2-git-send-email-andi@firstfloor.org
    Signed-off-by: Arnaldo Carvalho de Melo

    Andi Kleen
     

24 Feb, 2014

6 commits

  • Factor NO_LIBDW_DWARF_UNWIND makefile variable and code that selects
    default DWARf post unwinder based on detected features (libdw and
    libunwind support)

    If both are detected the libunwind is selected as default. Simple
    'make' will try to add:

    - libunwind unwinder if present
    - libdw unwinder if present
    - disable dwarf unwind if non of libunwind and libdw
    libraries are present

    If one of the DWARF unwind libraries is detected, message is displayed
    which one (libunwind/libdw) is compiled in.

    Examples:
    - compile in libdw unwinder if present:

    $ make NO_LIBUNWIND=1

    - compile in libdw (with libdw installation directory) unwinder if present:

    $ make LIBDW_DIR=/opt/elfutils/ NO_LIBUNWIND=1
    BUILD: Doing 'make -j4' parallel build

    Auto-detecting system features:
    ... dwarf: [ on ]
    ... glibc: [ on ]
    ... gtk2: [ on ]
    ... libaudit: [ on ]
    ... libbfd: [ on ]
    ... libelf: [ on ]
    ... libnuma: [ on ]
    ... libperl: [ on ]
    ... libpython: [ on ]
    ... libslang: [ on ]
    ... libunwind: [ on ]
    ... libdw-dwarf-unwind: [ on ]
    ... DWARF post unwind library: libdw

    - disable post dwarf unwind completely:

    $ make NO_LIBUNWIND=1 NO_LIBDW_DWARF_UNWIND=1
    BUILD: Doing 'make -j4' parallel build

    Auto-detecting system features:
    ... dwarf: [ on ]
    ... glibc: [ on ]
    ... gtk2: [ on ]
    ... libaudit: [ on ]
    ... libbfd: [ on ]
    ... libelf: [ on ]
    ... libnuma: [ on ]
    ... libperl: [ on ]
    ... libpython: [ on ]
    ... libslang: [ on ]
    ... libunwind: [ on ]
    ... libdw-dwarf-unwind: [ on ]
    ... DWARF post unwind library: libunwind

    Signed-off-by: Jiri Olsa
    Cc: Corey Ashford
    Cc: David Ahern
    Cc: Frederic Weisbecker
    Cc: Ingo Molnar
    Cc: Jean Pihet
    Cc: Namhyung Kim
    Cc: Paul Mackerras
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/1392825179-5228-6-git-send-email-jolsa@redhat.com
    [ Add suggestion about setting LIBDW_DIR when not finding libdw ]
    Signed-off-by: Arnaldo Carvalho de Melo

    Jiri Olsa
     
  • Adding libdw DWARF post unwind support, which is part of
    elfutils-devel/libdw-dev package from version 0.158.

    The new code is contained in unwin-libdw.c object, and implements
    unwind__get_entries unwind interface function.

    New Makefile variable NO_LIBDW_DWARF_UNWIND was added to control its
    compilation, and is marked as disabled now. It's factored with the rest
    of the Makefile unwind build code in the next patch.

    Arch specific code was added for x86.

    Signed-off-by: Jiri Olsa
    Cc: Corey Ashford
    Cc: David Ahern
    Cc: Frederic Weisbecker
    Cc: Ingo Molnar
    Cc: Jean Pihet
    Cc: Namhyung Kim
    Cc: Paul Mackerras
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/1392825179-5228-5-git-send-email-jolsa@redhat.com
    Signed-off-by: Arnaldo Carvalho de Melo

    Jiri Olsa
     
  • Adding feature check test code for libdw dwarf unwind.

    Signed-off-by: Jiri Olsa
    Cc: Corey Ashford
    Cc: David Ahern
    Cc: Frederic Weisbecker
    Cc: Ingo Molnar
    Cc: Jean Pihet
    Cc: Namhyung Kim
    Cc: Paul Mackerras
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/1392825179-5228-4-git-send-email-jolsa@redhat.com
    Signed-off-by: Arnaldo Carvalho de Melo

    Jiri Olsa
     
  • When one has libunwind installed somewhere the perf tools build process
    doesn't expects it to be, this happens:

    [acme@ssdandy linux]$ make O=/tmp/build/perf -C tools/perf/ install-bin
    make: Entering directory `/home/acme/git/linux/tools/perf'
    BUILD: Doing 'make -j8' parallel build
    config/Makefile:312: No libunwind found, disabling post unwind support. Please install libunwind-dev[el] >= 1.1

    Auto-detecting system features:

    ... libunwind: [ OFF ]

    Change the message so that it tells how to use a non-standard libunwind
    install directory:

    config/Makefile:312: No libunwind found, disabling post unwind support. Please install libunwind-dev[el] >= 1.1 and/or set LIBUNWIND_DIR

    [acme@ssdandy linux]$ make LIBUNWIND_DIR=/opt/libunwind-git/ O=/tmp/build/perf -C tools/perf/ install-bin
    make: Entering directory `/home/acme/git/linux/tools/perf'
    BUILD: Doing 'make -j8' parallel build

    Auto-detecting system features:

    ... libunwind: [ on ]

    Acked-by: Jiri Olsa
    Cc: Adrian Hunter
    Cc: David Ahern
    Cc: Frederic Weisbecker
    Cc: Jiri Olsa
    Cc: Mike Galbraith
    Cc: Namhyung Kim
    Cc: Paul Mackerras
    Cc: Peter Zijlstra
    Cc: Stephane Eranian
    Link: http://lkml.kernel.org/n/tip-huoxnou7sw85lm58k3pi1xhw@git.kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo

    Arnaldo Carvalho de Melo
     
  • Adding dump of interesting build directories to the make VF=1 output.

    $ make VF=1
    BUILD: Doing 'make -j4' parallel build

    Auto-detecting system features:
    ... dwarf: [ on ]
    ... glibc: [ on ]
    ... gtk2: [ on ]
    ... libaudit: [ on ]
    ... libbfd: [ on ]
    ... libelf: [ on ]
    ... libnuma: [ on ]
    ... libperl: [ on ]
    ... libpython: [ on ]
    ... libslang: [ on ]
    ... libunwind: [ on ]
    ... backtrace: [ on ]
    ... fortify-source: [ on ]
    ... gtk2-infobar: [ on ]
    ... libelf-getphdrnum: [ on ]
    ... libelf-mmap: [ on ]
    ... libpython-version: [ on ]
    ... on-exit: [ on ]
    ... stackprotector-all: [ on ]
    ... timerfd: [ on ]
    ... libunwind-debug-frame: [ OFF ]
    ... bionic: [ OFF ]

    ... prefix: /home/jolsa
    ... bindir: /home/jolsa/bin
    ... libdir: /home/jolsa/lib64
    ... sysconfdir: /home/jolsa/etc

    Adding functions to print variable/text in features display -
    feature_print_var/feature_print_text (feature_print_text is used in next
    patches).

    Signed-off-by: Jiri Olsa
    Cc: Corey Ashford
    Cc: David Ahern
    Cc: Frederic Weisbecker
    Cc: Ingo Molnar
    Cc: Jean Pihet
    Cc: Namhyung Kim
    Cc: Paul Mackerras
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/1392825179-5228-3-git-send-email-jolsa@redhat.com
    Signed-off-by: Arnaldo Carvalho de Melo

    Jiri Olsa
     
  • Currently the we display all detected features/libraries by following
    rules:

    - if one of the features is missing
    - if it's build from clean tree

    This patch changes changes this behavior in several ways.

    - We no longer display all detected features, only detected libraries
    are displayed by default:

    $ make
    BUILD: Doing 'make -j4' parallel build

    Auto-detecting system features:
    ... dwarf: [ on ]
    ... glibc: [ on ]
    ... gtk2: [ on ]
    ... libaudit: [ on ]
    ... libbfd: [ on ]
    ... libelf: [ on ]
    ... libnuma: [ on ]
    ... libperl: [ on ]
    ... libpython: [ on ]
    ... libslang: [ on ]
    ... libunwind: [ on ]

    The assumption is, that above libraries are the most interesting part
    of the detection, while we don't care much about detection of on-exit
    support.

    - If all above libraries are detected, the default is not shown on
    subsequent builds.

    - If one of the above libraries is missing, the detection output is
    forced.

    - The features status is stored in PERF-FEATURES file and the detection
    output is forced in case the there's difference between the file
    contents and currently detected features.

    - If you want to see all detected features, you can use VF=1 make
    variable, that forces the detected features output.

    $ make VF=1
    BUILD: Doing 'make -j4' parallel build

    Auto-detecting system features:
    ... dwarf: [ on ]
    ... glibc: [ on ]
    ... gtk2: [ on ]
    ... libaudit: [ on ]
    ... libbfd: [ on ]
    ... libelf: [ on ]
    ... libnuma: [ on ]
    ... libperl: [ on ]
    ... libpython: [ on ]
    ... libslang: [ on ]
    ... libunwind: [ on ]
    ... backtrace: [ on ]
    ... fortify-source: [ on ]
    ... gtk2-infobar: [ on ]
    ... libelf-getphdrnum: [ on ]
    ... libelf-mmap: [ on ]
    ... libpython-version: [ on ]
    ... on-exit: [ on ]
    ... stackprotector-all: [ on ]
    ... timerfd: [ on ]
    ... libunwind-debug-frame: [ OFF ]
    ... bionic: [ OFF ]

    Signed-off-by: Jiri Olsa
    Cc: Corey Ashford
    Cc: David Ahern
    Cc: Frederic Weisbecker
    Cc: Ingo Molnar
    Cc: Jean Pihet
    Cc: Namhyung Kim
    Cc: Paul Mackerras
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/1392825179-5228-2-git-send-email-jolsa@redhat.com
    Signed-off-by: Arnaldo Carvalho de Melo

    Jiri Olsa
     

18 Feb, 2014

1 commit

  • Introducing global macro HAVE_DWARF_UNWIND_SUPPORT to indicate we have
    dwarf unwind support. Any library providing the dwarf post unwind
    support will enable this macro.

    Signed-off-by: Jiri Olsa
    Acked-by: Jean Pihet
    Cc: Corey Ashford
    Cc: David Ahern
    Cc: Frederic Weisbecker
    Cc: Ingo Molnar
    Cc: Jean Pihet
    Cc: Namhyung Kim
    Cc: Paul Mackerras
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/1389098853-14466-12-git-send-email-jolsa@redhat.com
    Signed-off-by: Arnaldo Carvalho de Melo

    Jiri Olsa
     

24 Jan, 2014

1 commit

  • The plugindir_SQ definition contains $(prefix) which is not needed as
    the $(libdir) definition already contains prefix in it. This leads to
    the path including an extra prefix in it, e.g. /usr/usr/lib64.

    The -DPLUGIN_DIR defintion includes DESTDIR. This is incorrect, as it
    sets the plugin search path to include the value of DESTDIR. DESTDIR is
    a mechanism to install in a non-standard location such as a chroot or an
    RPM build root. In the RPM case, this leads to the search path being
    incorrect after the resulting RPM is installed (or in some cases an RPM
    build failure).

    Remove both of these unnecessary inclusions.

    Signed-off-by: Josh Boyer
    Acked-by: Jiri Olsa
    Cc: Ingo Molnar
    Cc: Jiri Olsa
    Cc: Steven Rostedt
    Link: http://lkml.kernel.org/r/20140122150147.GK16455@hansolo.jdub.homelinux.org
    Signed-off-by: Arnaldo Carvalho de Melo

    Josh Boyer
     

16 Jan, 2014

1 commit

  • Currently the feature-checks Makefile does not inherit $(CC), and calls
    cc rather than $(CROSS_COMPILE)gcc. Thus the feature checks invoke the
    native toolchain rather than the cross toolchain, and can identify
    features as available when they are not. This can break the build.

    Additionally the native pkg-config is always called as opposed to
    $(CROSS_COMPILE)pkg-config, so the wrong flags and paths may be passed
    to the cross compiler.

    This patch passes CROSS_COMPILE down to the feature-checks Makefile, and
    forces its use. Additionally pkg-config is replaced with
    $(CROSS_COMPILE)pkg-config via a new $(PKG_CONFIG) variable. This patch
    has been build tested on x86_64 and arm.

    Signed-off-by: Mark Rutland
    Cc: Ingo Molnar
    Cc: Jiri Olsa
    Cc: Will Deacon
    Link: http://lkml.kernel.org/r/1389782648-4417-4-git-send-email-mark.rutland@arm.com
    Signed-off-by: Arnaldo Carvalho de Melo

    Mark Rutland
     

14 Jan, 2014

1 commit

  • Since commit 01287e2cb7ad, test-volatile-register-var.c is no more built
    as part of the automatic feature check.

    This patch remove the unneeded file.

    Signed-off-by: Yann Droneaud
    Cc: David Ahern
    Cc: Ingo Molnar
    Cc: Jiri Olsa
    Cc: Namhyung Kim
    Cc: Paul Mackerras
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/339d86ad76741ed929defd18541f774b404003b4.1389461371.git.ydroneaud@opteya.com
    Signed-off-by: Arnaldo Carvalho de Melo

    Yann Droneaud
     

13 Jan, 2014

3 commits

  • So that it can be shared with others like libtraceevent.

    Signed-off-by: Namhyung Kim
    Acked-by: Borislav Petkov
    Cc: Frederic Weisbecker
    Cc: Ingo Molnar
    Cc: Jiri Olsa
    Cc: Namhyung Kim
    Cc: Steven Rostedt
    Link: http://lkml.kernel.org/r/1389276059-8829-2-git-send-email-namhyung@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo

    Namhyung Kim
     
  • Instead of explicitly adding same value into
    FEATURE_CHECK_(C|LD)FLAGS-all variables we can do that automatically.

    Signed-off-by: Jiri Olsa
    Cc: Corey Ashford
    Cc: David Ahern
    Cc: Frederic Weisbecker
    Cc: Ingo Molnar
    Cc: Jean Pihet
    Cc: Namhyung Kim
    Cc: Paul Mackerras
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/1389098853-14466-2-git-send-email-jolsa@redhat.com
    Signed-off-by: Arnaldo Carvalho de Melo

    Jiri Olsa
     
  • I need to use arch related setup in the tests/make, so moving arch setup
    into Makefile.arch.

    Signed-off-by: Jiri Olsa
    Cc: Corey Ashford
    Cc: David Ahern
    Cc: Frederic Weisbecker
    Cc: Ingo Molnar
    Cc: Namhyung Kim
    Cc: Paul Mackerras
    Cc: Peter Zijlstra
    Link: http://lkml.kernel.org/r/1388759553-12974-1-git-send-email-jolsa@redhat.com
    Signed-off-by: Arnaldo Carvalho de Melo

    Jiri Olsa
     

24 Dec, 2013

1 commit

  • 1. Rename the test-* binary files to test-*.bin for easier pattern matching as
    suggested by Ingo.
    2. Ignore *.bin and *.d files.

    Signed-off-by: Chunwei Chen
    Reviewed-by: Ingo Molnar
    Acked-by: Jiri Olsa
    Cc: Ingo Molnar
    Cc: Jiri Olsa
    Link: http://lkml.kernel.org/r/52B52B9B.50708@gmail.com
    Signed-off-by: Arnaldo Carvalho de Melo

    Chunwei Chen
     

20 Dec, 2013

1 commit

  • Moving QUIET_(CLEAN|INSTAL) variables into:

    tools/scripts/Makefile.include

    to be usable by other tools. The change to use them in libtraceevent is
    in following patches.

    Signed-off-by: Jiri Olsa
    Cc: Corey Ashford
    Cc: David Ahern
    Cc: Frederic Weisbecker
    Cc: Ingo Molnar
    Cc: Namhyung Kim
    Cc: Paul Mackerras
    Cc: Peter Zijlstra
    Cc: Steven Rostedt
    Link: http://lkml.kernel.org/r/1387460527-15030-3-git-send-email-jolsa@redhat.com
    Signed-off-by: Arnaldo Carvalho de Melo

    Jiri Olsa
     

11 Dec, 2013

2 commits

  • Use the per-feature check flags for the unwinding feature in order to
    correctly compile the test-all, libunwind and libunwind-debug-frame
    feature checks.

    Tested on x86_64, ARMv7 and ARMv8 with and without LIBUNWIND_DIR set in
    'make -C tools/perf'

    Signed-off-by: Jean Pihet
    Acked-by: Ingo Molnar
    Acked-by: Jiri Olsa
    Cc: Ingo Molnar
    Cc: Jiri Olsa
    Cc: Will Deacon
    Cc: linaro-kernel@lists.linaro.org
    Cc: patches@linaro.org
    Link: http://lkml.kernel.org/r/1386678244-13535-3-git-send-email-jean.pihet@linaro.org
    Signed-off-by: Arnaldo Carvalho de Melo

    Jean Pihet
     
  • Add CFLAGS and LDFLAGS for each feature to be checked. This allows to
    pass flags and parameters to the feature checks compilation. Also
    simplifies the feature check makefile, to come in a subsequent patch.

    Signed-off-by: Jean Pihet
    Acked-by: Ingo Molnar
    Acked-by: Jiri Olsa
    Cc: Ingo Molnar
    Cc: Jiri Olsa
    Cc: Will Deacon
    Cc: linaro-kernel@lists.linaro.org
    Cc: patches@linaro.org
    Link: http://lkml.kernel.org/r/1386678244-13535-2-git-send-email-jean.pihet@linaro.org
    Signed-off-by: Arnaldo Carvalho de Melo

    Jean Pihet
     

05 Dec, 2013

2 commits

  • Adding 'plugins' target along with the libtraceevent.a, so plugins are
    built together with traceevent library.

    Adding 'install-traceevent-plugins' Makefile install target, instructing
    perf to install plugins into:

    $(HOME)/.traceevent/plugins
    - If installed localy under $HOME

    $(DESTDIR)/$(prefix)/$(libdir)/traceevent/plugins
    - If installed globally

    Examples:
    $ make install
    ...
    $ find ~/.traceevent/plugins/
    /home/jolsa/.traceevent/plugins/
    /home/jolsa/.traceevent/plugins/plugin_mac80211.so
    /home/jolsa/.traceevent/plugins/plugin_kvm.so
    /home/jolsa/.traceevent/plugins/plugin_scsi.so
    /home/jolsa/.traceevent/plugins/plugin_sched_switch.so
    /home/jolsa/.traceevent/plugins/plugin_xen.so
    /home/jolsa/.traceevent/plugins/plugin_cfg80211.so
    /home/jolsa/.traceevent/plugins/plugin_function.so
    /home/jolsa/.traceevent/plugins/plugin_kmem.so
    /home/jolsa/.traceevent/plugins/plugin_hrtimer.so
    /home/jolsa/.traceevent/plugins/plugin_jbd2.so

    $ sudo make install DESTDIR=/opt/perf/
    ...
    $ find /opt/perf/lib64/traceevent/plugins/
    /opt/perf/lib64/traceevent/plugins/
    /opt/perf/lib64/traceevent/plugins/plugin_kvm.so
    /opt/perf/lib64/traceevent/plugins/plugin_scsi.so
    /opt/perf/lib64/traceevent/plugins/plugin_mac80211.so
    /opt/perf/lib64/traceevent/plugins/plugin_hrtimer.so
    /opt/perf/lib64/traceevent/plugins/plugin_kmem.so
    /opt/perf/lib64/traceevent/plugins/plugin_jbd2.so
    /opt/perf/lib64/traceevent/plugins/plugin_sched_switch.so
    /opt/perf/lib64/traceevent/plugins/plugin_function.so
    /opt/perf/lib64/traceevent/plugins/plugin_cfg80211.so
    /opt/perf/lib64/traceevent/plugins/plugin_xen.so

    Signed-off-by: Jiri Olsa
    Cc: Corey Ashford
    Cc: David Ahern
    Cc: Frederic Weisbecker
    Cc: Ingo Molnar
    Cc: Namhyung Kim
    Cc: Paul Mackerras
    Cc: Peter Zijlstra
    Cc: Steven Rostedt
    Link: http://lkml.kernel.org/r/1386076182-14484-8-git-send-email-jolsa@redhat.com
    Signed-off-by: Arnaldo Carvalho de Melo

    Jiri Olsa
     
  • We use -fstack-protector-all option to enable stack protecting for all
    available functions. There's no reason for enabling -Wstack-protector to
    get warning for unprotected functions.

    Removing stackprotector feature check which was used to enable the
    -Wstack-protector option.

    Signed-off-by: Jiri Olsa
    Cc: Corey Ashford
    Cc: David Ahern
    Cc: Frederic Weisbecker
    Cc: Ingo Molnar
    Cc: Namhyung Kim
    Cc: Paul Mackerras
    Cc: Peter Zijlstra
    Cc: Steven Rostedt
    Link: http://lkml.kernel.org/r/1386076182-14484-2-git-send-email-jolsa@redhat.com
    Signed-off-by: Arnaldo Carvalho de Melo

    Jiri Olsa
     

03 Dec, 2013

1 commit

  • We're missing test-stackprotector-all.c in test-all check, adding it.

    Signed-off-by: Jiri Olsa
    Cc: Corey Ashford
    Cc: David Ahern
    Cc: Frederic Weisbecker
    Cc: Ingo Molnar
    Cc: Namhyung Kim
    Cc: Paul Mackerras
    Cc: Peter Zijlstra
    Cc: Steven Rostedt
    Link: http://lkml.kernel.org/r/1385638408-23519-3-git-send-email-jolsa@redhat.com
    Signed-off-by: Arnaldo Carvalho de Melo

    Jiri Olsa
     

02 Dec, 2013

1 commit

  • The package required for numa is named numactl-devel in Fedora or RHEL,
    and libnuma-devel in OpenSuSE, and libnuma-dev in Ubuntu.

    This patch corrects the package name in warning message in
    feature-libnuma checking.

    Signed-off-by: Dongsheng Yang
    Acked-by: Peter Hurley
    Cc: Peter Hurley
    Link: http://lkml.kernel.org/r/1385998008-6851-1-git-send-email-yangds.fnst@cn.fujitsu.com
    Signed-off-by: Arnaldo Carvalho de Melo

    Dongsheng Yang
     

15 Nov, 2013

1 commit

  • Set feature-libunwind-debug-frame. We don't want it in
    CORE_FEATURE_TESTS because it's not the generic case, but we
    need to set it in the !feature-libunwind case.

    Also, because x86 distributions typically don't have
    dwarf_find_debug_frame() unwinding method:

    test-libunwind-debug-frame.c:(.text+0x31): undefined reference to `_Ux86_64_dwarf_find_debug_frame'

    Restrict this new API to ARM for the time being.

    With this patch test-all.c works again, so repeat perf builds
    are fast again:

    comet:~/tip> perf stat --null --repeat 5 make -C tools/perf/
    [...]

    0,452899660 seconds time elapsed ( +- 0,11% )

    While with before it was:

    comet:~/tip> perf stat --null --repeat 5 make -C tools/perf/
    [...]

    1,674001829 seconds time elapsed ( +- 0,16% )

    [ Includes fix to config/feature-checks/Makefile from Will Deacon. ]

    Tested-by: Will Deacon
    Tested-by: Jean Pihet
    Cc: Russell King
    Cc: Linus Torvalds
    Cc: Arnaldo Carvalho de Melo
    Cc: Jiri Olsa
    Link: http://lkml.kernel.org/n/tip-scsoctqzmou3rpkixCHezy9e@git.kernel.org
    Signed-off-by: Ingo Molnar

    Ingo Molnar
     

14 Nov, 2013

1 commit

  • 'feature_timerfd' is checked all the time and calculated explicitly,
    in a serial fashion. Add it to CORE_FEATURE_TESTS which causes it to
    be built in parallel, using the newfangled parallel build autodetection
    code.

    This shaves 137 msecs off the perf build time on my system, which
    speeds up the common case cached build by 43%:

    Before:

    comet:~/tip> perf stat --null --repeat 5 make -C tools/perf/
    [...]
    0,453771441 seconds time elapsed ( +- 0,09% )

    After:

    comet:~/tip> perf stat --null --repeat 5 make -C tools/perf/
    [...]
    0,316290185 seconds time elapsed ( +- 0,24% )

    Cc: David Ahern
    Cc: Arnaldo Carvalho de Melo
    Cc: Linus Torvalds
    Link: http://lkml.kernel.org/n/tip-bb92CmexihopoSyqnkqepvsy@git.kernel.org
    Signed-off-by: Ingo Molnar

    Ingo Molnar