09 Jan, 2017

1 commit


13 Sep, 2016

1 commit

  • This patch alters the renamed extcon API to set the state of the external
    connectors instead of deprecated extcon_set_cable_state_().

    Because the patch[1] modifies the function name to maintain the function
    naming pattern.
    - extcon_set_cable_state_() -> extcon_set_state_sync()
    - extcon_get_cable_state_() -> extcon_get_state()

    [1] https://lkml.org/lkml/2016/8/4/729
    - extcon: Rename the extcon_set/get_state() to maintain the function naming pattern

    Signed-off-by: Chanwoo Choi
    Acked-by: Charles Keepax
    Acked-by: Roger Quadros

    Chanwoo Choi
     

05 Feb, 2016

1 commit

  • The info->status[] array has 3 elements. We are using size
    MAX77843_MUIC_IRQ_NUM (16) instead of MAX77843_MUIC_STATUS_NUM (3) as
    intended.

    Fixes: 135d9f7d135a ('extcon: max77843: Clear IRQ bits state before request IRQ')
    Signed-off-by: Dan Carpenter
    Reviewed-by: Jaewon Kim
    Reviewed-by: Krzysztof Kozlowski
    [cw00.choi: Modify the patch title]
    Signed-off-by: Chanwoo Choi

    Dan Carpenter
     

25 Jan, 2016

1 commit

  • This patch adds the new EXTCON_CHG_USB_SDP connector to support SDP (Standard
    Downstream Port) USB charging port. The commit 11eecf910bd8 ("extcon: Modify
    the id and name of external connector") add the new EXTCON_CHG_USB_SDP
    connector which support the both data transfer and usb charging at the same
    time.

    Signed-off-by: Chanwoo Choi
    Reviewed-by: Krzysztof Kozlowski

    Chanwoo Choi
     

15 Dec, 2015

1 commit

  • The function can return negative values, so its result should
    be assigned to signed variable.

    The problem has been detected using proposed semantic patch
    scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].

    [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107

    Signed-off-by: Andrzej Hajda
    Reviewed-by: Krzysztof Kozlowski
    Signed-off-by: Chanwoo Choi

    Andrzej Hajda
     

16 Oct, 2015

1 commit

  • This patch modifies the id and name of external connector with the
    additional prefix to clarify both attribute and meaning of external
    connector as following:
    - EXTCON_CHG_* mean the charger connector.
    - EXTCON_JACK_* mean the jack connector.
    - EXTCON_DISP_* mean the display port connector.

    Following table show the new name of external connector with old name:
    --------------------------------------------------
    Old extcon name | New extcon name |
    --------------------------------------------------
    EXTCON_TA | EXTCON_CHG_USB_DCP |
    EXTCON_CHARGE_DOWNSTREAM| EXTCON_CHG_USB_CDP |
    EXTCON_FAST_CHARGER | EXTCON_CHG_USB_FAST |
    EXTCON_SLOW_CHARGER | EXTCON_CHG_USB_SLOW |
    --------------------------------------------------
    EXTCON_MICROPHONE | EXTCON_JACK_MICROPHONE |
    EXTCON_HEADPHONE | EXTCON_JACK_HEADPHONE |
    EXTCON_LINE_IN | EXTCON_JACK_LINE_IN |
    EXTCON_LINE_OUT | EXTCON_JACK_LINE_OUT |
    EXTCON_VIDEO_IN | EXTCON_JACK_VIDEO_IN |
    EXTCON_VIDEO_OUT | EXTCON_JACK_VIDEO_OUT |
    EXTCON_SPDIF_IN | EXTCON_JACK_SPDIF_IN |
    EXTCON_SPDIF_OUT | EXTCON_JACK_SPDIF_OUT |
    --------------------------------------------------
    EXTCON_HMDI | EXTCON_DISP_HDMI |
    EXTCON_MHL | EXTCON_DISP_MHL |
    EXTCON_DVI | EXTCON_DISP_DVI |
    EXTCON_VGA | EXTCON_DISP_VGA |
    --------------------------------------------------

    And, when altering the name of USB charger connector, EXTCON refers to the
    "Battery Charging v1.2 Spec and Adopters Agreement"[1] to use the standard
    name of USB charging port as following. Following name of USB charging port
    are already used in power_supply subsystem. We chan check it on patch[2].
    - EXTCON_CHG_USB_SDP /* Standard Downstream Port */
    - EXTCON_CHG_USB_DCP /* Dedicated Charging Port */
    - EXTCON_CHG_USB_CDP /* Charging Downstream Port */
    - EXTCON_CHG_USB_ACA /* Accessory Charger Adapter */

    [1] www.usb.org/developers/docs/devclass_docs/BCv1.2_070312.zip
    [2] commit 85efc8a18ced ("power_supply: Add types for USB chargers")

    Signed-off-by: Chanwoo Choi
    [ckeepax: For the Arizona changes]
    Acked-by: Charles Keepax
    Reviewed-by: Roger Quadros

    Chanwoo Choi
     

01 Sep, 2015

1 commit

  • Pull regulator updates from Mark Brown:
    "The biggest changes in the core this time around have been some
    refactorings that move us towards being able to drop the list of
    regulators maintained by the core and instead just use the driver
    model list maintained for the class devices for regulators which will
    make the code smaller and avoid some potential bugs.

    Otherwise another fairly quiet release for the regulator API,
    highlights include:

    - a new API for setting voltages based on a minimum, target, maximum
    triplet

    - support for continuous voltage ranges rather than tables of
    explicit steps in the PWM regulator, requiring less explicit
    configuration

    - new driver support for Dialog DA9215, Maxim 77843, Mediatek MT6311
    and Qualcomm RPM"

    * tag 'regulator-v4.3' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator: (70 commits)
    regulator: mt6311: fix platform_no_drv_owner.cocci warnings
    regulator: ltc3589: Remove unnecessary MODULE_ALIAS()
    regulator: ad5398: Remove unnecessary MODULE_ALIAS()
    regulator: pfuze100: Remove unnecessary MODULE_ALIAS()
    regulator: core: use debug level print in regulator_check_drms
    regulator: lp872x: handle error case
    regulator: lp872x: use the private data instead of updating I2C device platform data
    regulator: isl9305: Export OF module alias information
    regulators: max77693: register driver earlier to avoid deferred probe
    regulator: qcom_smd: Set n_voltages for pm8941_lnldo
    regulator: core: Use IS_ERR_OR_NULL()
    regulator: core: Define regulator_set_voltage_triplet()
    regulator: Regulator driver for the Qualcomm RPM
    regulator: pbias: Fix broken pbias disable functionality
    regulator: core: Spelling fix
    regulator: core: Use class device list for regulator_list in late init
    regulator: core: Move more deallocation into class unregister
    regulator: core: Reduce rdev locking region when releasing regulator
    Input: Remove the max77843 haptic driver
    Input: max77693: Add support for Maxim 77843
    ...

    Linus Torvalds
     

10 Aug, 2015

1 commit


17 Jul, 2015

2 commits


13 Jun, 2015

1 commit

  • This patch just redefine the unique id of supported external connectors without
    'enum extcon' type. Because unique id would be used on devictree file(*.dts) to
    indicate the specific external connectors like key number of input framework.
    So, I have the plan to move this definitions to following header file which
    includes the unique id of supported external connectors.
    - include/dt-bindings/extcon/extcon.h

    Fixes: 2a9de9c0f08d ("extcon: Use the unique id for external connector instead of string")
    Signed-off-by: Chanwoo Choi
    Signed-off-by: Greg Kroah-Hartman

    Chanwoo Choi
     

22 May, 2015

1 commit

  • This patch uses the unique id to identify the type of external connector instead
    of string name. The string name have the many potential issues. So, this patch
    defines the 'extcon' enumeration which includes all supported external connector
    on EXTCON subsystem. If new external connector is necessary, the unique id of
    new connector have to be added in 'extcon' enumeration. There are current
    supported external connector in 'enum extcon' as following:

    enum extcon {
    EXTCON_NONE = 0x0,

    /* USB external connector */
    EXTCON_USB = 0x1,
    EXTCON_USB_HOST = 0x2,

    /* Charger external connector */
    EXTCON_TA = 0x10,
    EXTCON_FAST_CHARGER = 0x11,
    EXTCON_SLOW_CHARGER = 0x12,
    EXTCON_CHARGE_DOWNSTREAM = 0x13,

    /* Audio and video external connector */
    EXTCON_LINE_IN = 0x20,
    EXTCON_LINE_OUT = 0x21,
    EXTCON_MICROPHONE = 0x22,
    EXTCON_HEADPHONE = 0x23,

    EXTCON_HDMI = 0x30,
    EXTCON_MHL = 0x31,
    EXTCON_DVI = 0x32,
    EXTCON_VGA = 0x33,
    EXTCON_SPDIF_IN = 0x34,
    EXTCON_SPDIF_OUT = 0x35,
    EXTCON_VIDEO_IN = 0x36,
    EXTCON_VIDEO_OUT = 0x37,

    /* Miscellaneous external connector */
    EXTCON_DOCK = 0x50,
    EXTCON_JIG = 0x51,
    EXTCON_MECHANICAL = 0x52,

    EXTCON_END,
    };

    For example in extcon-arizona.c:
    To use unique id removes the potential issue about handling
    the inconsistent name of external connector with string.
    - Previously, use the string to register the type of arizona jack connector
    static const char *arizona_cable[] = {
    "Mechanical",
    "Microphone",
    "Headphone",
    "Line-out",
    };
    - Newly, use the unique id to register the type of arizona jack connector
    static const enum extcon arizona_cable[] = {
    EXTCON_MECHANICAL,
    EXTCON_MICROPHONE,
    EXTCON_HEADPHONE,
    EXTCON_LINE_OUT,

    EXTCON_NONE,
    };

    And this patch modify the prototype of extcon_{get|set}_cable_state_() which
    uses the 'enum extcon id' instead of 'cable_index'. Because although one more
    extcon drivers support USB cable, each extcon driver might has the differnt
    'cable_index' for USB cable. All extcon drivers can use the unique id number
    for same external connector with modified extcon_{get|set}_cable_state_().

    - Previously, use 'cable_index' on these functions:
    extcon_get_cable_state_(struct extcon_dev*, int cable_index)
    extcon_set_cable_state_(struct extcon_dev*, int cable_index, bool state)

    -Newly, use 'enum extcon id' on these functions:
    extcon_get_cable_state_(struct extcon_dev*, enum extcon id)
    extcon_set_cable_state_(struct extcon_dev*, enum extcon id, bool state)

    Cc: Arnd Bergmann
    Cc: Felipe Balbi
    Signed-off-by: Chanwoo Choi
    Acked-by: Roger Quadros
    Acked-by: Charles Keepax
    Acked-by: Ramakrishna Pallala
    Reviewed-by: Krzysztof Kozlowski
    [arnd: Report the build break about drivers/usb/phy/phy-tahvo.c after using the
    unique id for external connector insteadf of string]
    Reported-by: Arnd Bergmann
    [dan.carpenter: Report the build warning of extcon_{set|get}_cable_state_()]
    Reported-by: Dan Carpenter

    Chanwoo Choi
     

19 May, 2015

2 commits

  • This patch alters the MHL-TA cable name to TA cable name because MHL-TA is not
    standard name. The MHL-TA is MHL cable with charger cable (TA or USB). So, this
    patch use the TA cable instead of MHL-TA to inform the charger cable state.
    - MHL-TA -> TA

    Signed-off-by: Chanwoo Choi
    Reviewed-by: Krzysztof Kozlowski

    Chanwoo Choi
     
  • This patch change the name of various jig cables as 'JIG' because the name of
    various jig cables are strange and ambiguous on user-space aspect. They include
    the different information of either USB and UART state. It is never important
    for user-space process. This patch unifies the name of jig cables as following:
    - JIG-USB-ON -->|--> JIG
    - JIG-USB-OFF -->|
    - JIG-UART-ON -->|
    - JIG-UART-OFF -->|

    Signed-off-by: Chanwoo Choi

    Chanwoo Choi
     

23 Mar, 2015

1 commit


16 Mar, 2015

1 commit


24 Feb, 2015

1 commit