14 Feb, 2015

1 commit

  • Now that all bitmap formatting usages have been converted to
    '%*pb[l]', the separate formatting functions are unnecessary. The
    following functions are removed.

    * bitmap_scn[list]printf()
    * cpumask_scnprintf(), cpulist_scnprintf()
    * [__]nodemask_scnprintf(), [__]nodelist_scnprintf()
    * seq_bitmap[_list](), seq_cpumask[_list](), seq_nodemask[_list]()
    * seq_buf_bitmask()

    Signed-off-by: Tejun Heo
    Cc: Rusty Russell
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tejun Heo
     

20 Nov, 2014

8 commits

  • The function bstr_printf() from lib/vsprnintf.c is only available if
    CONFIG_BINARY_PRINTF is defined. This is due to the only user currently
    being the tracing infrastructure, which needs to select this config
    when tracing is configured. Until there is another user of the binary
    printf formats, this will continue to be the case.

    Since seq_buf.c is now lives in lib/ and is compiled even without
    tracing, it must encompass its use of bstr_printf() which is used
    by seq_buf_printf(). This too is only used by the tracing infrastructure
    and is still encapsulated by the CONFIG_BINARY_PRINTF.

    Link: http://lkml.kernel.org/r/20141104160222.969013383@goodmis.org

    Tested-by: Jiri Kosina
    Acked-by: Jiri Kosina
    Reviewed-by: Petr Mladek
    Signed-off-by: Steven Rostedt

    Steven Rostedt (Red Hat)
     
  • Add two helper functions; seq_buf_get_buf() and seq_buf_commit() that
    are used by seq_buf_path(). This makes the code similar to the
    seq_file: seq_path() function, and will help to be able to consolidate
    the functions between seq_file and trace_seq.

    Link: http://lkml.kernel.org/r/20141104160222.644881406@goodmis.org
    Link: http://lkml.kernel.org/r/20141114011412.977571447@goodmis.org

    Tested-by: Jiri Kosina
    Acked-by: Jiri Kosina
    Reviewed-by: Petr Mladek
    Signed-off-by: Steven Rostedt

    Steven Rostedt (Red Hat)
     
  • Currently seq_buf is full when all but one byte of the buffer is
    filled. Change it so that the seq_buf is full when all of the
    buffer is filled.

    Some of the functions would fill the buffer completely and report
    everything was fine. This was inconsistent with the max of size - 1.
    Changing this to be max of size makes all functions consistent.

    Link: http://lkml.kernel.org/r/20141104160222.502133196@goodmis.org
    Link: http://lkml.kernel.org/r/20141114011412.811957882@goodmis.org

    Tested-by: Jiri Kosina
    Acked-by: Jiri Kosina
    Reviewed-by: Petr Mladek
    Signed-off-by: Steven Rostedt

    Steven Rostedt (Red Hat)
     
  • Add a helper function seq_buf_used() that replaces the SEQ_BUF_USED()
    private macro to let callers have a method to know how much of the
    seq_buf was written to.

    Link: http://lkml.kernel.org/r/20141114011412.170377300@goodmis.org
    Link: http://lkml.kernel.org/r/20141114011413.321654244@goodmis.org

    Reviewed-by: Petr Mladek
    Signed-off-by: Steven Rostedt

    Steven Rostedt (Red Hat)
     
  • Add a helper function seq_buf_clear() that resets the len and readpos
    fields of a seq_buf. Currently it is only used in the seq_buf_init()
    but will be used later when updating the seq_file code.

    Link: http://lkml.kernel.org/r/20141104160222.352309995@goodmis.org

    Tested-by: Jiri Kosina
    Acked-by: Jiri Kosina
    Reviewed-by: Petr Mladek
    Signed-off-by: Steven Rostedt

    Steven Rostedt (Red Hat)
     
  • In facilitating the conversion of seq_file to use seq_buf,
    have the seq_buf fields match the types used by seq_file.

    Link: http://lkml.kernel.org/r/20141104160222.195301024@goodmis.org

    Tested-by: Jiri Kosina
    Acked-by: Jiri Kosina
    Reviewed-by: Petr Mladek
    Signed-off-by: Steven Rostedt

    Steven Rostedt (Red Hat)
     
  • Rewrite seq_buf_path() like it is done in seq_path() and allow
    it to accept any escape character instead of just "\n".

    Making seq_buf_path() like seq_path() will help prevent problems
    when converting seq_file to use the seq_buf logic.

    Link: http://lkml.kernel.org/r/20141104160222.048795666@goodmis.org
    Link: http://lkml.kernel.org/r/20141114011412.338523371@goodmis.org

    Tested-by: Jiri Kosina
    Acked-by: Jiri Kosina
    Reviewed-by: Petr Mladek
    Signed-off-by: Steven Rostedt

    Steven Rostedt (Red Hat)
     
  • Create a seq_buf layer that trace_seq sits on. The seq_buf will not
    be limited to page size. This will allow other usages of seq_buf
    instead of a hard set PAGE_SIZE one that trace_seq has.

    Link: http://lkml.kernel.org/r/20141104160221.864997179@goodmis.org
    Link: http://lkml.kernel.org/r/20141114011412.170377300@goodmis.org

    Tested-by: Jiri Kosina
    Acked-by: Jiri Kosina
    Reviewed-by: Petr Mladek
    Signed-off-by: Steven Rostedt

    Steven Rostedt (Red Hat)