Eric Lee / smarc-fsl-linux-kernel

30 Dec, 2020

4 commits

  • 6af7b5ab2   Bluetooth: btusb: Fix detection of some fake CSR controllers with a bcdDevice val of 0x0134 ... Browse Code »

    [ Upstream commit d74e0ae7e03032b47b8631cc1e52a7ae1ce988c0 ]

    Commit cde1a8a99287 ("Bluetooth: btusb: Fix and detect most of the
    Chinese Bluetooth controllers") made the detection of fake controllers
    more generic fixing it for much of the newer fakes / clones.

    But this does not work for a fake CSR controller with a bcdDevice
    value of 0x0134, which was correctly identified as fake before
    this change.

    Add an extra check for this special case, checking for a combination
    of a bcdDevice value of 0x0134, together with a lmp_subver of 0x0c5c
    and a hci_ver of BLUETOOTH_VER_2_0.

    The chip inside this fake dongle is marked as with "clockwise cw6629d".

    Fixes: cde1a8a99287 ("Bluetooth: btusb: Fix and detect most of the Chinese Bluetooth controllers")
    Signed-off-by: Hans de Goede
    Signed-off-by: Marcel Holtmann
    Signed-off-by: Johan Hedberg
    Signed-off-by: Sasha Levin

    Hans de Goede
     
  • 046182ddb   Bluetooth: btmtksdio: Add the missed release_firmware() in mtk_setup_firmware() ... Browse Code »

    [ Upstream commit b73b5781a85c03113476f62346c390f0277baa4b ]

    mtk_setup_firmware() misses to call release_firmware() in an error
    path. Jump to free_fw to fix it.

    Fixes: 737cd06072a7 ("Bluetooth: btmtksdio: fix up firmware download sequence")
    Signed-off-by: Jing Xiangfeng
    Signed-off-by: Marcel Holtmann
    Signed-off-by: Johan Hedberg
    Signed-off-by: Sasha Levin

    Jing Xiangfeng
     
  • ae0e73776   Bluetooth: btusb: Add the missed release_firmware() in btusb_mtk_setup_firmware() ... Browse Code »

    [ Upstream commit d1e9d232e1e60fa63df1b836ec3ecba5abd3fa9d ]

    btusb_mtk_setup_firmware() misses to call release_firmware() in an error
    path. Jump to err_release_fw to fix it.

    Fixes: f645125711c8 ("Bluetooth: btusb: fix up firmware download sequence")
    Signed-off-by: Jing Xiangfeng
    Signed-off-by: Marcel Holtmann
    Signed-off-by: Johan Hedberg
    Signed-off-by: Sasha Levin

    Jing Xiangfeng
     
  • f48dbf515   Bluetooth: hci_h5: fix memory leak in h5_close ... Browse Code »

    [ Upstream commit 855af2d74c870d747bf53509f8b2d7b9dc9ee2c3 ]

    When h5_close() is called, h5 is directly freed when !hu->serdev.
    However, h5->rx_skb is not freed, which causes a memory leak.

    Freeing h5->rx_skb and setting it to NULL, fixes this memory leak.

    Fixes: ce945552fde4 ("Bluetooth: hci_h5: Add support for serdev enumerated devices")
    Reported-by: syzbot+6ce141c55b2f7aafd1c4@syzkaller.appspotmail.com
    Tested-by: syzbot+6ce141c55b2f7aafd1c4@syzkaller.appspotmail.com
    Signed-off-by: Anant Thazhemadam
    Reviewed-by: Hans de Goede
    Signed-off-by: Marcel Holtmann
    Signed-off-by: Sasha Levin

    Anant Thazhemadam
     

31 Oct, 2020

1 commit

  • 4acbf5545   Bluetooth: btintel: Replace zero-length array with flexible-array member ... Browse Code »

    There is a regular need in the kernel to provide a way to declare having a
    dynamically sized set of trailing elements in a structure. Kernel code should
    always use “flexible array members”[1] for these cases. The older style of
    one-element or zero-length arrays should no longer be used[2].

    [1] https://en.wikipedia.org/wiki/Flexible_array_member
    [2] https://www.kernel.org/doc/html/v5.9/process/deprecated.html#zero-length-and-one-element-arrays

    Signed-off-by: Gustavo A. R. Silva

    Gustavo A. R. Silva
     

16 Oct, 2020

1 commit

  • 9ff9b0d39   Merge tag 'net-next-5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next ... Browse Code »

    Pull networking updates from Jakub Kicinski:

    - Add redirect_neigh() BPF packet redirect helper, allowing to limit
    stack traversal in common container configs and improving TCP
    back-pressure.

    Daniel reports ~10Gbps => ~15Gbps single stream TCP performance gain.

    - Expand netlink policy support and improve policy export to user
    space. (Ge)netlink core performs request validation according to
    declared policies. Expand the expressiveness of those policies
    (min/max length and bitmasks). Allow dumping policies for particular
    commands. This is used for feature discovery by user space (instead
    of kernel version parsing or trial and error).

    - Support IGMPv3/MLDv2 multicast listener discovery protocols in
    bridge.

    - Allow more than 255 IPv4 multicast interfaces.

    - Add support for Type of Service (ToS) reflection in SYN/SYN-ACK
    packets of TCPv6.

    - In Multi-patch TCP (MPTCP) support concurrent transmission of data on
    multiple subflows in a load balancing scenario. Enhance advertising
    addresses via the RM_ADDR/ADD_ADDR options.

    - Support SMC-Dv2 version of SMC, which enables multi-subnet
    deployments.

    - Allow more calls to same peer in RxRPC.

    - Support two new Controller Area Network (CAN) protocols - CAN-FD and
    ISO 15765-2:2016.

    - Add xfrm/IPsec compat layer, solving the 32bit user space on 64bit
    kernel problem.

    - Add TC actions for implementing MPLS L2 VPNs.

    - Improve nexthop code - e.g. handle various corner cases when nexthop
    objects are removed from groups better, skip unnecessary
    notifications and make it easier to offload nexthops into HW by
    converting to a blocking notifier.

    - Support adding and consuming TCP header options by BPF programs,
    opening the doors for easy experimental and deployment-specific TCP
    option use.

    - Reorganize TCP congestion control (CC) initialization to simplify
    life of TCP CC implemented in BPF.

    - Add support for shipping BPF programs with the kernel and loading
    them early on boot via the User Mode Driver mechanism, hence reusing
    all the user space infra we have.

    - Support sleepable BPF programs, initially targeting LSM and tracing.

    - Add bpf_d_path() helper for returning full path for given 'struct
    path'.

    - Make bpf_tail_call compatible with bpf-to-bpf calls.

    - Allow BPF programs to call map_update_elem on sockmaps.

    - Add BPF Type Format (BTF) support for type and enum discovery, as
    well as support for using BTF within the kernel itself (current use
    is for pretty printing structures).

    - Support listing and getting information about bpf_links via the bpf
    syscall.

    - Enhance kernel interfaces around NIC firmware update. Allow
    specifying overwrite mask to control if settings etc. are reset
    during update; report expected max time operation may take to users;
    support firmware activation without machine reboot incl. limits of
    how much impact reset may have (e.g. dropping link or not).

    - Extend ethtool configuration interface to report IEEE-standard
    counters, to limit the need for per-vendor logic in user space.

    - Adopt or extend devlink use for debug, monitoring, fw update in many
    drivers (dsa loop, ice, ionic, sja1105, qed, mlxsw, mv88e6xxx,
    dpaa2-eth).

    - In mlxsw expose critical and emergency SFP module temperature alarms.
    Refactor port buffer handling to make the defaults more suitable and
    support setting these values explicitly via the DCBNL interface.

    - Add XDP support for Intel's igb driver.

    - Support offloading TC flower classification and filtering rules to
    mscc_ocelot switches.

    - Add PTP support for Marvell Octeontx2 and PP2.2 hardware, as well as
    fixed interval period pulse generator and one-step timestamping in
    dpaa-eth.

    - Add support for various auth offloads in WiFi APs, e.g. SAE (WPA3)
    offload.

    - Add Lynx PHY/PCS MDIO module, and convert various drivers which have
    this HW to use it. Convert mvpp2 to split PCS.

    - Support Marvell Prestera 98DX3255 24-port switch ASICs, as well as
    7-port Mediatek MT7531 IP.

    - Add initial support for QCA6390 and IPQ6018 in ath11k WiFi driver,
    and wcn3680 support in wcn36xx.

    - Improve performance for packets which don't require much offloads on
    recent Mellanox NICs by 20% by making multiple packets share a
    descriptor entry.

    - Move chelsio inline crypto drivers (for TLS and IPsec) from the
    crypto subtree to drivers/net. Move MDIO drivers out of the phy
    directory.

    - Clean up a lot of W=1 warnings, reportedly the actively developed
    subsections of networking drivers should now build W=1 warning free.

    - Make sure drivers don't use in_interrupt() to dynamically adapt their
    code. Convert tasklets to use new tasklet_setup API (sadly this
    conversion is not yet complete).

    * tag 'net-next-5.10' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next: (2583 commits)
    Revert "bpfilter: Fix build error with CONFIG_BPFILTER_UMH"
    net, sockmap: Don't call bpf_prog_put() on NULL pointer
    bpf, selftest: Fix flaky tcp_hdr_options test when adding addr to lo
    bpf, sockmap: Add locking annotations to iterator
    netfilter: nftables: allow re-computing sctp CRC-32C in 'payload' statements
    net: fix pos incrementment in ipv6_route_seq_next
    net/smc: fix invalid return code in smcd_new_buf_create()
    net/smc: fix valid DMBE buffer sizes
    net/smc: fix use-after-free of delayed events
    bpfilter: Fix build error with CONFIG_BPFILTER_UMH
    cxgb4/ch_ipsec: Replace the module name to ch_ipsec from chcr
    net: sched: Fix suspicious RCU usage while accessing tcf_tunnel_info
    bpf: Fix register equivalence tracking.
    rxrpc: Fix loss of final ack on shutdown
    rxrpc: Fix bundle counting for exclusive connections
    netfilter: restore NF_INET_NUMHOOKS
    ibmveth: Identify ingress large send packets.
    ibmveth: Switch order of ibmveth_helper calls.
    cxgb4: handle 4-tuple PEDIT to NAT mode translation
    selftests: Add VRF route leaking tests
    ...

    Linus Torvalds
     

28 Sep, 2020

1 commit

  • b40f58b97   Bluetooth: btusb: Add Qualcomm Bluetooth SoC WCN6855 support ... Browse Code »

    This patch add support for WCN6855 i.e. patch and nvm download
    support.

    T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 2 Spd=12 MxCh= 0
    D: Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
    P: Vendor=0cf3 ProdID=e600 Rev= 0.01
    C:* #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=100mA
    I:* If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
    E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms
    E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms
    E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms
    I:* If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
    E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms
    E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms
    I: If#= 1 Alt= 1 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
    E: Ad=83(I) Atr=01(Isoc) MxPS= 9 Ivl=1ms
    E: Ad=03(O) Atr=01(Isoc) MxPS= 9 Ivl=1ms
    I: If#= 1 Alt= 2 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
    E: Ad=83(I) Atr=01(Isoc) MxPS= 17 Ivl=1ms
    E: Ad=03(O) Atr=01(Isoc) MxPS= 17 Ivl=1ms
    I: If#= 1 Alt= 3 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
    E: Ad=83(I) Atr=01(Isoc) MxPS= 25 Ivl=1ms
    E: Ad=03(O) Atr=01(Isoc) MxPS= 25 Ivl=1ms
    I: If#= 1 Alt= 4 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
    E: Ad=83(I) Atr=01(Isoc) MxPS= 33 Ivl=1ms
    E: Ad=03(O) Atr=01(Isoc) MxPS= 33 Ivl=1ms
    I: If#= 1 Alt= 5 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
    E: Ad=83(I) Atr=01(Isoc) MxPS= 49 Ivl=1ms
    E: Ad=03(O) Atr=01(Isoc) MxPS= 49 Ivl=1ms
    I: If#= 1 Alt= 6 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
    E: Ad=83(I) Atr=01(Isoc) MxPS= 63 Ivl=1ms
    E: Ad=03(O) Atr=01(Isoc) MxPS= 63 Ivl=1ms
    I: If#= 1 Alt= 7 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
    E: Ad=83(I) Atr=01(Isoc) MxPS= 65 Ivl=1ms
    E: Ad=03(O) Atr=01(Isoc) MxPS= 65 Ivl=1ms

    Signed-off-by: Rocky Liao
    Signed-off-by: Marcel Holtmann

    Rocky Liao
     

25 Sep, 2020

2 commits

  • dbb29de70   Bluetooth: ath3k: use usb_control_msg_send() and usb_control_msg_recv() ... Browse Code »

    The usb_control_msg_send() and usb_control_msg_recv() calls can return
    an error if a "short" write/read happens, and they can handle data off
    of the stack, so move the driver over to using those calls instead,
    saving some logic when dynamically allocating memory.

    v2: changed API of use usb_control_msg_send() and usb_control_msg_recv()

    Cc: Marcel Holtmann
    Cc: Johan Hedberg
    Link: https://lore.kernel.org/r/20200914153756.3412156-11-gregkh@linuxfoundation.org
    Signed-off-by: Greg Kroah-Hartman
    Link: https://lore.kernel.org/r/20200923134348.23862-15-oneukum@suse.com
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     
  • cad874c4a   Revert "Bluetooth: ath3k: use usb_control_msg_send() and usb_control_msg_recv()" ... Browse Code »

    This reverts commit e9b20f0fe17ab06c3b55153046209987749daa48.
    The API has to be changed

    Signed-off-by: Oliver Neukum
    Link: https://lore.kernel.org/r/20200923134348.23862-3-oneukum@suse.com
    Signed-off-by: Greg Kroah-Hartman

    Oliver Neukum
     

20 Sep, 2020

1 commit

16 Sep, 2020

1 commit

  • e9b20f0fe   Bluetooth: ath3k: use usb_control_msg_send() and usb_control_msg_recv() ... Browse Code »

    The usb_control_msg_send() and usb_control_msg_recv() calls can return
    an error if a "short" write/read happens, and they can handle data off
    of the stack, so move the driver over to using those calls instead,
    saving some logic when dynamically allocating memory.

    Cc: Marcel Holtmann
    Cc: Johan Hedberg
    Link: https://lore.kernel.org/r/20200914153756.3412156-11-gregkh@linuxfoundation.org
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

15 Sep, 2020

2 commits

  • 81ebea535   Bluetooth: btintel: Functions to send firmware header / payload ... Browse Code »

    New generation controllers supports ECDSA secure boot engine.
    This patch adds,

    1) function to send ECDSA header

    2) function to download complete firmware for new generation Intel
    controllers

    Signed-off-by: Kiran K
    Signed-off-by: Amit K Bag
    Signed-off-by: Raghuram Hegde
    Reviewed-by: Chethan T N
    Reviewed-by: Srivatsa Ravishankar
    Signed-off-by: Marcel Holtmann

    Kiran K
     
  • 57375beef   Bluetooth: btintel: Add infrastructure to read controller information ... Browse Code »

    New generation Intel controllers returns version information in TLV
    format. This patch adds,

    1) Enums, structures for TLV

    2) function to read controller information, parse TLV data and populate
    intel_version_tlv structure

    3) function to print version information

    Signed-off-by: Kiran K
    Signed-off-by: Amit K Bag
    Signed-off-by: Raghuram Hegde
    Reviewed-by: Chethan T N
    Reviewed-by: Srivatsa Ravishankar
    Signed-off-by: Marcel Holtmann

    Kiran K
     

13 Sep, 2020

1 commit

  • e91172151   Bluetooth: btintel: Refactor firmware download function ... Browse Code »

    Split firmware download code into two functions - one to download
    header and other to download payload. This patch enhances readability
    and reusabiltiy of code

    Signed-off-by: Kiran K
    Reviewed-by: Chethan T N
    Reviewed-by: Sathish Narasimman
    Reviewed-by: Srivatsa Ravishankar
    Signed-off-by: Marcel Holtmann

    Kiran K
     

11 Sep, 2020

7 commits

  • 054ec5e94   Bluetooth: hci_qca: Remove duplicate power off in proto close ... Browse Code »

    During serdev unregister, hdev->shutdown is called before
    proto close. Removing duplicates power OFF call.

    Signed-off-by: Venkata Lakshmi Narayana Gubba
    Signed-off-by: Marcel Holtmann

    Venkata Lakshmi Narayana Gubba
     
  • de8892df7   Bluetooth: hci_serdev: Close UART port if NON_PERSISTENT_SETUP is set ... Browse Code »

    When HCI_QUIRK_NON_PERSISTENT_SETUP is set by drivers,
    it indicates that BT SoC will be completely powered OFF
    during BT OFF. On next BT ON firmware must be downloaded
    again. Holding UART port open during BT OFF is draining
    the battery. Now during BT OFF, UART port is closed if
    qurik HCI_QUIRK_NON_PERSISTENT_SETUP is set by clearing
    HCI_UART_PROTO_READY proto flag. On next BT ON, UART
    port is opened if HCI_UART_PROTO_READY proto flag is cleared.

    Signed-off-by: Venkata Lakshmi Narayana Gubba
    Signed-off-by: Marcel Holtmann

    Venkata Lakshmi Narayana Gubba
     
  • c6db01438   Bluetooth: hci_intel: enable on new platform ... Browse Code »

    On new Intel platform the device is provided with INT33E3 ID.
    Append it to the list.

    This will require ACPI_GPIO_QUIRK_ONLY_GPIOIO to be enabled because
    the relevant ASL looks like:

    UartSerialBusV2 ( ... )
    GpioInt ( ... ) { ... }
    GpioIo ( ... ) { ... }

    which means that first GPIO resource is an interrupt, while we are expecting it
    to be reset one (output). Do the same for host-wake because in case of
    GpioInt() the platform_get_irq() will do the job and should return correct
    Linux IRQ number. That said, host-wake GPIO can only be GpioIo() resource.

    While here, drop commas in terminator lines.

    Signed-off-by: Andy Shevchenko
    Signed-off-by: Marcel Holtmann

    Andy Shevchenko
     
  • 2041a3f50   Bluetooth: btmtksdio: use NULL instead of zero ... Browse Code »

    Fix sparse warnings:

    drivers/bluetooth/btmtksdio.c:499:57: warning: Using plain integer as NULL pointer
    drivers/bluetooth/btmtksdio.c:533:57: warning: Using plain integer as NULL pointer

    Signed-off-by: YueHaibing
    Signed-off-by: Marcel Holtmann

    YueHaibing
     
  • 7dbbd6926   Bluetooth: hci_intel: switch to list_for_each_entry() ... Browse Code »

    There is no need to have list_for_each() followed by list_entry()
    when we simply may use list_for_each_entry() directly.

    Signed-off-by: Andy Shevchenko
    Signed-off-by: Marcel Holtmann

    Andy Shevchenko
     
  • 0cc62caf4   Bluetooth: hci_intel: drop strange le16_to_cpu() against u8 values ... Browse Code »

    Sparse rightfully complains:

    hci_intel.c:696:26: warning: cast to restricted __le16
    hci_intel.c:701:26: warning: cast to restricted __le16
    hci_intel.c:702:26: warning: cast to restricted __le16
    hci_intel.c:703:26: warning: cast to restricted __le16
    hci_intel.c:725:26: warning: cast to restricted __le16
    hci_intel.c:730:26: warning: cast to restricted __le16
    hci_intel.c:731:26: warning: cast to restricted __le16
    hci_intel.c:732:26: warning: cast to restricted __le16

    because we access non-restricted types with le16_to_cpu().
    More confusion is added by using above against u8. On big-endian
    architecture we will get all zeroes. I bet it's not what should be
    in such case.

    Signed-off-by: Andy Shevchenko
    Signed-off-by: Marcel Holtmann

    Andy Shevchenko
     
  • 65a24d4c2   Bluetooth: hci_qca: remove redundant null check ... Browse Code »

    Because clk_disable_unprepare already checked
    NULL clock parameter, so the additional check is
    unnecessary, just remove it.

    Signed-off-by: Xu Wang
    Signed-off-by: Marcel Holtmann

    Xu Wang
     

01 Sep, 2020

1 commit

31 Aug, 2020

1 commit

03 Aug, 2020

3 commits

01 Aug, 2020

1 commit

  • 4bb540dbe   Merge branch 'for-upstream' of git://git.kernel.org/pub/scm/linux/kernel/git/blu… ... Browse Code »

    …etooth/bluetooth-next

    Johan Hedberg says:

    ====================
    pull request: bluetooth-next 2020-07-31

    Here's the main bluetooth-next pull request for 5.9:

    - Fix firmware filenames for Marvell chipsets
    - Several suspend-related fixes
    - Addedd mgmt commands for runtime configuration
    - Multiple fixes for Qualcomm-based controllers
    - Add new monitoring feature for mgmt
    - Fix handling of legacy cipher (E4) together with security level 4
    - Add support for Realtek 8822CE controller
    - Fix issues with Chinese controllers using fake VID/PID values
    - Multiple other smaller fixes & improvements
    ====================

    Signed-off-by: David S. Miller <davem@davemloft.net>

    David S. Miller
     

30 Jul, 2020

1 commit

  • 34ec58b9f   Revert "Bluetooth: btusb: Disable runtime suspend on Realtek devices" ... Browse Code »

    This reverts commit 7ecacafc240638148567742cca41aa7144b4fe1e.

    Testing this change on a board with RTL8822CE, I found that enabling
    autosuspend has no effect on the stability of the system. The board
    continued working after autosuspend, suspend and reboot.

    The original commit makes it impossible to enable autosuspend on working
    systems so it should be reverted. Disabling autosuspend should be done
    via module param or udev in userspace instead.

    Signed-off-by: Abhishek Pandit-Subedi
    Acked-by: Kai-Heng Feng
    Signed-off-by: Marcel Holtmann

    Abhishek Pandit-Subedi
     

29 Jul, 2020

1 commit

28 Jul, 2020

3 commits

  • 202798db9   Bluetooth: hci_serdev: Only unregister device if it was registered ... Browse Code »

    We should not call hci_unregister_dev if the device was not
    successfully registered.

    Fixes: c34dc3bfa7642fd ("Bluetooth: hci_serdev: Introduce hci_uart_unregister_device()")
    Signed-off-by: Nicolas Boichat
    Signed-off-by: Marcel Holtmann

    Nicolas Boichat
     
  • a7ad4b611   Bluetooth: hci_h5: Set HCI_UART_RESET_ON_INIT to correct flags ... Browse Code »

    HCI_UART_RESET_ON_INIT belongs in hdev_flags, not flags.

    Fixes: ce945552fde4a09 ("Bluetooth: hci_h5: Add support for serdev enumerated devices")
    Signed-off-by: Nicolas Boichat
    Reviewed-by: Hans de Goede
    Signed-off-by: Marcel Holtmann

    Nicolas Boichat
     
  • cde1a8a99   Bluetooth: btusb: Fix and detect most of the Chinese Bluetooth controllers ... Browse Code »

    For some reason they tend to squat on the very first CSR/
    Cambridge Silicon Radio VID/PID instead of paying fees.

    This is an extremely common problem; the issue goes as back as 2013
    and these devices are only getting more popular, even rebranded by
    reputable vendors and sold by retailers everywhere.

    So, at this point in time there are hundreds of modern dongles reusing
    the ID of what originally was an early Bluetooth 1.1 controller.

    Linux is the only place where they don't work due to spotty checks
    in our detection code. It only covered a minimum subset.

    So what's the big idea? Take advantage of the fact that all CSR
    chips report the same internal version as both the LMP sub-version and
    HCI revision number. It always matches, couple that with the manufacturer
    code, that rarely lies, and we now have a good idea of who is who.

    Additionally, by compiling a list of user-reported HCI/lsusb dumps, and
    searching around for legit CSR dongles in similar product ranges we can
    find what CSR BlueCore firmware supported which Bluetooth versions.

    That way we can narrow down ranges of fakes for each of them.

    e.g. Real CSR dongles with LMP subversion 0x73 are old enough that
    support BT 1.1 only; so it's a dead giveaway when some
    third-party BT 4.0 dongle reuses it.

    So, to sum things up; there are multiple classes of fake controllers
    reusing the same 0A12:0001 VID/PID. This has been broken for a while.

    Known 'fake' bcdDevices: 0x0100, 0x0134, 0x1915, 0x2520, 0x7558, 0x8891
    IC markings on 0x7558: FR3191AHAL 749H15143 (???)

    https://bugzilla.kernel.org/show_bug.cgi?id=60824

    Fixes: 81cac64ba258ae (Deal with USB devices that are faking CSR vendor)
    Reported-by: Michał Wiśniewski
    Tested-by: Mike Johnson
    Tested-by: Ricardo Rodrigues
    Tested-by: M.Hanny Sabbagh
    Tested-by: Oussama BEN BRAHIM
    Tested-by: Ismael Ferreras Morezuelas
    Signed-off-by: Ismael Ferreras Morezuelas
    Signed-off-by: Marcel Holtmann

    Ismael Ferreras Morezuelas
     

14 Jul, 2020

2 commits

11 Jul, 2020

1 commit

  • a3b4cbfc0   Bluetooth: Use fallthrough pseudo-keyword ... Browse Code »

    Replace the existing /* fall through */ comments and its variants with
    the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
    fall-through markings when it is the case.

    [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

    Signed-off-by: Gustavo A. R. Silva
    Signed-off-by: Marcel Holtmann

    Gustavo A. R. Silva
     

07 Jul, 2020

1 commit

26 Jun, 2020

1 commit

25 Jun, 2020

3 commits