Eric Lee / smarc-fsl-linux-kernel

16 Feb, 2020

1 commit

  • 3bf3c9744   bus: moxtet: fix potential stack buffer overflow ... Browse Code »

    The input_read function declares the size of the hex array relative to
    sizeof(buf), but buf is a pointer argument of the function. The hex
    array is meant to contain hexadecimal representation of the bin array.

    Link: https://lore.kernel.org/r/20200215142130.22743-1-marek.behun@nic.cz
    Fixes: 5bc7f990cd98 ("bus: Add support for Moxtet bus")
    Signed-off-by: Marek Behún
    Reported-by: sohu0106
    Signed-off-by: Olof Johansson

    Marek Behún
     

08 Jan, 2020

1 commit

04 Sep, 2019

2 commits

  • 6811d26df   bus: moxtet: fix unsigned comparison to less than zero ... Browse Code »

    Currently the size_t variable res is being checked for
    an error failure however the unsigned variable is never
    less than zero so this test is always false. Fix this by
    making variable res ssize_t

    Link: https://lore.kernel.org/r/20190822010351.15660-2-marek.behun@nic.cz
    Addresses-Coverity: ("Unsigned compared against 0")
    Fixes: 5bc7f990cd98 ("bus: Add support for Moxtet bus")
    Signed-off-by: Colin Ian King
    Signed-off-by: Marek Behún
    Signed-off-by: Arnd Bergmann

    Colin Ian King
     
  • caebdd3c1   bus: moxtet: remove set but not used variable 'dummy' ... Browse Code »

    Fixes gcc '-Wunused-but-set-variable' warning:

    drivers/bus/moxtet.c: In function moxtet_remove:
    drivers/bus/moxtet.c:822:6: warning: variable dummy set but not used
    [-Wunused-but-set-variable]

    Link: https://lore.kernel.org/r/20190822010351.15660-3-marek.behun@nic.cz
    Signed-off-by: Jason Yan
    Signed-off-by: Marek Behún
    Signed-off-by: Arnd Bergmann

    Jason Yan
     

14 Aug, 2019

1 commit

  • 5bc7f990c   bus: Add support for Moxtet bus ... Browse Code »

    On the Turris Mox router different modules can be connected to the main
    CPU board: currently a module with a SFP cage, a module with MiniPCIe
    connector, a PCIe pass-through MiniPCIe connector module, a 4-port
    switch module, an 8-port switch module, and a 4-port USB3 module.

    For example:
    [CPU]-[PCIe-pass-through]-[PCIe]-[8-port switch]-[8-port switch]-[SFP]

    Each of this modules has an input and output shift register, and these
    are connected via SPI to the CPU board.

    Via SPI we are able to discover which modules are connected, in which
    order, and we can also read some information about the modules (eg.
    their interrupt status), and configure them.
    From each module 8 bits can be read (of which low 4 bits identify the
    module) and 8 bits can be written.

    For example from the module with a SFP cage we can read the LOS,
    TX-FAULT and MOD-DEF0 signals, while we can write TX-DISABLE and
    RATE-SELECT signals.

    This driver creates a new bus type, called "moxtet". For each Mox module
    it finds via SPI, it creates a new device on the moxtet bus so that
    drivers can be written for them.

    It also implements a virtual interrupt controller for the modules which
    send their interrupt status over the SPI shift register. These modules
    do this in addition to sending their interrupt status via the shared
    interrupt line. When the shared interrupt is triggered, we read from the
    shift register and handle IRQs for all devices which are in interrupt.

    The topology of how Mox modules are connected can then be read by
    listing /sys/bus/moxtet/devices.

    Link: https://lore.kernel.org/r/20190812161118.21476-2-marek.behun@nic.cz
    Signed-off-by: Marek Behún
    Reviewed-by: Linus Walleij
    Signed-off-by: Arnd Bergmann

    Marek Behún