29 Aug, 2019

1 commit


21 Jun, 2019

1 commit

  • The return values of edac_debugfs_create_x16() and
    edac_debugfs_create_x8() are never checked (as they don't need to be),
    so no need to have them return anything, just make the functions return
    void instead.

    This is done with the goal of being able to change the debugfs_create_x*
    functions to also not return a value.

    Signed-off-by: Greg Kroah-Hartman
    Signed-off-by: Borislav Petkov
    Cc: James Morse
    Cc: linux-edac
    Cc: Mauro Carvalho Chehab
    Link: https://lkml.kernel.org/r/20190611175433.GA5108@kroah.com

    Greg Kroah-Hartman
     

21 May, 2019

1 commit

  • Add SPDX license identifiers to all files which:

    - Have no license information of any form

    - Have EXPORT_.*_SYMBOL_GPL inside which was used in the
    initial scan/conversion to ignore the file

    These files fall under the project license, GPL v2 only. The resulting SPDX
    license identifier is:

    GPL-2.0-only

    Signed-off-by: Thomas Gleixner
    Signed-off-by: Greg Kroah-Hartman

    Thomas Gleixner
     

23 Jan, 2019

1 commit

  • When calling debugfs functions, there is no need to ever check the
    return value. The function can work or not, but the code logic should
    never do something different based on this.

    [ bp: Make edac_debugfs_init() return void too, while at it. ]

    Signed-off-by: Greg Kroah-Hartman
    Signed-off-by: Borislav Petkov
    Cc: James Morse
    Cc: Mauro Carvalho Chehab
    Cc: linux-edac
    Link: https://lkml.kernel.org/r/20190122152151.16139-17-gregkh@linuxfoundation.org

    Greg Kroah-Hartman
     

10 Feb, 2016

1 commit

  • debugfs_remove() is used to remove a file or a directory from the
    debugfs filesystem on an EDAC device exit. However edac_debugfs might
    not be empty. This is similar to

    30f84a891bf6 ("EDAC: Use edac_debugfs_remove_recursive()")

    which changed the EDAC MCI code to use edac_debugfs_remove_recursive().

    Suggested-by: Borislav Petkov
    Signed-off-by: Thor Thayer
    Cc: linux-edac
    Link: http://lkml.kernel.org/r/1455064165-3816-1-git-send-email-tthayer@opensource.altera.com
    Signed-off-by: Borislav Petkov

    Thor Thayer
     

15 Oct, 2015

1 commit

  • debugfs_remove() is used to remove a file or a directory from the
    debugfs filesystem, but mci->debugfs might not empty.

    This can be triggered by the following sequence:

    1) Enable CONFIG_EDAC_DEBUG
    2) insmod an EDAC module (like i3000_edac or similar)
    3) rmmod this module
    4) we can see files remaining under /edac/ like
    "fake_inject", for example.

    Removing edac_core then, causes a NULL pointer dereference.

    Reported-by: Yun Wu (Abel)
    Signed-off-by: Tan Xiaojun
    Cc: Doug Thompson
    Cc: Mauro Carvalho Chehab
    Cc: linux-edac
    Link: http://lkml.kernel.org/r/1444787364-104353-1-git-send-email-tanxiaojun@huawei.com
    Signed-off-by: Borislav Petkov

    Tan Xiaojun
     

23 Sep, 2015

1 commit


22 Sep, 2015

1 commit