30 Dec, 2020
1 commit
-
[ Upstream commit e1efdb604f5c9903a5d92ef42244009d3c04880f ]
The platform device driver name is "max77693-muic", so advertise it
properly in the modalias string. This fixes automated module loading when
this driver is compiled as a module.Fixes: db1b9037424b ("extcon: MAX77693: Add extcon-max77693 driver to support Maxim MAX77693 MUIC device")
Signed-off-by: Marek Szyprowski
Signed-off-by: Chanwoo Choi
Signed-off-by: Sasha Levin
29 Sep, 2020
2 commits
-
module_platform_driver() makes the code simpler by eliminating
boilerplate code.Signed-off-by: Liu Shixin
Reviewed-by: Hans de Goede
Signed-off-by: Chanwoo Choi -
The commit 85256f611f66 ("extcon: ptn5150: Check current USB mode when
probing") reused code for checking CC status register in the probe path
to determine what is initially connected. However if nothing is
connected, the CC status register will have 0x0 value and print an error
message:ptn5150 1-003d: Unknown Port status : 0
This is not an error. Also any other unknown port status values are not
really errors but unhandled cases.Fixes: 85256f611f66 ("extcon: ptn5150: Check current USB mode when probing")
Signed-off-by: Krzysztof Kozlowski
Signed-off-by: Chanwoo Choi
24 Sep, 2020
19 commits
-
The register addresses are not continuous, so use simple defines for
them. This also makes it easier to find the address for register.No functional change.
Signed-off-by: Krzysztof Kozlowski
Signed-off-by: Chanwoo Choi -
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.Signed-off-by: Krzysztof Kozlowski
Signed-off-by: Chanwoo Choi -
devm_extcon_dev_allocate() can fail of multiple reasons. The call
returns proper error code on failure so pass it instead of fixed ENOMEM.Signed-off-by: Krzysztof Kozlowski
Signed-off-by: Chanwoo Choi -
devm_extcon_dev_allocate() can fail of multiple reasons. The call
returns proper error code on failure so pass it instead of fixed ENOMEM.Signed-off-by: Krzysztof Kozlowski
Signed-off-by: Chanwoo Choi -
devm_extcon_dev_allocate() can fail of multiple reasons. The call
returns proper error code on failure so pass it instead of fixed ENOMEM.Signed-off-by: Krzysztof Kozlowski
Signed-off-by: Chanwoo Choi -
devm_extcon_dev_allocate() can fail of multiple reasons. The call
returns proper error code on failure so pass it instead of fixed ENOMEM.Signed-off-by: Krzysztof Kozlowski
Signed-off-by: Chanwoo Choi -
Set the capability value of property for VBUS and POLARITY.
Signed-off-by: Ramuthevar Vadivel Murugan
[cw00.choi: Replace the space with tab for the indentation]
Signed-off-by: Chanwoo Choi -
Switch to GENMASK() and BIT() macros.
Signed-off-by: Ramuthevar Vadivel Murugan
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: Chanwoo Choi -
dev_err_probe() is designed to be used like
return dev_err_probe(dev, ret, "Error message\n");
Hence no need to have a separate return statement. Besides that
dev_err_probe() prints already returned error code, no need to repeat
that either.Signed-off-by: Andy Shevchenko
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: Chanwoo Choi -
Rationale:
Reduces attack surface on kernel devs opening the links for MITM
as HTTPS traffic is much harder to manipulate.Deterministic algorithm:
For each file:
If not .svg:
For each line:
If doesn't contain `\bxmlns\b`:
For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
If both the HTTP and HTTPS versions
return 200 OK and serve the same content:
Replace HTTP with HTTPS.Signed-off-by: Alexander A. Klimov
Signed-off-by: Chanwoo Choi -
The 'struct i2c_device_id' argument of probe function is not used, so
convert the driver to simpler 'probe_new' interface.Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Vijai Kumar K
Signed-off-by: Chanwoo Choi -
Use module_i2c_driver() to simplify driver init boilerplate.
Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Vijai Kumar K
Signed-off-by: Chanwoo Choi -
There is no point to print deferred probe (and its failures to get
resources) as an error. In case of multiple probe tries this would
pollute the dmesg.Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Vijai Kumar K
Signed-off-by: Chanwoo Choi -
The PTN5150 chip can be used in hardware designs with only reporting of
USB Type-C connection, without the VBUS control. The driver however
unconditionally expected 'vbus-gpios'.Since all uses of the VBUS GPIO descriptor are NULL safe, the code can
accept missing GPIO and provide only extcon status reporting.Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Vijai Kumar K
Signed-off-by: Chanwoo Choi -
When machine boots up, the USB could be already in OTG mode. In such
case there will be no interrupt coming to ptn5150 device and driver will
report default state of nothing connected. Detection of USB connection
would happen on first unplug of the cable.Factor out code for checking current connection mode and call it right
after probe so the existing USB mode will be properly reported.Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Vijai Kumar K
Signed-off-by: Chanwoo Choi -
The ptn5150 driver always prints device type on probe but as raw hex,
without any translation to meaningful description. This is useful only
for board bring up time so lower the verbosity to debug.Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Vijai Kumar K
Signed-off-by: Chanwoo Choi -
Instead of obtaining GPIO as input and configuring it right after to
output-low, just use proper GPIOD_OUT_LOW flag. Code is smaller and
simpler.Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Vijai Kumar K
Signed-off-by: Chanwoo Choi -
Interrupts do not have to be always GPIO based so instead of expecting
"int-gpios" property and converting the GPIO to an interrupt, just
accept any interrupt via generic "interrupts" property.Keep support for old "int-gpios" for backward compatibility.
Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Vijai Kumar K
Signed-off-by: Chanwoo Choi -
The driver uses atomic version of gpiod_set_value() without any real
reason. It is called in a workqueue under mutex so it could sleep
there. Changing it to "can_sleep" flavor allows to use the driver with
all GPIO chips.Fixes: 4ed754de2d66 ("extcon: Add support for ptn5150 extcon driver")
Cc:
Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Vijai Kumar K
Signed-off-by: Chanwoo Choi
29 May, 2020
4 commits
-
When arizona_request_irq() returns an error code, a
pairing runtime PM usage counter decrement is needed
to keep the counter balanced. For error paths after
this function, things are the same.Also, remove calls to pm_runtime_disable() when
pm_runtime_enable() has not been executed.Signed-off-by: Dinghao Liu
Signed-off-by: Chanwoo Choi -
Add device tree compatible strings and create proper modalias structures
to let this driver load automatically if compiled as module, because
max14577 MFD driver creates MFD cells with such compatible strings.Signed-off-by: Marek Szyprowski
Signed-off-by: Chanwoo Choi -
In some error handling paths, a call to 'iio_channel_get()' is not balanced
by a corresponding call to 'iio_channel_release()'.This can be achieved easily by using the devm_ variant of
'iio_channel_get()'.This has the extra benefit to simplify the remove function.
Fixes: 19939860dcae ("extcon: adc_jack: adc-jack driver to support 3.5 pi or simliar devices")
Signed-off-by: Christophe JAILLET
Signed-off-by: Chanwoo Choi -
The variable idx is being initialized with a value that is never read
and it is being updated later with a new value. The initialization is
redundant and can be removed.Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King
Signed-off-by: Chanwoo Choi
04 Apr, 2020
1 commit
-
Pull char/misc driver updates from Greg KH:
"Here is the big set of char/misc/other driver patches for 5.7-rc1.Lots of things in here, and it's later than expected due to some
reverts to resolve some reported issues. All is now clean with no
reported problems in linux-next.Included in here is:
- interconnect updates
- mei driver updates
- uio updates
- nvmem driver updates
- soundwire updates
- binderfs updates
- coresight updates
- habanalabs updates
- mhi new bus type and core
- extcon driver updates
- some Kconfig cleanups
- other small misc driver cleanups and updatesAs mentioned, all have been in linux-next for a while, and with the
last two reverts, all is calm and good"* tag 'char-misc-5.7-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc: (174 commits)
Revert "driver core: platform: Initialize dma_parms for platform devices"
Revert "amba: Initialize dma_parms for amba devices"
amba: Initialize dma_parms for amba devices
driver core: platform: Initialize dma_parms for platform devices
bus: mhi: core: Drop the references to mhi_dev in mhi_destroy_device()
bus: mhi: core: Initialize bhie field in mhi_cntrl for RDDM capture
bus: mhi: core: Add support for reading MHI info from device
misc: rtsx: set correct pcr_ops for rts522A
speakup: misc: Use dynamic minor numbers for speakup devices
mei: me: add cedar fork device ids
coresight: do not use the BIT() macro in the UAPI header
Documentation: provide IBM contacts for embargoed hardware
nvmem: core: remove nvmem_sysfs_get_groups()
nvmem: core: use is_bin_visible for permissions
nvmem: core: use device_register and device_unregister
nvmem: core: add root_only member to nvmem device struct
extcon: axp288: Add wakeup support
extcon: Mark extcon_get_edev_name() function as exported symbol
extcon: palmas: Hide error messages if gpio returns -EPROBE_DEFER
dt-bindings: extcon: usbc-cros-ec: convert extcon-usbc-cros-ec.txt to yaml format
...
25 Mar, 2020
4 commits
-
On devices with an AXP288, we need to wakeup from suspend when a charger
is plugged in, so that we can do charger-type detection and so that the
axp288-charger driver, which listens for our extcon events, can configure
the input-current-limit accordingly.Cc: stable@vger.kernel.org
Signed-off-by: Hans de Goede
Signed-off-by: Chanwoo Choi -
extcon_get_edev_name() function provides client driver to request
extcon dev's name. If extcon driver and client driver are compiled
as loadable modules, extcon_get_edev_name() function symbol is not
visible to client driver. Hence mark extcon_find_edev_name() function
as exported symbol.Signed-off-by: Mayank Rana
Signed-off-by: Chanwoo Choi -
If the gpios are probed after this driver (e.g. if they
come from an i2c expander) there is no need to print an
error message.Signed-off-by: H. Nikolaus Schaller
Signed-off-by: Chanwoo Choi -
The new macro set has a consistent namespace and uses C99 initializers
instead of the grufty C89 ones.Signed-off-by: Thomas Gleixner
Signed-off-by: Borislav Petkov
Reviewed-by: Greg Kroah-Hartman
Link: https://lkml.kernel.org/r/20200320131510.075227793@linutronix.de
16 Dec, 2019
1 commit
-
Remove unneeded semicolon reported by coccinelle.
Signed-off-by: Xu Wang
[cw00.choi: Edit patch title and description]
Signed-off-by: Chanwoo Choi
09 Dec, 2019
8 commits
-
Continue refactoring the microphone detect handling by factoring
out the handling for microphone detection and button detection
into separate functions. This both makes the code a little clearer
and prepares for some planned future refactoring to make the state
handling in the driver more explicit.Signed-off-by: Charles Keepax
Signed-off-by: Chanwoo Choi -
The microphone detection handler is very long, start breaking it up
by factoring out the actual reading of the impedance value into a
separate functions. Additionally, this also fixes a minor bug and
ensures that the microphone timeout will be rescheduled in all error
cases.Signed-off-by: Charles Keepax
Signed-off-by: Chanwoo Choi -
Invert the check of hpdet_acc_id at the top of arizona_hpdet_do_id to
reduce the identation within the function.Signed-off-by: Charles Keepax
Signed-off-by: Chanwoo Choi -
A WARN_ON is very strong for simply finding a button that is out of
range, downgrade this to a simple error message in the log.Signed-off-by: Charles Keepax
Signed-off-by: Chanwoo Choi -
arizona_start_mic sets ACCDET_MODE as required for the microphone
detection as such it is redundant to set this outside of this function.Signed-off-by: Charles Keepax
Signed-off-by: Chanwoo Choi -
Moving from microphone detection to headphone detection is done fairly
haphazardly at the moment, sometimes calling arizona_stop_mic at the
call site sometimes relying on a call inside arizona_identify_headphone.
Simplify all this and always call arizona_stop_mic at the top of
arizona_identify_headphone.Signed-off-by: Charles Keepax
Signed-off-by: Chanwoo Choi -
It makes sense to clear the internal state of the jack detection
regardless of if the headphone detect based accessory detection or
the normal microphone detect based flow is used.No issues are currently known because of this but the change makes
more logical sense and eases future refactoring of the code.Signed-off-by: Charles Keepax
Signed-off-by: Chanwoo Choi -
It makes no sense to be extracting values from pdata for the first time
in the jack detection handler function, move this to probe time where it
belongs.Signed-off-by: Charles Keepax
Signed-off-by: Chanwoo Choi
